[INFO] updating cached repository decafjoe/mgit [INFO] running `"git" "fetch" "--all"` [INFO] [stdout] Fetching origin [INFO] [stderr] From git://github.com/decafjoe/mgit [INFO] [stderr] * branch HEAD -> FETCH_HEAD [INFO] running `"git" "clone" "work/cache/sources/gh/decafjoe/mgit" "work/ex/clippy-test-run/sources/stable/gh/decafjoe/mgit"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/decafjoe/mgit'... [INFO] [stderr] done. [INFO] running `"git" "clone" "work/cache/sources/gh/decafjoe/mgit" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/decafjoe/mgit"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/decafjoe/mgit'... [INFO] [stderr] done. [INFO] running `"git" "rev-parse" "HEAD"` [INFO] [stdout] ffef1cbfc293fee717d831ec00d9858e5c687497 [INFO] sha for GitHub repo decafjoe/mgit: ffef1cbfc293fee717d831ec00d9858e5c687497 [INFO] validating manifest of decafjoe/mgit on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of decafjoe/mgit on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing decafjoe/mgit [INFO] finished frobbing decafjoe/mgit [INFO] frobbed toml for decafjoe/mgit written to work/ex/clippy-test-run/sources/stable/gh/decafjoe/mgit/Cargo.toml [INFO] started frobbing decafjoe/mgit [INFO] finished frobbing decafjoe/mgit [INFO] frobbed toml for decafjoe/mgit written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/decafjoe/mgit/Cargo.toml [INFO] crate decafjoe/mgit has a lockfile. skipping [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting decafjoe/mgit against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-7/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/gh/decafjoe/mgit:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 1b4f23bbd1136f60c76b38e82c0119f1f4ad94288ba944e185ae3e4de9e69922 [INFO] running `"docker" "start" "-a" "1b4f23bbd1136f60c76b38e82c0119f1f4ad94288ba944e185ae3e4de9e69922"` [INFO] [stderr] Checking ordermap v0.4.0 [INFO] [stderr] Compiling cmake v0.1.29 [INFO] [stderr] Compiling libz-sys v1.0.18 [INFO] [stderr] Compiling curl-sys v0.4.1 [INFO] [stderr] Checking term_size v0.3.1 [INFO] [stderr] Checking users v0.6.0 [INFO] [stderr] Checking walkdir v2.1.3 [INFO] [stderr] Checking pager v0.14.0 [INFO] [stderr] Checking rust-ini v0.10.2 [INFO] [stderr] Checking textwrap v0.9.0 [INFO] [stderr] Compiling libssh2-sys v0.2.6 [INFO] [stderr] Compiling libgit2-sys v0.6.19 [INFO] [stderr] Checking clap v2.29.4 [INFO] [stderr] Checking git2 v0.6.11 [INFO] [stderr] Checking mgit v0.3.1 (/opt/crater/workdir) [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/app.rs:495:13 [INFO] [stderr] | [INFO] [stderr] 495 | repos: repos, [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `repos` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/app.rs:531:13 [INFO] [stderr] | [INFO] [stderr] 531 | repos: repos, [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `repos` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/app.rs:825:13 [INFO] [stderr] | [INFO] [stderr] 825 | warning_action: warning_action, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `warning_action` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/app.rs:929:13 [INFO] [stderr] | [INFO] [stderr] 929 | config: config, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `config` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/app.rs:930:13 [INFO] [stderr] | [INFO] [stderr] 930 | tags: tags, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `tags` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/app.rs:931:13 [INFO] [stderr] | [INFO] [stderr] 931 | indices: indices, [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: replace it with: `indices` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/app.rs:988:13 [INFO] [stderr] | [INFO] [stderr] 988 | config: config, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `config` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/app.rs:989:13 [INFO] [stderr] | [INFO] [stderr] 989 | control: control, [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: replace it with: `control` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/app.rs:990:13 [INFO] [stderr] | [INFO] [stderr] 990 | matches: matches, [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: replace it with: `matches` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: using `write!()` with a format string that ends in a single newline, consider using `writeln!()` instead [INFO] [stderr] --> src/cmd/pull.rs:629:9 [INFO] [stderr] | [INFO] [stderr] 629 | write!(self.t, "{}{}\n", clear::All, cursor::Show) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::write_with_newline)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#write_with_newline [INFO] [stderr] [INFO] [stderr] warning: 5th binding whose name is just one char [INFO] [stderr] --> src/cmd/pull.rs:742:25 [INFO] [stderr] | [INFO] [stderr] 742 | let s = &name[..remaining - 1]; [INFO] [stderr] | ^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::many_single_char_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#many_single_char_names [INFO] [stderr] [INFO] [stderr] warning: 5th binding whose name is just one char [INFO] [stderr] --> src/cmd/pull.rs:795:29 [INFO] [stderr] | [INFO] [stderr] 795 | let s = &full_name[..remaining - 2]; [INFO] [stderr] | ^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#many_single_char_names [INFO] [stderr] [INFO] [stderr] warning: 5th binding whose name is just one char [INFO] [stderr] --> src/cmd/pull.rs:814:25 [INFO] [stderr] | [INFO] [stderr] 814 | let x = w - ((remaining - 2) as u16); [INFO] [stderr] | ^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#many_single_char_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/ui.rs:40:13 [INFO] [stderr] | [INFO] [stderr] 40 | group: group, [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `group` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/ui.rs:41:13 [INFO] [stderr] | [INFO] [stderr] 41 | kind: kind, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `kind` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/ui.rs:85:13 [INFO] [stderr] | [INFO] [stderr] 85 | indices: indices, [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: replace it with: `indices` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/ui.rs:86:13 [INFO] [stderr] | [INFO] [stderr] 86 | summary: summary, [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: replace it with: `summary` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/ui.rs:174:16 [INFO] [stderr] | [INFO] [stderr] 174 | Self { branch: branch } [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `branch` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/ui.rs:250:39 [INFO] [stderr] | [INFO] [stderr] 250 | Ok(branches) => Ok(Self { branches: branches }), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: replace it with: `branches` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/app.rs:495:13 [INFO] [stderr] | [INFO] [stderr] 495 | repos: repos, [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `repos` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/app.rs:531:13 [INFO] [stderr] | [INFO] [stderr] 531 | repos: repos, [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `repos` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/app.rs:825:13 [INFO] [stderr] | [INFO] [stderr] 825 | warning_action: warning_action, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `warning_action` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/app.rs:929:13 [INFO] [stderr] | [INFO] [stderr] 929 | config: config, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `config` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/app.rs:930:13 [INFO] [stderr] | [INFO] [stderr] 930 | tags: tags, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `tags` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/app.rs:931:13 [INFO] [stderr] | [INFO] [stderr] 931 | indices: indices, [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: replace it with: `indices` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/app.rs:988:13 [INFO] [stderr] | [INFO] [stderr] 988 | config: config, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `config` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/app.rs:989:13 [INFO] [stderr] | [INFO] [stderr] 989 | control: control, [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: replace it with: `control` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/app.rs:990:13 [INFO] [stderr] | [INFO] [stderr] 990 | matches: matches, [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: replace it with: `matches` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: using `write!()` with a format string that ends in a single newline, consider using `writeln!()` instead [INFO] [stderr] --> src/cmd/pull.rs:629:9 [INFO] [stderr] | [INFO] [stderr] 629 | write!(self.t, "{}{}\n", clear::All, cursor::Show) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::write_with_newline)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#write_with_newline [INFO] [stderr] [INFO] [stderr] warning: 5th binding whose name is just one char [INFO] [stderr] --> src/cmd/pull.rs:742:25 [INFO] [stderr] | [INFO] [stderr] 742 | let s = &name[..remaining - 1]; [INFO] [stderr] | ^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::many_single_char_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#many_single_char_names [INFO] [stderr] [INFO] [stderr] warning: 5th binding whose name is just one char [INFO] [stderr] --> src/cmd/pull.rs:795:29 [INFO] [stderr] | [INFO] [stderr] 795 | let s = &full_name[..remaining - 2]; [INFO] [stderr] | ^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#many_single_char_names [INFO] [stderr] [INFO] [stderr] warning: 5th binding whose name is just one char [INFO] [stderr] --> src/cmd/pull.rs:814:25 [INFO] [stderr] | [INFO] [stderr] 814 | let x = w - ((remaining - 2) as u16); [INFO] [stderr] | ^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#many_single_char_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/ui.rs:40:13 [INFO] [stderr] | [INFO] [stderr] 40 | group: group, [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `group` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/ui.rs:41:13 [INFO] [stderr] | [INFO] [stderr] 41 | kind: kind, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `kind` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/ui.rs:85:13 [INFO] [stderr] | [INFO] [stderr] 85 | indices: indices, [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: replace it with: `indices` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/ui.rs:86:13 [INFO] [stderr] | [INFO] [stderr] 86 | summary: summary, [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: replace it with: `summary` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/ui.rs:174:16 [INFO] [stderr] | [INFO] [stderr] 174 | Self { branch: branch } [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `branch` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/ui.rs:250:39 [INFO] [stderr] | [INFO] [stderr] 250 | Ok(branches) => Ok(Self { branches: branches }), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: replace it with: `branches` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: lint name `match_as_ref` is deprecated and may not have an effect in the future. Also `cfg_attr(cargo-clippy)` won't be necessary anymore [INFO] [stderr] --> src/app.rs:362:48 [INFO] [stderr] | [INFO] [stderr] 362 | #[cfg_attr(feature = "cargo-clippy", allow(match_as_ref))] [INFO] [stderr] | ^^^^^^^^^^^^ help: change it to: `clippy::match_as_ref` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(renamed_and_removed_lints)] on by default [INFO] [stderr] [INFO] [stderr] warning: lint name `match_as_ref` is deprecated and may not have an effect in the future. Also `cfg_attr(cargo-clippy)` won't be necessary anymore [INFO] [stderr] --> src/app.rs:371:48 [INFO] [stderr] | [INFO] [stderr] 371 | #[cfg_attr(feature = "cargo-clippy", allow(match_as_ref))] [INFO] [stderr] | ^^^^^^^^^^^^ help: change it to: `clippy::match_as_ref` [INFO] [stderr] [INFO] [stderr] warning: lint name `print_stdout` is deprecated and may not have an effect in the future. Also `cfg_attr(cargo-clippy)` won't be necessary anymore [INFO] [stderr] --> src/cmd/config.rs:37:44 [INFO] [stderr] | [INFO] [stderr] 37 | #[cfg_attr(feature = "cargo-clippy", allow(print_stdout))] [INFO] [stderr] | ^^^^^^^^^^^^ help: change it to: `clippy::print_stdout` [INFO] [stderr] [INFO] [stderr] warning: lint name `print_stdout` is deprecated and may not have an effect in the future. Also `cfg_attr(cargo-clippy)` won't be necessary anymore [INFO] [stderr] --> src/cmd/pull.rs:75:44 [INFO] [stderr] | [INFO] [stderr] 75 | #[cfg_attr(feature = "cargo-clippy", allow(print_stdout))] [INFO] [stderr] | ^^^^^^^^^^^^ help: change it to: `clippy::print_stdout` [INFO] [stderr] [INFO] [stderr] warning: lint name `cast_possible_truncation` is deprecated and may not have an effect in the future. Also `cfg_attr(cargo-clippy)` won't be necessary anymore [INFO] [stderr] --> src/cmd/pull.rs:642:22 [INFO] [stderr] | [INFO] [stderr] 642 | allow(cast_possible_truncation, many_single_char_names))] [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: change it to: `clippy::cast_possible_truncation` [INFO] [stderr] [INFO] [stderr] warning: lint name `many_single_char_names` is deprecated and may not have an effect in the future. Also `cfg_attr(cargo-clippy)` won't be necessary anymore [INFO] [stderr] --> src/cmd/pull.rs:642:48 [INFO] [stderr] | [INFO] [stderr] 642 | allow(cast_possible_truncation, many_single_char_names))] [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: change it to: `clippy::many_single_char_names` [INFO] [stderr] [INFO] [stderr] warning: lint name `print_stdout` is deprecated and may not have an effect in the future. Also `cfg_attr(cargo-clippy)` won't be necessary anymore [INFO] [stderr] --> src/cmd/status.rs:56:44 [INFO] [stderr] | [INFO] [stderr] 56 | #[cfg_attr(feature = "cargo-clippy", allow(print_stdout))] [INFO] [stderr] | ^^^^^^^^^^^^ help: change it to: `clippy::print_stdout` [INFO] [stderr] [INFO] [stderr] warning: lint name `match_as_ref` is deprecated and may not have an effect in the future. Also `cfg_attr(cargo-clippy)` won't be necessary anymore [INFO] [stderr] --> src/app.rs:362:48 [INFO] [stderr] | [INFO] [stderr] 362 | #[cfg_attr(feature = "cargo-clippy", allow(match_as_ref))] [INFO] [stderr] | ^^^^^^^^^^^^ help: change it to: `clippy::match_as_ref` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(renamed_and_removed_lints)] on by default [INFO] [stderr] [INFO] [stderr] warning: lint name `match_as_ref` is deprecated and may not have an effect in the future. Also `cfg_attr(cargo-clippy)` won't be necessary anymore [INFO] [stderr] --> src/app.rs:371:48 [INFO] [stderr] | [INFO] [stderr] 371 | #[cfg_attr(feature = "cargo-clippy", allow(match_as_ref))] [INFO] [stderr] | ^^^^^^^^^^^^ help: change it to: `clippy::match_as_ref` [INFO] [stderr] [INFO] [stderr] warning: lint name `print_stdout` is deprecated and may not have an effect in the future. Also `cfg_attr(cargo-clippy)` won't be necessary anymore [INFO] [stderr] --> src/cmd/config.rs:37:44 [INFO] [stderr] | [INFO] [stderr] 37 | #[cfg_attr(feature = "cargo-clippy", allow(print_stdout))] [INFO] [stderr] | ^^^^^^^^^^^^ help: change it to: `clippy::print_stdout` [INFO] [stderr] [INFO] [stderr] warning: lint name `print_stdout` is deprecated and may not have an effect in the future. Also `cfg_attr(cargo-clippy)` won't be necessary anymore [INFO] [stderr] --> src/cmd/pull.rs:75:44 [INFO] [stderr] | [INFO] [stderr] 75 | #[cfg_attr(feature = "cargo-clippy", allow(print_stdout))] [INFO] [stderr] | ^^^^^^^^^^^^ help: change it to: `clippy::print_stdout` [INFO] [stderr] [INFO] [stderr] warning: lint name `cast_possible_truncation` is deprecated and may not have an effect in the future. Also `cfg_attr(cargo-clippy)` won't be necessary anymore [INFO] [stderr] --> src/cmd/pull.rs:642:22 [INFO] [stderr] | [INFO] [stderr] 642 | allow(cast_possible_truncation, many_single_char_names))] [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: change it to: `clippy::cast_possible_truncation` [INFO] [stderr] [INFO] [stderr] warning: lint name `many_single_char_names` is deprecated and may not have an effect in the future. Also `cfg_attr(cargo-clippy)` won't be necessary anymore [INFO] [stderr] --> src/cmd/pull.rs:642:48 [INFO] [stderr] | [INFO] [stderr] 642 | allow(cast_possible_truncation, many_single_char_names))] [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: change it to: `clippy::many_single_char_names` [INFO] [stderr] [INFO] [stderr] warning: lint name `print_stdout` is deprecated and may not have an effect in the future. Also `cfg_attr(cargo-clippy)` won't be necessary anymore [INFO] [stderr] --> src/cmd/status.rs:56:44 [INFO] [stderr] | [INFO] [stderr] 56 | #[cfg_attr(feature = "cargo-clippy", allow(print_stdout))] [INFO] [stderr] | ^^^^^^^^^^^^ help: change it to: `clippy::print_stdout` [INFO] [stderr] [INFO] [stderr] warning: lint name `match_as_ref` is deprecated and may not have an effect in the future. Also `cfg_attr(cargo-clippy)` won't be necessary anymore [INFO] [stderr] --> src/app.rs:362:48 [INFO] [stderr] | [INFO] [stderr] 362 | #[cfg_attr(feature = "cargo-clippy", allow(match_as_ref))] [INFO] [stderr] | ^^^^^^^^^^^^ help: change it to: `clippy::match_as_ref` [INFO] [stderr] [INFO] [stderr] warning: lint name `match_as_ref` is deprecated and may not have an effect in the future. Also `cfg_attr(cargo-clippy)` won't be necessary anymore [INFO] [stderr] --> src/app.rs:362:48 [INFO] [stderr] | [INFO] [stderr] 362 | #[cfg_attr(feature = "cargo-clippy", allow(match_as_ref))] [INFO] [stderr] | ^^^^^^^^^^^^ help: change it to: `clippy::match_as_ref` [INFO] [stderr] [INFO] [stderr] warning: use of `expect` followed by a function call [INFO] [stderr] --> src/app.rs:198:56 [INFO] [stderr] | [INFO] [stderr] 198 | path[1..].split(MAIN_SEPARATOR).nth(0).expect(&format!( [INFO] [stderr] | ________________________________________________________^ [INFO] [stderr] 199 | | "splitting '{}' on MAIN_SEPARATOR ('{}') failed", [INFO] [stderr] 200 | | path, MAIN_SEPARATOR [INFO] [stderr] 201 | | )); [INFO] [stderr] | |__________________^ help: try this: `unwrap_or_else(|| panic!("splitting '{}' on MAIN_SEPARATOR ('{}') failed", path))` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::expect_fun_call)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#expect_fun_call [INFO] [stderr] [INFO] [stderr] warning: use of `expect` followed by a function call [INFO] [stderr] --> src/app.rs:415:43 [INFO] [stderr] | [INFO] [stderr] 415 | Repository::open(&self.full_path).expect(&format!( [INFO] [stderr] | ___________________________________________^ [INFO] [stderr] 416 | | "failed to open git repository at '{}'", [INFO] [stderr] 417 | | self.full_path [INFO] [stderr] 418 | | )) [INFO] [stderr] | |__________^ help: try this: `unwrap_or_else(|_| panic!("failed to open git repository at '{}'", self.full_path))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#expect_fun_call [INFO] [stderr] [INFO] [stderr] warning: use of `expect` followed by a function call [INFO] [stderr] --> src/cmd/pull.rs:80:10 [INFO] [stderr] | [INFO] [stderr] 80 | .expect(&format!("{} to have an argument", CONCURRENT_ARG)); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `unwrap_or_else(|| panic!("{} to have an argument", CONCURRENT_ARG))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#expect_fun_call [INFO] [stderr] [INFO] [stderr] warning: use of `expect` followed by a function call [INFO] [stderr] --> src/cmd/status.rs:230:43 [INFO] [stderr] | [INFO] [stderr] 230 | let summary = cache.get(repo).expect(&format!( [INFO] [stderr] | ___________________________________________^ [INFO] [stderr] 231 | | "failed to get summary from cache for repo '{}'", [INFO] [stderr] 232 | | repo.name_or_default() [INFO] [stderr] 233 | | )); [INFO] [stderr] | |______________^ help: try this: `unwrap_or_else(|| panic!("failed to get summary from cache for repo '{}'", repo.name_or_default()))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#expect_fun_call [INFO] [stderr] [INFO] [stderr] warning: use of `expect` followed by a function call [INFO] [stderr] --> src/app.rs:198:56 [INFO] [stderr] | [INFO] [stderr] 198 | path[1..].split(MAIN_SEPARATOR).nth(0).expect(&format!( [INFO] [stderr] | ________________________________________________________^ [INFO] [stderr] 199 | | "splitting '{}' on MAIN_SEPARATOR ('{}') failed", [INFO] [stderr] 200 | | path, MAIN_SEPARATOR [INFO] [stderr] 201 | | )); [INFO] [stderr] | |__________________^ help: try this: `unwrap_or_else(|| panic!("splitting '{}' on MAIN_SEPARATOR ('{}') failed", path))` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::expect_fun_call)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#expect_fun_call [INFO] [stderr] [INFO] [stderr] warning: use of `expect` followed by a function call [INFO] [stderr] --> src/app.rs:415:43 [INFO] [stderr] | [INFO] [stderr] 415 | Repository::open(&self.full_path).expect(&format!( [INFO] [stderr] | ___________________________________________^ [INFO] [stderr] 416 | | "failed to open git repository at '{}'", [INFO] [stderr] 417 | | self.full_path [INFO] [stderr] 418 | | )) [INFO] [stderr] | |__________^ help: try this: `unwrap_or_else(|_| panic!("failed to open git repository at '{}'", self.full_path))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#expect_fun_call [INFO] [stderr] [INFO] [stderr] warning: use of `expect` followed by a function call [INFO] [stderr] --> src/cmd/pull.rs:80:10 [INFO] [stderr] | [INFO] [stderr] 80 | .expect(&format!("{} to have an argument", CONCURRENT_ARG)); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `unwrap_or_else(|| panic!("{} to have an argument", CONCURRENT_ARG))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#expect_fun_call [INFO] [stderr] [INFO] [stderr] warning: use of `expect` followed by a function call [INFO] [stderr] --> src/cmd/status.rs:230:43 [INFO] [stderr] | [INFO] [stderr] 230 | let summary = cache.get(repo).expect(&format!( [INFO] [stderr] | ___________________________________________^ [INFO] [stderr] 231 | | "failed to get summary from cache for repo '{}'", [INFO] [stderr] 232 | | repo.name_or_default() [INFO] [stderr] 233 | | )); [INFO] [stderr] | |______________^ help: try this: `unwrap_or_else(|| panic!("failed to get summary from cache for repo '{}'", repo.name_or_default()))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#expect_fun_call [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 2m 46s [INFO] running `"docker" "inspect" "1b4f23bbd1136f60c76b38e82c0119f1f4ad94288ba944e185ae3e4de9e69922"` [INFO] running `"docker" "rm" "-f" "1b4f23bbd1136f60c76b38e82c0119f1f4ad94288ba944e185ae3e4de9e69922"` [INFO] [stdout] 1b4f23bbd1136f60c76b38e82c0119f1f4ad94288ba944e185ae3e4de9e69922