[INFO] updating cached repository deaz/adventofcode-2018 [INFO] running `"git" "fetch" "--all"` [INFO] [stdout] Fetching origin [INFO] [stderr] From git://github.com/deaz/adventofcode-2018 [INFO] [stderr] * branch HEAD -> FETCH_HEAD [INFO] running `"git" "clone" "work/cache/sources/gh/deaz/adventofcode-2018" "work/ex/clippy-test-run/sources/stable/gh/deaz/adventofcode-2018"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/deaz/adventofcode-2018'... [INFO] [stderr] done. [INFO] running `"git" "clone" "work/cache/sources/gh/deaz/adventofcode-2018" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/deaz/adventofcode-2018"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/deaz/adventofcode-2018'... [INFO] [stderr] done. [INFO] running `"git" "rev-parse" "HEAD"` [INFO] [stdout] 73d86c0e5fde50dd8029fa2aa376fdcb6fac913d [INFO] sha for GitHub repo deaz/adventofcode-2018: 73d86c0e5fde50dd8029fa2aa376fdcb6fac913d [INFO] validating manifest of deaz/adventofcode-2018 on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of deaz/adventofcode-2018 on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing deaz/adventofcode-2018 [INFO] finished frobbing deaz/adventofcode-2018 [INFO] frobbed toml for deaz/adventofcode-2018 written to work/ex/clippy-test-run/sources/stable/gh/deaz/adventofcode-2018/Cargo.toml [INFO] started frobbing deaz/adventofcode-2018 [INFO] finished frobbing deaz/adventofcode-2018 [INFO] frobbed toml for deaz/adventofcode-2018 written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/deaz/adventofcode-2018/Cargo.toml [INFO] crate deaz/adventofcode-2018 has a lockfile. skipping [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting deaz/adventofcode-2018 against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-1/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/gh/deaz/adventofcode-2018:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 45ad2f47d80a24f40b7957e4762795d9f11486783a80f3395d0ef29d710516aa [INFO] running `"docker" "start" "-a" "45ad2f47d80a24f40b7957e4762795d9f11486783a80f3395d0ef29d710516aa"` [INFO] [stderr] Checking adventofcode-2018 v0.1.0 (/opt/crater/workdir) [INFO] [stderr] warning: redundant closure found [INFO] [stderr] --> src/puzzle_07.rs:44:37 [INFO] [stderr] | [INFO] [stderr] 44 | .or_insert_with(|| Vec::new()) [INFO] [stderr] | ^^^^^^^^^^^^^ help: remove closure as shown: `Vec::new` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_closure)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure [INFO] [stderr] [INFO] [stderr] warning: called `.get().unwrap()` on a HashMap. Using `[]` is more clear and more concise [INFO] [stderr] --> src/puzzle_07.rs:57:19 [INFO] [stderr] | [INFO] [stderr] 57 | let minute = *state [INFO] [stderr] | ___________________^ [INFO] [stderr] 58 | | .get(id) [INFO] [stderr] 59 | | .unwrap() [INFO] [stderr] | |_________________^ help: try this: `&state[id]` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::get_unwrap)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#get_unwrap [INFO] [stderr] [INFO] [stderr] warning: redundant closure found [INFO] [stderr] --> src/puzzle_08.rs:44:37 [INFO] [stderr] | [INFO] [stderr] 44 | .or_insert_with(|| Vec::new()) [INFO] [stderr] | ^^^^^^^^^^^^^ help: remove closure as shown: `Vec::new` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure [INFO] [stderr] [INFO] [stderr] error: using `clone` on a double-reference; this will copy the reference instead of cloning the inner type [INFO] [stderr] --> src/puzzle_10.rs:4:13 [INFO] [stderr] | [INFO] [stderr] 4 | / input [INFO] [stderr] 5 | | .clone() [INFO] [stderr] | |________________________^ [INFO] [stderr] | [INFO] [stderr] = note: #[deny(clippy::clone_double_ref)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_double_ref [INFO] [stderr] help: try dereferencing it [INFO] [stderr] | [INFO] [stderr] 4 | &(*input).clone() [INFO] [stderr] | [INFO] [stderr] help: or try being explicit about what type to clone [INFO] [stderr] | [INFO] [stderr] 4 | &str::clone(input) [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/puzzle_11.rs:75:41 [INFO] [stderr] | [INFO] [stderr] 75 | fn dist((x1, y1): (i32, i32), (x2, y2): &(i32, i32)) -> i32 { [INFO] [stderr] | ^^^^^^^^^^^ help: consider passing by value instead: `(i32, i32)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::trivially_copy_pass_by_ref)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/puzzle_12.rs:51:41 [INFO] [stderr] | [INFO] [stderr] 51 | fn dist((x1, y1): (i32, i32), (x2, y2): &(i32, i32)) -> i32 { [INFO] [stderr] | ^^^^^^^^^^^ help: consider passing by value instead: `(i32, i32)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: redundant closure found [INFO] [stderr] --> src/puzzle_13.rs:16:33 [INFO] [stderr] | [INFO] [stderr] 16 | .or_insert_with(|| HashSet::new()) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: remove closure as shown: `HashSet::new` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure [INFO] [stderr] [INFO] [stderr] warning: redundant closure found [INFO] [stderr] --> src/puzzle_13.rs:18:49 [INFO] [stderr] | [INFO] [stderr] 18 | incoming.entry(from).or_insert_with(|| HashSet::new()); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: remove closure as shown: `HashSet::new` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure [INFO] [stderr] [INFO] [stderr] warning: redundant closure found [INFO] [stderr] --> src/puzzle_14.rs:20:33 [INFO] [stderr] | [INFO] [stderr] 20 | .or_insert_with(|| HashSet::new()) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: remove closure as shown: `HashSet::new` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure [INFO] [stderr] [INFO] [stderr] warning: redundant closure found [INFO] [stderr] --> src/puzzle_14.rs:22:49 [INFO] [stderr] | [INFO] [stderr] 22 | incoming.entry(from).or_insert_with(|| HashSet::new()); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: remove closure as shown: `HashSet::new` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure [INFO] [stderr] [INFO] [stderr] warning: redundant closure found [INFO] [stderr] --> src/puzzle_07.rs:44:37 [INFO] [stderr] | [INFO] [stderr] 44 | .or_insert_with(|| Vec::new()) [INFO] [stderr] | ^^^^^^^^^^^^^ help: remove closure as shown: `Vec::new` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_closure)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure [INFO] [stderr] [INFO] [stderr] warning: called `.get().unwrap()` on a HashMap. Using `[]` is more clear and more concise [INFO] [stderr] --> src/puzzle_07.rs:57:19 [INFO] [stderr] | [INFO] [stderr] 57 | let minute = *state [INFO] [stderr] | ___________________^ [INFO] [stderr] 58 | | .get(id) [INFO] [stderr] 59 | | .unwrap() [INFO] [stderr] | |_________________^ help: try this: `&state[id]` [INFO] [stderr] error: aborting due to previous error [INFO] [stderr] [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::get_unwrap)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#get_unwrap [INFO] [stderr] [INFO] [stderr] warning: redundant closure found [INFO] [stderr] --> src/puzzle_08.rs:44:37 [INFO] [stderr] | [INFO] [stderr] 44 | .or_insert_with(|| Vec::new()) [INFO] [stderr] | ^^^^^^^^^^^^^ help: remove closure as shown: `Vec::new` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure [INFO] [stderr] [INFO] [stderr] error: Could not compile `adventofcode-2018`. [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stderr] error: using `clone` on a double-reference; this will copy the reference instead of cloning the inner type [INFO] [stderr] --> src/puzzle_10.rs:4:13 [INFO] [stderr] | [INFO] [stderr] 4 | / input [INFO] [stderr] 5 | | .clone() [INFO] [stderr] | |________________________^ [INFO] [stderr] | [INFO] [stderr] = note: #[deny(clippy::clone_double_ref)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_double_ref [INFO] [stderr] help: try dereferencing it [INFO] [stderr] | [INFO] [stderr] 4 | &(*input).clone() [INFO] [stderr] | [INFO] [stderr] help: or try being explicit about what type to clone [INFO] [stderr] | [INFO] [stderr] 4 | &str::clone(input) [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/puzzle_11.rs:75:41 [INFO] [stderr] | [INFO] [stderr] 75 | fn dist((x1, y1): (i32, i32), (x2, y2): &(i32, i32)) -> i32 { [INFO] [stderr] | ^^^^^^^^^^^ help: consider passing by value instead: `(i32, i32)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::trivially_copy_pass_by_ref)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/puzzle_12.rs:51:41 [INFO] [stderr] | [INFO] [stderr] 51 | fn dist((x1, y1): (i32, i32), (x2, y2): &(i32, i32)) -> i32 { [INFO] [stderr] | ^^^^^^^^^^^ help: consider passing by value instead: `(i32, i32)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: redundant closure found [INFO] [stderr] --> src/puzzle_13.rs:16:33 [INFO] [stderr] | [INFO] [stderr] 16 | .or_insert_with(|| HashSet::new()) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: remove closure as shown: `HashSet::new` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure [INFO] [stderr] [INFO] [stderr] warning: redundant closure found [INFO] [stderr] --> src/puzzle_13.rs:18:49 [INFO] [stderr] | [INFO] [stderr] 18 | incoming.entry(from).or_insert_with(|| HashSet::new()); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: remove closure as shown: `HashSet::new` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure [INFO] [stderr] [INFO] [stderr] warning: redundant closure found [INFO] [stderr] --> src/puzzle_14.rs:20:33 [INFO] [stderr] | [INFO] [stderr] 20 | .or_insert_with(|| HashSet::new()) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: remove closure as shown: `HashSet::new` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure [INFO] [stderr] [INFO] [stderr] warning: redundant closure found [INFO] [stderr] --> src/puzzle_14.rs:22:49 [INFO] [stderr] | [INFO] [stderr] 22 | incoming.entry(from).or_insert_with(|| HashSet::new()); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: remove closure as shown: `HashSet::new` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure [INFO] [stderr] [INFO] [stderr] error: aborting due to previous error [INFO] [stderr] [INFO] [stderr] error: Could not compile `adventofcode-2018`. [INFO] [stderr] [INFO] [stderr] To learn more, run the command again with --verbose. [INFO] running `"docker" "inspect" "45ad2f47d80a24f40b7957e4762795d9f11486783a80f3395d0ef29d710516aa"` [INFO] running `"docker" "rm" "-f" "45ad2f47d80a24f40b7957e4762795d9f11486783a80f3395d0ef29d710516aa"` [INFO] [stdout] 45ad2f47d80a24f40b7957e4762795d9f11486783a80f3395d0ef29d710516aa