[INFO] updating cached repository deathlyfrantic/rust-toy-coreutils
[INFO] running `"git" "fetch" "--all"`
[INFO] [stdout] Fetching origin
[INFO] [stderr] From git://github.com/deathlyfrantic/rust-toy-coreutils
[INFO] [stderr]  * branch            HEAD       -> FETCH_HEAD
[INFO] running `"git" "clone" "work/cache/sources/gh/deathlyfrantic/rust-toy-coreutils" "work/ex/clippy-test-run/sources/stable/gh/deathlyfrantic/rust-toy-coreutils"`
[INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/deathlyfrantic/rust-toy-coreutils'...
[INFO] [stderr] done.
[INFO] running `"git" "clone" "work/cache/sources/gh/deathlyfrantic/rust-toy-coreutils" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/deathlyfrantic/rust-toy-coreutils"`
[INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/deathlyfrantic/rust-toy-coreutils'...
[INFO] [stderr] done.
[INFO] running `"git" "rev-parse" "HEAD"`
[INFO] [stdout] e9b50fb345a500ab2578d0cd972c0bd07ac81c09
[INFO] sha for GitHub repo deathlyfrantic/rust-toy-coreutils: e9b50fb345a500ab2578d0cd972c0bd07ac81c09
[INFO] validating manifest of deathlyfrantic/rust-toy-coreutils on toolchain stable
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"`
[INFO] validating manifest of deathlyfrantic/rust-toy-coreutils on toolchain stable+rustflags=-Dclippy::into_iter_on_array
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"`
[INFO] started frobbing deathlyfrantic/rust-toy-coreutils
[INFO] finished frobbing deathlyfrantic/rust-toy-coreutils
[INFO] frobbed toml for deathlyfrantic/rust-toy-coreutils written to work/ex/clippy-test-run/sources/stable/gh/deathlyfrantic/rust-toy-coreutils/Cargo.toml
[INFO] started frobbing deathlyfrantic/rust-toy-coreutils
[INFO] finished frobbing deathlyfrantic/rust-toy-coreutils
[INFO] frobbed toml for deathlyfrantic/rust-toy-coreutils written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/deathlyfrantic/rust-toy-coreutils/Cargo.toml
[INFO] crate deathlyfrantic/rust-toy-coreutils has a lockfile. skipping
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"`
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"`
[INFO] linting deathlyfrantic/rust-toy-coreutils against stable for clippy-test-run
[INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-1/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/gh/deathlyfrantic/rust-toy-coreutils:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"`
[INFO] [stdout] bf7192af4dd8b44c68df166f1e1e63a8bd69a9d0da86aae48d9e14ff4bf33a4e
[INFO] running `"docker" "start" "-a" "bf7192af4dd8b44c68df166f1e1e63a8bd69a9d0da86aae48d9e14ff4bf33a4e"`
[INFO] [stderr]     Checking termsize v0.1.5
[INFO] [stderr]     Checking coreutils-rs v0.1.0 (/opt/crater/workdir)
[INFO] [stderr] warning: using `println!("")`
[INFO] [stderr]    --> src/ls.rs:146:17
[INFO] [stderr]     |
[INFO] [stderr] 146 |                 println!("");
[INFO] [stderr]     |                 ^^^^^^^^^^^^ help: replace it with: `println!()`
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::println_empty_string)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#println_empty_string
[INFO] [stderr] 
[INFO] [stderr] warning: using `println!("")`
[INFO] [stderr]    --> src/ls.rs:153:9
[INFO] [stderr]     |
[INFO] [stderr] 153 |         println!("");
[INFO] [stderr]     |         ^^^^^^^^^^^^ help: replace it with: `println!()`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#println_empty_string
[INFO] [stderr] 
[INFO] [stderr] warning: using `println!("")`
[INFO] [stderr]    --> src/ls.rs:146:17
[INFO] [stderr]     |
[INFO] [stderr] 146 |                 println!("");
[INFO] [stderr]     |                 ^^^^^^^^^^^^ help: replace it with: `println!()`
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::println_empty_string)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#println_empty_string
[INFO] [stderr] 
[INFO] [stderr] warning: using `println!("")`
[INFO] [stderr]    --> src/ls.rs:153:9
[INFO] [stderr]     |
[INFO] [stderr] 153 |         println!("");
[INFO] [stderr]     |         ^^^^^^^^^^^^ help: replace it with: `println!()`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#println_empty_string
[INFO] [stderr] 
[INFO] [stderr] warning: single-character string constant used as pattern
[INFO] [stderr]   --> src/ls.rs:68:37
[INFO] [stderr]    |
[INFO] [stderr] 68 |         is_hidden: path.starts_with("."),
[INFO] [stderr]    |                                     ^^^ help: try using a char instead: `'.'`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::single_char_pattern)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern
[INFO] [stderr] 
[INFO] [stderr] warning: identical conversion
[INFO] [stderr]   --> src/ls.rs:97:17
[INFO] [stderr]    |
[INFO] [stderr] 97 |     let mut s = String::from(old_str);
[INFO] [stderr]    |                 ^^^^^^^^^^^^^^^^^^^^^ help: consider removing `String::from()`: `old_str`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::identity_conversion)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_conversion
[INFO] [stderr] 
[INFO] [stderr] warning: length comparison to zero
[INFO] [stderr]    --> src/ls.rs:164:18
[INFO] [stderr]     |
[INFO] [stderr] 164 |     let dir = if args.len() > 0 {
[INFO] [stderr]     |                  ^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `!args.is_empty()`
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::len_zero)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero
[INFO] [stderr] 
[INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices.
[INFO] [stderr]  --> src/tree.rs:8:15
[INFO] [stderr]   |
[INFO] [stderr] 8 |     lines_at: &Vec<usize>,
[INFO] [stderr]   |               ^^^^^^^^^^^ help: change this to: `&[usize]`
[INFO] [stderr]   |
[INFO] [stderr]   = note: #[warn(clippy::ptr_arg)] on by default
[INFO] [stderr]   = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg
[INFO] [stderr] 
[INFO] [stderr] warning: single-character string constant used as pattern
[INFO] [stderr]   --> src/tree.rs:16:38
[INFO] [stderr]    |
[INFO] [stderr] 16 |                     if s.starts_with(".") {
[INFO] [stderr]    |                                      ^^^ help: try using a char instead: `'.'`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::single_char_pattern)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern
[INFO] [stderr] 
[INFO] [stderr] warning: single-character string constant used as pattern
[INFO] [stderr]   --> src/tree.rs:69:30
[INFO] [stderr]    |
[INFO] [stderr] 69 |                 .starts_with(".")
[INFO] [stderr]    |                              ^^^ help: try using a char instead: `'.'`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern
[INFO] [stderr] 
[INFO] [stderr] warning: length comparison to zero
[INFO] [stderr]   --> src/tree.rs:84:18
[INFO] [stderr]    |
[INFO] [stderr] 84 |     let dir = if args.len() > 0 {
[INFO] [stderr]    |                  ^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `!args.is_empty()`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::len_zero)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero
[INFO] [stderr] 
[INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices.
[INFO] [stderr]  --> src/tree.rs:8:15
[INFO] [stderr]   |
[INFO] [stderr] 8 |     lines_at: &Vec<usize>,
[INFO] [stderr]   |               ^^^^^^^^^^^ help: change this to: `&[usize]`
[INFO] [stderr]   |
[INFO] [stderr]   = note: #[warn(clippy::ptr_arg)] on by default
[INFO] [stderr]   = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg
[INFO] [stderr] 
[INFO] [stderr] warning: single-character string constant used as pattern
[INFO] [stderr]   --> src/tree.rs:16:38
[INFO] [stderr]    |
[INFO] [stderr] 16 |                     if s.starts_with(".") {
[INFO] [stderr]    |                                      ^^^ help: try using a char instead: `'.'`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::single_char_pattern)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern
[INFO] [stderr] 
[INFO] [stderr] warning: single-character string constant used as pattern
[INFO] [stderr]   --> src/tree.rs:69:30
[INFO] [stderr]    |
[INFO] [stderr] 69 |                 .starts_with(".")
[INFO] [stderr]    |                              ^^^ help: try using a char instead: `'.'`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern
[INFO] [stderr] 
[INFO] [stderr] warning: length comparison to zero
[INFO] [stderr]   --> src/tree.rs:84:18
[INFO] [stderr]    |
[INFO] [stderr] 84 |     let dir = if args.len() > 0 {
[INFO] [stderr]    |                  ^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `!args.is_empty()`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::len_zero)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero
[INFO] [stderr] 
[INFO] [stderr] warning: single-character string constant used as pattern
[INFO] [stderr]   --> src/ls.rs:68:37
[INFO] [stderr]    |
[INFO] [stderr] 68 |         is_hidden: path.starts_with("."),
[INFO] [stderr]    |                                     ^^^ help: try using a char instead: `'.'`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::single_char_pattern)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern
[INFO] [stderr] 
[INFO] [stderr] warning: identical conversion
[INFO] [stderr]   --> src/ls.rs:97:17
[INFO] [stderr]    |
[INFO] [stderr] 97 |     let mut s = String::from(old_str);
[INFO] [stderr]    |                 ^^^^^^^^^^^^^^^^^^^^^ help: consider removing `String::from()`: `old_str`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::identity_conversion)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_conversion
[INFO] [stderr] 
[INFO] [stderr] warning: length comparison to zero
[INFO] [stderr]    --> src/ls.rs:164:18
[INFO] [stderr]     |
[INFO] [stderr] 164 |     let dir = if args.len() > 0 {
[INFO] [stderr]     |                  ^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `!args.is_empty()`
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::len_zero)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero
[INFO] [stderr] 
[INFO] [stderr]     Finished dev [unoptimized + debuginfo] target(s) in 2.08s
[INFO] running `"docker" "inspect" "bf7192af4dd8b44c68df166f1e1e63a8bd69a9d0da86aae48d9e14ff4bf33a4e"`
[INFO] running `"docker" "rm" "-f" "bf7192af4dd8b44c68df166f1e1e63a8bd69a9d0da86aae48d9e14ff4bf33a4e"`
[INFO] [stdout] bf7192af4dd8b44c68df166f1e1e63a8bd69a9d0da86aae48d9e14ff4bf33a4e