[INFO] updating cached repository dbasedow/imgdiff
[INFO] running `"git" "fetch" "--all"`
[INFO] [stdout] Fetching origin
[INFO] [stderr] From git://github.com/dbasedow/imgdiff
[INFO] [stderr]  * branch            HEAD       -> FETCH_HEAD
[INFO] running `"git" "clone" "work/cache/sources/gh/dbasedow/imgdiff" "work/ex/clippy-test-run/sources/stable/gh/dbasedow/imgdiff"`
[INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/dbasedow/imgdiff'...
[INFO] [stderr] done.
[INFO] running `"git" "clone" "work/cache/sources/gh/dbasedow/imgdiff" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/dbasedow/imgdiff"`
[INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/dbasedow/imgdiff'...
[INFO] [stderr] done.
[INFO] running `"git" "rev-parse" "HEAD"`
[INFO] [stdout] 5b4b6181c00bee72fd6d6451beb764ffa181f703
[INFO] sha for GitHub repo dbasedow/imgdiff: 5b4b6181c00bee72fd6d6451beb764ffa181f703
[INFO] validating manifest of dbasedow/imgdiff on toolchain stable
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"`
[INFO] validating manifest of dbasedow/imgdiff on toolchain stable+rustflags=-Dclippy::into_iter_on_array
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"`
[INFO] started frobbing dbasedow/imgdiff
[INFO] finished frobbing dbasedow/imgdiff
[INFO] frobbed toml for dbasedow/imgdiff written to work/ex/clippy-test-run/sources/stable/gh/dbasedow/imgdiff/Cargo.toml
[INFO] started frobbing dbasedow/imgdiff
[INFO] finished frobbing dbasedow/imgdiff
[INFO] frobbed toml for dbasedow/imgdiff written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/dbasedow/imgdiff/Cargo.toml
[INFO] crate dbasedow/imgdiff has a lockfile. skipping
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"`
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"`
[INFO] linting dbasedow/imgdiff against stable for clippy-test-run
[INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-3/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/gh/dbasedow/imgdiff:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"`
[INFO] [stdout] 6388091e02d854e9a33cb21063e66eabb52da0b40772107dc92c10b597fd4bd5
[INFO] running `"docker" "start" "-a" "6388091e02d854e9a33cb21063e66eabb52da0b40772107dc92c10b597fd4bd5"`
[INFO] [stderr]     Checking image v0.18.0
[INFO] [stderr]     Checking imgdiff v0.1.0 (/opt/crater/workdir)
[INFO] [stderr] warning: unused variable: `left`
[INFO] [stderr]   --> src/main.rs:20:12
[INFO] [stderr]    |
[INFO] [stderr] 20 | fn diff_bw(left: &[u8], right: &[u8]) -> u8 {
[INFO] [stderr]    |            ^^^^ help: consider using `_left` instead
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(unused_variables)] on by default
[INFO] [stderr] 
[INFO] [stderr] warning: unused variable: `right`
[INFO] [stderr]   --> src/main.rs:20:25
[INFO] [stderr]    |
[INFO] [stderr] 20 | fn diff_bw(left: &[u8], right: &[u8]) -> u8 {
[INFO] [stderr]    |                         ^^^^^ help: consider using `_right` instead
[INFO] [stderr] 
[INFO] [stderr] warning: function is never used: `diff_bw`
[INFO] [stderr]   --> src/main.rs:20:1
[INFO] [stderr]    |
[INFO] [stderr] 20 | fn diff_bw(left: &[u8], right: &[u8]) -> u8 {
[INFO] [stderr]    | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(dead_code)] on by default
[INFO] [stderr] 
[INFO] [stderr] warning: casting u8 to i32 may become silently lossy if types change
[INFO] [stderr]   --> src/main.rs:30:17
[INFO] [stderr]    |
[INFO] [stderr] 30 |         sum += (*l as i32 - *r as i32).abs();
[INFO] [stderr]    |                 ^^^^^^^^^ help: try: `i32::from(*l)`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::cast_lossless)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless
[INFO] [stderr] 
[INFO] [stderr] warning: casting u8 to i32 may become silently lossy if types change
[INFO] [stderr]   --> src/main.rs:30:29
[INFO] [stderr]    |
[INFO] [stderr] 30 |         sum += (*l as i32 - *r as i32).abs();
[INFO] [stderr]    |                             ^^^^^^^^^ help: try: `i32::from(*r)`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless
[INFO] [stderr] 
[INFO] [stderr] warning: use of `expect` followed by a function call
[INFO] [stderr]   --> src/main.rs:38:32
[INFO] [stderr]    |
[INFO] [stderr] 38 |     let f1 = File::open(path1).expect(&format!("error opening file {}", path1));
[INFO] [stderr]    |                                ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `unwrap_or_else(|_| panic!("error opening file {}", path1))`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::expect_fun_call)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#expect_fun_call
[INFO] [stderr] 
[INFO] [stderr] warning: use of `expect` followed by a function call
[INFO] [stderr]   --> src/main.rs:39:32
[INFO] [stderr]    |
[INFO] [stderr] 39 |     let f2 = File::open(path2).expect(&format!("error opening file {}", path2));
[INFO] [stderr]    |                                ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `unwrap_or_else(|_| panic!("error opening file {}", path2))`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#expect_fun_call
[INFO] [stderr] 
[INFO] [stderr] warning: unused variable: `left`
[INFO] [stderr]   --> src/main.rs:20:12
[INFO] [stderr]    |
[INFO] [stderr] 20 | fn diff_bw(left: &[u8], right: &[u8]) -> u8 {
[INFO] [stderr]    |            ^^^^ help: consider using `_left` instead
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(unused_variables)] on by default
[INFO] [stderr] 
[INFO] [stderr] warning: unused variable: `right`
[INFO] [stderr]   --> src/main.rs:20:25
[INFO] [stderr]    |
[INFO] [stderr] 20 | fn diff_bw(left: &[u8], right: &[u8]) -> u8 {
[INFO] [stderr]    |                         ^^^^^ help: consider using `_right` instead
[INFO] [stderr] 
[INFO] [stderr] warning: function is never used: `diff_bw`
[INFO] [stderr]   --> src/main.rs:20:1
[INFO] [stderr]    |
[INFO] [stderr] 20 | fn diff_bw(left: &[u8], right: &[u8]) -> u8 {
[INFO] [stderr]    | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(dead_code)] on by default
[INFO] [stderr] 
[INFO] [stderr] warning: casting u8 to i32 may become silently lossy if types change
[INFO] [stderr]   --> src/main.rs:30:17
[INFO] [stderr]    |
[INFO] [stderr] 30 |         sum += (*l as i32 - *r as i32).abs();
[INFO] [stderr]    |                 ^^^^^^^^^ help: try: `i32::from(*l)`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::cast_lossless)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless
[INFO] [stderr] 
[INFO] [stderr] warning: casting u8 to i32 may become silently lossy if types change
[INFO] [stderr]   --> src/main.rs:30:29
[INFO] [stderr]    |
[INFO] [stderr] 30 |         sum += (*l as i32 - *r as i32).abs();
[INFO] [stderr]    |                             ^^^^^^^^^ help: try: `i32::from(*r)`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless
[INFO] [stderr] 
[INFO] [stderr] warning: use of `expect` followed by a function call
[INFO] [stderr]   --> src/main.rs:38:32
[INFO] [stderr]    |
[INFO] [stderr] 38 |     let f1 = File::open(path1).expect(&format!("error opening file {}", path1));
[INFO] [stderr]    |                                ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `unwrap_or_else(|_| panic!("error opening file {}", path1))`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::expect_fun_call)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#expect_fun_call
[INFO] [stderr] 
[INFO] [stderr] warning: use of `expect` followed by a function call
[INFO] [stderr]   --> src/main.rs:39:32
[INFO] [stderr]    |
[INFO] [stderr] 39 |     let f2 = File::open(path2).expect(&format!("error opening file {}", path2));
[INFO] [stderr]    |                                ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `unwrap_or_else(|_| panic!("error opening file {}", path2))`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#expect_fun_call
[INFO] [stderr] 
[INFO] [stderr]     Finished dev [unoptimized + debuginfo] target(s) in 7.57s
[INFO] running `"docker" "inspect" "6388091e02d854e9a33cb21063e66eabb52da0b40772107dc92c10b597fd4bd5"`
[INFO] running `"docker" "rm" "-f" "6388091e02d854e9a33cb21063e66eabb52da0b40772107dc92c10b597fd4bd5"`
[INFO] [stdout] 6388091e02d854e9a33cb21063e66eabb52da0b40772107dc92c10b597fd4bd5