[INFO] updating cached repository dbasedow/cantact [INFO] running `"git" "fetch" "--all"` [INFO] [stdout] Fetching origin [INFO] [stderr] From git://github.com/dbasedow/cantact [INFO] [stderr] * branch HEAD -> FETCH_HEAD [INFO] running `"git" "clone" "work/cache/sources/gh/dbasedow/cantact" "work/ex/clippy-test-run/sources/stable/gh/dbasedow/cantact"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/dbasedow/cantact'... [INFO] [stderr] done. [INFO] running `"git" "clone" "work/cache/sources/gh/dbasedow/cantact" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/dbasedow/cantact"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/dbasedow/cantact'... [INFO] [stderr] done. [INFO] running `"git" "rev-parse" "HEAD"` [INFO] [stdout] 9f5f1564a25e04535c750976cf618eeb58159db9 [INFO] sha for GitHub repo dbasedow/cantact: 9f5f1564a25e04535c750976cf618eeb58159db9 [INFO] validating manifest of dbasedow/cantact on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of dbasedow/cantact on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing dbasedow/cantact [INFO] finished frobbing dbasedow/cantact [INFO] frobbed toml for dbasedow/cantact written to work/ex/clippy-test-run/sources/stable/gh/dbasedow/cantact/Cargo.toml [INFO] started frobbing dbasedow/cantact [INFO] finished frobbing dbasedow/cantact [INFO] frobbed toml for dbasedow/cantact written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/dbasedow/cantact/Cargo.toml [INFO] crate dbasedow/cantact has a lockfile. skipping [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting dbasedow/cantact against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-5/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/gh/dbasedow/cantact:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] d0a60c724056f086bee43d72e110a01aeaf6b93fd4739f4668c51d9d0f899553 [INFO] running `"docker" "start" "-a" "d0a60c724056f086bee43d72e110a01aeaf6b93fd4739f4668c51d9d0f899553"` [INFO] [stderr] Checking ioctl-rs v0.1.6 [INFO] [stderr] Checking serial-unix v0.4.0 [INFO] [stderr] Checking serial v0.4.0 [INFO] [stderr] Checking cantact v0.1.0 (/opt/crater/workdir) [INFO] [stderr] warning: unused import: `std::io::BufReader` [INFO] [stderr] --> src/main.rs:7:5 [INFO] [stderr] | [INFO] [stderr] 7 | use std::io::BufReader; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_imports)] on by default [INFO] [stderr] [INFO] [stderr] warning: unused import: `std::io::prelude` [INFO] [stderr] --> src/main.rs:6:5 [INFO] [stderr] | [INFO] [stderr] 6 | use std::io::prelude::*; [INFO] [stderr] | ^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: unused variable: `frame` [INFO] [stderr] --> src/main.rs:47:21 [INFO] [stderr] | [INFO] [stderr] 47 | let frame = slcan::parse_serial_line(&frame_buf[0..i]); [INFO] [stderr] | ^^^^^ help: consider using `_frame` instead [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_variables)] on by default [INFO] [stderr] [INFO] [stderr] warning: unused variable: `source_address` [INFO] [stderr] --> src/protocols/transport/isotp.rs:43:9 [INFO] [stderr] | [INFO] [stderr] 43 | source_address: u32, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: consider using `_source_address` instead [INFO] [stderr] [INFO] [stderr] warning: unused variable: `target_address` [INFO] [stderr] --> src/protocols/transport/isotp.rs:44:9 [INFO] [stderr] | [INFO] [stderr] 44 | target_address: u32, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: consider using `_target_address` instead [INFO] [stderr] [INFO] [stderr] warning: unused variable: `data` [INFO] [stderr] --> src/protocols/transport/isotp.rs:45:9 [INFO] [stderr] | [INFO] [stderr] 45 | data: &[u8], [INFO] [stderr] | ^^^^ help: consider using `_data` instead [INFO] [stderr] [INFO] [stderr] warning: struct is never constructed: `IsoTp` [INFO] [stderr] --> src/protocols/transport/isotp.rs:14:1 [INFO] [stderr] | [INFO] [stderr] 14 | struct IsoTp {} [INFO] [stderr] | ^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(dead_code)] on by default [INFO] [stderr] [INFO] [stderr] warning: enum is never used: `MessageType` [INFO] [stderr] --> src/protocols/transport/isotp.rs:16:1 [INFO] [stderr] | [INFO] [stderr] 16 | enum MessageType { [INFO] [stderr] | ^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: enum is never used: `TargetAddressType` [INFO] [stderr] --> src/protocols/transport/isotp.rs:21:1 [INFO] [stderr] | [INFO] [stderr] 21 | enum TargetAddressType { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: enum is never used: `ResultType` [INFO] [stderr] --> src/protocols/transport/isotp.rs:26:1 [INFO] [stderr] | [INFO] [stderr] 26 | enum ResultType { [INFO] [stderr] | ^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: struct is never constructed: `Message` [INFO] [stderr] --> src/protocols/transport/isotp.rs:39:1 [INFO] [stderr] | [INFO] [stderr] 39 | struct Message {} [INFO] [stderr] | ^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: method is never used: `requestTransfer` [INFO] [stderr] --> src/protocols/transport/isotp.rs:42:5 [INFO] [stderr] | [INFO] [stderr] 42 | / fn requestTransfer( [INFO] [stderr] 43 | | source_address: u32, [INFO] [stderr] 44 | | target_address: u32, [INFO] [stderr] 45 | | data: &[u8], [INFO] [stderr] 46 | | ) -> Result<(), ResultType> { [INFO] [stderr] 47 | | Ok(()) [INFO] [stderr] 48 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] [INFO] [stderr] error: handle written amount returned or use `Write::write_all` instead [INFO] [stderr] --> src/main.rs:34:5 [INFO] [stderr] | [INFO] [stderr] 34 | try!(port.write(b"C\r")); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[deny(clippy::unused_io_amount)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_io_amount [INFO] [stderr] = note: this error originates in a macro outside of the current crate (in Nightly builds, run with -Z external-macro-backtrace for more info) [INFO] [stderr] [INFO] [stderr] error: handle written amount returned or use `Write::write_all` instead [INFO] [stderr] --> src/main.rs:35:5 [INFO] [stderr] | [INFO] [stderr] 35 | try!(port.write(b"S6\r")); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_io_amount [INFO] [stderr] = note: this error originates in a macro outside of the current crate (in Nightly builds, run with -Z external-macro-backtrace for more info) [INFO] [stderr] [INFO] [stderr] error: handle written amount returned or use `Write::write_all` instead [INFO] [stderr] --> src/main.rs:36:5 [INFO] [stderr] | [INFO] [stderr] 36 | try!(port.write(b"O\r")); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_io_amount [INFO] [stderr] = note: this error originates in a macro outside of the current crate (in Nightly builds, run with -Z external-macro-backtrace for more info) [INFO] [stderr] [INFO] [stderr] warning: `if _ { .. } else { .. }` is an expression [INFO] [stderr] --> src/slcan.rs:14:5 [INFO] [stderr] | [INFO] [stderr] 14 | / let data_offset; [INFO] [stderr] 15 | | [INFO] [stderr] 16 | | if !frame.ext { [INFO] [stderr] 17 | | frame.id = hex_digit_to_int(line[3]).into(); [INFO] [stderr] ... | [INFO] [stderr] 34 | | data_offset = 10; [INFO] [stderr] 35 | | } [INFO] [stderr] | |_____^ help: it is more idiomatic to write: `let data_offset = if !frame.ext { ..; 5 } else { ..; 10 };` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::useless_let_if_seq)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_let_if_seq [INFO] [stderr] [INFO] [stderr] warning: manual implementation of an assign operation [INFO] [stderr] --> src/slcan.rs:18:9 [INFO] [stderr] | [INFO] [stderr] 18 | frame.id = frame.id | (hex_digit_to_int(line[2]) as u32) << 4; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `frame.id |= (hex_digit_to_int(line[2]) as u32) << 4` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::assign_op_pattern)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u32 may become silently lossy if types change [INFO] [stderr] --> src/slcan.rs:18:31 [INFO] [stderr] | [INFO] [stderr] 18 | frame.id = frame.id | (hex_digit_to_int(line[2]) as u32) << 4; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u32::from(hex_digit_to_int(line[2]))` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cast_lossless)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: manual implementation of an assign operation [INFO] [stderr] --> src/slcan.rs:19:9 [INFO] [stderr] | [INFO] [stderr] 19 | frame.id = frame.id | (hex_digit_to_int(line[1]) as u32) << 8; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `frame.id |= (hex_digit_to_int(line[1]) as u32) << 8` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u32 may become silently lossy if types change [INFO] [stderr] --> src/slcan.rs:19:31 [INFO] [stderr] | [INFO] [stderr] 19 | frame.id = frame.id | (hex_digit_to_int(line[1]) as u32) << 8; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u32::from(hex_digit_to_int(line[1]))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: manual implementation of an assign operation [INFO] [stderr] --> src/slcan.rs:25:9 [INFO] [stderr] | [INFO] [stderr] 25 | frame.id = frame.id | (hex_digit_to_int(line[7]) as u32) << 4; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `frame.id |= (hex_digit_to_int(line[7]) as u32) << 4` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u32 may become silently lossy if types change [INFO] [stderr] --> src/slcan.rs:25:31 [INFO] [stderr] | [INFO] [stderr] 25 | frame.id = frame.id | (hex_digit_to_int(line[7]) as u32) << 4; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u32::from(hex_digit_to_int(line[7]))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: manual implementation of an assign operation [INFO] [stderr] --> src/slcan.rs:26:9 [INFO] [stderr] | [INFO] [stderr] 26 | frame.id = frame.id | (hex_digit_to_int(line[6]) as u32) << 8; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `frame.id |= (hex_digit_to_int(line[6]) as u32) << 8` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u32 may become silently lossy if types change [INFO] [stderr] --> src/slcan.rs:26:31 [INFO] [stderr] | [INFO] [stderr] 26 | frame.id = frame.id | (hex_digit_to_int(line[6]) as u32) << 8; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u32::from(hex_digit_to_int(line[6]))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: manual implementation of an assign operation [INFO] [stderr] --> src/slcan.rs:27:9 [INFO] [stderr] | [INFO] [stderr] 27 | frame.id = frame.id | (hex_digit_to_int(line[5]) as u32) << 12; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `frame.id |= (hex_digit_to_int(line[5]) as u32) << 12` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u32 may become silently lossy if types change [INFO] [stderr] --> src/slcan.rs:27:31 [INFO] [stderr] | [INFO] [stderr] 27 | frame.id = frame.id | (hex_digit_to_int(line[5]) as u32) << 12; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u32::from(hex_digit_to_int(line[5]))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: manual implementation of an assign operation [INFO] [stderr] --> src/slcan.rs:28:9 [INFO] [stderr] | [INFO] [stderr] 28 | frame.id = frame.id | (hex_digit_to_int(line[4]) as u32) << 16; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `frame.id |= (hex_digit_to_int(line[4]) as u32) << 16` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u32 may become silently lossy if types change [INFO] [stderr] --> src/slcan.rs:28:31 [INFO] [stderr] | [INFO] [stderr] 28 | frame.id = frame.id | (hex_digit_to_int(line[4]) as u32) << 16; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u32::from(hex_digit_to_int(line[4]))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: manual implementation of an assign operation [INFO] [stderr] --> src/slcan.rs:29:9 [INFO] [stderr] | [INFO] [stderr] 29 | frame.id = frame.id | (hex_digit_to_int(line[3]) as u32) << 20; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `frame.id |= (hex_digit_to_int(line[3]) as u32) << 20` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u32 may become silently lossy if types change [INFO] [stderr] --> src/slcan.rs:29:31 [INFO] [stderr] | [INFO] [stderr] 29 | frame.id = frame.id | (hex_digit_to_int(line[3]) as u32) << 20; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u32::from(hex_digit_to_int(line[3]))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: manual implementation of an assign operation [INFO] [stderr] --> src/slcan.rs:30:9 [INFO] [stderr] | [INFO] [stderr] 30 | frame.id = frame.id | (hex_digit_to_int(line[2]) as u32) << 24; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `frame.id |= (hex_digit_to_int(line[2]) as u32) << 24` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u32 may become silently lossy if types change [INFO] [stderr] --> src/slcan.rs:30:31 [INFO] [stderr] | [INFO] [stderr] 30 | frame.id = frame.id | (hex_digit_to_int(line[2]) as u32) << 24; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u32::from(hex_digit_to_int(line[2]))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: manual implementation of an assign operation [INFO] [stderr] --> src/slcan.rs:31:9 [INFO] [stderr] | [INFO] [stderr] 31 | frame.id = frame.id | (hex_digit_to_int(line[1]) as u32) << 28; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `frame.id |= (hex_digit_to_int(line[1]) as u32) << 28` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u32 may become silently lossy if types change [INFO] [stderr] --> src/slcan.rs:31:31 [INFO] [stderr] | [INFO] [stderr] 31 | frame.id = frame.id | (hex_digit_to_int(line[1]) as u32) << 28; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u32::from(hex_digit_to_int(line[1]))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: the variable `i` is used as a loop counter. Consider using `for (i, item) in it.enumerate()` or similar iterators [INFO] [stderr] --> src/slcan.rs:44:18 [INFO] [stderr] | [INFO] [stderr] 44 | for b in it { [INFO] [stderr] | ^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::explicit_counter_loop)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#explicit_counter_loop [INFO] [stderr] [INFO] [stderr] warning: method `requestTransfer` should have a snake case name such as `request_transfer` [INFO] [stderr] --> src/protocols/transport/isotp.rs:42:5 [INFO] [stderr] | [INFO] [stderr] 42 | / fn requestTransfer( [INFO] [stderr] 43 | | source_address: u32, [INFO] [stderr] 44 | | target_address: u32, [INFO] [stderr] 45 | | data: &[u8], [INFO] [stderr] 46 | | ) -> Result<(), ResultType> { [INFO] [stderr] 47 | | Ok(()) [INFO] [stderr] 48 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(non_snake_case)] on by default [INFO] [stderr] [INFO] [stderr] error: aborting due to 3 previous errors [INFO] [stderr] [INFO] [stderr] error: Could not compile `cantact`. [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stderr] warning: unused import: `std::io::BufReader` [INFO] [stderr] --> src/main.rs:7:5 [INFO] [stderr] | [INFO] [stderr] 7 | use std::io::BufReader; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_imports)] on by default [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/slcan.rs:74:26 [INFO] [stderr] | [INFO] [stderr] 74 | assert_eq!(frame.id, 0x12345678); [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0x1234_5678` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::unreadable_literal)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/slcan.rs:81:26 [INFO] [stderr] | [INFO] [stderr] 81 | assert_eq!(frame.id, 0x12345678); [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0x1234_5678` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: unused import: `std::io::prelude` [INFO] [stderr] --> src/main.rs:6:5 [INFO] [stderr] | [INFO] [stderr] 6 | use std::io::prelude::*; [INFO] [stderr] | ^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: unused variable: `frame` [INFO] [stderr] --> src/main.rs:47:21 [INFO] [stderr] | [INFO] [stderr] 47 | let frame = slcan::parse_serial_line(&frame_buf[0..i]); [INFO] [stderr] | ^^^^^ help: consider using `_frame` instead [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_variables)] on by default [INFO] [stderr] [INFO] [stderr] warning: unused variable: `source_address` [INFO] [stderr] --> src/protocols/transport/isotp.rs:43:9 [INFO] [stderr] | [INFO] [stderr] 43 | source_address: u32, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: consider using `_source_address` instead [INFO] [stderr] [INFO] [stderr] warning: unused variable: `target_address` [INFO] [stderr] --> src/protocols/transport/isotp.rs:44:9 [INFO] [stderr] | [INFO] [stderr] 44 | target_address: u32, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: consider using `_target_address` instead [INFO] [stderr] [INFO] [stderr] warning: unused variable: `data` [INFO] [stderr] --> src/protocols/transport/isotp.rs:45:9 [INFO] [stderr] | [INFO] [stderr] 45 | data: &[u8], [INFO] [stderr] | ^^^^ help: consider using `_data` instead [INFO] [stderr] [INFO] [stderr] warning: struct is never constructed: `IsoTp` [INFO] [stderr] --> src/protocols/transport/isotp.rs:14:1 [INFO] [stderr] | [INFO] [stderr] 14 | struct IsoTp {} [INFO] [stderr] | ^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(dead_code)] on by default [INFO] [stderr] [INFO] [stderr] warning: enum is never used: `MessageType` [INFO] [stderr] --> src/protocols/transport/isotp.rs:16:1 [INFO] [stderr] | [INFO] [stderr] 16 | enum MessageType { [INFO] [stderr] | ^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: enum is never used: `TargetAddressType` [INFO] [stderr] --> src/protocols/transport/isotp.rs:21:1 [INFO] [stderr] | [INFO] [stderr] 21 | enum TargetAddressType { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: enum is never used: `ResultType` [INFO] [stderr] --> src/protocols/transport/isotp.rs:26:1 [INFO] [stderr] | [INFO] [stderr] 26 | enum ResultType { [INFO] [stderr] | ^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: struct is never constructed: `Message` [INFO] [stderr] --> src/protocols/transport/isotp.rs:39:1 [INFO] [stderr] | [INFO] [stderr] 39 | struct Message {} [INFO] [stderr] | ^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: method is never used: `requestTransfer` [INFO] [stderr] --> src/protocols/transport/isotp.rs:42:5 [INFO] [stderr] | [INFO] [stderr] 42 | / fn requestTransfer( [INFO] [stderr] 43 | | source_address: u32, [INFO] [stderr] 44 | | target_address: u32, [INFO] [stderr] 45 | | data: &[u8], [INFO] [stderr] 46 | | ) -> Result<(), ResultType> { [INFO] [stderr] 47 | | Ok(()) [INFO] [stderr] 48 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] [INFO] [stderr] error: handle written amount returned or use `Write::write_all` instead [INFO] [stderr] --> src/main.rs:34:5 [INFO] [stderr] | [INFO] [stderr] 34 | try!(port.write(b"C\r")); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[deny(clippy::unused_io_amount)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_io_amount [INFO] [stderr] = note: this error originates in a macro outside of the current crate (in Nightly builds, run with -Z external-macro-backtrace for more info) [INFO] [stderr] [INFO] [stderr] error: handle written amount returned or use `Write::write_all` instead [INFO] [stderr] --> src/main.rs:35:5 [INFO] [stderr] | [INFO] [stderr] 35 | try!(port.write(b"S6\r")); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_io_amount [INFO] [stderr] = note: this error originates in a macro outside of the current crate (in Nightly builds, run with -Z external-macro-backtrace for more info) [INFO] [stderr] [INFO] [stderr] error: handle written amount returned or use `Write::write_all` instead [INFO] [stderr] --> src/main.rs:36:5 [INFO] [stderr] | [INFO] [stderr] 36 | try!(port.write(b"O\r")); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_io_amount [INFO] [stderr] = note: this error originates in a macro outside of the current crate (in Nightly builds, run with -Z external-macro-backtrace for more info) [INFO] [stderr] [INFO] [stderr] warning: `if _ { .. } else { .. }` is an expression [INFO] [stderr] --> src/slcan.rs:14:5 [INFO] [stderr] | [INFO] [stderr] 14 | / let data_offset; [INFO] [stderr] 15 | | [INFO] [stderr] 16 | | if !frame.ext { [INFO] [stderr] 17 | | frame.id = hex_digit_to_int(line[3]).into(); [INFO] [stderr] ... | [INFO] [stderr] 34 | | data_offset = 10; [INFO] [stderr] 35 | | } [INFO] [stderr] | |_____^ help: it is more idiomatic to write: `let data_offset = if !frame.ext { ..; 5 } else { ..; 10 };` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::useless_let_if_seq)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_let_if_seq [INFO] [stderr] [INFO] [stderr] warning: manual implementation of an assign operation [INFO] [stderr] --> src/slcan.rs:18:9 [INFO] [stderr] | [INFO] [stderr] 18 | frame.id = frame.id | (hex_digit_to_int(line[2]) as u32) << 4; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `frame.id |= (hex_digit_to_int(line[2]) as u32) << 4` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::assign_op_pattern)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u32 may become silently lossy if types change [INFO] [stderr] --> src/slcan.rs:18:31 [INFO] [stderr] | [INFO] [stderr] 18 | frame.id = frame.id | (hex_digit_to_int(line[2]) as u32) << 4; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u32::from(hex_digit_to_int(line[2]))` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cast_lossless)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: manual implementation of an assign operation [INFO] [stderr] --> src/slcan.rs:19:9 [INFO] [stderr] | [INFO] [stderr] 19 | frame.id = frame.id | (hex_digit_to_int(line[1]) as u32) << 8; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `frame.id |= (hex_digit_to_int(line[1]) as u32) << 8` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u32 may become silently lossy if types change [INFO] [stderr] --> src/slcan.rs:19:31 [INFO] [stderr] | [INFO] [stderr] 19 | frame.id = frame.id | (hex_digit_to_int(line[1]) as u32) << 8; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u32::from(hex_digit_to_int(line[1]))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: manual implementation of an assign operation [INFO] [stderr] --> src/slcan.rs:25:9 [INFO] [stderr] | [INFO] [stderr] 25 | frame.id = frame.id | (hex_digit_to_int(line[7]) as u32) << 4; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `frame.id |= (hex_digit_to_int(line[7]) as u32) << 4` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u32 may become silently lossy if types change [INFO] [stderr] --> src/slcan.rs:25:31 [INFO] [stderr] | [INFO] [stderr] 25 | frame.id = frame.id | (hex_digit_to_int(line[7]) as u32) << 4; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u32::from(hex_digit_to_int(line[7]))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: manual implementation of an assign operation [INFO] [stderr] --> src/slcan.rs:26:9 [INFO] [stderr] | [INFO] [stderr] 26 | frame.id = frame.id | (hex_digit_to_int(line[6]) as u32) << 8; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `frame.id |= (hex_digit_to_int(line[6]) as u32) << 8` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u32 may become silently lossy if types change [INFO] [stderr] --> src/slcan.rs:26:31 [INFO] [stderr] | [INFO] [stderr] 26 | frame.id = frame.id | (hex_digit_to_int(line[6]) as u32) << 8; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u32::from(hex_digit_to_int(line[6]))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: manual implementation of an assign operation [INFO] [stderr] --> src/slcan.rs:27:9 [INFO] [stderr] | [INFO] [stderr] 27 | frame.id = frame.id | (hex_digit_to_int(line[5]) as u32) << 12; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `frame.id |= (hex_digit_to_int(line[5]) as u32) << 12` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u32 may become silently lossy if types change [INFO] [stderr] --> src/slcan.rs:27:31 [INFO] [stderr] | [INFO] [stderr] 27 | frame.id = frame.id | (hex_digit_to_int(line[5]) as u32) << 12; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u32::from(hex_digit_to_int(line[5]))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: manual implementation of an assign operation [INFO] [stderr] --> src/slcan.rs:28:9 [INFO] [stderr] | [INFO] [stderr] 28 | frame.id = frame.id | (hex_digit_to_int(line[4]) as u32) << 16; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `frame.id |= (hex_digit_to_int(line[4]) as u32) << 16` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u32 may become silently lossy if types change [INFO] [stderr] --> src/slcan.rs:28:31 [INFO] [stderr] | [INFO] [stderr] 28 | frame.id = frame.id | (hex_digit_to_int(line[4]) as u32) << 16; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u32::from(hex_digit_to_int(line[4]))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: manual implementation of an assign operation [INFO] [stderr] --> src/slcan.rs:29:9 [INFO] [stderr] | [INFO] [stderr] 29 | frame.id = frame.id | (hex_digit_to_int(line[3]) as u32) << 20; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `frame.id |= (hex_digit_to_int(line[3]) as u32) << 20` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u32 may become silently lossy if types change [INFO] [stderr] --> src/slcan.rs:29:31 [INFO] [stderr] | [INFO] [stderr] 29 | frame.id = frame.id | (hex_digit_to_int(line[3]) as u32) << 20; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u32::from(hex_digit_to_int(line[3]))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: manual implementation of an assign operation [INFO] [stderr] --> src/slcan.rs:30:9 [INFO] [stderr] | [INFO] [stderr] 30 | frame.id = frame.id | (hex_digit_to_int(line[2]) as u32) << 24; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `frame.id |= (hex_digit_to_int(line[2]) as u32) << 24` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u32 may become silently lossy if types change [INFO] [stderr] --> src/slcan.rs:30:31 [INFO] [stderr] | [INFO] [stderr] 30 | frame.id = frame.id | (hex_digit_to_int(line[2]) as u32) << 24; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u32::from(hex_digit_to_int(line[2]))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: manual implementation of an assign operation [INFO] [stderr] --> src/slcan.rs:31:9 [INFO] [stderr] | [INFO] [stderr] 31 | frame.id = frame.id | (hex_digit_to_int(line[1]) as u32) << 28; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `frame.id |= (hex_digit_to_int(line[1]) as u32) << 28` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u32 may become silently lossy if types change [INFO] [stderr] --> src/slcan.rs:31:31 [INFO] [stderr] | [INFO] [stderr] 31 | frame.id = frame.id | (hex_digit_to_int(line[1]) as u32) << 28; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u32::from(hex_digit_to_int(line[1]))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: the variable `i` is used as a loop counter. Consider using `for (i, item) in it.enumerate()` or similar iterators [INFO] [stderr] --> src/slcan.rs:44:18 [INFO] [stderr] | [INFO] [stderr] 44 | for b in it { [INFO] [stderr] | ^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::explicit_counter_loop)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#explicit_counter_loop [INFO] [stderr] [INFO] [stderr] warning: method `requestTransfer` should have a snake case name such as `request_transfer` [INFO] [stderr] --> src/protocols/transport/isotp.rs:42:5 [INFO] [stderr] | [INFO] [stderr] 42 | / fn requestTransfer( [INFO] [stderr] 43 | | source_address: u32, [INFO] [stderr] 44 | | target_address: u32, [INFO] [stderr] 45 | | data: &[u8], [INFO] [stderr] 46 | | ) -> Result<(), ResultType> { [INFO] [stderr] 47 | | Ok(()) [INFO] [stderr] 48 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(non_snake_case)] on by default [INFO] [stderr] [INFO] [stderr] error: aborting due to 3 previous errors [INFO] [stderr] [INFO] [stderr] error: Could not compile `cantact`. [INFO] [stderr] [INFO] [stderr] To learn more, run the command again with --verbose. [INFO] running `"docker" "inspect" "d0a60c724056f086bee43d72e110a01aeaf6b93fd4739f4668c51d9d0f899553"` [INFO] running `"docker" "rm" "-f" "d0a60c724056f086bee43d72e110a01aeaf6b93fd4739f4668c51d9d0f899553"` [INFO] [stdout] d0a60c724056f086bee43d72e110a01aeaf6b93fd4739f4668c51d9d0f899553