[INFO] updating cached repository dawee/rust-sokoban [INFO] running `"git" "fetch" "--all"` [INFO] [stdout] Fetching origin [INFO] [stderr] From git://github.com/dawee/rust-sokoban [INFO] [stderr] * branch HEAD -> FETCH_HEAD [INFO] running `"git" "clone" "work/cache/sources/gh/dawee/rust-sokoban" "work/ex/clippy-test-run/sources/stable/gh/dawee/rust-sokoban"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/dawee/rust-sokoban'... [INFO] [stderr] done. [INFO] running `"git" "clone" "work/cache/sources/gh/dawee/rust-sokoban" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/dawee/rust-sokoban"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/dawee/rust-sokoban'... [INFO] [stderr] done. [INFO] running `"git" "rev-parse" "HEAD"` [INFO] [stdout] 7f46c756e52ca3ab95f5dc36fabdb8226a90e44e [INFO] sha for GitHub repo dawee/rust-sokoban: 7f46c756e52ca3ab95f5dc36fabdb8226a90e44e [INFO] validating manifest of dawee/rust-sokoban on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of dawee/rust-sokoban on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing dawee/rust-sokoban [INFO] finished frobbing dawee/rust-sokoban [INFO] frobbed toml for dawee/rust-sokoban written to work/ex/clippy-test-run/sources/stable/gh/dawee/rust-sokoban/Cargo.toml [INFO] started frobbing dawee/rust-sokoban [INFO] finished frobbing dawee/rust-sokoban [INFO] frobbed toml for dawee/rust-sokoban written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/dawee/rust-sokoban/Cargo.toml [INFO] crate dawee/rust-sokoban has a lockfile. skipping [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting dawee/rust-sokoban against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-1/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/gh/dawee/rust-sokoban:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] e7d5d0956e78ec38680ed1afd90226d7b95f076b15e8e94b507cf3f157ad5d87 [INFO] running `"docker" "start" "-a" "e7d5d0956e78ec38680ed1afd90226d7b95f076b15e8e94b507cf3f157ad5d87"` [INFO] [stderr] Compiling libc v0.2.34 [INFO] [stderr] Compiling x11-dl v2.17.0 [INFO] [stderr] Compiling rand v0.3.18 [INFO] [stderr] Compiling phf_generator v0.7.21 [INFO] [stderr] Compiling phf_codegen v0.7.21 [INFO] [stderr] Compiling target_build_utils v0.3.1 [INFO] [stderr] Compiling libloading v0.3.4 [INFO] [stderr] Checking dlib v0.3.1 [INFO] [stderr] Checking wayland-sys v0.9.10 [INFO] [stderr] Checking wayland-client v0.9.10 [INFO] [stderr] Checking wayland-protocols v0.9.10 [INFO] [stderr] Checking wayland-kbd v0.9.1 [INFO] [stderr] Checking wayland-window v0.8.0 [INFO] [stderr] Checking winit v0.8.3 [INFO] [stderr] Checking glutin v0.10.1 [INFO] [stderr] Checking pistoncore-glutin_window v0.43.0 [INFO] [stderr] Checking rust-sokoban v0.1.0 (/opt/crater/workdir) [INFO] [stderr] warning: unused import: `transform_pos` [INFO] [stderr] --> src/sokoban/block.rs:7:42 [INFO] [stderr] | [INFO] [stderr] 7 | use graphics::math::{Matrix2d, identity, transform_pos}; [INFO] [stderr] | ^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_imports)] on by default [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/sokoban/block.rs:30:9 [INFO] [stderr] | [INFO] [stderr] 30 | / return row >= 0 && row < 12 [INFO] [stderr] 31 | | && col >= 0 && col < 16 [INFO] [stderr] 32 | | && !level.contains_wall(row, col); [INFO] [stderr] | |______________________________________________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_return)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] help: remove `return` as shown [INFO] [stderr] | [INFO] [stderr] 30 | row >= 0 && row < 12 [INFO] [stderr] 31 | && col >= 0 && col < 16 [INFO] [stderr] 32 | && !level.contains_wall(row, col) [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: unused import: `transform_pos` [INFO] [stderr] --> src/sokoban/character.rs:7:42 [INFO] [stderr] | [INFO] [stderr] 7 | use graphics::math::{Matrix2d, identity, transform_pos}; [INFO] [stderr] | ^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/sokoban/character.rs:53:9 [INFO] [stderr] | [INFO] [stderr] 53 | / return !contains_blocks [INFO] [stderr] 54 | | && row >= 0 && row < 12 [INFO] [stderr] 55 | | && col >= 0 && col < 16 [INFO] [stderr] 56 | | && !level.contains_wall(row, col); [INFO] [stderr] | |______________________________________________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] help: remove `return` as shown [INFO] [stderr] | [INFO] [stderr] 53 | !contains_blocks [INFO] [stderr] 54 | && row >= 0 && row < 12 [INFO] [stderr] 55 | && col >= 0 && col < 16 [INFO] [stderr] 56 | && !level.contains_wall(row, col) [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: unnecessary parentheses around `if` condition [INFO] [stderr] --> src/sokoban/level.rs:18:8 [INFO] [stderr] | [INFO] [stderr] 18 | if (*col == 16) { [INFO] [stderr] | ^^^^^^^^^^^^ help: remove these parentheses [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_parens)] on by default [INFO] [stderr] [INFO] [stderr] warning: unnecessary parentheses around `if` condition [INFO] [stderr] --> src/sokoban/level.rs:84:16 [INFO] [stderr] | [INFO] [stderr] 84 | if (cell == cell_type) { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ help: remove these parentheses [INFO] [stderr] [INFO] [stderr] warning: unused variable: `rows` [INFO] [stderr] --> src/sokoban/game.rs:24:14 [INFO] [stderr] | [INFO] [stderr] 24 | let (rows, cols) = (12, 16); [INFO] [stderr] | ^^^^ help: consider using `_rows` instead [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_variables)] on by default [INFO] [stderr] [INFO] [stderr] warning: unused variable: `cols` [INFO] [stderr] --> src/sokoban/game.rs:24:20 [INFO] [stderr] | [INFO] [stderr] 24 | let (rows, cols) = (12, 16); [INFO] [stderr] | ^^^^ help: consider using `_cols` instead [INFO] [stderr] [INFO] [stderr] warning: unused variable: `cell` [INFO] [stderr] --> src/sokoban/level.rs:103:30 [INFO] [stderr] | [INFO] [stderr] 103 | self.each(|row, col, cell| { [INFO] [stderr] | ^^^^ help: consider using `_cell` instead [INFO] [stderr] [INFO] [stderr] warning: variable does not need to be mutable [INFO] [stderr] --> src/sokoban/level.rs:90:40 [INFO] [stderr] | [INFO] [stderr] 90 | pub fn each_wall(&self, mut predicate: Predicate) where Predicate: FnMut(u32, u32) { [INFO] [stderr] | ----^^^^^^^^^ [INFO] [stderr] | | [INFO] [stderr] | help: remove this `mut` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_mut)] on by default [INFO] [stderr] [INFO] [stderr] warning: variable does not need to be mutable [INFO] [stderr] --> src/sokoban/level.rs:94:41 [INFO] [stderr] | [INFO] [stderr] 94 | pub fn each_block(&self, mut predicate: Predicate) where Predicate: FnMut(u32, u32) { [INFO] [stderr] | ----^^^^^^^^^ [INFO] [stderr] | | [INFO] [stderr] | help: remove this `mut` [INFO] [stderr] [INFO] [stderr] warning: variable does not need to be mutable [INFO] [stderr] --> src/sokoban/level.rs:98:43 [INFO] [stderr] | [INFO] [stderr] 98 | pub fn each_diamond(&self, mut predicate: Predicate) where Predicate: FnMut(u32, u32) { [INFO] [stderr] | ----^^^^^^^^^ [INFO] [stderr] | | [INFO] [stderr] | help: remove this `mut` [INFO] [stderr] [INFO] [stderr] warning: writing `&String` instead of `&str` involves a new object where a slice will do. [INFO] [stderr] --> src/hydro/provider.rs:24:42 [INFO] [stderr] | [INFO] [stderr] 24 | pub fn load_texture(&mut self, name: &String) { [INFO] [stderr] | ^^^^^^^ help: change this to: `&str` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::ptr_arg)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: writing `&String` instead of `&str` involves a new object where a slice will do. [INFO] [stderr] --> src/hydro/provider.rs:34:40 [INFO] [stderr] | [INFO] [stderr] 34 | pub fn use_texture(&self, name: &String, use_texture: F) where F: FnOnce(&Texture) { [INFO] [stderr] | ^^^^^^^ help: change this to: `&str` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: casting i32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/sokoban/block.rs:97:48 [INFO] [stderr] | [INFO] [stderr] 97 | let transform = parent_transform.trans(self.col as f64 * 50.0, self.row as f64 * 50.0); [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: try: `f64::from(self.col)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cast_lossless)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting i32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/sokoban/block.rs:97:72 [INFO] [stderr] | [INFO] [stderr] 97 | let transform = parent_transform.trans(self.col as f64 * 50.0, self.row as f64 * 50.0); [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: try: `f64::from(self.row)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/sokoban/character.rs:50:56 [INFO] [stderr] | [INFO] [stderr] 50 | fn is_reachable(&self, row: i32, col: i32, blocks: &Vec, level: &Level) -> bool { [INFO] [stderr] | ^^^^^^^^^^^ help: change this to: `&[Block]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/sokoban/character.rs:59:39 [INFO] [stderr] | [INFO] [stderr] 59 | pub fn move_up(&mut self, blocks: &Vec, level: &Level) { [INFO] [stderr] | ^^^^^^^^^^^ help: change this to: `&[Block]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/sokoban/character.rs:66:42 [INFO] [stderr] | [INFO] [stderr] 66 | pub fn move_right(&mut self, blocks: &Vec, level: &Level) { [INFO] [stderr] | ^^^^^^^^^^^ help: change this to: `&[Block]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/sokoban/character.rs:73:41 [INFO] [stderr] | [INFO] [stderr] 73 | pub fn move_down(&mut self, blocks: &Vec, level: &Level) { [INFO] [stderr] | ^^^^^^^^^^^ help: change this to: `&[Block]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/sokoban/character.rs:80:41 [INFO] [stderr] | [INFO] [stderr] 80 | pub fn move_left(&mut self, blocks: &Vec, level: &Level) { [INFO] [stderr] | ^^^^^^^^^^^ help: change this to: `&[Block]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: casting i32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/sokoban/character.rs:99:48 [INFO] [stderr] | [INFO] [stderr] 99 | let transform = parent_transform.trans(self.col as f64 * 50.0, self.row as f64 * 50.0); [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: try: `f64::from(self.col)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting i32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/sokoban/character.rs:99:72 [INFO] [stderr] | [INFO] [stderr] 99 | let transform = parent_transform.trans(self.col as f64 * 50.0, self.row as f64 * 50.0); [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: try: `f64::from(self.row)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/sokoban/game.rs:30:53 [INFO] [stderr] | [INFO] [stderr] 30 | tiles.push(Sprite::new(identity().trans(col as f64 * 50.0, row as f64 * 50.0), "GroundGravel_Concrete")); [INFO] [stderr] | ^^^^^^^^^^ help: try: `f64::from(col)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/sokoban/game.rs:30:72 [INFO] [stderr] | [INFO] [stderr] 30 | tiles.push(Sprite::new(identity().trans(col as f64 * 50.0, row as f64 * 50.0), "GroundGravel_Concrete")); [INFO] [stderr] | ^^^^^^^^^^ help: try: `f64::from(row)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/sokoban/game.rs:34:53 [INFO] [stderr] | [INFO] [stderr] 34 | tiles.push(Sprite::new(identity().trans(col as f64 * 50.0, row as f64 * 50.0), "Wall_Black")); [INFO] [stderr] | ^^^^^^^^^^ help: try: `f64::from(col)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/sokoban/game.rs:34:72 [INFO] [stderr] | [INFO] [stderr] 34 | tiles.push(Sprite::new(identity().trans(col as f64 * 50.0, row as f64 * 50.0), "Wall_Black")); [INFO] [stderr] | ^^^^^^^^^^ help: try: `f64::from(row)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/sokoban/game.rs:38:53 [INFO] [stderr] | [INFO] [stderr] 38 | tiles.push(Sprite::new(identity().trans(col as f64 * 50.0, row as f64 * 50.0), "EndPoint_Purple")); [INFO] [stderr] | ^^^^^^^^^^ help: try: `f64::from(col)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/sokoban/game.rs:38:72 [INFO] [stderr] | [INFO] [stderr] 38 | tiles.push(Sprite::new(identity().trans(col as f64 * 50.0, row as f64 * 50.0), "EndPoint_Purple")); [INFO] [stderr] | ^^^^^^^^^^ help: try: `f64::from(row)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/sokoban/game.rs:49:9 [INFO] [stderr] | [INFO] [stderr] 49 | / match button { [INFO] [stderr] 50 | | Button::Keyboard(key) => self.on_press_key(key), [INFO] [stderr] 51 | | _ => () [INFO] [stderr] 52 | | }; [INFO] [stderr] | |_________^ help: try this: `if let Button::Keyboard(key) = button { self.on_press_key(key) }` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::single_match)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/sokoban/level.rs:14:84 [INFO] [stderr] | [INFO] [stderr] 14 | fn set_next_cell(cells: &mut [[Cell; 16]; 12], row: &mut u32, col: &mut u32, cell: &Cell) { [INFO] [stderr] | ^^^^^ help: consider passing by value instead: `Cell` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::trivially_copy_pass_by_ref)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: the variable `row_index` is used as a loop counter. Consider using `for (row_index, item) in self.cells.iter().enumerate()` or similar iterators [INFO] [stderr] --> src/sokoban/level.rs:70:20 [INFO] [stderr] | [INFO] [stderr] 70 | for row in self.cells.iter() { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::explicit_counter_loop)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#explicit_counter_loop [INFO] [stderr] [INFO] [stderr] warning: the variable `col_index` is used as a loop counter. Consider using `for (col_index, item) in row.iter().enumerate()` or similar iterators [INFO] [stderr] --> src/sokoban/level.rs:73:25 [INFO] [stderr] | [INFO] [stderr] 73 | for cell in row.iter() { [INFO] [stderr] | ^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#explicit_counter_loop [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/sokoban/level.rs:82:51 [INFO] [stderr] | [INFO] [stderr] 82 | pub fn each_type(&self, cell_type: &Cell, mut predicate: Predicate) where Predicate: FnMut(u32, u32) { [INFO] [stderr] | ^^^^^ help: consider passing by value instead: `Cell` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: The function/method `render` doesn't need a mutable reference [INFO] [stderr] --> src/main.rs:40:27 [INFO] [stderr] | [INFO] [stderr] 40 | game.render(&mut provider, &context.transform, gl); [INFO] [stderr] | ^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::unnecessary_mut_passed)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_mut_passed [INFO] [stderr] [INFO] [stderr] warning: unused import: `transform_pos` [INFO] [stderr] --> src/sokoban/block.rs:7:42 [INFO] [stderr] | [INFO] [stderr] 7 | use graphics::math::{Matrix2d, identity, transform_pos}; [INFO] [stderr] | ^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_imports)] on by default [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/sokoban/block.rs:30:9 [INFO] [stderr] | [INFO] [stderr] 30 | / return row >= 0 && row < 12 [INFO] [stderr] 31 | | && col >= 0 && col < 16 [INFO] [stderr] 32 | | && !level.contains_wall(row, col); [INFO] [stderr] | |______________________________________________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_return)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] help: remove `return` as shown [INFO] [stderr] | [INFO] [stderr] 30 | row >= 0 && row < 12 [INFO] [stderr] 31 | && col >= 0 && col < 16 [INFO] [stderr] 32 | && !level.contains_wall(row, col) [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: unused import: `transform_pos` [INFO] [stderr] --> src/sokoban/character.rs:7:42 [INFO] [stderr] | [INFO] [stderr] 7 | use graphics::math::{Matrix2d, identity, transform_pos}; [INFO] [stderr] | ^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/sokoban/character.rs:53:9 [INFO] [stderr] | [INFO] [stderr] 53 | / return !contains_blocks [INFO] [stderr] 54 | | && row >= 0 && row < 12 [INFO] [stderr] 55 | | && col >= 0 && col < 16 [INFO] [stderr] 56 | | && !level.contains_wall(row, col); [INFO] [stderr] | |______________________________________________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] help: remove `return` as shown [INFO] [stderr] | [INFO] [stderr] 53 | !contains_blocks [INFO] [stderr] 54 | && row >= 0 && row < 12 [INFO] [stderr] 55 | && col >= 0 && col < 16 [INFO] [stderr] 56 | && !level.contains_wall(row, col) [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: unnecessary parentheses around `if` condition [INFO] [stderr] --> src/sokoban/level.rs:18:8 [INFO] [stderr] | [INFO] [stderr] 18 | if (*col == 16) { [INFO] [stderr] | ^^^^^^^^^^^^ help: remove these parentheses [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_parens)] on by default [INFO] [stderr] [INFO] [stderr] warning: unnecessary parentheses around `if` condition [INFO] [stderr] --> src/sokoban/level.rs:84:16 [INFO] [stderr] | [INFO] [stderr] 84 | if (cell == cell_type) { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ help: remove these parentheses [INFO] [stderr] [INFO] [stderr] warning: unused variable: `rows` [INFO] [stderr] --> src/sokoban/game.rs:24:14 [INFO] [stderr] | [INFO] [stderr] 24 | let (rows, cols) = (12, 16); [INFO] [stderr] | ^^^^ help: consider using `_rows` instead [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_variables)] on by default [INFO] [stderr] [INFO] [stderr] warning: unused variable: `cols` [INFO] [stderr] --> src/sokoban/game.rs:24:20 [INFO] [stderr] | [INFO] [stderr] 24 | let (rows, cols) = (12, 16); [INFO] [stderr] | ^^^^ help: consider using `_cols` instead [INFO] [stderr] [INFO] [stderr] warning: unused variable: `cell` [INFO] [stderr] --> src/sokoban/level.rs:103:30 [INFO] [stderr] | [INFO] [stderr] 103 | self.each(|row, col, cell| { [INFO] [stderr] | ^^^^ help: consider using `_cell` instead [INFO] [stderr] [INFO] [stderr] warning: variable does not need to be mutable [INFO] [stderr] --> src/sokoban/level.rs:90:40 [INFO] [stderr] | [INFO] [stderr] 90 | pub fn each_wall(&self, mut predicate: Predicate) where Predicate: FnMut(u32, u32) { [INFO] [stderr] | ----^^^^^^^^^ [INFO] [stderr] | | [INFO] [stderr] | help: remove this `mut` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_mut)] on by default [INFO] [stderr] [INFO] [stderr] warning: variable does not need to be mutable [INFO] [stderr] --> src/sokoban/level.rs:94:41 [INFO] [stderr] | [INFO] [stderr] 94 | pub fn each_block(&self, mut predicate: Predicate) where Predicate: FnMut(u32, u32) { [INFO] [stderr] | ----^^^^^^^^^ [INFO] [stderr] | | [INFO] [stderr] | help: remove this `mut` [INFO] [stderr] [INFO] [stderr] warning: variable does not need to be mutable [INFO] [stderr] --> src/sokoban/level.rs:98:43 [INFO] [stderr] | [INFO] [stderr] 98 | pub fn each_diamond(&self, mut predicate: Predicate) where Predicate: FnMut(u32, u32) { [INFO] [stderr] | ----^^^^^^^^^ [INFO] [stderr] | | [INFO] [stderr] | help: remove this `mut` [INFO] [stderr] [INFO] [stderr] warning: writing `&String` instead of `&str` involves a new object where a slice will do. [INFO] [stderr] --> src/hydro/provider.rs:24:42 [INFO] [stderr] | [INFO] [stderr] 24 | pub fn load_texture(&mut self, name: &String) { [INFO] [stderr] | ^^^^^^^ help: change this to: `&str` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::ptr_arg)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: writing `&String` instead of `&str` involves a new object where a slice will do. [INFO] [stderr] --> src/hydro/provider.rs:34:40 [INFO] [stderr] | [INFO] [stderr] 34 | pub fn use_texture(&self, name: &String, use_texture: F) where F: FnOnce(&Texture) { [INFO] [stderr] | ^^^^^^^ help: change this to: `&str` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: casting i32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/sokoban/block.rs:97:48 [INFO] [stderr] | [INFO] [stderr] 97 | let transform = parent_transform.trans(self.col as f64 * 50.0, self.row as f64 * 50.0); [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: try: `f64::from(self.col)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cast_lossless)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting i32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/sokoban/block.rs:97:72 [INFO] [stderr] | [INFO] [stderr] 97 | let transform = parent_transform.trans(self.col as f64 * 50.0, self.row as f64 * 50.0); [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: try: `f64::from(self.row)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/sokoban/character.rs:50:56 [INFO] [stderr] | [INFO] [stderr] 50 | fn is_reachable(&self, row: i32, col: i32, blocks: &Vec, level: &Level) -> bool { [INFO] [stderr] | ^^^^^^^^^^^ help: change this to: `&[Block]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/sokoban/character.rs:59:39 [INFO] [stderr] | [INFO] [stderr] 59 | pub fn move_up(&mut self, blocks: &Vec, level: &Level) { [INFO] [stderr] | ^^^^^^^^^^^ help: change this to: `&[Block]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/sokoban/character.rs:66:42 [INFO] [stderr] | [INFO] [stderr] 66 | pub fn move_right(&mut self, blocks: &Vec, level: &Level) { [INFO] [stderr] | ^^^^^^^^^^^ help: change this to: `&[Block]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/sokoban/character.rs:73:41 [INFO] [stderr] | [INFO] [stderr] 73 | pub fn move_down(&mut self, blocks: &Vec, level: &Level) { [INFO] [stderr] | ^^^^^^^^^^^ help: change this to: `&[Block]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/sokoban/character.rs:80:41 [INFO] [stderr] | [INFO] [stderr] 80 | pub fn move_left(&mut self, blocks: &Vec, level: &Level) { [INFO] [stderr] | ^^^^^^^^^^^ help: change this to: `&[Block]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: casting i32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/sokoban/character.rs:99:48 [INFO] [stderr] | [INFO] [stderr] 99 | let transform = parent_transform.trans(self.col as f64 * 50.0, self.row as f64 * 50.0); [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: try: `f64::from(self.col)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting i32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/sokoban/character.rs:99:72 [INFO] [stderr] | [INFO] [stderr] 99 | let transform = parent_transform.trans(self.col as f64 * 50.0, self.row as f64 * 50.0); [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: try: `f64::from(self.row)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/sokoban/game.rs:30:53 [INFO] [stderr] | [INFO] [stderr] 30 | tiles.push(Sprite::new(identity().trans(col as f64 * 50.0, row as f64 * 50.0), "GroundGravel_Concrete")); [INFO] [stderr] | ^^^^^^^^^^ help: try: `f64::from(col)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/sokoban/game.rs:30:72 [INFO] [stderr] | [INFO] [stderr] 30 | tiles.push(Sprite::new(identity().trans(col as f64 * 50.0, row as f64 * 50.0), "GroundGravel_Concrete")); [INFO] [stderr] | ^^^^^^^^^^ help: try: `f64::from(row)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/sokoban/game.rs:34:53 [INFO] [stderr] | [INFO] [stderr] 34 | tiles.push(Sprite::new(identity().trans(col as f64 * 50.0, row as f64 * 50.0), "Wall_Black")); [INFO] [stderr] | ^^^^^^^^^^ help: try: `f64::from(col)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/sokoban/game.rs:34:72 [INFO] [stderr] | [INFO] [stderr] 34 | tiles.push(Sprite::new(identity().trans(col as f64 * 50.0, row as f64 * 50.0), "Wall_Black")); [INFO] [stderr] | ^^^^^^^^^^ help: try: `f64::from(row)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/sokoban/game.rs:38:53 [INFO] [stderr] | [INFO] [stderr] 38 | tiles.push(Sprite::new(identity().trans(col as f64 * 50.0, row as f64 * 50.0), "EndPoint_Purple")); [INFO] [stderr] | ^^^^^^^^^^ help: try: `f64::from(col)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/sokoban/game.rs:38:72 [INFO] [stderr] | [INFO] [stderr] 38 | tiles.push(Sprite::new(identity().trans(col as f64 * 50.0, row as f64 * 50.0), "EndPoint_Purple")); [INFO] [stderr] | ^^^^^^^^^^ help: try: `f64::from(row)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/sokoban/game.rs:49:9 [INFO] [stderr] | [INFO] [stderr] 49 | / match button { [INFO] [stderr] 50 | | Button::Keyboard(key) => self.on_press_key(key), [INFO] [stderr] 51 | | _ => () [INFO] [stderr] 52 | | }; [INFO] [stderr] | |_________^ help: try this: `if let Button::Keyboard(key) = button { self.on_press_key(key) }` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::single_match)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/sokoban/level.rs:14:84 [INFO] [stderr] | [INFO] [stderr] 14 | fn set_next_cell(cells: &mut [[Cell; 16]; 12], row: &mut u32, col: &mut u32, cell: &Cell) { [INFO] [stderr] | ^^^^^ help: consider passing by value instead: `Cell` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::trivially_copy_pass_by_ref)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: the variable `row_index` is used as a loop counter. Consider using `for (row_index, item) in self.cells.iter().enumerate()` or similar iterators [INFO] [stderr] --> src/sokoban/level.rs:70:20 [INFO] [stderr] | [INFO] [stderr] 70 | for row in self.cells.iter() { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::explicit_counter_loop)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#explicit_counter_loop [INFO] [stderr] [INFO] [stderr] warning: the variable `col_index` is used as a loop counter. Consider using `for (col_index, item) in row.iter().enumerate()` or similar iterators [INFO] [stderr] --> src/sokoban/level.rs:73:25 [INFO] [stderr] | [INFO] [stderr] 73 | for cell in row.iter() { [INFO] [stderr] | ^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#explicit_counter_loop [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/sokoban/level.rs:82:51 [INFO] [stderr] | [INFO] [stderr] 82 | pub fn each_type(&self, cell_type: &Cell, mut predicate: Predicate) where Predicate: FnMut(u32, u32) { [INFO] [stderr] | ^^^^^ help: consider passing by value instead: `Cell` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: The function/method `render` doesn't need a mutable reference [INFO] [stderr] --> src/main.rs:40:27 [INFO] [stderr] | [INFO] [stderr] 40 | game.render(&mut provider, &context.transform, gl); [INFO] [stderr] | ^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::unnecessary_mut_passed)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_mut_passed [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 45.66s [INFO] running `"docker" "inspect" "e7d5d0956e78ec38680ed1afd90226d7b95f076b15e8e94b507cf3f157ad5d87"` [INFO] running `"docker" "rm" "-f" "e7d5d0956e78ec38680ed1afd90226d7b95f076b15e8e94b507cf3f157ad5d87"` [INFO] [stdout] e7d5d0956e78ec38680ed1afd90226d7b95f076b15e8e94b507cf3f157ad5d87