[INFO] updating cached repository davll/cargo-rustc-ndk [INFO] running `"git" "fetch" "--all"` [INFO] [stdout] Fetching origin [INFO] [stderr] From git://github.com/davll/cargo-rustc-ndk [INFO] [stderr] * branch HEAD -> FETCH_HEAD [INFO] running `"git" "clone" "work/cache/sources/gh/davll/cargo-rustc-ndk" "work/ex/clippy-test-run/sources/stable/gh/davll/cargo-rustc-ndk"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/davll/cargo-rustc-ndk'... [INFO] [stderr] done. [INFO] running `"git" "clone" "work/cache/sources/gh/davll/cargo-rustc-ndk" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/davll/cargo-rustc-ndk"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/davll/cargo-rustc-ndk'... [INFO] [stderr] done. [INFO] running `"git" "rev-parse" "HEAD"` [INFO] [stdout] c700a74fa7e6c3df7102646964fd1b5dbcac6960 [INFO] sha for GitHub repo davll/cargo-rustc-ndk: c700a74fa7e6c3df7102646964fd1b5dbcac6960 [INFO] validating manifest of davll/cargo-rustc-ndk on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of davll/cargo-rustc-ndk on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing davll/cargo-rustc-ndk [INFO] finished frobbing davll/cargo-rustc-ndk [INFO] frobbed toml for davll/cargo-rustc-ndk written to work/ex/clippy-test-run/sources/stable/gh/davll/cargo-rustc-ndk/Cargo.toml [INFO] started frobbing davll/cargo-rustc-ndk [INFO] finished frobbing davll/cargo-rustc-ndk [INFO] frobbed toml for davll/cargo-rustc-ndk written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/davll/cargo-rustc-ndk/Cargo.toml [INFO] crate davll/cargo-rustc-ndk has a lockfile. skipping [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting davll/cargo-rustc-ndk against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-4/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/gh/davll/cargo-rustc-ndk:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] a9b435624aaeb58e36967cf321b21eaed743b03d8b0e00a86d0b8b3ef38c0834 [INFO] running `"docker" "start" "-a" "a9b435624aaeb58e36967cf321b21eaed743b03d8b0e00a86d0b8b3ef38c0834"` [INFO] [stderr] Compiling winapi v0.3.4 [INFO] [stderr] Checking directories v0.9.0 [INFO] [stderr] Checking cargo-rustc-ndk v0.1.0 (/opt/crater/workdir) [INFO] [stderr] warning: use of `unwrap_or` followed by a function call [INFO] [stderr] --> src/main.rs:92:86 [INFO] [stderr] | [INFO] [stderr] 92 | let rustc_args: Vec<&str> = matches.values_of("rustc-args").map(|x| x.collect()).unwrap_or(vec![]); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: try this: `unwrap_or_else(|| vec![])` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::or_fun_call)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] warning: equality checks against false can be replaced by a negation [INFO] [stderr] --> src/main.rs:154:8 [INFO] [stderr] | [INFO] [stderr] 154 | if toolchain_path.is_dir() == false { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try simplifying it as shown: `!toolchain_path.is_dir()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::bool_comparison)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_comparison [INFO] [stderr] [INFO] [stderr] warning: useless use of `format!` [INFO] [stderr] --> src/main.rs:267:17 [INFO] [stderr] | [INFO] [stderr] 267 | None => format!(""), [INFO] [stderr] | ^^^^^^^^^^^ help: consider using .to_string(): `"".to_string()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::useless_format)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format [INFO] [stderr] [INFO] [stderr] warning: use of `unwrap_or` followed by a function call [INFO] [stderr] --> src/main.rs:92:86 [INFO] [stderr] | [INFO] [stderr] 92 | let rustc_args: Vec<&str> = matches.values_of("rustc-args").map(|x| x.collect()).unwrap_or(vec![]); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: try this: `unwrap_or_else(|| vec![])` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::or_fun_call)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] warning: equality checks against false can be replaced by a negation [INFO] [stderr] --> src/main.rs:154:8 [INFO] [stderr] | [INFO] [stderr] 154 | if toolchain_path.is_dir() == false { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try simplifying it as shown: `!toolchain_path.is_dir()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::bool_comparison)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_comparison [INFO] [stderr] [INFO] [stderr] warning: useless use of `format!` [INFO] [stderr] --> src/main.rs:267:17 [INFO] [stderr] | [INFO] [stderr] 267 | None => format!(""), [INFO] [stderr] | ^^^^^^^^^^^ help: consider using .to_string(): `"".to_string()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::useless_format)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 5.11s [INFO] running `"docker" "inspect" "a9b435624aaeb58e36967cf321b21eaed743b03d8b0e00a86d0b8b3ef38c0834"` [INFO] running `"docker" "rm" "-f" "a9b435624aaeb58e36967cf321b21eaed743b03d8b0e00a86d0b8b3ef38c0834"` [INFO] [stdout] a9b435624aaeb58e36967cf321b21eaed743b03d8b0e00a86d0b8b3ef38c0834