[INFO] updating cached repository davidpdrsn/derive-builder [INFO] running `"git" "fetch" "--all"` [INFO] [stdout] Fetching origin [INFO] [stderr] From git://github.com/davidpdrsn/derive-builder [INFO] [stderr] * branch HEAD -> FETCH_HEAD [INFO] running `"git" "clone" "work/cache/sources/gh/davidpdrsn/derive-builder" "work/ex/clippy-test-run/sources/stable/gh/davidpdrsn/derive-builder"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/davidpdrsn/derive-builder'... [INFO] [stderr] done. [INFO] running `"git" "clone" "work/cache/sources/gh/davidpdrsn/derive-builder" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/davidpdrsn/derive-builder"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/davidpdrsn/derive-builder'... [INFO] [stderr] done. [INFO] running `"git" "rev-parse" "HEAD"` [INFO] [stdout] bcc0fd4dc11fd162a3f4298096008fcfba8189de [INFO] sha for GitHub repo davidpdrsn/derive-builder: bcc0fd4dc11fd162a3f4298096008fcfba8189de [INFO] validating manifest of davidpdrsn/derive-builder on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of davidpdrsn/derive-builder on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing davidpdrsn/derive-builder [INFO] finished frobbing davidpdrsn/derive-builder [INFO] frobbed toml for davidpdrsn/derive-builder written to work/ex/clippy-test-run/sources/stable/gh/davidpdrsn/derive-builder/Cargo.toml [INFO] started frobbing davidpdrsn/derive-builder [INFO] finished frobbing davidpdrsn/derive-builder [INFO] frobbed toml for davidpdrsn/derive-builder written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/davidpdrsn/derive-builder/Cargo.toml [INFO] crate davidpdrsn/derive-builder has a lockfile. skipping [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting davidpdrsn/derive-builder against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-5/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/gh/davidpdrsn/derive-builder:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 5b646670a8ae9360e6184dabaa4e07f805904f72052049c8f8ec6cf911ad4567 [INFO] running `"docker" "start" "-a" "5b646670a8ae9360e6184dabaa4e07f805904f72052049c8f8ec6cf911ad4567"` [INFO] [stderr] Checking derive-builder v0.1.0 (/opt/crater/workdir) [INFO] [stderr] warning: you don't need to add `&` to both the expression and the patterns [INFO] [stderr] --> src/lib.rs:28:36 [INFO] [stderr] | [INFO] [stderr] 28 | let fields: &Vec = match &ast.body { [INFO] [stderr] | ____________________________________^ [INFO] [stderr] 29 | | &syn::Body::Enum(_) => panic!("Cannot derive Builder for enums"), [INFO] [stderr] 30 | | &syn::Body::Struct(ref data) => { [INFO] [stderr] 31 | | match data { [INFO] [stderr] ... | [INFO] [stderr] 36 | | } [INFO] [stderr] 37 | | }; [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::match_ref_pats)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: try [INFO] [stderr] | [INFO] [stderr] 28 | let fields: &Vec = match ast.body { [INFO] [stderr] 29 | syn::Body::Enum(_) => panic!("Cannot derive Builder for enums"), [INFO] [stderr] 30 | syn::Body::Struct(ref data) => { [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/lib.rs:31:13 [INFO] [stderr] | [INFO] [stderr] 31 | / match data { [INFO] [stderr] 32 | | &syn::VariantData::Tuple(_) => panic!("Canont derive Builder for Tuple structs"), [INFO] [stderr] 33 | | &syn::VariantData::Unit => panic!("Cannot derive Builder for unit structs"), [INFO] [stderr] 34 | | &syn::VariantData::Struct(ref fields) => fields, [INFO] [stderr] 35 | | } [INFO] [stderr] | |_____________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 31 | match *data { [INFO] [stderr] 32 | syn::VariantData::Tuple(_) => panic!("Canont derive Builder for Tuple structs"), [INFO] [stderr] 33 | syn::VariantData::Unit => panic!("Cannot derive Builder for unit structs"), [INFO] [stderr] 34 | syn::VariantData::Struct(ref fields) => fields, [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: called `.get().unwrap()` on a Vec. Using `[]` is more clear and more concise [INFO] [stderr] --> src/lib.rs:100:45 [INFO] [stderr] | [INFO] [stderr] 100 | let generic_type_name = generic_builder_fields.get(idx).unwrap(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `generic_builder_fields[idx]` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::get_unwrap)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#get_unwrap [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to both the expression and the patterns [INFO] [stderr] --> src/lib.rs:28:36 [INFO] [stderr] | [INFO] [stderr] 28 | let fields: &Vec = match &ast.body { [INFO] [stderr] | ____________________________________^ [INFO] [stderr] 29 | | &syn::Body::Enum(_) => panic!("Cannot derive Builder for enums"), [INFO] [stderr] 30 | | &syn::Body::Struct(ref data) => { [INFO] [stderr] 31 | | match data { [INFO] [stderr] ... | [INFO] [stderr] 36 | | } [INFO] [stderr] 37 | | }; [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::match_ref_pats)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: try [INFO] [stderr] | [INFO] [stderr] 28 | let fields: &Vec = match ast.body { [INFO] [stderr] 29 | syn::Body::Enum(_) => panic!("Cannot derive Builder for enums"), [INFO] [stderr] 30 | syn::Body::Struct(ref data) => { [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/lib.rs:31:13 [INFO] [stderr] | [INFO] [stderr] 31 | / match data { [INFO] [stderr] 32 | | &syn::VariantData::Tuple(_) => panic!("Canont derive Builder for Tuple structs"), [INFO] [stderr] 33 | | &syn::VariantData::Unit => panic!("Cannot derive Builder for unit structs"), [INFO] [stderr] 34 | | &syn::VariantData::Struct(ref fields) => fields, [INFO] [stderr] 35 | | } [INFO] [stderr] | |_____________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 31 | match *data { [INFO] [stderr] 32 | syn::VariantData::Tuple(_) => panic!("Canont derive Builder for Tuple structs"), [INFO] [stderr] 33 | syn::VariantData::Unit => panic!("Cannot derive Builder for unit structs"), [INFO] [stderr] 34 | syn::VariantData::Struct(ref fields) => fields, [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: called `.get().unwrap()` on a Vec. Using `[]` is more clear and more concise [INFO] [stderr] --> src/lib.rs:100:45 [INFO] [stderr] | [INFO] [stderr] 100 | let generic_type_name = generic_builder_fields.get(idx).unwrap(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `generic_builder_fields[idx]` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::get_unwrap)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#get_unwrap [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 1.10s [INFO] running `"docker" "inspect" "5b646670a8ae9360e6184dabaa4e07f805904f72052049c8f8ec6cf911ad4567"` [INFO] running `"docker" "rm" "-f" "5b646670a8ae9360e6184dabaa4e07f805904f72052049c8f8ec6cf911ad4567"` [INFO] [stdout] 5b646670a8ae9360e6184dabaa4e07f805904f72052049c8f8ec6cf911ad4567