[INFO] updating cached repository davidbarsky/husk [INFO] running `"git" "fetch" "--all"` [INFO] [stdout] Fetching origin [INFO] [stderr] From git://github.com/davidbarsky/husk [INFO] [stderr] * branch HEAD -> FETCH_HEAD [INFO] running `"git" "clone" "work/cache/sources/gh/davidbarsky/husk" "work/ex/clippy-test-run/sources/stable/gh/davidbarsky/husk"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/davidbarsky/husk'... [INFO] [stderr] done. [INFO] running `"git" "clone" "work/cache/sources/gh/davidbarsky/husk" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/davidbarsky/husk"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/davidbarsky/husk'... [INFO] [stderr] done. [INFO] running `"git" "rev-parse" "HEAD"` [INFO] [stdout] 88830a1c775a07879e27e7d2036b98602f90d5b1 [INFO] sha for GitHub repo davidbarsky/husk: 88830a1c775a07879e27e7d2036b98602f90d5b1 [INFO] validating manifest of davidbarsky/husk on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of davidbarsky/husk on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing davidbarsky/husk [INFO] finished frobbing davidbarsky/husk [INFO] frobbed toml for davidbarsky/husk written to work/ex/clippy-test-run/sources/stable/gh/davidbarsky/husk/Cargo.toml [INFO] started frobbing davidbarsky/husk [INFO] finished frobbing davidbarsky/husk [INFO] frobbed toml for davidbarsky/husk written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/davidbarsky/husk/Cargo.toml [INFO] crate davidbarsky/husk has a lockfile. skipping [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting davidbarsky/husk against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-2/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/gh/davidbarsky/husk:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 7bb56e97c7184594983de38fc8f75d253db836ccfbeb60d6599c06f1e62c1c51 [INFO] running `"docker" "start" "-a" "7bb56e97c7184594983de38fc8f75d253db836ccfbeb60d6599c06f1e62c1c51"` [INFO] [stderr] Compiling backtrace-sys v0.1.11 [INFO] [stderr] Checking nix v0.8.1 [INFO] [stderr] Checking backtrace v0.3.2 [INFO] [stderr] Checking error-chain v0.10.0 [INFO] [stderr] Checking husk v0.1.0 (/opt/crater/workdir) [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/main.rs:250:13 [INFO] [stderr] | [INFO] [stderr] 250 | argv: argv, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `argv` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/main.rs:250:13 [INFO] [stderr] | [INFO] [stderr] 250 | argv: argv, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `argv` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] error: calls to `std::mem::drop` with a value that implements Copy. Dropping a copy leaves the original intact. [INFO] [stderr] --> src/main.rs:86:16 [INFO] [stderr] | [INFO] [stderr] 86 | defer!(drop(close(tty_fd))); // drop to ignore result. [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[deny(clippy::drop_copy)] on by default [INFO] [stderr] note: argument has type std::result::Result<(), nix::Error> [INFO] [stderr] --> src/main.rs:86:21 [INFO] [stderr] | [INFO] [stderr] 86 | defer!(drop(close(tty_fd))); // drop to ignore result. [INFO] [stderr] | ^^^^^^^^^^^^^ [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#drop_copy [INFO] [stderr] [INFO] [stderr] error: calls to `std::mem::drop` with a value that implements Copy. Dropping a copy leaves the original intact. [INFO] [stderr] --> src/main.rs:96:16 [INFO] [stderr] | [INFO] [stderr] 96 | defer!(drop(setpgid(0, original_pgid))); // drop to ignore result. [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] note: argument has type std::result::Result<(), nix::Error> [INFO] [stderr] --> src/main.rs:96:21 [INFO] [stderr] | [INFO] [stderr] 96 | defer!(drop(setpgid(0, original_pgid))); // drop to ignore result. [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#drop_copy [INFO] [stderr] [INFO] [stderr] error: calls to `std::mem::drop` with a value that implements Copy. Dropping a copy leaves the original intact. [INFO] [stderr] --> src/main.rs:101:16 [INFO] [stderr] | [INFO] [stderr] 101 | defer!(drop(tcsetpgrp(tty_fd, original_tpgid))); // drop to ignore result. [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] note: argument has type std::result::Result<(), nix::Error> [INFO] [stderr] --> src/main.rs:101:21 [INFO] [stderr] | [INFO] [stderr] 101 | defer!(drop(tcsetpgrp(tty_fd, original_tpgid))); // drop to ignore result. [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#drop_copy [INFO] [stderr] [INFO] [stderr] error: Variable in the condition are not mutated in the loop body. This either leads to an infinite or to a never running loop. [INFO] [stderr] --> src/main.rs:107:15 [INFO] [stderr] | [INFO] [stderr] 107 | while !self.should_exit { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[deny(clippy::while_immutable_condition)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#while_immutable_condition [INFO] [stderr] [INFO] [stderr] warning: redundant closure found [INFO] [stderr] --> src/main.rs:231:36 [INFO] [stderr] | [INFO] [stderr] 231 | let dest = args.next().map(|d| OsString::from(d)); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^ help: remove closure as shown: `OsString::from` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_closure)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure [INFO] [stderr] [INFO] [stderr] error: aborting due to 4 previous errors [INFO] [stderr] [INFO] [stderr] error: Could not compile `husk`. [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stderr] error: calls to `std::mem::drop` with a value that implements Copy. Dropping a copy leaves the original intact. [INFO] [stderr] --> src/main.rs:86:16 [INFO] [stderr] | [INFO] [stderr] 86 | defer!(drop(close(tty_fd))); // drop to ignore result. [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[deny(clippy::drop_copy)] on by default [INFO] [stderr] note: argument has type std::result::Result<(), nix::Error> [INFO] [stderr] --> src/main.rs:86:21 [INFO] [stderr] | [INFO] [stderr] 86 | defer!(drop(close(tty_fd))); // drop to ignore result. [INFO] [stderr] | ^^^^^^^^^^^^^ [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#drop_copy [INFO] [stderr] [INFO] [stderr] error: calls to `std::mem::drop` with a value that implements Copy. Dropping a copy leaves the original intact. [INFO] [stderr] --> src/main.rs:96:16 [INFO] [stderr] | [INFO] [stderr] 96 | defer!(drop(setpgid(0, original_pgid))); // drop to ignore result. [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] note: argument has type std::result::Result<(), nix::Error> [INFO] [stderr] --> src/main.rs:96:21 [INFO] [stderr] | [INFO] [stderr] 96 | defer!(drop(setpgid(0, original_pgid))); // drop to ignore result. [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#drop_copy [INFO] [stderr] [INFO] [stderr] error: calls to `std::mem::drop` with a value that implements Copy. Dropping a copy leaves the original intact. [INFO] [stderr] --> src/main.rs:101:16 [INFO] [stderr] | [INFO] [stderr] 101 | defer!(drop(tcsetpgrp(tty_fd, original_tpgid))); // drop to ignore result. [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] note: argument has type std::result::Result<(), nix::Error> [INFO] [stderr] --> src/main.rs:101:21 [INFO] [stderr] | [INFO] [stderr] 101 | defer!(drop(tcsetpgrp(tty_fd, original_tpgid))); // drop to ignore result. [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#drop_copy [INFO] [stderr] [INFO] [stderr] error: Variable in the condition are not mutated in the loop body. This either leads to an infinite or to a never running loop. [INFO] [stderr] --> src/main.rs:107:15 [INFO] [stderr] | [INFO] [stderr] 107 | while !self.should_exit { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[deny(clippy::while_immutable_condition)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#while_immutable_condition [INFO] [stderr] [INFO] [stderr] warning: redundant closure found [INFO] [stderr] --> src/main.rs:231:36 [INFO] [stderr] | [INFO] [stderr] 231 | let dest = args.next().map(|d| OsString::from(d)); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^ help: remove closure as shown: `OsString::from` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_closure)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure [INFO] [stderr] [INFO] [stderr] error: aborting due to 4 previous errors [INFO] [stderr] [INFO] [stderr] error: Could not compile `husk`. [INFO] [stderr] [INFO] [stderr] To learn more, run the command again with --verbose. [INFO] running `"docker" "inspect" "7bb56e97c7184594983de38fc8f75d253db836ccfbeb60d6599c06f1e62c1c51"` [INFO] running `"docker" "rm" "-f" "7bb56e97c7184594983de38fc8f75d253db836ccfbeb60d6599c06f1e62c1c51"` [INFO] [stdout] 7bb56e97c7184594983de38fc8f75d253db836ccfbeb60d6599c06f1e62c1c51