[INFO] updating cached repository davidarmstronglewis/dingus [INFO] running `"git" "fetch" "--all"` [INFO] [stdout] Fetching origin [INFO] [stderr] From git://github.com/davidarmstronglewis/dingus [INFO] [stderr] * branch HEAD -> FETCH_HEAD [INFO] running `"git" "clone" "work/cache/sources/gh/davidarmstronglewis/dingus" "work/ex/clippy-test-run/sources/stable/gh/davidarmstronglewis/dingus"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/davidarmstronglewis/dingus'... [INFO] [stderr] done. [INFO] running `"git" "clone" "work/cache/sources/gh/davidarmstronglewis/dingus" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/davidarmstronglewis/dingus"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/davidarmstronglewis/dingus'... [INFO] [stderr] done. [INFO] running `"git" "rev-parse" "HEAD"` [INFO] [stdout] a0965880040403e5b3d1e4451bbbb233dfe4c91a [INFO] sha for GitHub repo davidarmstronglewis/dingus: a0965880040403e5b3d1e4451bbbb233dfe4c91a [INFO] validating manifest of davidarmstronglewis/dingus on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of davidarmstronglewis/dingus on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing davidarmstronglewis/dingus [INFO] finished frobbing davidarmstronglewis/dingus [INFO] frobbed toml for davidarmstronglewis/dingus written to work/ex/clippy-test-run/sources/stable/gh/davidarmstronglewis/dingus/Cargo.toml [INFO] started frobbing davidarmstronglewis/dingus [INFO] finished frobbing davidarmstronglewis/dingus [INFO] frobbed toml for davidarmstronglewis/dingus written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/davidarmstronglewis/dingus/Cargo.toml [INFO] crate davidarmstronglewis/dingus has a lockfile. skipping [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting davidarmstronglewis/dingus against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-1/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/gh/davidarmstronglewis/dingus:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 14a2f38ebd9b155a31dfdd8b9831b0ce8a00c921272c93c345cfe4c62f3c61ef [INFO] running `"docker" "start" "-a" "14a2f38ebd9b155a31dfdd8b9831b0ce8a00c921272c93c345cfe4c62f3c61ef"` [INFO] [stderr] Checking clap v2.32.0 [INFO] [stderr] Checking dingus v0.5.6 (/opt/crater/workdir) [INFO] [stderr] warning: passing a unit value to a function [INFO] [stderr] --> src/dingus/app.rs:210:12 [INFO] [stderr] | [INFO] [stderr] 210 | Ok(println!( [INFO] [stderr] | ____________^ [INFO] [stderr] 211 | | "{}", [INFO] [stderr] 212 | | Style::new().bold().paint("Exiting Dingus Session\n") [INFO] [stderr] 213 | | )) [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::unit_arg)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unit_arg [INFO] [stderr] = note: this error originates in a macro outside of the current crate (in Nightly builds, run with -Z external-macro-backtrace for more info) [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/dingus/app.rs:247:13 [INFO] [stderr] | [INFO] [stderr] 247 | / match dingus_file { [INFO] [stderr] 248 | | Some(path) => output.push(format!( [INFO] [stderr] 249 | | "{} {}\n", [INFO] [stderr] 250 | | Green.paint("Found in path:"), [INFO] [stderr] ... | [INFO] [stderr] 253 | | None => {} [INFO] [stderr] 254 | | } [INFO] [stderr] | |_____________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::single_match)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 247 | if let Some(path) = dingus_file { output.push(format!( [INFO] [stderr] 248 | "{} {}\n", [INFO] [stderr] 249 | Green.paint("Found in path:"), [INFO] [stderr] 250 | path.to_string_lossy() [INFO] [stderr] 251 | )) } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to match on a boolean expression [INFO] [stderr] --> src/dingus/app.rs:283:13 [INFO] [stderr] | [INFO] [stderr] 283 | / match found_configs.is_empty() { [INFO] [stderr] 284 | | true => output.push(format!( [INFO] [stderr] 285 | | "{}", [INFO] [stderr] 286 | | Style::new() [INFO] [stderr] ... | [INFO] [stderr] 297 | | } [INFO] [stderr] 298 | | } [INFO] [stderr] | |_____________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::match_bool)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_bool [INFO] [stderr] help: consider using an if/else expression [INFO] [stderr] | [INFO] [stderr] 283 | if found_configs.is_empty() { output.push(format!( [INFO] [stderr] 284 | "{}", [INFO] [stderr] 285 | Style::new() [INFO] [stderr] 286 | .bold() [INFO] [stderr] 287 | .paint("No valid config files found in config folder.") [INFO] [stderr] 288 | )) } else { [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: passing a unit value to a function [INFO] [stderr] --> src/dingus/app.rs:301:12 [INFO] [stderr] | [INFO] [stderr] 301 | Ok(println!("{}", output.join("\n"))) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unit_arg [INFO] [stderr] = note: this error originates in a macro outside of the current crate (in Nightly builds, run with -Z external-macro-backtrace for more info) [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/main.rs:76:5 [INFO] [stderr] | [INFO] [stderr] 76 | / match Dingus::from_clap(app).and_then(|app| app.run()) { [INFO] [stderr] 77 | | Err(e) => eprintln!("{} {}", Style::new().bold().paint("Error:"), e), [INFO] [stderr] 78 | | _ => {} [INFO] [stderr] 79 | | }; [INFO] [stderr] | |_____^ help: try this: `if let Err(e) = Dingus::from_clap(app).and_then(|app| app.run()) { eprintln!("{} {}", Style::new().bold().paint("Error:"), e) }` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] [INFO] [stderr] warning: passing a unit value to a function [INFO] [stderr] --> src/dingus/app.rs:210:12 [INFO] [stderr] | [INFO] [stderr] 210 | Ok(println!( [INFO] [stderr] | ____________^ [INFO] [stderr] 211 | | "{}", [INFO] [stderr] 212 | | Style::new().bold().paint("Exiting Dingus Session\n") [INFO] [stderr] 213 | | )) [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::unit_arg)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unit_arg [INFO] [stderr] = note: this error originates in a macro outside of the current crate (in Nightly builds, run with -Z external-macro-backtrace for more info) [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/dingus/app.rs:247:13 [INFO] [stderr] | [INFO] [stderr] 247 | / match dingus_file { [INFO] [stderr] 248 | | Some(path) => output.push(format!( [INFO] [stderr] 249 | | "{} {}\n", [INFO] [stderr] 250 | | Green.paint("Found in path:"), [INFO] [stderr] ... | [INFO] [stderr] 253 | | None => {} [INFO] [stderr] 254 | | } [INFO] [stderr] | |_____________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::single_match)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 247 | if let Some(path) = dingus_file { output.push(format!( [INFO] [stderr] 248 | "{} {}\n", [INFO] [stderr] 249 | Green.paint("Found in path:"), [INFO] [stderr] 250 | path.to_string_lossy() [INFO] [stderr] 251 | )) } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to match on a boolean expression [INFO] [stderr] --> src/dingus/app.rs:283:13 [INFO] [stderr] | [INFO] [stderr] 283 | / match found_configs.is_empty() { [INFO] [stderr] 284 | | true => output.push(format!( [INFO] [stderr] 285 | | "{}", [INFO] [stderr] 286 | | Style::new() [INFO] [stderr] ... | [INFO] [stderr] 297 | | } [INFO] [stderr] 298 | | } [INFO] [stderr] | |_____________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::match_bool)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_bool [INFO] [stderr] help: consider using an if/else expression [INFO] [stderr] | [INFO] [stderr] 283 | if found_configs.is_empty() { output.push(format!( [INFO] [stderr] 284 | "{}", [INFO] [stderr] 285 | Style::new() [INFO] [stderr] 286 | .bold() [INFO] [stderr] 287 | .paint("No valid config files found in config folder.") [INFO] [stderr] 288 | )) } else { [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: passing a unit value to a function [INFO] [stderr] --> src/dingus/app.rs:301:12 [INFO] [stderr] | [INFO] [stderr] 301 | Ok(println!("{}", output.join("\n"))) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unit_arg [INFO] [stderr] = note: this error originates in a macro outside of the current crate (in Nightly builds, run with -Z external-macro-backtrace for more info) [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/main.rs:76:5 [INFO] [stderr] | [INFO] [stderr] 76 | / match Dingus::from_clap(app).and_then(|app| app.run()) { [INFO] [stderr] 77 | | Err(e) => eprintln!("{} {}", Style::new().bold().paint("Error:"), e), [INFO] [stderr] 78 | | _ => {} [INFO] [stderr] 79 | | }; [INFO] [stderr] | |_____^ help: try this: `if let Err(e) = Dingus::from_clap(app).and_then(|app| app.run()) { eprintln!("{} {}", Style::new().bold().paint("Error:"), e) }` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 8.15s [INFO] running `"docker" "inspect" "14a2f38ebd9b155a31dfdd8b9831b0ce8a00c921272c93c345cfe4c62f3c61ef"` [INFO] running `"docker" "rm" "-f" "14a2f38ebd9b155a31dfdd8b9831b0ce8a00c921272c93c345cfe4c62f3c61ef"` [INFO] [stdout] 14a2f38ebd9b155a31dfdd8b9831b0ce8a00c921272c93c345cfe4c62f3c61ef