[INFO] updating cached repository davidB/git-find
[INFO] running `"git" "fetch" "--all"`
[INFO] [stdout] Fetching origin
[INFO] [stderr] From git://github.com/davidB/git-find
[INFO] [stderr]  * branch            HEAD       -> FETCH_HEAD
[INFO] running `"git" "clone" "work/cache/sources/gh/davidB/git-find" "work/ex/clippy-test-run/sources/stable/gh/davidB/git-find"`
[INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/davidB/git-find'...
[INFO] [stderr] done.
[INFO] running `"git" "clone" "work/cache/sources/gh/davidB/git-find" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/davidB/git-find"`
[INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/davidB/git-find'...
[INFO] [stderr] done.
[INFO] running `"git" "rev-parse" "HEAD"`
[INFO] [stdout] 2db7a83f3ef59caac05292833449b8650f6538c0
[INFO] sha for GitHub repo davidB/git-find: 2db7a83f3ef59caac05292833449b8650f6538c0
[INFO] validating manifest of davidB/git-find on toolchain stable
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"`
[INFO] validating manifest of davidB/git-find on toolchain stable+rustflags=-Dclippy::into_iter_on_array
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"`
[INFO] started frobbing davidB/git-find
[INFO] finished frobbing davidB/git-find
[INFO] frobbed toml for davidB/git-find written to work/ex/clippy-test-run/sources/stable/gh/davidB/git-find/Cargo.toml
[INFO] started frobbing davidB/git-find
[INFO] finished frobbing davidB/git-find
[INFO] frobbed toml for davidB/git-find written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/davidB/git-find/Cargo.toml
[INFO] crate davidB/git-find has a lockfile. skipping
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"`
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"`
[INFO] linting davidB/git-find against stable for clippy-test-run
[INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-4/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/gh/davidB/git-find:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"`
[INFO] [stdout] a660a026dccb1dd3c16cd1bd07668f2b9b33650833bb6a6b4352d53c7e7a3729
[INFO] running `"docker" "start" "-a" "a660a026dccb1dd3c16cd1bd07668f2b9b33650833bb6a6b4352d53c7e7a3729"`
[INFO] [stderr]    Compiling cc v1.0.26
[INFO] [stderr]    Compiling slog v2.4.1
[INFO] [stderr]     Checking gtmpl_value v0.3.3
[INFO] [stderr]     Checking walkdir v2.2.7
[INFO] [stderr]     Checking rand v0.4.2
[INFO] [stderr]     Checking memchr v2.0.2
[INFO] [stderr]     Checking atty v0.2.10
[INFO] [stderr]     Checking isatty v0.1.7
[INFO] [stderr]    Compiling syn v0.15.8
[INFO] [stderr]     Checking aho-corasick v0.6.8
[INFO] [stderr]     Checking clap v2.31.2
[INFO] [stderr]     Checking chrono v0.4.2
[INFO] [stderr]     Checking gtmpl v0.5.6
[INFO] [stderr]     Checking regex v1.1.0
[INFO] [stderr]     Checking num-bigint v0.1.44
[INFO] [stderr]     Checking slog-async v2.3.0
[INFO] [stderr]    Compiling libz-sys v1.0.25
[INFO] [stderr]    Compiling libgit2-sys v0.7.11
[INFO] [stderr]     Checking slog-term v2.4.0
[INFO] [stderr]     Checking num-rational v0.1.42
[INFO] [stderr]     Checking num v0.1.42
[INFO] [stderr]     Checking spectral v0.6.0
[INFO] [stderr]    Compiling structopt-derive v0.2.14
[INFO] [stderr]    Compiling gtmpl_derive v0.3.3
[INFO] [stderr]     Checking structopt v0.2.14
[INFO] [stderr]     Checking git2 v0.8.0
[INFO] [stderr]     Checking git-find v0.4.1 (/opt/crater/workdir)
[INFO] [stderr] warning: redundant closure found
[INFO] [stderr]   --> src/lib.rs:87:26
[INFO] [stderr]    |
[INFO] [stderr] 87 |                     .map(|remote| RemoteData::from(remote))
[INFO] [stderr]    |                          ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove closure as shown: `RemoteData::from`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::redundant_closure)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure
[INFO] [stderr] 
[INFO] [stderr] warning: use of `unwrap_or` followed by a function call
[INFO] [stderr]    --> src/lib.rs:171:28
[INFO] [stderr]     |
[INFO] [stderr] 171 |             url_host: host.unwrap_or("".to_owned()),
[INFO] [stderr]     |                            ^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `unwrap_or_else(|| "".to_owned())`
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::or_fun_call)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call
[INFO] [stderr] 
[INFO] [stderr] warning: use of `unwrap_or` followed by a function call
[INFO] [stderr]    --> src/lib.rs:172:28
[INFO] [stderr]     |
[INFO] [stderr] 172 |             url_path: path.unwrap_or("".to_owned()),
[INFO] [stderr]     |                            ^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `unwrap_or_else(|| "".to_owned())`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call
[INFO] [stderr] 
[INFO] [stderr] warning: single-character string constant used as pattern
[INFO] [stderr]    --> src/lib.rs:229:32
[INFO] [stderr]     |
[INFO] [stderr] 229 |         .map(|s| s.starts_with("."))
[INFO] [stderr]     |                                ^^^ help: try using a char instead: `'.'`
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::single_char_pattern)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern
[INFO] [stderr] 
[INFO] [stderr] warning: unused `#[macro_use]` import
[INFO] [stderr]   --> src/lib.rs:12:1
[INFO] [stderr]    |
[INFO] [stderr] 12 | #[macro_use]
[INFO] [stderr]    | ^^^^^^^^^^^^
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(unused_imports)] on by default
[INFO] [stderr] 
[INFO] [stderr] warning: redundant closure found
[INFO] [stderr]   --> src/lib.rs:87:26
[INFO] [stderr]    |
[INFO] [stderr] 87 |                     .map(|remote| RemoteData::from(remote))
[INFO] [stderr]    |                          ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove closure as shown: `RemoteData::from`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::redundant_closure)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure
[INFO] [stderr] 
[INFO] [stderr] warning: use of `unwrap_or` followed by a function call
[INFO] [stderr]    --> src/lib.rs:171:28
[INFO] [stderr]     |
[INFO] [stderr] 171 |             url_host: host.unwrap_or("".to_owned()),
[INFO] [stderr]     |                            ^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `unwrap_or_else(|| "".to_owned())`
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::or_fun_call)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call
[INFO] [stderr] 
[INFO] [stderr] warning: use of `unwrap_or` followed by a function call
[INFO] [stderr]    --> src/lib.rs:172:28
[INFO] [stderr]     |
[INFO] [stderr] 172 |             url_path: path.unwrap_or("".to_owned()),
[INFO] [stderr]     |                            ^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `unwrap_or_else(|| "".to_owned())`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call
[INFO] [stderr] 
[INFO] [stderr] warning: single-character string constant used as pattern
[INFO] [stderr]    --> src/lib.rs:229:32
[INFO] [stderr]     |
[INFO] [stderr] 229 |         .map(|s| s.starts_with("."))
[INFO] [stderr]     |                                ^^^ help: try using a char instead: `'.'`
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::single_char_pattern)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern
[INFO] [stderr] 
[INFO] [stderr] warning: unused `#[macro_use]` import
[INFO] [stderr]  --> src/main.rs:6:1
[INFO] [stderr]   |
[INFO] [stderr] 6 | #[macro_use]
[INFO] [stderr]   | ^^^^^^^^^^^^
[INFO] [stderr]   |
[INFO] [stderr]   = note: #[warn(unused_imports)] on by default
[INFO] [stderr] 
[INFO] [stderr] warning: unused `#[macro_use]` import
[INFO] [stderr]  --> src/main.rs:6:1
[INFO] [stderr]   |
[INFO] [stderr] 6 | #[macro_use]
[INFO] [stderr]   | ^^^^^^^^^^^^
[INFO] [stderr]   |
[INFO] [stderr]   = note: #[warn(unused_imports)] on by default
[INFO] [stderr] 
[INFO] [stderr]     Finished dev [unoptimized + debuginfo] target(s) in 1m 04s
[INFO] running `"docker" "inspect" "a660a026dccb1dd3c16cd1bd07668f2b9b33650833bb6a6b4352d53c7e7a3729"`
[INFO] running `"docker" "rm" "-f" "a660a026dccb1dd3c16cd1bd07668f2b9b33650833bb6a6b4352d53c7e7a3729"`
[INFO] [stdout] a660a026dccb1dd3c16cd1bd07668f2b9b33650833bb6a6b4352d53c7e7a3729