[INFO] updating cached repository davidB/ffizer [INFO] running `"git" "fetch" "--all"` [INFO] [stdout] Fetching origin [INFO] [stderr] From git://github.com/davidB/ffizer [INFO] [stderr] * branch HEAD -> FETCH_HEAD [INFO] running `"git" "clone" "work/cache/sources/gh/davidB/ffizer" "work/ex/clippy-test-run/sources/stable/gh/davidB/ffizer"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/davidB/ffizer'... [INFO] [stderr] done. [INFO] running `"git" "clone" "work/cache/sources/gh/davidB/ffizer" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/davidB/ffizer"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/davidB/ffizer'... [INFO] [stderr] done. [INFO] running `"git" "rev-parse" "HEAD"` [INFO] [stdout] 6770f222e4f2044429d153c80732e78af9874b7f [INFO] sha for GitHub repo davidB/ffizer: 6770f222e4f2044429d153c80732e78af9874b7f [INFO] validating manifest of davidB/ffizer on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of davidB/ffizer on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing davidB/ffizer [INFO] finished frobbing davidB/ffizer [INFO] frobbed toml for davidB/ffizer written to work/ex/clippy-test-run/sources/stable/gh/davidB/ffizer/Cargo.toml [INFO] started frobbing davidB/ffizer [INFO] finished frobbing davidB/ffizer [INFO] frobbed toml for davidB/ffizer written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/davidB/ffizer/Cargo.toml [INFO] crate davidB/ffizer has a lockfile. skipping [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting davidB/ffizer against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-0/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/gh/davidB/ffizer:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 13c2f763e8b0fb5ba9c0f556b813c8034f146edf6c9b64eb4a31762c39ad405f [INFO] running `"docker" "start" "-a" "13c2f763e8b0fb5ba9c0f556b813c8034f146edf6c9b64eb4a31762c39ad405f"` [INFO] [stderr] Compiling crc32fast v1.1.1 [INFO] [stderr] Compiling serde v1.0.82 [INFO] [stderr] Compiling slog v2.4.1 [INFO] [stderr] Checking predicates-core v1.0.0 [INFO] [stderr] Checking treeline v0.1.0 [INFO] [stderr] Compiling libgit2-sys v0.7.11 [INFO] [stderr] Checking num-bigint v0.1.44 [INFO] [stderr] Checking chrono v0.4.6 [INFO] [stderr] Compiling structopt-derive v0.2.14 [INFO] [stderr] Checking predicates v1.0.0 [INFO] [stderr] Checking os_type v2.2.0 [INFO] [stderr] Checking globset v0.4.2 [INFO] [stderr] Checking Inflector v0.11.3 [INFO] [stderr] Checking predicates-tree v1.0.0 [INFO] [stderr] Checking tokio-reactor v0.1.7 [INFO] [stderr] Checking num-rational v0.1.42 [INFO] [stderr] Checking slog-term v2.4.0 [INFO] [stderr] Checking slog-async v2.3.0 [INFO] [stderr] Checking dialoguer v0.3.0 [INFO] [stderr] Checking libflate v0.1.19 [INFO] [stderr] Checking tokio-uds v0.2.4 [INFO] [stderr] Checking tokio-udp v0.1.3 [INFO] [stderr] Checking tokio-tcp v0.1.2 [INFO] [stderr] Checking num v0.1.42 [INFO] [stderr] Checking structopt v0.2.14 [INFO] [stderr] Checking spectral v0.6.0 [INFO] [stderr] Checking tokio v0.1.13 [INFO] [stderr] Checking hyper v0.12.16 [INFO] [stderr] Checking serde_urlencoded v0.5.4 [INFO] [stderr] Checking toml v0.4.10 [INFO] [stderr] Checking serde_json v1.0.33 [INFO] [stderr] Checking serde_yaml v0.8.8 [INFO] [stderr] Checking hyper-tls v0.3.1 [INFO] [stderr] Checking human-panic v1.0.1 [INFO] [stderr] Checking escargot v0.3.1 [INFO] [stderr] Checking handlebars v1.1.0 [INFO] [stderr] Checking reqwest v0.9.5 [INFO] [stderr] Checking assert_cmd v0.10.2 [INFO] [stderr] Checking git2 v0.8.0 [INFO] [stderr] Checking ffizer v0.8.0 (/opt/crater/workdir) [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/template_cfg.rs:6:31 [INFO] [stderr] | [INFO] [stderr] 6 | const TEMPLATE_CFG_FILENAME: &'static str = ".ffizer.yaml"; [INFO] [stderr] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::const_static_lifetime)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/template_cfg.rs:6:31 [INFO] [stderr] | [INFO] [stderr] 6 | const TEMPLATE_CFG_FILENAME: &'static str = ".ffizer.yaml"; [INFO] [stderr] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/lib.rs:44:28 [INFO] [stderr] | [INFO] [stderr] 44 | const FILEEXT_HANDLEBARS: &'static str = ".ffizer.hbs"; [INFO] [stderr] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::const_static_lifetime)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/lib.rs:44:28 [INFO] [stderr] | [INFO] [stderr] 44 | const FILEEXT_HANDLEBARS: &'static str = ".ffizer.hbs"; [INFO] [stderr] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: explicit lifetimes given in parameter types where they could be elided (or replaced with `'_` if needed by type declaration) [INFO] [stderr] --> src/git.rs:64:1 [INFO] [stderr] | [INFO] [stderr] 64 | / fn clone<'a, P, U, R>(dst: P, url: U, rev: R, fo: FetchOptions<'a>) -> Result<(), Error> [INFO] [stderr] 65 | | where [INFO] [stderr] 66 | | P: AsRef, [INFO] [stderr] 67 | | R: AsRef, [INFO] [stderr] ... | [INFO] [stderr] 75 | | Ok(()) [INFO] [stderr] 76 | | } [INFO] [stderr] | |_^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_lifetimes)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes [INFO] [stderr] [INFO] [stderr] warning: this lifetime isn't used in the function definition [INFO] [stderr] --> src/git.rs:100:13 [INFO] [stderr] | [INFO] [stderr] 100 | fn checkout<'a, P, R>(dst: P, rev: R) -> Result<(), Error> [INFO] [stderr] | ^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::extra_unused_lifetimes)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#extra_unused_lifetimes [INFO] [stderr] [INFO] [stderr] warning: use of `unwrap_or` followed by a function call [INFO] [stderr] --> src/hbs.rs:79:88 [INFO] [stderr] | [INFO] [stderr] 79 | handlebars_helper!(parent: |v: str| Path::new(v).parent().and_then(|s| s.to_str()).unwrap_or("".into())); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: try this: `unwrap_or_else(|| "".into())` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::or_fun_call)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] warning: identical conversion [INFO] [stderr] --> src/hbs.rs:79:98 [INFO] [stderr] | [INFO] [stderr] 79 | handlebars_helper!(parent: |v: str| Path::new(v).parent().and_then(|s| s.to_str()).unwrap_or("".into())); [INFO] [stderr] | ^^^^^^^^^ help: consider removing `.into()`: `""` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::identity_conversion)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_conversion [INFO] [stderr] [INFO] [stderr] warning: use of `unwrap_or` followed by a function call [INFO] [stderr] --> src/hbs.rs:82:94 [INFO] [stderr] | [INFO] [stderr] 82 | handlebars_helper!(file_name: |v: str| Path::new(v).file_name().and_then(|s| s.to_str()).unwrap_or("".into())); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: try this: `unwrap_or_else(|| "".into())` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] warning: identical conversion [INFO] [stderr] --> src/hbs.rs:82:104 [INFO] [stderr] | [INFO] [stderr] 82 | handlebars_helper!(file_name: |v: str| Path::new(v).file_name().and_then(|s| s.to_str()).unwrap_or("".into())); [INFO] [stderr] | ^^^^^^^^^ help: consider removing `.into()`: `""` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_conversion [INFO] [stderr] [INFO] [stderr] warning: use of `unwrap_or` followed by a function call [INFO] [stderr] --> src/hbs.rs:85:94 [INFO] [stderr] | [INFO] [stderr] 85 | handlebars_helper!(extension: |v: str| Path::new(v).extension().and_then(|s| s.to_str()).unwrap_or("".into())); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: try this: `unwrap_or_else(|| "".into())` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] warning: identical conversion [INFO] [stderr] --> src/hbs.rs:85:104 [INFO] [stderr] | [INFO] [stderr] 85 | handlebars_helper!(extension: |v: str| Path::new(v).extension().and_then(|s| s.to_str()).unwrap_or("".into())); [INFO] [stderr] | ^^^^^^^^^ help: consider removing `.into()`: `""` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_conversion [INFO] [stderr] [INFO] [stderr] warning: explicit lifetimes given in parameter types where they could be elided (or replaced with `'_` if needed by type declaration) [INFO] [stderr] --> src/git.rs:64:1 [INFO] [stderr] | [INFO] [stderr] 64 | / fn clone<'a, P, U, R>(dst: P, url: U, rev: R, fo: FetchOptions<'a>) -> Result<(), Error> [INFO] [stderr] 65 | | where [INFO] [stderr] 66 | | P: AsRef, [INFO] [stderr] 67 | | R: AsRef, [INFO] [stderr] ... | [INFO] [stderr] 75 | | Ok(()) [INFO] [stderr] 76 | | } [INFO] [stderr] | |_^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_lifetimes)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes [INFO] [stderr] [INFO] [stderr] warning: use of `unwrap_or` followed by a function call [INFO] [stderr] --> src/hbs.rs:89:89 [INFO] [stderr] | [INFO] [stderr] 89 | Path::new(v).canonicalize().ok().and_then(|s| s.to_str().map(|v| v.to_owned())).unwrap_or("".into()) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: try this: `unwrap_or_else(|| "".into())` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] warning: this lifetime isn't used in the function definition [INFO] [stderr] --> src/git.rs:100:13 [INFO] [stderr] | [INFO] [stderr] 100 | fn checkout<'a, P, R>(dst: P, rev: R) -> Result<(), Error> [INFO] [stderr] | ^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::extra_unused_lifetimes)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#extra_unused_lifetimes [INFO] [stderr] [INFO] [stderr] warning: use of `ok_or` followed by a function call [INFO] [stderr] --> src/source_uri.rs:41:16 [INFO] [stderr] | [INFO] [stderr] 41 | }).ok_or(format_err!("failed to parse source uri")) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `ok_or_else(|| format_err!("failed to parse source uri"))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] warning: use of `unwrap_or` followed by a function call [INFO] [stderr] --> src/ui.rs:52:58 [INFO] [stderr] | [INFO] [stderr] 52 | let value = (variable.default_value).clone().unwrap_or("".into()); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: try this: `unwrap_or_else(|| "".into())` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/ui.rs:60:41 [INFO] [stderr] | [INFO] [stderr] 60 | pub fn confirm_plan(ctx: &Ctx, actions: &Vec) -> Result { [INFO] [stderr] | ^^^^^^^^^^^^ help: change this to: `&[Action]` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::ptr_arg)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: use of `unwrap_or` followed by a function call [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/lib.rs:202:32 [INFO] [stderr] | [INFO] [stderr] 202 | fn execute(ctx: &Ctx, actions: &Vec, variables: &Variables) -> Result<(), Error> { [INFO] [stderr] | ^^^^^^^^^^^^ help: change this to: `&[Action]` [INFO] [stderr] --> src/hbs.rs:79:88 [INFO] [stderr] | [INFO] [stderr] 79 | handlebars_helper!(parent: |v: str| Path::new(v).parent().and_then(|s| s.to_str()).unwrap_or("".into())); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: try this: `unwrap_or_else(|| "".into())` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::or_fun_call)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] warning: identical conversion [INFO] [stderr] --> src/hbs.rs:79:98 [INFO] [stderr] | [INFO] [stderr] 79 | handlebars_helper!(parent: |v: str| Path::new(v).parent().and_then(|s| s.to_str()).unwrap_or("".into())); [INFO] [stderr] | ^^^^^^^^^ help: consider removing `.into()`: `""` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::identity_conversion)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_conversion [INFO] [stderr] [INFO] [stderr] warning: use of `unwrap_or` followed by a function call [INFO] [stderr] --> src/hbs.rs:82:94 [INFO] [stderr] | [INFO] [stderr] 82 | handlebars_helper!(file_name: |v: str| Path::new(v).file_name().and_then(|s| s.to_str()).unwrap_or("".into())); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: try this: `unwrap_or_else(|| "".into())` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] warning: identical conversion [INFO] [stderr] --> src/lib.rs:234:17 [INFO] [stderr] | [INFO] [stderr] 234 | None => PathBuf::from(uri.path.clone()), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider removing `PathBuf::from()`: `uri.path.clone()` [INFO] [stderr] warning: identical conversion [INFO] [stderr] --> src/hbs.rs:82:104 [INFO] [stderr] | [INFO] [stderr] 82 | handlebars_helper!(file_name: |v: str| Path::new(v).file_name().and_then(|s| s.to_str()).unwrap_or("".into())); [INFO] [stderr] | ^^^^^^^^^ help: consider removing `.into()`: `""` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_conversion [INFO] [stderr] [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_conversion [INFO] [stderr] [INFO] [stderr] warning: use of `unwrap_or` followed by a function call [INFO] [stderr] --> src/lib.rs:247:18 [INFO] [stderr] | [INFO] [stderr] 247 | .unwrap_or("".to_owned()) //path.to_str().unwrap_or("??") [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `unwrap_or_else(|| "".to_owned())` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] warning: use of `unwrap_or` followed by a function call [INFO] [stderr] --> src/lib.rs:255:52 [INFO] [stderr] | [INFO] [stderr] 255 | let app_name = std::env::var("CARGO_PKG_NAME").unwrap_or("".into()); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: try this: `unwrap_or_else(|_| "".into())` [INFO] [stderr] warning: use of `unwrap_or` followed by a function call [INFO] [stderr] --> src/hbs.rs:85:94 [INFO] [stderr] | [INFO] [stderr] 85 | handlebars_helper!(extension: |v: str| Path::new(v).extension().and_then(|s| s.to_str()).unwrap_or("".into())); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: try this: `unwrap_or_else(|| "".into())` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] [INFO] [stderr] warning: use of `ok_or` followed by a function call [INFO] [stderr] --> src/lib.rs:257:10 [INFO] [stderr] | [INFO] [stderr] 257 | .ok_or(format_err!("Home directory not found"))?; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `ok_or_else(|| format_err!("Home directory not found"))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] warning: identical conversion [INFO] [stderr] --> src/hbs.rs:85:104 [INFO] [stderr] | [INFO] [stderr] 85 | handlebars_helper!(extension: |v: str| Path::new(v).extension().and_then(|s| s.to_str()).unwrap_or("".into())); [INFO] [stderr] | ^^^^^^^^^ help: consider removing `.into()`: `""` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_conversion [INFO] [stderr] [INFO] [stderr] warning: use of `unwrap_or` followed by a function call [INFO] [stderr] --> src/lib.rs:261:33 [INFO] [stderr] | [INFO] [stderr] 261 | .join(&uri.host.clone().unwrap_or("no_host".to_owned())) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `unwrap_or_else(|| "no_host".to_owned())` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] warning: use of `unwrap_or` followed by a function call [INFO] [stderr] --> src/hbs.rs:89:89 [INFO] [stderr] | [INFO] [stderr] 89 | Path::new(v).canonicalize().ok().and_then(|s| s.to_str().map(|v| v.to_owned())).unwrap_or("".into()) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: try this: `unwrap_or_else(|| "".into())` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] warning: use of `ok_or` followed by a function call [INFO] [stderr] --> src/lib.rs:304:10 [INFO] [stderr] | [INFO] [stderr] 304 | .ok_or(format_err!("failed to stringify path")) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `ok_or_else(|| format_err!("failed to stringify path"))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] warning: use of `ok_or` followed by a function call [INFO] [stderr] --> src/source_uri.rs:41:16 [INFO] [stderr] | [INFO] [stderr] 41 | }).ok_or(format_err!("failed to parse source uri")) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `ok_or_else(|| format_err!("failed to parse source uri"))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] warning: use of `ok_or` followed by a function call [INFO] [stderr] --> src/lib.rs:314:14 [INFO] [stderr] | [INFO] [stderr] 314 | .ok_or(format_err!("failed to extract file_name"))?; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `ok_or_else(|| format_err!("failed to extract file_name"))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] warning: use of `ok_or` followed by a function call [INFO] [stderr] --> src/lib.rs:317:14 [INFO] [stderr] | [INFO] [stderr] 317 | .ok_or(format_err!( [INFO] [stderr] | ______________^ [INFO] [stderr] 318 | | "failed to remove {} from file_name", [INFO] [stderr] 319 | | FILEEXT_HANDLEBARS [INFO] [stderr] 320 | | ))?; [INFO] [stderr] | |______________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 317 | .ok_or_else(|| format_err!( [INFO] [stderr] 318 | "failed to remove {} from file_name", [INFO] [stderr] 319 | FILEEXT_HANDLEBARS [INFO] [stderr] 320 | ))?; [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/lib.rs:337:14 [INFO] [stderr] | [INFO] [stderr] 337 | actions: &Vec, [INFO] [stderr] | ^^^^^^^^^^^^ help: change this to: `&[Action]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: use of `unwrap_or` followed by a function call [INFO] [stderr] --> src/ui.rs:52:58 [INFO] [stderr] | [INFO] [stderr] 52 | let value = (variable.default_value).clone().unwrap_or("".into()); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: try this: `unwrap_or_else(|| "".into())` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/ui.rs:60:41 [INFO] [stderr] | [INFO] [stderr] 60 | pub fn confirm_plan(ctx: &Ctx, actions: &Vec) -> Result { [INFO] [stderr] | ^^^^^^^^^^^^ help: change this to: `&[Action]` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::ptr_arg)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/lib.rs:202:32 [INFO] [stderr] | [INFO] [stderr] 202 | fn execute(ctx: &Ctx, actions: &Vec, variables: &Variables) -> Result<(), Error> { [INFO] [stderr] | ^^^^^^^^^^^^ help: change this to: `&[Action]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: identical conversion [INFO] [stderr] --> src/lib.rs:234:17 [INFO] [stderr] | [INFO] [stderr] 234 | None => PathBuf::from(uri.path.clone()), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider removing `PathBuf::from()`: `uri.path.clone()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_conversion [INFO] [stderr] [INFO] [stderr] warning: use of `unwrap_or` followed by a function call [INFO] [stderr] --> src/lib.rs:247:18 [INFO] [stderr] | [INFO] [stderr] 247 | .unwrap_or("".to_owned()) //path.to_str().unwrap_or("??") [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `unwrap_or_else(|| "".to_owned())` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] warning: use of `unwrap_or` followed by a function call [INFO] [stderr] --> src/lib.rs:255:52 [INFO] [stderr] | [INFO] [stderr] 255 | let app_name = std::env::var("CARGO_PKG_NAME").unwrap_or("".into()); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: try this: `unwrap_or_else(|_| "".into())` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] warning: use of `ok_or` followed by a function call [INFO] [stderr] --> src/lib.rs:257:10 [INFO] [stderr] | [INFO] [stderr] 257 | .ok_or(format_err!("Home directory not found"))?; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `ok_or_else(|| format_err!("Home directory not found"))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] warning: use of `unwrap_or` followed by a function call [INFO] [stderr] --> src/lib.rs:261:33 [INFO] [stderr] | [INFO] [stderr] 261 | .join(&uri.host.clone().unwrap_or("no_host".to_owned())) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `unwrap_or_else(|| "no_host".to_owned())` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] warning: use of `ok_or` followed by a function call [INFO] [stderr] --> src/lib.rs:304:10 [INFO] [stderr] | [INFO] [stderr] 304 | .ok_or(format_err!("failed to stringify path")) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `ok_or_else(|| format_err!("failed to stringify path"))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] warning: use of `ok_or` followed by a function call [INFO] [stderr] --> src/lib.rs:314:14 [INFO] [stderr] | [INFO] [stderr] 314 | .ok_or(format_err!("failed to extract file_name"))?; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `ok_or_else(|| format_err!("failed to extract file_name"))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] warning: use of `ok_or` followed by a function call [INFO] [stderr] --> src/lib.rs:317:14 [INFO] [stderr] | [INFO] [stderr] 317 | .ok_or(format_err!( [INFO] [stderr] | ______________^ [INFO] [stderr] 318 | | "failed to remove {} from file_name", [INFO] [stderr] 319 | | FILEEXT_HANDLEBARS [INFO] [stderr] 320 | | ))?; [INFO] [stderr] | |______________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 317 | .ok_or_else(|| format_err!( [INFO] [stderr] 318 | "failed to remove {} from file_name", [INFO] [stderr] 319 | FILEEXT_HANDLEBARS [INFO] [stderr] 320 | ))?; [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/lib.rs:337:14 [INFO] [stderr] | [INFO] [stderr] 337 | actions: &Vec, [INFO] [stderr] | ^^^^^^^^^^^^ help: change this to: `&[Action]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: this boolean expression can be simplified [INFO] [stderr] --> tests/dir_diff.rs:42:8 [INFO] [stderr] | [INFO] [stderr] 42 | Ok(!a_walker.next().is_none() || !b_walker.next().is_none()) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `a_walker.next().is_some() || b_walker.next().is_some()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::nonminimal_bool)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stderr] [INFO] [stderr] warning: this boolean expression can be simplified [INFO] [stderr] --> tests/dir_diff.rs:42:8 [INFO] [stderr] | [INFO] [stderr] 42 | Ok(!a_walker.next().is_none() || !b_walker.next().is_none()) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `a_walker.next().is_some() || b_walker.next().is_some()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::nonminimal_bool)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 1m 37s [INFO] running `"docker" "inspect" "13c2f763e8b0fb5ba9c0f556b813c8034f146edf6c9b64eb4a31762c39ad405f"` [INFO] running `"docker" "rm" "-f" "13c2f763e8b0fb5ba9c0f556b813c8034f146edf6c9b64eb4a31762c39ad405f"` [INFO] [stdout] 13c2f763e8b0fb5ba9c0f556b813c8034f146edf6c9b64eb4a31762c39ad405f