[INFO] updating cached repository davemcg3/isitup [INFO] running `"git" "fetch" "--all"` [INFO] [stdout] Fetching origin [INFO] [stderr] From git://github.com/davemcg3/isitup [INFO] [stderr] * branch HEAD -> FETCH_HEAD [INFO] running `"git" "clone" "work/cache/sources/gh/davemcg3/isitup" "work/ex/clippy-test-run/sources/stable/gh/davemcg3/isitup"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/davemcg3/isitup'... [INFO] [stderr] done. [INFO] running `"git" "clone" "work/cache/sources/gh/davemcg3/isitup" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/davemcg3/isitup"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/davemcg3/isitup'... [INFO] [stderr] done. [INFO] running `"git" "rev-parse" "HEAD"` [INFO] [stdout] ba833160ba69213e505a8764156a58f5fdcabca9 [INFO] sha for GitHub repo davemcg3/isitup: ba833160ba69213e505a8764156a58f5fdcabca9 [INFO] validating manifest of davemcg3/isitup on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of davemcg3/isitup on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing davemcg3/isitup [INFO] finished frobbing davemcg3/isitup [INFO] frobbed toml for davemcg3/isitup written to work/ex/clippy-test-run/sources/stable/gh/davemcg3/isitup/Cargo.toml [INFO] started frobbing davemcg3/isitup [INFO] finished frobbing davemcg3/isitup [INFO] frobbed toml for davemcg3/isitup written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/davemcg3/isitup/Cargo.toml [INFO] crate davemcg3/isitup has a lockfile. skipping [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting davemcg3/isitup against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-5/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/gh/davemcg3/isitup:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] f26a929e38fc7ebdba57bf56ba4797b72cd418ef8c1d373f443200817cdd68a5 [INFO] running `"docker" "start" "-a" "f26a929e38fc7ebdba57bf56ba4797b72cd418ef8c1d373f443200817cdd68a5"` [INFO] [stderr] Compiling version_check v0.1.5 [INFO] [stderr] Compiling cc v1.0.25 [INFO] [stderr] Checking want v0.0.6 [INFO] [stderr] Checking tokio-io v0.1.9 [INFO] [stderr] Compiling lazy_static v1.1.0 [INFO] [stderr] Compiling unicase v1.4.2 [INFO] [stderr] Compiling unicase v2.2.0 [INFO] [stderr] Checking tokio-codec v0.1.1 [INFO] [stderr] Checking h2 v0.1.13 [INFO] [stderr] Checking crossbeam-epoch v0.5.2 [INFO] [stderr] Checking tokio-reactor v0.1.6 [INFO] [stderr] Compiling openssl-sys v0.9.39 [INFO] [stderr] Checking phf_shared v0.7.23 [INFO] [stderr] Compiling phf_generator v0.7.23 [INFO] [stderr] Checking mime v0.3.12 [INFO] [stderr] Checking crossbeam-deque v0.6.1 [INFO] [stderr] Checking phf v0.7.23 [INFO] [stderr] Compiling phf_codegen v0.7.23 [INFO] [stderr] Compiling openssl v0.10.14 [INFO] [stderr] Compiling native-tls v0.2.1 [INFO] [stderr] Checking tokio-threadpool v0.1.7 [INFO] [stderr] Checking tokio-udp v0.1.2 [INFO] [stderr] Checking tokio-tcp v0.1.2 [INFO] [stderr] Checking tokio-uds v0.2.2 [INFO] [stderr] Compiling mime_guess v2.0.0-alpha.6 [INFO] [stderr] Checking tokio-fs v0.1.3 [INFO] [stderr] Checking tokio v0.1.11 [INFO] [stderr] Checking hyper v0.12.12 [INFO] [stderr] Checking hyper-tls v0.3.1 [INFO] [stderr] Checking reqwest v0.9.3 [INFO] [stderr] Checking isitup v0.1.0 (/opt/crater/workdir) [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/main.rs:11:5 [INFO] [stderr] | [INFO] [stderr] 11 | return "site doesn't exist!"; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `"site doesn't exist!"` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_return)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/main.rs:16:7 [INFO] [stderr] | [INFO] [stderr] 16 | return "site is up!"; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `"site is up!"` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/main.rs:18:7 [INFO] [stderr] | [INFO] [stderr] 18 | return "site is down!"; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `"site is down!"` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: useless use of `format!` [INFO] [stderr] --> src/main.rs:8:13 [INFO] [stderr] | [INFO] [stderr] 8 | let url = format!("{}", site); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ help: consider using .to_string(): `site.to_string()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::useless_format)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format [INFO] [stderr] = note: this error originates in a macro outside of the current crate (in Nightly builds, run with -Z external-macro-backtrace for more info) [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/main.rs:11:5 [INFO] [stderr] | [INFO] [stderr] 11 | return "site doesn't exist!"; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `"site doesn't exist!"` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_return)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/main.rs:16:7 [INFO] [stderr] | [INFO] [stderr] 16 | return "site is up!"; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `"site is up!"` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/main.rs:18:7 [INFO] [stderr] | [INFO] [stderr] 18 | return "site is down!"; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `"site is down!"` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: useless use of `format!` [INFO] [stderr] --> src/main.rs:8:13 [INFO] [stderr] | [INFO] [stderr] 8 | let url = format!("{}", site); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ help: consider using .to_string(): `site.to_string()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::useless_format)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format [INFO] [stderr] = note: this error originates in a macro outside of the current crate (in Nightly builds, run with -Z external-macro-backtrace for more info) [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 42.55s [INFO] running `"docker" "inspect" "f26a929e38fc7ebdba57bf56ba4797b72cd418ef8c1d373f443200817cdd68a5"` [INFO] running `"docker" "rm" "-f" "f26a929e38fc7ebdba57bf56ba4797b72cd418ef8c1d373f443200817cdd68a5"` [INFO] [stdout] f26a929e38fc7ebdba57bf56ba4797b72cd418ef8c1d373f443200817cdd68a5