[INFO] updating cached repository davelpz/mal
[INFO] running `"git" "fetch" "--all"`
[INFO] [stdout] Fetching origin
[INFO] [stderr] From git://github.com/davelpz/mal
[INFO] [stderr]  * branch            HEAD       -> FETCH_HEAD
[INFO] running `"git" "clone" "work/cache/sources/gh/davelpz/mal" "work/ex/clippy-test-run/sources/stable/gh/davelpz/mal"`
[INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/davelpz/mal'...
[INFO] [stderr] done.
[INFO] running `"git" "clone" "work/cache/sources/gh/davelpz/mal" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/davelpz/mal"`
[INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/davelpz/mal'...
[INFO] [stderr] done.
[INFO] running `"git" "rev-parse" "HEAD"`
[INFO] [stdout] d36de8c879dff639590c3da511ce9781b46c3ef0
[INFO] sha for GitHub repo davelpz/mal: d36de8c879dff639590c3da511ce9781b46c3ef0
[INFO] validating manifest of davelpz/mal on toolchain stable
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"`
[INFO] validating manifest of davelpz/mal on toolchain stable+rustflags=-Dclippy::into_iter_on_array
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"`
[INFO] started frobbing davelpz/mal
[INFO] finished frobbing davelpz/mal
[INFO] frobbed toml for davelpz/mal written to work/ex/clippy-test-run/sources/stable/gh/davelpz/mal/Cargo.toml
[INFO] started frobbing davelpz/mal
[INFO] finished frobbing davelpz/mal
[INFO] frobbed toml for davelpz/mal written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/davelpz/mal/Cargo.toml
[INFO] crate davelpz/mal has a lockfile. skipping
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"`
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"`
[INFO] linting davelpz/mal against stable for clippy-test-run
[INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-2/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/gh/davelpz/mal:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"`
[INFO] [stdout] 41e428445acc01a159a4b5080496985957751c48dcee4ce899138534728cb7e8
[INFO] running `"docker" "start" "-a" "41e428445acc01a159a4b5080496985957751c48dcee4ce899138534728cb7e8"`
[INFO] [stderr]     Checking rustyline v2.1.0
[INFO] [stderr]     Checking mal v0.1.0 (/opt/crater/workdir)
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]    --> src/core.rs:205:5
[INFO] [stderr]     |
[INFO] [stderr] 205 |     return MalType::bool(false);
[INFO] [stderr]     |     ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `MalType::bool(false)`
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::needless_return)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]    --> src/core.rs:225:5
[INFO] [stderr]     |
[INFO] [stderr] 225 |     return MalType::bool(false);
[INFO] [stderr]     |     ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `MalType::bool(false)`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]    --> src/core.rs:245:5
[INFO] [stderr]     |
[INFO] [stderr] 245 |     return MalType::bool(false);
[INFO] [stderr]     |     ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `MalType::bool(false)`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]    --> src/core.rs:265:5
[INFO] [stderr]     |
[INFO] [stderr] 265 |     return MalType::bool(false);
[INFO] [stderr]     |     ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `MalType::bool(false)`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]    --> src/core.rs:457:13
[INFO] [stderr]     |
[INFO] [stderr] 457 |             return result;
[INFO] [stderr]     |             ^^^^^^^^^^^^^^ help: remove `return` as shown: `result`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]    --> src/core.rs:462:13
[INFO] [stderr]     |
[INFO] [stderr] 462 |             return result;
[INFO] [stderr]     |             ^^^^^^^^^^^^^^ help: remove `return` as shown: `result`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]    --> src/core.rs:464:13
[INFO] [stderr]     |
[INFO] [stderr] 464 |             return MalType::error("swap! 2nd argument must be a function".to_string());
[INFO] [stderr]     |             ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `MalType::error("swap! 2nd argument must be a function".to_string())`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] 
[INFO] [stderr] warning: this `else { if .. }` block can be collapsed
[INFO] [stderr]    --> src/core.rs:472:12
[INFO] [stderr]     |
[INFO] [stderr] 472 |       } else {
[INFO] [stderr]     |  ____________^
[INFO] [stderr] 473 | |         if args[1].is_list() || args[1].is_vector() {
[INFO] [stderr] 474 | |             let l = &*args[1].get_list();
[INFO] [stderr] 475 | |             let mut result_list: Vec<MalType> = Vec::new();
[INFO] [stderr] ...   |
[INFO] [stderr] 482 | |         }
[INFO] [stderr] 483 | |     }
[INFO] [stderr]     | |_____^
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::collapsible_if)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if
[INFO] [stderr] help: try
[INFO] [stderr]     |
[INFO] [stderr] 472 |     } else if args[1].is_list() || args[1].is_vector() {
[INFO] [stderr] 473 |     let l = &*args[1].get_list();
[INFO] [stderr] 474 |     let mut result_list: Vec<MalType> = Vec::new();
[INFO] [stderr] 475 |     let mut clone_list = l.clone();
[INFO] [stderr] 476 |     result_list.push(args[0].clone());
[INFO] [stderr] 477 |     result_list.append(&mut clone_list);
[INFO] [stderr]   ...
[INFO] [stderr] 
[INFO] [stderr] warning: this `else { if .. }` block can be collapsed
[INFO] [stderr]    --> src/core.rs:553:24
[INFO] [stderr]     |
[INFO] [stderr] 553 |                   } else {
[INFO] [stderr]     |  ________________________^
[INFO] [stderr] 554 | |                     if list.len() > 1 {
[INFO] [stderr] 555 | |                         MalType::list(list[1..].to_vec())
[INFO] [stderr] 556 | |                     } else {
[INFO] [stderr] ...   |
[INFO] [stderr] 559 | |                     }
[INFO] [stderr] 560 | |                 }
[INFO] [stderr]     | |_________________^
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if
[INFO] [stderr] help: try
[INFO] [stderr]     |
[INFO] [stderr] 553 |                 } else if list.len() > 1 {
[INFO] [stderr] 554 |     MalType::list(list[1..].to_vec())
[INFO] [stderr] 555 | } else {
[INFO] [stderr] 556 |     let temp: Vec<MalType> = Vec::new();
[INFO] [stderr] 557 |     MalType::list(temp)
[INFO] [stderr] 558 | }
[INFO] [stderr]     |
[INFO] [stderr] 
[INFO] [stderr] warning: this `else { if .. }` block can be collapsed
[INFO] [stderr]   --> src/eval.rs:41:16
[INFO] [stderr]    |
[INFO] [stderr] 41 |           } else {
[INFO] [stderr]    |  ________________^
[INFO] [stderr] 42 | |             if let Some(out) = self.outer.clone() {
[INFO] [stderr] 43 | |                 out.borrow().find(key)
[INFO] [stderr] 44 | |             } else {
[INFO] [stderr] 45 | |                 None
[INFO] [stderr] 46 | |             }
[INFO] [stderr] 47 | |         }
[INFO] [stderr]    | |_________^
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if
[INFO] [stderr] help: try
[INFO] [stderr]    |
[INFO] [stderr] 41 |         } else if let Some(out) = self.outer.clone() {
[INFO] [stderr] 42 |     out.borrow().find(key)
[INFO] [stderr] 43 | } else {
[INFO] [stderr] 44 |     None
[INFO] [stderr] 45 | }
[INFO] [stderr]    |
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]    --> src/eval.rs:188:9
[INFO] [stderr]     |
[INFO] [stderr] 188 |         return MalType::list(list);
[INFO] [stderr]     |         ^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `MalType::list(list)`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]    --> src/eval.rs:193:9
[INFO] [stderr]     |
[INFO] [stderr] 193 |         return MalType::list(list);
[INFO] [stderr]     |         ^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `MalType::list(list)`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] 
[INFO] [stderr] warning: this if statement can be collapsed
[INFO] [stderr]    --> src/eval.rs:200:9
[INFO] [stderr]     |
[INFO] [stderr] 200 | /         if !l.is_empty() {
[INFO] [stderr] 201 | |             if l[0].is_symbol() {
[INFO] [stderr] 202 | |                 let sym = l[0].get_string();
[INFO] [stderr] 203 | |                 let val = env.get(&sym);
[INFO] [stderr] 204 | |                 return val.is_macro();
[INFO] [stderr] 205 | |             }
[INFO] [stderr] 206 | |         }
[INFO] [stderr]     | |_________^
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if
[INFO] [stderr] help: try
[INFO] [stderr]     |
[INFO] [stderr] 200 |         if !l.is_empty() && l[0].is_symbol() {
[INFO] [stderr] 201 |     let sym = l[0].get_string();
[INFO] [stderr] 202 |     let val = env.get(&sym);
[INFO] [stderr] 203 |     return val.is_macro();
[INFO] [stderr] 204 | }
[INFO] [stderr]     |
[INFO] [stderr] 
[INFO] [stderr] warning: this `else { if .. }` block can be collapsed
[INFO] [stderr]    --> src/eval.rs:317:28
[INFO] [stderr]     |
[INFO] [stderr] 317 |                       } else {
[INFO] [stderr]     |  ____________________________^
[INFO] [stderr] 318 | |                         if uneval_list.len() > 2 {
[INFO] [stderr] 319 | |                             ast = uneval_list[2].clone();
[INFO] [stderr] 320 | |                         } else {
[INFO] [stderr] 321 | |                             return MalType::nil();
[INFO] [stderr] 322 | |                         }
[INFO] [stderr] 323 | |                     }
[INFO] [stderr]     | |_____________________^
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if
[INFO] [stderr] help: try
[INFO] [stderr]     |
[INFO] [stderr] 317 |                     } else if uneval_list.len() > 2 {
[INFO] [stderr] 318 |     ast = uneval_list[2].clone();
[INFO] [stderr] 319 | } else {
[INFO] [stderr] 320 |     return MalType::nil();
[INFO] [stderr] 321 | }
[INFO] [stderr]     |
[INFO] [stderr] 
[INFO] [stderr] warning: long literal lacking separators
[INFO] [stderr]    --> src/eval.rs:961:64
[INFO] [stderr]     |
[INFO] [stderr] 961 |         tests.push(("(def! res2 (sum2 10000 0))", MalType::int(50005000)));
[INFO] [stderr]     |                                                                ^^^^^^^^ help: consider: `50_005_000`
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::unreadable_literal)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]    --> src/core.rs:205:5
[INFO] [stderr]     |
[INFO] [stderr] 205 |     return MalType::bool(false);
[INFO] [stderr]     |     ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `MalType::bool(false)`
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::needless_return)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]    --> src/core.rs:225:5
[INFO] [stderr]     |
[INFO] [stderr] 225 |     return MalType::bool(false);
[INFO] [stderr]     |     ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `MalType::bool(false)`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]    --> src/core.rs:245:5
[INFO] [stderr]     |
[INFO] [stderr] 245 |     return MalType::bool(false);
[INFO] [stderr]     |     ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `MalType::bool(false)`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]    --> src/core.rs:265:5
[INFO] [stderr]     |
[INFO] [stderr] 265 |     return MalType::bool(false);
[INFO] [stderr]     |     ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `MalType::bool(false)`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]    --> src/core.rs:457:13
[INFO] [stderr]     |
[INFO] [stderr] 457 |             return result;
[INFO] [stderr]     |             ^^^^^^^^^^^^^^ help: remove `return` as shown: `result`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]    --> src/core.rs:462:13
[INFO] [stderr]     |
[INFO] [stderr] 462 |             return result;
[INFO] [stderr]     |             ^^^^^^^^^^^^^^ help: remove `return` as shown: `result`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]    --> src/core.rs:464:13
[INFO] [stderr]     |
[INFO] [stderr] 464 |             return MalType::error("swap! 2nd argument must be a function".to_string());
[INFO] [stderr]     |             ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `MalType::error("swap! 2nd argument must be a function".to_string())`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] 
[INFO] [stderr] warning: this `else { if .. }` block can be collapsed
[INFO] [stderr]    --> src/core.rs:472:12
[INFO] [stderr]     |
[INFO] [stderr] 472 |       } else {
[INFO] [stderr]     |  ____________^
[INFO] [stderr] 473 | |         if args[1].is_list() || args[1].is_vector() {
[INFO] [stderr] 474 | |             let l = &*args[1].get_list();
[INFO] [stderr] 475 | |             let mut result_list: Vec<MalType> = Vec::new();
[INFO] [stderr] ...   |
[INFO] [stderr] 482 | |         }
[INFO] [stderr] 483 | |     }
[INFO] [stderr]     | |_____^
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::collapsible_if)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if
[INFO] [stderr] help: try
[INFO] [stderr]     |
[INFO] [stderr] 472 |     } else if args[1].is_list() || args[1].is_vector() {
[INFO] [stderr] 473 |     let l = &*args[1].get_list();
[INFO] [stderr] 474 |     let mut result_list: Vec<MalType> = Vec::new();
[INFO] [stderr] 475 |     let mut clone_list = l.clone();
[INFO] [stderr] 476 |     result_list.push(args[0].clone());
[INFO] [stderr] 477 |     result_list.append(&mut clone_list);
[INFO] [stderr]   ...
[INFO] [stderr] 
[INFO] [stderr] warning: this `else { if .. }` block can be collapsed
[INFO] [stderr]    --> src/core.rs:553:24
[INFO] [stderr]     |
[INFO] [stderr] 553 |                   } else {
[INFO] [stderr]     |  ________________________^
[INFO] [stderr] 554 | |                     if list.len() > 1 {
[INFO] [stderr] 555 | |                         MalType::list(list[1..].to_vec())
[INFO] [stderr] 556 | |                     } else {
[INFO] [stderr] ...   |
[INFO] [stderr] 559 | |                     }
[INFO] [stderr] 560 | |                 }
[INFO] [stderr]     | |_________________^
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if
[INFO] [stderr] help: try
[INFO] [stderr]     |
[INFO] [stderr] 553 |                 } else if list.len() > 1 {
[INFO] [stderr] 554 |     MalType::list(list[1..].to_vec())
[INFO] [stderr] 555 | } else {
[INFO] [stderr] 556 |     let temp: Vec<MalType> = Vec::new();
[INFO] [stderr] 557 |     MalType::list(temp)
[INFO] [stderr] 558 | }
[INFO] [stderr]     |
[INFO] [stderr] 
[INFO] [stderr] warning: this `else { if .. }` block can be collapsed
[INFO] [stderr]   --> src/eval.rs:41:16
[INFO] [stderr]    |
[INFO] [stderr] 41 |           } else {
[INFO] [stderr]    |  ________________^
[INFO] [stderr] 42 | |             if let Some(out) = self.outer.clone() {
[INFO] [stderr] 43 | |                 out.borrow().find(key)
[INFO] [stderr] 44 | |             } else {
[INFO] [stderr] 45 | |                 None
[INFO] [stderr] 46 | |             }
[INFO] [stderr] 47 | |         }
[INFO] [stderr]    | |_________^
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if
[INFO] [stderr] help: try
[INFO] [stderr]    |
[INFO] [stderr] 41 |         } else if let Some(out) = self.outer.clone() {
[INFO] [stderr] 42 |     out.borrow().find(key)
[INFO] [stderr] 43 | } else {
[INFO] [stderr] 44 |     None
[INFO] [stderr] 45 | }
[INFO] [stderr]    |
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]    --> src/eval.rs:188:9
[INFO] [stderr]     |
[INFO] [stderr] 188 |         return MalType::list(list);
[INFO] [stderr]     |         ^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `MalType::list(list)`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]    --> src/eval.rs:193:9
[INFO] [stderr]     |
[INFO] [stderr] 193 |         return MalType::list(list);
[INFO] [stderr]     |         ^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `MalType::list(list)`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] 
[INFO] [stderr] warning: this if statement can be collapsed
[INFO] [stderr]    --> src/eval.rs:200:9
[INFO] [stderr]     |
[INFO] [stderr] 200 | /         if !l.is_empty() {
[INFO] [stderr] 201 | |             if l[0].is_symbol() {
[INFO] [stderr] 202 | |                 let sym = l[0].get_string();
[INFO] [stderr] 203 | |                 let val = env.get(&sym);
[INFO] [stderr] 204 | |                 return val.is_macro();
[INFO] [stderr] 205 | |             }
[INFO] [stderr] 206 | |         }
[INFO] [stderr]     | |_________^
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if
[INFO] [stderr] help: try
[INFO] [stderr]     |
[INFO] [stderr] 200 |         if !l.is_empty() && l[0].is_symbol() {
[INFO] [stderr] 201 |     let sym = l[0].get_string();
[INFO] [stderr] 202 |     let val = env.get(&sym);
[INFO] [stderr] 203 |     return val.is_macro();
[INFO] [stderr] 204 | }
[INFO] [stderr]     |
[INFO] [stderr] 
[INFO] [stderr] warning: this `else { if .. }` block can be collapsed
[INFO] [stderr]    --> src/eval.rs:317:28
[INFO] [stderr]     |
[INFO] [stderr] 317 |                       } else {
[INFO] [stderr]     |  ____________________________^
[INFO] [stderr] 318 | |                         if uneval_list.len() > 2 {
[INFO] [stderr] 319 | |                             ast = uneval_list[2].clone();
[INFO] [stderr] 320 | |                         } else {
[INFO] [stderr] 321 | |                             return MalType::nil();
[INFO] [stderr] 322 | |                         }
[INFO] [stderr] 323 | |                     }
[INFO] [stderr]     | |_____________________^
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if
[INFO] [stderr] help: try
[INFO] [stderr]     |
[INFO] [stderr] 317 |                     } else if uneval_list.len() > 2 {
[INFO] [stderr] 318 |     ast = uneval_list[2].clone();
[INFO] [stderr] 319 | } else {
[INFO] [stderr] 320 |     return MalType::nil();
[INFO] [stderr] 321 | }
[INFO] [stderr]     |
[INFO] [stderr] 
[INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices.
[INFO] [stderr]   --> src/core.rs:62:22
[INFO] [stderr]    |
[INFO] [stderr] 62 | fn all_numeric(args: &BuiltinFuncArgs) -> bool {
[INFO] [stderr]    |                      ^^^^^^^^^^^^^^^^
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::ptr_arg)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg
[INFO] [stderr] 
[INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices.
[INFO] [stderr]   --> src/core.rs:66:18
[INFO] [stderr]    |
[INFO] [stderr] 66 | fn all_int(args: &BuiltinFuncArgs) -> bool {
[INFO] [stderr]    |                  ^^^^^^^^^^^^^^^^
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg
[INFO] [stderr] 
[INFO] [stderr] warning: useless use of `format!`
[INFO] [stderr]   --> src/core.rs:98:21
[INFO] [stderr]    |
[INFO] [stderr] 98 |     MalType::string(format!("{}", prn_helper(args, true, " ")))
[INFO] [stderr]    |                     ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using .to_string(): `prn_helper(args, true, " ").to_string()`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::useless_format)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format
[INFO] [stderr]    = note: this error originates in a macro outside of the current crate (in Nightly builds, run with -Z external-macro-backtrace for more info)
[INFO] [stderr] 
[INFO] [stderr] warning: useless use of `format!`
[INFO] [stderr]    --> src/core.rs:102:21
[INFO] [stderr]     |
[INFO] [stderr] 102 |     MalType::string(format!("{}", prn_helper(args, false, "")))
[INFO] [stderr]     |                     ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using .to_string(): `prn_helper(args, false, "").to_string()`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format
[INFO] [stderr]     = note: this error originates in a macro outside of the current crate (in Nightly builds, run with -Z external-macro-backtrace for more info)
[INFO] [stderr] 
[INFO] [stderr] error: this `if` has identical blocks
[INFO] [stderr]    --> src/core.rs:150:46
[INFO] [stderr]     |
[INFO] [stderr] 150 |       } else if a.is_symbol() && b.is_symbol() {
[INFO] [stderr]     |  ______________________________________________^
[INFO] [stderr] 151 | |         a.get_string() == b.get_string()
[INFO] [stderr] 152 | |     } else if a.is_atom() && b.is_atom() {
[INFO] [stderr]     | |_____^
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[deny(clippy::if_same_then_else)] on by default
[INFO] [stderr] note: same as this
[INFO] [stderr]    --> src/core.rs:148:46
[INFO] [stderr]     |
[INFO] [stderr] 148 |       } else if a.is_string() && b.is_string() {
[INFO] [stderr]     |  ______________________________________________^
[INFO] [stderr] 149 | |         a.get_string() == b.get_string()
[INFO] [stderr] 150 | |     } else if a.is_symbol() && b.is_symbol() {
[INFO] [stderr]     | |_____^
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#if_same_then_else
[INFO] [stderr] 
[INFO] [stderr] error: strict comparison of f32 or f64
[INFO] [stderr]    --> src/core.rs:137:9
[INFO] [stderr]     |
[INFO] [stderr] 137 |         a.get_float() == b.get_float()
[INFO] [stderr]     |         ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider comparing them within some error: `(a.get_float() - b.get_float()).abs() < error`
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[deny(clippy::float_cmp)] on by default
[INFO] [stderr] note: std::f32::EPSILON and std::f64::EPSILON are available.
[INFO] [stderr]    --> src/core.rs:137:9
[INFO] [stderr]     |
[INFO] [stderr] 137 |         a.get_float() == b.get_float()
[INFO] [stderr]     |         ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#float_cmp
[INFO] [stderr] 
[INFO] [stderr] error: this `if` has identical blocks
[INFO] [stderr]    --> src/core.rs:199:42
[INFO] [stderr]     |
[INFO] [stderr] 199 |               } else if args[1].is_float() {
[INFO] [stderr]     |  __________________________________________^
[INFO] [stderr] 200 | |                 return MalType::bool(args[0].get_float() < args[1].get_float());
[INFO] [stderr] 201 | |             }
[INFO] [stderr]     | |_____________^
[INFO] [stderr]     |
[INFO] [stderr] note: same as this
[INFO] [stderr]    --> src/core.rs:197:33
[INFO] [stderr]     |
[INFO] [stderr] 197 |               if args[1].is_int() {
[INFO] [stderr]     |  _________________________________^
[INFO] [stderr] 198 | |                 return MalType::bool(args[0].get_float() < args[1].get_float());
[INFO] [stderr] 199 | |             } else if args[1].is_float() {
[INFO] [stderr]     | |_____________^
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#if_same_then_else
[INFO] [stderr] 
[INFO] [stderr] error: this `if` has identical blocks
[INFO] [stderr]    --> src/core.rs:219:42
[INFO] [stderr]     |
[INFO] [stderr] 219 |               } else if args[1].is_float() {
[INFO] [stderr]     |  __________________________________________^
[INFO] [stderr] 220 | |                 return MalType::bool(args[0].get_float() <= args[1].get_float());
[INFO] [stderr] 221 | |             }
[INFO] [stderr]     | |_____________^
[INFO] [stderr]     |
[INFO] [stderr] note: same as this
[INFO] [stderr]    --> src/core.rs:217:33
[INFO] [stderr]     |
[INFO] [stderr] 217 |               if args[1].is_int() {
[INFO] [stderr]     |  _________________________________^
[INFO] [stderr] 218 | |                 return MalType::bool(args[0].get_float() <= args[1].get_float());
[INFO] [stderr] 219 | |             } else if args[1].is_float() {
[INFO] [stderr]     | |_____________^
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#if_same_then_else
[INFO] [stderr] 
[INFO] [stderr] error: this `if` has identical blocks
[INFO] [stderr]    --> src/core.rs:239:42
[INFO] [stderr]     |
[INFO] [stderr] 239 |               } else if args[1].is_float() {
[INFO] [stderr]     |  __________________________________________^
[INFO] [stderr] 240 | |                 return MalType::bool(args[0].get_float() > args[1].get_float());
[INFO] [stderr] 241 | |             }
[INFO] [stderr]     | |_____________^
[INFO] [stderr]     |
[INFO] [stderr] note: same as this
[INFO] [stderr]    --> src/core.rs:237:33
[INFO] [stderr]     |
[INFO] [stderr] 237 |               if args[1].is_int() {
[INFO] [stderr]     |  _________________________________^
[INFO] [stderr] 238 | |                 return MalType::bool(args[0].get_float() > args[1].get_float());
[INFO] [stderr] 239 | |             } else if args[1].is_float() {
[INFO] [stderr]     | |_____________^
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#if_same_then_else
[INFO] [stderr] 
[INFO] [stderr] error: this `if` has identical blocks
[INFO] [stderr]    --> src/core.rs:259:42
[INFO] [stderr]     |
[INFO] [stderr] 259 |               } else if args[1].is_float() {
[INFO] [stderr]     |  __________________________________________^
[INFO] [stderr] 260 | |                 return MalType::bool(args[0].get_float() >= args[1].get_float());
[INFO] [stderr] 261 | |             }
[INFO] [stderr]     | |_____________^
[INFO] [stderr]     |
[INFO] [stderr] note: same as this
[INFO] [stderr]    --> src/core.rs:257:33
[INFO] [stderr]     |
[INFO] [stderr] 257 |               if args[1].is_int() {
[INFO] [stderr]     |  _________________________________^
[INFO] [stderr] 258 | |                 return MalType::bool(args[0].get_float() >= args[1].get_float());
[INFO] [stderr] 259 | |             } else if args[1].is_float() {
[INFO] [stderr]     | |_____________^
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#if_same_then_else
[INFO] [stderr] 
[INFO] [stderr] error: this loop never actually loops
[INFO] [stderr]    --> src/core.rs:387:5
[INFO] [stderr]     |
[INFO] [stderr] 387 | /     for arg in args {
[INFO] [stderr] 388 | |         return MalType::atom(arg);
[INFO] [stderr] 389 | |     }
[INFO] [stderr]     | |_____^
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[deny(clippy::never_loop)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#never_loop
[INFO] [stderr] 
[INFO] [stderr] error: this loop never actually loops
[INFO] [stderr]    --> src/core.rs:395:5
[INFO] [stderr]     |
[INFO] [stderr] 395 | /     for arg in args {
[INFO] [stderr] 396 | |         return MalType::bool(arg.is_atom());
[INFO] [stderr] 397 | |     }
[INFO] [stderr]     | |_____^
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#never_loop
[INFO] [stderr] 
[INFO] [stderr] error: this loop never actually loops
[INFO] [stderr]    --> src/core.rs:403:5
[INFO] [stderr]     |
[INFO] [stderr] 403 | /     for arg in args {
[INFO] [stderr] 404 | |         return if arg.is_atom() {
[INFO] [stderr] 405 | |             arg.get_atom()
[INFO] [stderr] 406 | |         } else {
[INFO] [stderr] 407 | |             MalType::error("deref argument not an atom".to_string())
[INFO] [stderr] 408 | |         };
[INFO] [stderr] 409 | |     }
[INFO] [stderr]     | |_____^
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#never_loop
[INFO] [stderr] 
[INFO] [stderr] warning: length comparison to one
[INFO] [stderr]    --> src/core.rs:526:8
[INFO] [stderr]     |
[INFO] [stderr] 526 |     if args.len() < 1 {
[INFO] [stderr]     |        ^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `args.is_empty()`
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::len_zero)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero
[INFO] [stderr] 
[INFO] [stderr] warning: length comparison to one
[INFO] [stderr]    --> src/core.rs:544:8
[INFO] [stderr]     |
[INFO] [stderr] 544 |     if args.len() < 1 {
[INFO] [stderr]     |        ^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `args.is_empty()`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero
[INFO] [stderr] 
[INFO] [stderr] warning: you should consider deriving a `Default` implementation for `eval::Environment`
[INFO] [stderr]   --> src/eval.rs:25:5
[INFO] [stderr]    |
[INFO] [stderr] 25 | /     pub fn new() -> Environment {
[INFO] [stderr] 26 | |         Environment {
[INFO] [stderr] 27 | |             map: Rc::new(RefCell::new(HashMap::new())),
[INFO] [stderr] 28 | |             outer: None,
[INFO] [stderr] 29 | |         }
[INFO] [stderr] 30 | |     }
[INFO] [stderr]    | |_____^
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::new_without_default_derive)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default_derive
[INFO] [stderr] help: try this
[INFO] [stderr]    |
[INFO] [stderr] 13 | #[derive(Default)]
[INFO] [stderr]    |
[INFO] [stderr] 
[INFO] [stderr] error: using `clone` on a double-reference; this will copy the reference instead of cloning the inner type
[INFO] [stderr]   --> src/eval.rs:51:25
[INFO] [stderr]    |
[INFO] [stderr] 51 |         match self.find(key.clone()) {
[INFO] [stderr]    |                         ^^^^^^^^^^^
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[deny(clippy::clone_double_ref)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_double_ref
[INFO] [stderr] help: try dereferencing it
[INFO] [stderr]    |
[INFO] [stderr] 51 |         match self.find(&(*key).clone()) {
[INFO] [stderr]    |                         ^^^^^^^^^^^^^^^
[INFO] [stderr] help: or try being explicit about what type to clone
[INFO] [stderr]    |
[INFO] [stderr] 51 |         match self.find(&str::clone(key)) {
[INFO] [stderr]    |                         ^^^^^^^^^^^^^^^^
[INFO] [stderr] 
[INFO] [stderr] warning: equality checks against false can be replaced by a negation
[INFO] [stderr]    --> src/eval.rs:311:67
[INFO] [stderr]     |
[INFO] [stderr] 311 |                     } else if temp.is_nil() || (temp.is_bool() && temp.get_bool() == false) {
[INFO] [stderr]     |                                                                   ^^^^^^^^^^^^^^^^^^^^^^^^ help: try simplifying it as shown: `!temp.get_bool()`
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::bool_comparison)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_comparison
[INFO] [stderr] 
[INFO] [stderr] error: this `if` has identical blocks
[INFO] [stderr]   --> src/printer.rs:42:30
[INFO] [stderr]    |
[INFO] [stderr] 42 |       } else if t.is_keyword() {
[INFO] [stderr]    |  ______________________________^
[INFO] [stderr] 43 | |         t.get_string().to_string()
[INFO] [stderr] 44 | |     } else if t.is_atom() {
[INFO] [stderr]    | |_____^
[INFO] [stderr]    |
[INFO] [stderr] note: same as this
[INFO] [stderr]   --> src/printer.rs:40:29
[INFO] [stderr]    |
[INFO] [stderr] 40 |       } else if t.is_symbol() {
[INFO] [stderr]    |  _____________________________^
[INFO] [stderr] 41 | |         t.get_string().to_string()
[INFO] [stderr] 42 | |     } else if t.is_keyword() {
[INFO] [stderr]    | |_____^
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#if_same_then_else
[INFO] [stderr] 
[INFO] [stderr] warning: using `clone` on a `Copy` type
[INFO] [stderr]    --> src/types.rs:268:63
[INFO] [stderr]     |
[INFO] [stderr] 268 |             MalEnum::Func(ref f, ref is_macro) => (f.clone(), is_macro.clone()),
[INFO] [stderr]     |                                                               ^^^^^^^^^^^^^^^^ help: try dereferencing it: `*is_macro`
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::clone_on_copy)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy
[INFO] [stderr] 
[INFO] [stderr] error: aborting due to 11 previous errors
[INFO] [stderr] 
[INFO] [stderr] error: Could not compile `mal`.
[INFO] [stderr] warning: build failed, waiting for other jobs to finish...
[INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices.
[INFO] [stderr]   --> src/core.rs:62:22
[INFO] [stderr]    |
[INFO] [stderr] 62 | fn all_numeric(args: &BuiltinFuncArgs) -> bool {
[INFO] [stderr]    |                      ^^^^^^^^^^^^^^^^
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::ptr_arg)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg
[INFO] [stderr] 
[INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices.
[INFO] [stderr]   --> src/core.rs:66:18
[INFO] [stderr]    |
[INFO] [stderr] 66 | fn all_int(args: &BuiltinFuncArgs) -> bool {
[INFO] [stderr]    |                  ^^^^^^^^^^^^^^^^
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg
[INFO] [stderr] 
[INFO] [stderr] warning: useless use of `format!`
[INFO] [stderr]   --> src/core.rs:98:21
[INFO] [stderr]    |
[INFO] [stderr] 98 |     MalType::string(format!("{}", prn_helper(args, true, " ")))
[INFO] [stderr]    |                     ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using .to_string(): `prn_helper(args, true, " ").to_string()`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::useless_format)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format
[INFO] [stderr]    = note: this error originates in a macro outside of the current crate (in Nightly builds, run with -Z external-macro-backtrace for more info)
[INFO] [stderr] 
[INFO] [stderr] warning: useless use of `format!`
[INFO] [stderr]    --> src/core.rs:102:21
[INFO] [stderr]     |
[INFO] [stderr] 102 |     MalType::string(format!("{}", prn_helper(args, false, "")))
[INFO] [stderr]     |                     ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using .to_string(): `prn_helper(args, false, "").to_string()`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format
[INFO] [stderr]     = note: this error originates in a macro outside of the current crate (in Nightly builds, run with -Z external-macro-backtrace for more info)
[INFO] [stderr] 
[INFO] [stderr] error: this `if` has identical blocks
[INFO] [stderr]    --> src/core.rs:150:46
[INFO] [stderr]     |
[INFO] [stderr] 150 |       } else if a.is_symbol() && b.is_symbol() {
[INFO] [stderr]     |  ______________________________________________^
[INFO] [stderr] 151 | |         a.get_string() == b.get_string()
[INFO] [stderr] 152 | |     } else if a.is_atom() && b.is_atom() {
[INFO] [stderr]     | |_____^
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[deny(clippy::if_same_then_else)] on by default
[INFO] [stderr] note: same as this
[INFO] [stderr]    --> src/core.rs:148:46
[INFO] [stderr]     |
[INFO] [stderr] 148 |       } else if a.is_string() && b.is_string() {
[INFO] [stderr]     |  ______________________________________________^
[INFO] [stderr] 149 | |         a.get_string() == b.get_string()
[INFO] [stderr] 150 | |     } else if a.is_symbol() && b.is_symbol() {
[INFO] [stderr]     | |_____^
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#if_same_then_else
[INFO] [stderr] 
[INFO] [stderr] error: strict comparison of f32 or f64
[INFO] [stderr]    --> src/core.rs:137:9
[INFO] [stderr]     |
[INFO] [stderr] 137 |         a.get_float() == b.get_float()
[INFO] [stderr]     |         ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider comparing them within some error: `(a.get_float() - b.get_float()).abs() < error`
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[deny(clippy::float_cmp)] on by default
[INFO] [stderr] note: std::f32::EPSILON and std::f64::EPSILON are available.
[INFO] [stderr]    --> src/core.rs:137:9
[INFO] [stderr]     |
[INFO] [stderr] 137 |         a.get_float() == b.get_float()
[INFO] [stderr]     |         ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#float_cmp
[INFO] [stderr] 
[INFO] [stderr] error: this `if` has identical blocks
[INFO] [stderr]    --> src/core.rs:199:42
[INFO] [stderr]     |
[INFO] [stderr] 199 |               } else if args[1].is_float() {
[INFO] [stderr]     |  __________________________________________^
[INFO] [stderr] 200 | |                 return MalType::bool(args[0].get_float() < args[1].get_float());
[INFO] [stderr] 201 | |             }
[INFO] [stderr]     | |_____________^
[INFO] [stderr]     |
[INFO] [stderr] note: same as this
[INFO] [stderr]    --> src/core.rs:197:33
[INFO] [stderr]     |
[INFO] [stderr] 197 |               if args[1].is_int() {
[INFO] [stderr]     |  _________________________________^
[INFO] [stderr] 198 | |                 return MalType::bool(args[0].get_float() < args[1].get_float());
[INFO] [stderr] 199 | |             } else if args[1].is_float() {
[INFO] [stderr]     | |_____________^
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#if_same_then_else
[INFO] [stderr] 
[INFO] [stderr] error: this `if` has identical blocks
[INFO] [stderr]    --> src/core.rs:219:42
[INFO] [stderr]     |
[INFO] [stderr] 219 |               } else if args[1].is_float() {
[INFO] [stderr]     |  __________________________________________^
[INFO] [stderr] 220 | |                 return MalType::bool(args[0].get_float() <= args[1].get_float());
[INFO] [stderr] 221 | |             }
[INFO] [stderr]     | |_____________^
[INFO] [stderr]     |
[INFO] [stderr] note: same as this
[INFO] [stderr]    --> src/core.rs:217:33
[INFO] [stderr]     |
[INFO] [stderr] 217 |               if args[1].is_int() {
[INFO] [stderr]     |  _________________________________^
[INFO] [stderr] 218 | |                 return MalType::bool(args[0].get_float() <= args[1].get_float());
[INFO] [stderr] 219 | |             } else if args[1].is_float() {
[INFO] [stderr]     | |_____________^
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#if_same_then_else
[INFO] [stderr] 
[INFO] [stderr] error: this `if` has identical blocks
[INFO] [stderr]    --> src/core.rs:239:42
[INFO] [stderr]     |
[INFO] [stderr] 239 |               } else if args[1].is_float() {
[INFO] [stderr]     |  __________________________________________^
[INFO] [stderr] 240 | |                 return MalType::bool(args[0].get_float() > args[1].get_float());
[INFO] [stderr] 241 | |             }
[INFO] [stderr]     | |_____________^
[INFO] [stderr]     |
[INFO] [stderr] note: same as this
[INFO] [stderr]    --> src/core.rs:237:33
[INFO] [stderr]     |
[INFO] [stderr] 237 |               if args[1].is_int() {
[INFO] [stderr]     |  _________________________________^
[INFO] [stderr] 238 | |                 return MalType::bool(args[0].get_float() > args[1].get_float());
[INFO] [stderr] 239 | |             } else if args[1].is_float() {
[INFO] [stderr]     | |_____________^
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#if_same_then_else
[INFO] [stderr] 
[INFO] [stderr] error: this `if` has identical blocks
[INFO] [stderr]    --> src/core.rs:259:42
[INFO] [stderr]     |
[INFO] [stderr] 259 |               } else if args[1].is_float() {
[INFO] [stderr]     |  __________________________________________^
[INFO] [stderr] 260 | |                 return MalType::bool(args[0].get_float() >= args[1].get_float());
[INFO] [stderr] 261 | |             }
[INFO] [stderr]     | |_____________^
[INFO] [stderr]     |
[INFO] [stderr] note: same as this
[INFO] [stderr]    --> src/core.rs:257:33
[INFO] [stderr]     |
[INFO] [stderr] 257 |               if args[1].is_int() {
[INFO] [stderr]     |  _________________________________^
[INFO] [stderr] 258 | |                 return MalType::bool(args[0].get_float() >= args[1].get_float());
[INFO] [stderr] 259 | |             } else if args[1].is_float() {
[INFO] [stderr]     | |_____________^
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#if_same_then_else
[INFO] [stderr] 
[INFO] [stderr] error: this loop never actually loops
[INFO] [stderr]    --> src/core.rs:387:5
[INFO] [stderr]     |
[INFO] [stderr] 387 | /     for arg in args {
[INFO] [stderr] 388 | |         return MalType::atom(arg);
[INFO] [stderr] 389 | |     }
[INFO] [stderr]     | |_____^
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[deny(clippy::never_loop)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#never_loop
[INFO] [stderr] 
[INFO] [stderr] error: this loop never actually loops
[INFO] [stderr]    --> src/core.rs:395:5
[INFO] [stderr]     |
[INFO] [stderr] 395 | /     for arg in args {
[INFO] [stderr] 396 | |         return MalType::bool(arg.is_atom());
[INFO] [stderr] 397 | |     }
[INFO] [stderr]     | |_____^
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#never_loop
[INFO] [stderr] 
[INFO] [stderr] error: this loop never actually loops
[INFO] [stderr]    --> src/core.rs:403:5
[INFO] [stderr]     |
[INFO] [stderr] 403 | /     for arg in args {
[INFO] [stderr] 404 | |         return if arg.is_atom() {
[INFO] [stderr] 405 | |             arg.get_atom()
[INFO] [stderr] 406 | |         } else {
[INFO] [stderr] 407 | |             MalType::error("deref argument not an atom".to_string())
[INFO] [stderr] 408 | |         };
[INFO] [stderr] 409 | |     }
[INFO] [stderr]     | |_____^
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#never_loop
[INFO] [stderr] 
[INFO] [stderr] warning: length comparison to one
[INFO] [stderr]    --> src/core.rs:526:8
[INFO] [stderr]     |
[INFO] [stderr] 526 |     if args.len() < 1 {
[INFO] [stderr]     |        ^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `args.is_empty()`
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::len_zero)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero
[INFO] [stderr] 
[INFO] [stderr] warning: length comparison to one
[INFO] [stderr]    --> src/core.rs:544:8
[INFO] [stderr]     |
[INFO] [stderr] 544 |     if args.len() < 1 {
[INFO] [stderr]     |        ^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `args.is_empty()`
[INFO] [stderr]     |
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero
[INFO] [stderr] 
[INFO] [stderr] warning: you should consider deriving a `Default` implementation for `eval::Environment`
[INFO] [stderr]   --> src/eval.rs:25:5
[INFO] [stderr]    |
[INFO] [stderr] 25 | /     pub fn new() -> Environment {
[INFO] [stderr] 26 | |         Environment {
[INFO] [stderr] 27 | |             map: Rc::new(RefCell::new(HashMap::new())),
[INFO] [stderr] 28 | |             outer: None,
[INFO] [stderr] 29 | |         }
[INFO] [stderr] 30 | |     }
[INFO] [stderr]    | |_____^
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::new_without_default_derive)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default_derive
[INFO] [stderr] help: try this
[INFO] [stderr]    |
[INFO] [stderr] 13 | #[derive(Default)]
[INFO] [stderr]    |
[INFO] [stderr] 
[INFO] [stderr] error: using `clone` on a double-reference; this will copy the reference instead of cloning the inner type
[INFO] [stderr]   --> src/eval.rs:51:25
[INFO] [stderr]    |
[INFO] [stderr] 51 |         match self.find(key.clone()) {
[INFO] [stderr]    |                         ^^^^^^^^^^^
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[deny(clippy::clone_double_ref)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_double_ref
[INFO] [stderr] help: try dereferencing it
[INFO] [stderr]    |
[INFO] [stderr] 51 |         match self.find(&(*key).clone()) {
[INFO] [stderr]    |                         ^^^^^^^^^^^^^^^
[INFO] [stderr] help: or try being explicit about what type to clone
[INFO] [stderr]    |
[INFO] [stderr] 51 |         match self.find(&str::clone(key)) {
[INFO] [stderr]    |                         ^^^^^^^^^^^^^^^^
[INFO] [stderr] 
[INFO] [stderr] warning: equality checks against false can be replaced by a negation
[INFO] [stderr]    --> src/eval.rs:311:67
[INFO] [stderr]     |
[INFO] [stderr] 311 |                     } else if temp.is_nil() || (temp.is_bool() && temp.get_bool() == false) {
[INFO] [stderr]     |                                                                   ^^^^^^^^^^^^^^^^^^^^^^^^ help: try simplifying it as shown: `!temp.get_bool()`
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::bool_comparison)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#bool_comparison
[INFO] [stderr] 
[INFO] [stderr] error: this `if` has identical blocks
[INFO] [stderr]   --> src/printer.rs:42:30
[INFO] [stderr]    |
[INFO] [stderr] 42 |       } else if t.is_keyword() {
[INFO] [stderr]    |  ______________________________^
[INFO] [stderr] 43 | |         t.get_string().to_string()
[INFO] [stderr] 44 | |     } else if t.is_atom() {
[INFO] [stderr]    | |_____^
[INFO] [stderr]    |
[INFO] [stderr] note: same as this
[INFO] [stderr]   --> src/printer.rs:40:29
[INFO] [stderr]    |
[INFO] [stderr] 40 |       } else if t.is_symbol() {
[INFO] [stderr]    |  _____________________________^
[INFO] [stderr] 41 | |         t.get_string().to_string()
[INFO] [stderr] 42 | |     } else if t.is_keyword() {
[INFO] [stderr]    | |_____^
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#if_same_then_else
[INFO] [stderr] 
[INFO] [stderr] warning: using `clone` on a `Copy` type
[INFO] [stderr]    --> src/types.rs:268:63
[INFO] [stderr]     |
[INFO] [stderr] 268 |             MalEnum::Func(ref f, ref is_macro) => (f.clone(), is_macro.clone()),
[INFO] [stderr]     |                                                               ^^^^^^^^^^^^^^^^ help: try dereferencing it: `*is_macro`
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::clone_on_copy)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_on_copy
[INFO] [stderr] 
[INFO] [stderr] error: aborting due to 11 previous errors
[INFO] [stderr] 
[INFO] [stderr] error: Could not compile `mal`.
[INFO] [stderr] 
[INFO] [stderr] To learn more, run the command again with --verbose.
[INFO] running `"docker" "inspect" "41e428445acc01a159a4b5080496985957751c48dcee4ce899138534728cb7e8"`
[INFO] running `"docker" "rm" "-f" "41e428445acc01a159a4b5080496985957751c48dcee4ce899138534728cb7e8"`
[INFO] [stdout] 41e428445acc01a159a4b5080496985957751c48dcee4ce899138534728cb7e8