[INFO] updating cached repository davedissian/rasteriser [INFO] running `"git" "fetch" "--all"` [INFO] [stdout] Fetching origin [INFO] [stderr] From git://github.com/davedissian/rasteriser [INFO] [stderr] * branch HEAD -> FETCH_HEAD [INFO] running `"git" "clone" "work/cache/sources/gh/davedissian/rasteriser" "work/ex/clippy-test-run/sources/stable/gh/davedissian/rasteriser"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/davedissian/rasteriser'... [INFO] [stderr] done. [INFO] running `"git" "clone" "work/cache/sources/gh/davedissian/rasteriser" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/davedissian/rasteriser"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/davedissian/rasteriser'... [INFO] [stderr] done. [INFO] running `"git" "rev-parse" "HEAD"` [INFO] [stdout] f26c7fc63ecff2210382e0218962cba159f6e483 [INFO] sha for GitHub repo davedissian/rasteriser: f26c7fc63ecff2210382e0218962cba159f6e483 [INFO] validating manifest of davedissian/rasteriser on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of davedissian/rasteriser on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing davedissian/rasteriser [INFO] finished frobbing davedissian/rasteriser [INFO] frobbed toml for davedissian/rasteriser written to work/ex/clippy-test-run/sources/stable/gh/davedissian/rasteriser/Cargo.toml [INFO] started frobbing davedissian/rasteriser [INFO] finished frobbing davedissian/rasteriser [INFO] frobbed toml for davedissian/rasteriser written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/davedissian/rasteriser/Cargo.toml [INFO] crate davedissian/rasteriser has a lockfile. skipping [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting davedissian/rasteriser against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-2/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/gh/davedissian/rasteriser:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] a7999ad29d049a928b1fc4eeec0498c6108d3b9dffb07489e124e76e6e64ff12 [INFO] running `"docker" "start" "-a" "a7999ad29d049a928b1fc4eeec0498c6108d3b9dffb07489e124e76e6e64ff12"` [INFO] [stderr] Compiling glium v0.19.0 [INFO] [stderr] Checking rasteriser v0.1.0 (/opt/crater/workdir) [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/driver/glium.rs:82:13 [INFO] [stderr] | [INFO] [stderr] 82 | width: width, [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `width` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/driver/glium.rs:83:13 [INFO] [stderr] | [INFO] [stderr] 83 | height: height, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `height` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/driver/glium.rs:85:13 [INFO] [stderr] | [INFO] [stderr] 85 | events_loop: events_loop, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `events_loop` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/driver/glium.rs:82:13 [INFO] [stderr] | [INFO] [stderr] 82 | width: width, [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `width` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/driver/glium.rs:83:13 [INFO] [stderr] | [INFO] [stderr] 83 | height: height, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `height` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/driver/glium.rs:85:13 [INFO] [stderr] | [INFO] [stderr] 85 | events_loop: events_loop, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `events_loop` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/driver/glium.rs:144:9 [INFO] [stderr] | [INFO] [stderr] 144 | return running; [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: remove `return` as shown: `running` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_return)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/driver/mod.rs:16:23 [INFO] [stderr] | [INFO] [stderr] 16 | ((h & 0xFF0000) >> 16) as u8, [INFO] [stderr] | ^^^^^^^^ help: consider: `0x00FF_0000` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::unreadable_literal)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/driver/mod.rs:17:23 [INFO] [stderr] | [INFO] [stderr] 17 | ((h & 0x00FF00) >> 8) as u8, [INFO] [stderr] | ^^^^^^^^ help: consider: `0x0000_FF00` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/driver/mod.rs:18:22 [INFO] [stderr] | [INFO] [stderr] 18 | (h & 0x0000FF) as u8 [INFO] [stderr] | ^^^^^^^^ help: consider: `0x0000_00FF` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: function is never used: `clear_pixels` [INFO] [stderr] --> src/driver/glium.rs:55:1 [INFO] [stderr] | [INFO] [stderr] 55 | fn clear_pixels(width: usize, height: usize, colour: (u8, u8, u8)) -> Vec { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(dead_code)] on by default [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/driver/glium.rs:131:13 [INFO] [stderr] | [INFO] [stderr] 131 | / match event { [INFO] [stderr] 132 | | glutin::Event::WindowEvent{event, ..} => match event { [INFO] [stderr] 133 | | glutin::WindowEvent::Closed => running = false, [INFO] [stderr] 134 | | glutin::WindowEvent::KeyboardInput{input, ..} => { [INFO] [stderr] ... | [INFO] [stderr] 141 | | _ => () [INFO] [stderr] 142 | | } [INFO] [stderr] | |_____________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::single_match)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 131 | if let glutin::Event::WindowEvent{event, ..} = event { match event { [INFO] [stderr] 132 | glutin::WindowEvent::Closed => running = false, [INFO] [stderr] 133 | glutin::WindowEvent::KeyboardInput{input, ..} => { [INFO] [stderr] 134 | if let Some(keycode) = input.virtual_keycode { [INFO] [stderr] 135 | key_callback(keycode, input.state); [INFO] [stderr] 136 | } [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/driver/glium.rs:144:9 [INFO] [stderr] | [INFO] [stderr] 144 | return running; [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: remove `return` as shown: `running` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_return)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/driver/mod.rs:16:23 [INFO] [stderr] | [INFO] [stderr] 16 | ((h & 0xFF0000) >> 16) as u8, [INFO] [stderr] | ^^^^^^^^ help: consider: `0x00FF_0000` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::unreadable_literal)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/driver/mod.rs:17:23 [INFO] [stderr] | [INFO] [stderr] 17 | ((h & 0x00FF00) >> 8) as u8, [INFO] [stderr] | ^^^^^^^^ help: consider: `0x0000_FF00` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/driver/mod.rs:18:22 [INFO] [stderr] | [INFO] [stderr] 18 | (h & 0x0000FF) as u8 [INFO] [stderr] | ^^^^^^^^ help: consider: `0x0000_00FF` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: function is never used: `clear_pixels` [INFO] [stderr] --> src/driver/glium.rs:55:1 [INFO] [stderr] | [INFO] [stderr] 55 | fn clear_pixels(width: usize, height: usize, colour: (u8, u8, u8)) -> Vec { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(dead_code)] on by default [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/driver/glium.rs:131:13 [INFO] [stderr] | [INFO] [stderr] 131 | / match event { [INFO] [stderr] 132 | | glutin::Event::WindowEvent{event, ..} => match event { [INFO] [stderr] 133 | | glutin::WindowEvent::Closed => running = false, [INFO] [stderr] 134 | | glutin::WindowEvent::KeyboardInput{input, ..} => { [INFO] [stderr] ... | [INFO] [stderr] 141 | | _ => () [INFO] [stderr] 142 | | } [INFO] [stderr] | |_____________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::single_match)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 131 | if let glutin::Event::WindowEvent{event, ..} = event { match event { [INFO] [stderr] 132 | glutin::WindowEvent::Closed => running = false, [INFO] [stderr] 133 | glutin::WindowEvent::KeyboardInput{input, ..} => { [INFO] [stderr] 134 | if let Some(keycode) = input.virtual_keycode { [INFO] [stderr] 135 | key_callback(keycode, input.state); [INFO] [stderr] 136 | } [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 36.22s [INFO] running `"docker" "inspect" "a7999ad29d049a928b1fc4eeec0498c6108d3b9dffb07489e124e76e6e64ff12"` [INFO] running `"docker" "rm" "-f" "a7999ad29d049a928b1fc4eeec0498c6108d3b9dffb07489e124e76e6e64ff12"` [INFO] [stdout] a7999ad29d049a928b1fc4eeec0498c6108d3b9dffb07489e124e76e6e64ff12