[INFO] updating cached repository davebenvenuti/marionette [INFO] running `"git" "fetch" "--all"` [INFO] [stdout] Fetching origin [INFO] [stderr] From git://github.com/davebenvenuti/marionette [INFO] [stderr] * branch HEAD -> FETCH_HEAD [INFO] running `"git" "clone" "work/cache/sources/gh/davebenvenuti/marionette" "work/ex/clippy-test-run/sources/stable/gh/davebenvenuti/marionette"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/davebenvenuti/marionette'... [INFO] [stderr] done. [INFO] running `"git" "clone" "work/cache/sources/gh/davebenvenuti/marionette" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/davebenvenuti/marionette"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/davebenvenuti/marionette'... [INFO] [stderr] done. [INFO] running `"git" "rev-parse" "HEAD"` [INFO] [stdout] 5a0a043be34a657b9bbc8621f7ecadce79b50f4a [INFO] sha for GitHub repo davebenvenuti/marionette: 5a0a043be34a657b9bbc8621f7ecadce79b50f4a [INFO] validating manifest of davebenvenuti/marionette on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of davebenvenuti/marionette on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing davebenvenuti/marionette [INFO] finished frobbing davebenvenuti/marionette [INFO] frobbed toml for davebenvenuti/marionette written to work/ex/clippy-test-run/sources/stable/gh/davebenvenuti/marionette/Cargo.toml [INFO] started frobbing davebenvenuti/marionette [INFO] finished frobbing davebenvenuti/marionette [INFO] frobbed toml for davebenvenuti/marionette written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/davebenvenuti/marionette/Cargo.toml [INFO] crate davebenvenuti/marionette has a lockfile. skipping [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting davebenvenuti/marionette against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-6/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/gh/davebenvenuti/marionette:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 2184164b5fe42c599342bb798a23eb8bda62920ee401bf24dcbea97b66ca07da [INFO] running `"docker" "start" "-a" "2184164b5fe42c599342bb798a23eb8bda62920ee401bf24dcbea97b66ca07da"` [INFO] [stderr] Compiling openssl-sys v0.9.23 [INFO] [stderr] Checking clap v2.29.0 [INFO] [stderr] Checking libz-sys v1.0.18 [INFO] [stderr] Compiling libssh2-sys v0.2.6 [INFO] [stderr] Checking ssh2 v0.3.2 [INFO] [stderr] Checking marionette v0.1.0 (/opt/crater/workdir) [INFO] [stderr] warning: unused imports: `Agent`, `Identities`, `PublicKey` [INFO] [stderr] --> src/main.rs:8:21 [INFO] [stderr] | [INFO] [stderr] 8 | use ssh2::{Session, Identities, Agent, PublicKey}; [INFO] [stderr] | ^^^^^^^^^^ ^^^^^ ^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_imports)] on by default [INFO] [stderr] [INFO] [stderr] warning: unused import: `errors` [INFO] [stderr] --> src/types.rs:3:5 [INFO] [stderr] | [INFO] [stderr] 3 | use errors; [INFO] [stderr] | ^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: unused imports: `Agent`, `Session` [INFO] [stderr] --> src/types.rs:6:12 [INFO] [stderr] | [INFO] [stderr] 6 | use ssh2::{Session, Agent}; [INFO] [stderr] | ^^^^^^^ ^^^^^ [INFO] [stderr] [INFO] [stderr] warning: single-character string constant used as pattern [INFO] [stderr] --> src/types.rs:20:62 [INFO] [stderr] | [INFO] [stderr] 20 | let host_string_parts: Vec<&str> = host_string.split(":").collect::>(); [INFO] [stderr] | ^^^ help: try using a char instead: `':'` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::single_char_pattern)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern [INFO] [stderr] [INFO] [stderr] warning: taken reference of right operand [INFO] [stderr] --> src/main.rs:18:23 [INFO] [stderr] | [INFO] [stderr] 18 | let host_string = server.host.to_string() + &":" + &server.port.to_string(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^---- [INFO] [stderr] | | [INFO] [stderr] | help: use the right value directly: `":"` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::op_ref)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#op_ref [INFO] [stderr] [INFO] [stderr] warning: unused `std::result::Result` that must be used [INFO] [stderr] --> src/main.rs:31:9 [INFO] [stderr] | [INFO] [stderr] 31 | agent.userauth(username, &identity.unwrap()); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_must_use)] on by default [INFO] [stderr] = note: this `Result` may be an `Err` variant, which should be handled [INFO] [stderr] [INFO] [stderr] warning: single-character string constant used as pattern [INFO] [stderr] --> src/main.rs:93:37 [INFO] [stderr] | [INFO] [stderr] 93 | let servers = host_string.split(",").map(create_server); [INFO] [stderr] | ^^^ help: try using a char instead: `','` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern [INFO] [stderr] [INFO] [stderr] warning: unused `std::result::Result` that must be used [INFO] [stderr] --> src/main.rs:114:21 [INFO] [stderr] | [INFO] [stderr] 114 | channel.wait_close(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: this `Result` may be an `Err` variant, which should be handled [INFO] [stderr] [INFO] [stderr] warning: unused `std::result::Result` that must be used [INFO] [stderr] --> src/main.rs:126:9 [INFO] [stderr] | [INFO] [stderr] 126 | thread.join(); [INFO] [stderr] | ^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: this `Result` may be an `Err` variant, which should be handled [INFO] [stderr] [INFO] [stderr] warning: unused imports: `Agent`, `Identities`, `PublicKey` [INFO] [stderr] --> src/main.rs:8:21 [INFO] [stderr] | [INFO] [stderr] 8 | use ssh2::{Session, Identities, Agent, PublicKey}; [INFO] [stderr] | ^^^^^^^^^^ ^^^^^ ^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_imports)] on by default [INFO] [stderr] [INFO] [stderr] warning: unused import: `errors` [INFO] [stderr] --> src/types.rs:3:5 [INFO] [stderr] | [INFO] [stderr] 3 | use errors; [INFO] [stderr] | ^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: unused imports: `Agent`, `Session` [INFO] [stderr] --> src/types.rs:6:12 [INFO] [stderr] | [INFO] [stderr] 6 | use ssh2::{Session, Agent}; [INFO] [stderr] | ^^^^^^^ ^^^^^ [INFO] [stderr] [INFO] [stderr] warning: single-character string constant used as pattern [INFO] [stderr] --> src/types.rs:20:62 [INFO] [stderr] | [INFO] [stderr] 20 | let host_string_parts: Vec<&str> = host_string.split(":").collect::>(); [INFO] [stderr] | ^^^ help: try using a char instead: `':'` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::single_char_pattern)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern [INFO] [stderr] [INFO] [stderr] warning: taken reference of right operand [INFO] [stderr] --> src/main.rs:18:23 [INFO] [stderr] | [INFO] [stderr] 18 | let host_string = server.host.to_string() + &":" + &server.port.to_string(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^---- [INFO] [stderr] | | [INFO] [stderr] | help: use the right value directly: `":"` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::op_ref)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#op_ref [INFO] [stderr] [INFO] [stderr] warning: unused `std::result::Result` that must be used [INFO] [stderr] --> src/main.rs:31:9 [INFO] [stderr] | [INFO] [stderr] 31 | agent.userauth(username, &identity.unwrap()); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_must_use)] on by default [INFO] [stderr] = note: this `Result` may be an `Err` variant, which should be handled [INFO] [stderr] [INFO] [stderr] warning: single-character string constant used as pattern [INFO] [stderr] --> src/main.rs:93:37 [INFO] [stderr] | [INFO] [stderr] 93 | let servers = host_string.split(",").map(create_server); [INFO] [stderr] | ^^^ help: try using a char instead: `','` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern [INFO] [stderr] [INFO] [stderr] warning: unused `std::result::Result` that must be used [INFO] [stderr] --> src/main.rs:114:21 [INFO] [stderr] | [INFO] [stderr] 114 | channel.wait_close(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: this `Result` may be an `Err` variant, which should be handled [INFO] [stderr] [INFO] [stderr] warning: unused `std::result::Result` that must be used [INFO] [stderr] --> src/main.rs:126:9 [INFO] [stderr] | [INFO] [stderr] 126 | thread.join(); [INFO] [stderr] | ^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: this `Result` may be an `Err` variant, which should be handled [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 22.01s [INFO] running `"docker" "inspect" "2184164b5fe42c599342bb798a23eb8bda62920ee401bf24dcbea97b66ca07da"` [INFO] running `"docker" "rm" "-f" "2184164b5fe42c599342bb798a23eb8bda62920ee401bf24dcbea97b66ca07da"` [INFO] [stdout] 2184164b5fe42c599342bb798a23eb8bda62920ee401bf24dcbea97b66ca07da