[INFO] updating cached repository daveallie/rustyboy
[INFO] running `"git" "fetch" "--all"`
[INFO] [stdout] Fetching origin
[INFO] [stderr] From git://github.com/daveallie/rustyboy
[INFO] [stderr]  * branch            HEAD       -> FETCH_HEAD
[INFO] running `"git" "clone" "work/cache/sources/gh/daveallie/rustyboy" "work/ex/clippy-test-run/sources/stable/gh/daveallie/rustyboy"`
[INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/daveallie/rustyboy'...
[INFO] [stderr] done.
[INFO] running `"git" "clone" "work/cache/sources/gh/daveallie/rustyboy" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/daveallie/rustyboy"`
[INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/daveallie/rustyboy'...
[INFO] [stderr] done.
[INFO] running `"git" "rev-parse" "HEAD"`
[INFO] [stdout] 3380f86679ea56243e1840423197dd48778cb961
[INFO] sha for GitHub repo daveallie/rustyboy: 3380f86679ea56243e1840423197dd48778cb961
[INFO] validating manifest of daveallie/rustyboy on toolchain stable
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"`
[INFO] validating manifest of daveallie/rustyboy on toolchain stable+rustflags=-Dclippy::into_iter_on_array
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"`
[INFO] started frobbing daveallie/rustyboy
[INFO] finished frobbing daveallie/rustyboy
[INFO] frobbed toml for daveallie/rustyboy written to work/ex/clippy-test-run/sources/stable/gh/daveallie/rustyboy/Cargo.toml
[INFO] started frobbing daveallie/rustyboy
[INFO] finished frobbing daveallie/rustyboy
[INFO] frobbed toml for daveallie/rustyboy written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/daveallie/rustyboy/Cargo.toml
[INFO] crate daveallie/rustyboy has a lockfile. skipping
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"`
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"`
[INFO] linting daveallie/rustyboy against stable for clippy-test-run
[INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-1/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/gh/daveallie/rustyboy:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"`
[INFO] [stdout] b69031f6e2b48cb0e7ccc029a03c50b1f48563626027ac7aafb7cce498e554b3
[INFO] running `"docker" "start" "-a" "b69031f6e2b48cb0e7ccc029a03c50b1f48563626027ac7aafb7cce498e554b3"`
[INFO] [stderr]    Compiling x11-dl v2.18.3
[INFO] [stderr]     Checking shared_library v0.1.8
[INFO] [stderr]    Compiling wayland-scanner v0.20.12
[INFO] [stderr]     Checking nix v0.11.0
[INFO] [stderr]     Checking dlib v0.4.0
[INFO] [stderr]     Checking parking_lot_core v0.3.0
[INFO] [stderr]    Compiling glutin v0.17.0
[INFO] [stderr]    Compiling glium v0.22.0
[INFO] [stderr]     Checking backtrace v0.3.5
[INFO] [stderr]     Checking osmesa-sys v0.1.2
[INFO] [stderr]     Checking wayland-sys v0.20.12
[INFO] [stderr]     Checking parking_lot v0.6.4
[INFO] [stderr]     Checking wayland-commons v0.20.12
[INFO] [stderr]    Compiling wayland-client v0.20.12
[INFO] [stderr]    Compiling wayland-protocols v0.20.12
[INFO] [stderr]     Checking smithay-client-toolkit v0.2.6
[INFO] [stderr]     Checking winit v0.16.2
[INFO] [stderr]     Checking rustyboy v0.1.0 (/opt/crater/workdir)
[INFO] [stderr] warning: returning the result of a let binding from a block. Consider returning the expression directly.
[INFO] [stderr]    --> src/cpu/mod.rs:173:9
[INFO] [stderr]     |
[INFO] [stderr] 173 |         signed_byte
[INFO] [stderr]     |         ^^^^^^^^^^^
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::let_and_return)] on by default
[INFO] [stderr] note: this expression can be directly returned
[INFO] [stderr]    --> src/cpu/mod.rs:172:27
[INFO] [stderr]     |
[INFO] [stderr] 172 |         let signed_byte = self.get_byte() as i8;
[INFO] [stderr]     |                           ^^^^^^^^^^^^^^^^^^^^^
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_and_return
[INFO] [stderr] 
[INFO] [stderr] warning: returning the result of a let binding from a block. Consider returning the expression directly.
[INFO] [stderr]    --> src/register/alu.rs:137:9
[INFO] [stderr]     |
[INFO] [stderr] 137 |         casted_result
[INFO] [stderr]     |         ^^^^^^^^^^^^^
[INFO] [stderr]     |
[INFO] [stderr] note: this expression can be directly returned
[INFO] [stderr]    --> src/register/alu.rs:136:29
[INFO] [stderr]     |
[INFO] [stderr] 136 |         let casted_result = result as u16;
[INFO] [stderr]     |                             ^^^^^^^^^^^^^
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_and_return
[INFO] [stderr] 
[INFO] [stderr] warning: returning the result of a let binding from a block. Consider returning the expression directly.
[INFO] [stderr]    --> src/cpu/mod.rs:173:9
[INFO] [stderr]     |
[INFO] [stderr] 173 |         signed_byte
[INFO] [stderr]     |         ^^^^^^^^^^^
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::let_and_return)] on by default
[INFO] [stderr] note: this expression can be directly returned
[INFO] [stderr]    --> src/cpu/mod.rs:172:27
[INFO] [stderr]     |
[INFO] [stderr] 172 |         let signed_byte = self.get_byte() as i8;
[INFO] [stderr]     |                           ^^^^^^^^^^^^^^^^^^^^^
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_and_return
[INFO] [stderr] 
[INFO] [stderr] warning: returning the result of a let binding from a block. Consider returning the expression directly.
[INFO] [stderr]    --> src/register/alu.rs:137:9
[INFO] [stderr]     |
[INFO] [stderr] 137 |         casted_result
[INFO] [stderr]     |         ^^^^^^^^^^^^^
[INFO] [stderr]     |
[INFO] [stderr] note: this expression can be directly returned
[INFO] [stderr]    --> src/register/alu.rs:136:29
[INFO] [stderr]     |
[INFO] [stderr] 136 |         let casted_result = result as u16;
[INFO] [stderr]     |                             ^^^^^^^^^^^^^
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_and_return
[INFO] [stderr] 
[INFO] [stderr] warning: the loop variable `flag_number` is used to index `interrupt_jump_addresses`
[INFO] [stderr]    --> src/cpu/mod.rs:150:28
[INFO] [stderr]     |
[INFO] [stderr] 150 |         for flag_number in 0..4 {
[INFO] [stderr]     |                            ^^^^
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::needless_range_loop)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop
[INFO] [stderr] help: consider using an iterator
[INFO] [stderr]     |
[INFO] [stderr] 150 |         for (flag_number, <item>) in interrupt_jump_addresses.iter().enumerate().take(4) {
[INFO] [stderr]     |             ^^^^^^^^^^^^^^^^^^^^^    ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stderr] 
[INFO] [stderr] warning: the loop variable `flag_number` is used to index `interrupt_jump_addresses`
[INFO] [stderr]    --> src/cpu/mod.rs:150:28
[INFO] [stderr]     |
[INFO] [stderr] 150 |         for flag_number in 0..4 {
[INFO] [stderr]     |                            ^^^^
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::needless_range_loop)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop
[INFO] [stderr] help: consider using an iterator
[INFO] [stderr]     |
[INFO] [stderr] 150 |         for (flag_number, <item>) in interrupt_jump_addresses.iter().enumerate().take(4) {
[INFO] [stderr]     |             ^^^^^^^^^^^^^^^^^^^^^    ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
[INFO] [stderr] 
[INFO] [stderr]     Finished dev [unoptimized + debuginfo] target(s) in 1m 04s
[INFO] running `"docker" "inspect" "b69031f6e2b48cb0e7ccc029a03c50b1f48563626027ac7aafb7cce498e554b3"`
[INFO] running `"docker" "rm" "-f" "b69031f6e2b48cb0e7ccc029a03c50b1f48563626027ac7aafb7cce498e554b3"`
[INFO] [stdout] b69031f6e2b48cb0e7ccc029a03c50b1f48563626027ac7aafb7cce498e554b3