[INFO] updating cached repository daveallie/privnoters [INFO] running `"git" "fetch" "--all"` [INFO] [stdout] Fetching origin [INFO] [stderr] From git://github.com/daveallie/privnoters [INFO] [stderr] * branch HEAD -> FETCH_HEAD [INFO] running `"git" "clone" "work/cache/sources/gh/daveallie/privnoters" "work/ex/clippy-test-run/sources/stable/gh/daveallie/privnoters"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/daveallie/privnoters'... [INFO] [stderr] done. [INFO] running `"git" "clone" "work/cache/sources/gh/daveallie/privnoters" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/daveallie/privnoters"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/daveallie/privnoters'... [INFO] [stderr] done. [INFO] running `"git" "rev-parse" "HEAD"` [INFO] [stdout] f9d6756b58058ec7a4c64fb58ab1527fc28b0fbd [INFO] sha for GitHub repo daveallie/privnoters: f9d6756b58058ec7a4c64fb58ab1527fc28b0fbd [INFO] validating manifest of daveallie/privnoters on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of daveallie/privnoters on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing daveallie/privnoters [INFO] finished frobbing daveallie/privnoters [INFO] frobbed toml for daveallie/privnoters written to work/ex/clippy-test-run/sources/stable/gh/daveallie/privnoters/Cargo.toml [INFO] started frobbing daveallie/privnoters [INFO] finished frobbing daveallie/privnoters [INFO] frobbed toml for daveallie/privnoters written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/daveallie/privnoters/Cargo.toml [INFO] crate daveallie/privnoters has a lockfile. skipping [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting daveallie/privnoters against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-5/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/gh/daveallie/privnoters:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 9f4bcb848be7add7d32867a2f2da3638eb5659d973760d52a02f5c601995fffe [INFO] running `"docker" "start" "-a" "9f4bcb848be7add7d32867a2f2da3638eb5659d973760d52a02f5c601995fffe"` [INFO] [stderr] Checking rust-crypto v0.2.36 [INFO] [stderr] Checking hyper v0.11.26 [INFO] [stderr] Checking hyper-tls v0.1.3 [INFO] [stderr] Checking privnoters v0.1.0 (/opt/crater/workdir) [INFO] [stderr] warning: lint name `clippy` is deprecated and may not have an effect in the future. Also `cfg_attr(cargo-clippy)` won't be necessary anymore [INFO] [stderr] --> src/main.rs:1:42 [INFO] [stderr] | [INFO] [stderr] 1 | #![cfg_attr(feature="cargo-clippy", deny(clippy, clippy_restriction, clippy_pedantic, clippy_style, [INFO] [stderr] | ^^^^^^ help: change it to: `clippy::all` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(renamed_and_removed_lints)] on by default [INFO] [stderr] [INFO] [stderr] warning: lint name `clippy_restriction` is deprecated and may not have an effect in the future. Also `cfg_attr(cargo-clippy)` won't be necessary anymore [INFO] [stderr] --> src/main.rs:1:50 [INFO] [stderr] | [INFO] [stderr] 1 | #![cfg_attr(feature="cargo-clippy", deny(clippy, clippy_restriction, clippy_pedantic, clippy_style, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: change it to: `clippy::restriction` [INFO] [stderr] [INFO] [stderr] warning: lint name `clippy_pedantic` is deprecated and may not have an effect in the future. Also `cfg_attr(cargo-clippy)` won't be necessary anymore [INFO] [stderr] --> src/main.rs:1:70 [INFO] [stderr] | [INFO] [stderr] 1 | #![cfg_attr(feature="cargo-clippy", deny(clippy, clippy_restriction, clippy_pedantic, clippy_style, [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: change it to: `clippy::pedantic` [INFO] [stderr] [INFO] [stderr] warning: lint name `clippy_style` is deprecated and may not have an effect in the future. Also `cfg_attr(cargo-clippy)` won't be necessary anymore [INFO] [stderr] --> src/main.rs:1:87 [INFO] [stderr] | [INFO] [stderr] 1 | #![cfg_attr(feature="cargo-clippy", deny(clippy, clippy_restriction, clippy_pedantic, clippy_style, [INFO] [stderr] | ^^^^^^^^^^^^ help: change it to: `clippy::style` [INFO] [stderr] [INFO] [stderr] warning: lint name `clippy_complexity` is deprecated and may not have an effect in the future. Also `cfg_attr(cargo-clippy)` won't be necessary anymore [INFO] [stderr] --> src/main.rs:2:42 [INFO] [stderr] | [INFO] [stderr] 2 | clippy_complexity, clippy_correctness, clippy_perf, clippy_nursery))] [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: change it to: `clippy::complexity` [INFO] [stderr] [INFO] [stderr] warning: lint name `clippy_correctness` is deprecated and may not have an effect in the future. Also `cfg_attr(cargo-clippy)` won't be necessary anymore [INFO] [stderr] --> src/main.rs:2:61 [INFO] [stderr] | [INFO] [stderr] 2 | clippy_complexity, clippy_correctness, clippy_perf, clippy_nursery))] [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: change it to: `clippy::correctness` [INFO] [stderr] [INFO] [stderr] warning: lint name `clippy_perf` is deprecated and may not have an effect in the future. Also `cfg_attr(cargo-clippy)` won't be necessary anymore [INFO] [stderr] --> src/main.rs:2:81 [INFO] [stderr] | [INFO] [stderr] 2 | clippy_complexity, clippy_correctness, clippy_perf, clippy_nursery))] [INFO] [stderr] | ^^^^^^^^^^^ help: change it to: `clippy::perf` [INFO] [stderr] [INFO] [stderr] warning: lint name `clippy_nursery` is deprecated and may not have an effect in the future. Also `cfg_attr(cargo-clippy)` won't be necessary anymore [INFO] [stderr] --> src/main.rs:2:94 [INFO] [stderr] | [INFO] [stderr] 2 | clippy_complexity, clippy_correctness, clippy_perf, clippy_nursery))] [INFO] [stderr] | ^^^^^^^^^^^^^^ help: change it to: `clippy::nursery` [INFO] [stderr] [INFO] [stderr] warning: lint name `missing_docs_in_private_items` is deprecated and may not have an effect in the future. Also `cfg_attr(cargo-clippy)` won't be necessary anymore [INFO] [stderr] --> src/main.rs:3:43 [INFO] [stderr] | [INFO] [stderr] 3 | #![cfg_attr(feature="cargo-clippy", allow(missing_docs_in_private_items, print_stdout))] [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: change it to: `clippy::missing_docs_in_private_items` [INFO] [stderr] [INFO] [stderr] warning: lint name `print_stdout` is deprecated and may not have an effect in the future. Also `cfg_attr(cargo-clippy)` won't be necessary anymore [INFO] [stderr] --> src/main.rs:3:74 [INFO] [stderr] | [INFO] [stderr] 3 | #![cfg_attr(feature="cargo-clippy", allow(missing_docs_in_private_items, print_stdout))] [INFO] [stderr] | ^^^^^^^^^^^^ help: change it to: `clippy::print_stdout` [INFO] [stderr] [INFO] [stderr] warning: lint name `clippy` is deprecated and may not have an effect in the future. Also `cfg_attr(cargo-clippy)` won't be necessary anymore [INFO] [stderr] --> src/main.rs:1:42 [INFO] [stderr] | [INFO] [stderr] 1 | #![cfg_attr(feature="cargo-clippy", deny(clippy, clippy_restriction, clippy_pedantic, clippy_style, [INFO] [stderr] | ^^^^^^ help: change it to: `clippy::all` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(renamed_and_removed_lints)] on by default [INFO] [stderr] [INFO] [stderr] warning: lint name `clippy_restriction` is deprecated and may not have an effect in the future. Also `cfg_attr(cargo-clippy)` won't be necessary anymore [INFO] [stderr] --> src/main.rs:1:50 [INFO] [stderr] | [INFO] [stderr] 1 | #![cfg_attr(feature="cargo-clippy", deny(clippy, clippy_restriction, clippy_pedantic, clippy_style, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: change it to: `clippy::restriction` [INFO] [stderr] [INFO] [stderr] warning: lint name `clippy_pedantic` is deprecated and may not have an effect in the future. Also `cfg_attr(cargo-clippy)` won't be necessary anymore [INFO] [stderr] --> src/main.rs:1:70 [INFO] [stderr] | [INFO] [stderr] 1 | #![cfg_attr(feature="cargo-clippy", deny(clippy, clippy_restriction, clippy_pedantic, clippy_style, [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: change it to: `clippy::pedantic` [INFO] [stderr] [INFO] [stderr] warning: lint name `clippy_style` is deprecated and may not have an effect in the future. Also `cfg_attr(cargo-clippy)` won't be necessary anymore [INFO] [stderr] --> src/main.rs:1:87 [INFO] [stderr] | [INFO] [stderr] 1 | #![cfg_attr(feature="cargo-clippy", deny(clippy, clippy_restriction, clippy_pedantic, clippy_style, [INFO] [stderr] | ^^^^^^^^^^^^ help: change it to: `clippy::style` [INFO] [stderr] [INFO] [stderr] warning: lint name `clippy_complexity` is deprecated and may not have an effect in the future. Also `cfg_attr(cargo-clippy)` won't be necessary anymore [INFO] [stderr] --> src/main.rs:2:42 [INFO] [stderr] | [INFO] [stderr] 2 | clippy_complexity, clippy_correctness, clippy_perf, clippy_nursery))] [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: change it to: `clippy::complexity` [INFO] [stderr] [INFO] [stderr] warning: lint name `clippy_correctness` is deprecated and may not have an effect in the future. Also `cfg_attr(cargo-clippy)` won't be necessary anymore [INFO] [stderr] --> src/main.rs:2:61 [INFO] [stderr] | [INFO] [stderr] 2 | clippy_complexity, clippy_correctness, clippy_perf, clippy_nursery))] [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: change it to: `clippy::correctness` [INFO] [stderr] [INFO] [stderr] warning: lint name `clippy_perf` is deprecated and may not have an effect in the future. Also `cfg_attr(cargo-clippy)` won't be necessary anymore [INFO] [stderr] --> src/main.rs:2:81 [INFO] [stderr] | [INFO] [stderr] 2 | clippy_complexity, clippy_correctness, clippy_perf, clippy_nursery))] [INFO] [stderr] | ^^^^^^^^^^^ help: change it to: `clippy::perf` [INFO] [stderr] [INFO] [stderr] warning: lint name `clippy_nursery` is deprecated and may not have an effect in the future. Also `cfg_attr(cargo-clippy)` won't be necessary anymore [INFO] [stderr] --> src/main.rs:2:94 [INFO] [stderr] | [INFO] [stderr] 2 | clippy_complexity, clippy_correctness, clippy_perf, clippy_nursery))] [INFO] [stderr] | ^^^^^^^^^^^^^^ help: change it to: `clippy::nursery` [INFO] [stderr] [INFO] [stderr] warning: lint name `missing_docs_in_private_items` is deprecated and may not have an effect in the future. Also `cfg_attr(cargo-clippy)` won't be necessary anymore [INFO] [stderr] --> src/main.rs:3:43 [INFO] [stderr] | [INFO] [stderr] 3 | #![cfg_attr(feature="cargo-clippy", allow(missing_docs_in_private_items, print_stdout))] [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: change it to: `clippy::missing_docs_in_private_items` [INFO] [stderr] [INFO] [stderr] warning: lint name `print_stdout` is deprecated and may not have an effect in the future. Also `cfg_attr(cargo-clippy)` won't be necessary anymore [INFO] [stderr] --> src/main.rs:3:74 [INFO] [stderr] | [INFO] [stderr] 3 | #![cfg_attr(feature="cargo-clippy", allow(missing_docs_in_private_items, print_stdout))] [INFO] [stderr] | ^^^^^^^^^^^^ help: change it to: `clippy::print_stdout` [INFO] [stderr] [INFO] [stderr] warning: lint name `clippy` is deprecated and may not have an effect in the future. Also `cfg_attr(cargo-clippy)` won't be necessary anymore [INFO] [stderr] --> src/main.rs:1:42 [INFO] [stderr] | [INFO] [stderr] 1 | #![cfg_attr(feature="cargo-clippy", deny(clippy, clippy_restriction, clippy_pedantic, clippy_style, [INFO] [stderr] | ^^^^^^ help: change it to: `clippy::all` [INFO] [stderr] [INFO] [stderr] warning: lint name `clippy` is deprecated and may not have an effect in the future. Also `cfg_attr(cargo-clippy)` won't be necessary anymore [INFO] [stderr] --> src/main.rs:1:42 [INFO] [stderr] | [INFO] [stderr] 1 | #![cfg_attr(feature="cargo-clippy", deny(clippy, clippy_restriction, clippy_pedantic, clippy_style, [INFO] [stderr] | ^^^^^^ help: change it to: `clippy::all` [INFO] [stderr] [INFO] [stderr] error: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/encryption.rs:54:45 [INFO] [stderr] | [INFO] [stderr] 54 | fn key_from_password(password: &[u8], salt: &[u8; 8]) -> Key { [INFO] [stderr] | ^^^^^^^^ help: consider passing by value instead: `[u8; 8]` [INFO] [stderr] | [INFO] [stderr] note: lint level defined here [INFO] [stderr] --> src/main.rs:2:81 [INFO] [stderr] | [INFO] [stderr] 2 | clippy_complexity, clippy_correctness, clippy_perf, clippy_nursery))] [INFO] [stderr] | ^^^^^^^^^^^ [INFO] [stderr] = note: #[deny(clippy::trivially_copy_pass_by_ref)] implied by #[deny(clippy::perf)] [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] error: aborting due to previous error [INFO] [stderr] [INFO] [stderr] error: Could not compile `privnoters`. [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stderr] error: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/encryption.rs:54:45 [INFO] [stderr] | [INFO] [stderr] 54 | fn key_from_password(password: &[u8], salt: &[u8; 8]) -> Key { [INFO] [stderr] | ^^^^^^^^ help: consider passing by value instead: `[u8; 8]` [INFO] [stderr] | [INFO] [stderr] note: lint level defined here [INFO] [stderr] --> src/main.rs:2:81 [INFO] [stderr] | [INFO] [stderr] 2 | clippy_complexity, clippy_correctness, clippy_perf, clippy_nursery))] [INFO] [stderr] | ^^^^^^^^^^^ [INFO] [stderr] = note: #[deny(clippy::trivially_copy_pass_by_ref)] implied by #[deny(clippy::perf)] [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] error: aborting due to previous error [INFO] [stderr] [INFO] [stderr] error: Could not compile `privnoters`. [INFO] [stderr] [INFO] [stderr] To learn more, run the command again with --verbose. [INFO] running `"docker" "inspect" "9f4bcb848be7add7d32867a2f2da3638eb5659d973760d52a02f5c601995fffe"` [INFO] running `"docker" "rm" "-f" "9f4bcb848be7add7d32867a2f2da3638eb5659d973760d52a02f5c601995fffe"` [INFO] [stdout] 9f4bcb848be7add7d32867a2f2da3638eb5659d973760d52a02f5c601995fffe