[INFO] updating cached repository dave-leeper/rusty_spider_server [INFO] running `"git" "fetch" "--all"` [INFO] [stdout] Fetching origin [INFO] [stderr] From git://github.com/dave-leeper/rusty_spider_server [INFO] [stderr] * branch HEAD -> FETCH_HEAD [INFO] running `"git" "clone" "work/cache/sources/gh/dave-leeper/rusty_spider_server" "work/ex/clippy-test-run/sources/stable/gh/dave-leeper/rusty_spider_server"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/dave-leeper/rusty_spider_server'... [INFO] [stderr] done. [INFO] running `"git" "clone" "work/cache/sources/gh/dave-leeper/rusty_spider_server" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/dave-leeper/rusty_spider_server"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/dave-leeper/rusty_spider_server'... [INFO] [stderr] done. [INFO] running `"git" "rev-parse" "HEAD"` [INFO] [stdout] da4932cf474d232c36d37f1881c1bb29509fec4f [INFO] sha for GitHub repo dave-leeper/rusty_spider_server: da4932cf474d232c36d37f1881c1bb29509fec4f [INFO] validating manifest of dave-leeper/rusty_spider_server on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of dave-leeper/rusty_spider_server on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing dave-leeper/rusty_spider_server [INFO] finished frobbing dave-leeper/rusty_spider_server [INFO] frobbed toml for dave-leeper/rusty_spider_server written to work/ex/clippy-test-run/sources/stable/gh/dave-leeper/rusty_spider_server/Cargo.toml [INFO] started frobbing dave-leeper/rusty_spider_server [INFO] finished frobbing dave-leeper/rusty_spider_server [INFO] frobbed toml for dave-leeper/rusty_spider_server written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/dave-leeper/rusty_spider_server/Cargo.toml [INFO] crate dave-leeper/rusty_spider_server has a lockfile. skipping [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting dave-leeper/rusty_spider_server against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-6/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/gh/dave-leeper/rusty_spider_server:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] d5859f8ec59d34582bd9dbcbe214ef52cc6597867deaa3a557fc31d2b56802b4 [INFO] running `"docker" "start" "-a" "d5859f8ec59d34582bd9dbcbe214ef52cc6597867deaa3a557fc31d2b56802b4"` [INFO] [stderr] Checking log v0.4.2 [INFO] [stderr] Checking console v0.6.1 [INFO] [stderr] Checking chrono v0.4.4 [INFO] [stderr] Checking mio v0.6.14 [INFO] [stderr] Checking tokio-io v0.1.7 [INFO] [stderr] Checking tokio-threadpool v0.1.4 [INFO] [stderr] Checking want v0.0.5 [INFO] [stderr] Checking tokio-codec v0.1.0 [INFO] [stderr] Checking h2 v0.1.10 [INFO] [stderr] Checking tokio-reactor v0.1.2 [INFO] [stderr] Checking tokio-fs v0.1.1 [INFO] [stderr] Checking tokio-tcp v0.1.0 [INFO] [stderr] Checking tokio-udp v0.1.1 [INFO] [stderr] Checking tokio v0.1.7 [INFO] [stderr] Checking hyper v0.12.3 [INFO] [stderr] Checking web_server v0.1.0 (/opt/crater/workdir) [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/i18n.rs:22:13 [INFO] [stderr] | [INFO] [stderr] 22 | path: path [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `path` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: literal with an empty format string [INFO] [stderr] --> src/log.rs:86:17 [INFO] [stderr] | [INFO] [stderr] 86 | "{ ", [INFO] [stderr] | ^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::write_literal)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#write_literal [INFO] [stderr] [INFO] [stderr] warning: literal with an empty format string [INFO] [stderr] --> src/log.rs:87:17 [INFO] [stderr] | [INFO] [stderr] 87 | "\"message\": \"", message, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#write_literal [INFO] [stderr] [INFO] [stderr] warning: literal with an empty format string [INFO] [stderr] --> src/log.rs:88:17 [INFO] [stderr] | [INFO] [stderr] 88 | "\" }" [INFO] [stderr] | ^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#write_literal [INFO] [stderr] [INFO] [stderr] warning: literal with an empty format string [INFO] [stderr] --> src/log.rs:93:17 [INFO] [stderr] | [INFO] [stderr] 93 | "{ ", [INFO] [stderr] | ^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#write_literal [INFO] [stderr] [INFO] [stderr] warning: literal with an empty format string [INFO] [stderr] --> src/log.rs:94:17 [INFO] [stderr] | [INFO] [stderr] 94 | "\"message\" :\"", message, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#write_literal [INFO] [stderr] [INFO] [stderr] warning: literal with an empty format string [INFO] [stderr] --> src/log.rs:95:17 [INFO] [stderr] | [INFO] [stderr] 95 | "\", \"verb\": \"", verb, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#write_literal [INFO] [stderr] [INFO] [stderr] warning: literal with an empty format string [INFO] [stderr] --> src/log.rs:96:17 [INFO] [stderr] | [INFO] [stderr] 96 | "\", \"path\": \"", path, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#write_literal [INFO] [stderr] [INFO] [stderr] warning: literal with an empty format string [INFO] [stderr] --> src/log.rs:97:17 [INFO] [stderr] | [INFO] [stderr] 97 | "\" }" [INFO] [stderr] | ^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#write_literal [INFO] [stderr] [INFO] [stderr] warning: literal with an empty format string [INFO] [stderr] --> src/log.rs:102:17 [INFO] [stderr] | [INFO] [stderr] 102 | "{ ", [INFO] [stderr] | ^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#write_literal [INFO] [stderr] [INFO] [stderr] warning: literal with an empty format string [INFO] [stderr] --> src/log.rs:103:17 [INFO] [stderr] | [INFO] [stderr] 103 | "\"message\" :\"", message, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#write_literal [INFO] [stderr] [INFO] [stderr] warning: literal with an empty format string [INFO] [stderr] --> src/log.rs:104:17 [INFO] [stderr] | [INFO] [stderr] 104 | "\", \"verb\": \"", verb, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#write_literal [INFO] [stderr] [INFO] [stderr] warning: literal with an empty format string [INFO] [stderr] --> src/log.rs:105:17 [INFO] [stderr] | [INFO] [stderr] 105 | "\", \"path\": \"", path, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#write_literal [INFO] [stderr] [INFO] [stderr] warning: literal with an empty format string [INFO] [stderr] --> src/log.rs:106:17 [INFO] [stderr] | [INFO] [stderr] 106 | "\" }" [INFO] [stderr] | ^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#write_literal [INFO] [stderr] [INFO] [stderr] warning: literal with an empty format string [INFO] [stderr] --> src/log.rs:111:17 [INFO] [stderr] | [INFO] [stderr] 111 | "{ ", [INFO] [stderr] | ^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#write_literal [INFO] [stderr] [INFO] [stderr] warning: literal with an empty format string [INFO] [stderr] --> src/log.rs:112:17 [INFO] [stderr] | [INFO] [stderr] 112 | "\"message\" :\"", message, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#write_literal [INFO] [stderr] [INFO] [stderr] warning: literal with an empty format string [INFO] [stderr] --> src/log.rs:113:17 [INFO] [stderr] | [INFO] [stderr] 113 | "\", \"file\": \"", file, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#write_literal [INFO] [stderr] [INFO] [stderr] warning: literal with an empty format string [INFO] [stderr] --> src/log.rs:114:17 [INFO] [stderr] | [INFO] [stderr] 114 | "\" }" [INFO] [stderr] | ^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#write_literal [INFO] [stderr] [INFO] [stderr] warning: literal with an empty format string [INFO] [stderr] --> src/log.rs:141:17 [INFO] [stderr] | [INFO] [stderr] 141 | "{ ", [INFO] [stderr] | ^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#write_literal [INFO] [stderr] [INFO] [stderr] warning: literal with an empty format string [INFO] [stderr] --> src/log.rs:142:17 [INFO] [stderr] | [INFO] [stderr] 142 | "\"message\": \"", message, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#write_literal [INFO] [stderr] [INFO] [stderr] warning: literal with an empty format string [INFO] [stderr] --> src/log.rs:143:17 [INFO] [stderr] | [INFO] [stderr] 143 | "\", \"status_code\": \"", status_code, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#write_literal [INFO] [stderr] [INFO] [stderr] warning: literal with an empty format string [INFO] [stderr] --> src/log.rs:144:17 [INFO] [stderr] | [INFO] [stderr] 144 | "\" }" [INFO] [stderr] | ^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#write_literal [INFO] [stderr] [INFO] [stderr] warning: literal with an empty format string [INFO] [stderr] --> src/log.rs:149:17 [INFO] [stderr] | [INFO] [stderr] 149 | "{ ", [INFO] [stderr] | ^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#write_literal [INFO] [stderr] [INFO] [stderr] warning: literal with an empty format string [INFO] [stderr] --> src/log.rs:150:17 [INFO] [stderr] | [INFO] [stderr] 150 | "\"message\": \"", message, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#write_literal [INFO] [stderr] [INFO] [stderr] warning: literal with an empty format string [INFO] [stderr] --> src/log.rs:151:17 [INFO] [stderr] | [INFO] [stderr] 151 | "\", \"file\": \"", file, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#write_literal [INFO] [stderr] [INFO] [stderr] warning: literal with an empty format string [INFO] [stderr] --> src/log.rs:152:17 [INFO] [stderr] | [INFO] [stderr] 152 | "\", \"status_code\": \"", status_code, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#write_literal [INFO] [stderr] [INFO] [stderr] warning: literal with an empty format string [INFO] [stderr] --> src/log.rs:153:17 [INFO] [stderr] | [INFO] [stderr] 153 | "\" }" [INFO] [stderr] | ^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#write_literal [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/log.rs:159:66 [INFO] [stderr] | [INFO] [stderr] 159 | return StructuredError::Error{ message: message.to_string(), status_code: status_code }; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `status_code` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/log.rs:162:70 [INFO] [stderr] | [INFO] [stderr] 162 | return StructuredError::FileError{ message: message.to_string(), status_code: status_code, file: file.to_string() }; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `status_code` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/log.rs:190:13 [INFO] [stderr] | [INFO] [stderr] 190 | level: level, [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `level` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/log.rs:191:13 [INFO] [stderr] | [INFO] [stderr] 191 | prefix_fatal_error: prefix_fatal_error, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `prefix_fatal_error` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/log.rs:192:13 [INFO] [stderr] | [INFO] [stderr] 192 | prefix_error: prefix_error, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `prefix_error` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/log.rs:193:13 [INFO] [stderr] | [INFO] [stderr] 193 | prefix_warning: prefix_warning, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `prefix_warning` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/log.rs:194:13 [INFO] [stderr] | [INFO] [stderr] 194 | prefix_info: prefix_info, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `prefix_info` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/log.rs:195:13 [INFO] [stderr] | [INFO] [stderr] 195 | prefix_debug: prefix_debug, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `prefix_debug` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/log.rs:196:13 [INFO] [stderr] | [INFO] [stderr] 196 | prefix_trace: prefix_trace, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `prefix_trace` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/log.rs:197:13 [INFO] [stderr] | [INFO] [stderr] 197 | prefix_all: prefix_all [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `prefix_all` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/config.rs:141:13 [INFO] [stderr] | [INFO] [stderr] 141 | i18n: i18n, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `i18n` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/config.rs:201:21 [INFO] [stderr] | [INFO] [stderr] 201 | general: general, [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: replace it with: `general` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/config.rs:207:21 [INFO] [stderr] | [INFO] [stderr] 207 | general: general, [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: replace it with: `general` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/config.rs:230:13 [INFO] [stderr] | [INFO] [stderr] 230 | port: port, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `port` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/config.rs:387:17 [INFO] [stderr] | [INFO] [stderr] 387 | verb: verb, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `verb` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/config.rs:388:17 [INFO] [stderr] | [INFO] [stderr] 388 | path: path, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `path` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/config.rs:389:17 [INFO] [stderr] | [INFO] [stderr] 389 | response: response, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: replace it with: `response` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/config.rs:390:17 [INFO] [stderr] | [INFO] [stderr] 390 | response_type: response_type, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `response_type` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/config.rs:391:17 [INFO] [stderr] | [INFO] [stderr] 391 | hbs_data: hbs_data, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: replace it with: `hbs_data` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/config.rs:392:17 [INFO] [stderr] | [INFO] [stderr] 392 | authentication: authentication, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `authentication` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/config.rs:393:17 [INFO] [stderr] | [INFO] [stderr] 393 | authorization: authorization, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `authorization` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/config.rs:394:17 [INFO] [stderr] | [INFO] [stderr] 394 | logging: logging, [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: replace it with: `logging` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/config.rs:395:17 [INFO] [stderr] | [INFO] [stderr] 395 | headers: headers, [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: replace it with: `headers` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/config.rs:396:17 [INFO] [stderr] | [INFO] [stderr] 396 | cookies: cookies, [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: replace it with: `cookies` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/config.rs:503:13 [INFO] [stderr] | [INFO] [stderr] 503 | expires: expires, [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: replace it with: `expires` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/config.rs:504:13 [INFO] [stderr] | [INFO] [stderr] 504 | max: max [INFO] [stderr] | ^^^^^^^^ help: replace it with: `max` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/i18n.rs:22:13 [INFO] [stderr] | [INFO] [stderr] 22 | path: path [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `path` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: literal with an empty format string [INFO] [stderr] --> src/log.rs:86:17 [INFO] [stderr] | [INFO] [stderr] 86 | "{ ", [INFO] [stderr] | ^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::write_literal)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#write_literal [INFO] [stderr] [INFO] [stderr] warning: literal with an empty format string [INFO] [stderr] --> src/log.rs:87:17 [INFO] [stderr] | [INFO] [stderr] 87 | "\"message\": \"", message, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#write_literal [INFO] [stderr] [INFO] [stderr] warning: literal with an empty format string [INFO] [stderr] --> src/log.rs:88:17 [INFO] [stderr] | [INFO] [stderr] 88 | "\" }" [INFO] [stderr] | ^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#write_literal [INFO] [stderr] [INFO] [stderr] warning: literal with an empty format string [INFO] [stderr] --> src/log.rs:93:17 [INFO] [stderr] | [INFO] [stderr] 93 | "{ ", [INFO] [stderr] | ^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#write_literal [INFO] [stderr] [INFO] [stderr] warning: literal with an empty format string [INFO] [stderr] --> src/log.rs:94:17 [INFO] [stderr] | [INFO] [stderr] 94 | "\"message\" :\"", message, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#write_literal [INFO] [stderr] [INFO] [stderr] warning: literal with an empty format string [INFO] [stderr] --> src/log.rs:95:17 [INFO] [stderr] | [INFO] [stderr] 95 | "\", \"verb\": \"", verb, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#write_literal [INFO] [stderr] [INFO] [stderr] warning: literal with an empty format string [INFO] [stderr] --> src/log.rs:96:17 [INFO] [stderr] | [INFO] [stderr] 96 | "\", \"path\": \"", path, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#write_literal [INFO] [stderr] [INFO] [stderr] warning: literal with an empty format string [INFO] [stderr] --> src/log.rs:97:17 [INFO] [stderr] | [INFO] [stderr] 97 | "\" }" [INFO] [stderr] | ^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#write_literal [INFO] [stderr] [INFO] [stderr] warning: literal with an empty format string [INFO] [stderr] --> src/log.rs:102:17 [INFO] [stderr] | [INFO] [stderr] 102 | "{ ", [INFO] [stderr] | ^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#write_literal [INFO] [stderr] [INFO] [stderr] warning: literal with an empty format string [INFO] [stderr] --> src/log.rs:103:17 [INFO] [stderr] | [INFO] [stderr] 103 | "\"message\" :\"", message, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#write_literal [INFO] [stderr] [INFO] [stderr] warning: literal with an empty format string [INFO] [stderr] --> src/log.rs:104:17 [INFO] [stderr] | [INFO] [stderr] 104 | "\", \"verb\": \"", verb, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#write_literal [INFO] [stderr] [INFO] [stderr] warning: literal with an empty format string [INFO] [stderr] --> src/log.rs:105:17 [INFO] [stderr] | [INFO] [stderr] 105 | "\", \"path\": \"", path, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#write_literal [INFO] [stderr] [INFO] [stderr] warning: literal with an empty format string [INFO] [stderr] --> src/log.rs:106:17 [INFO] [stderr] | [INFO] [stderr] 106 | "\" }" [INFO] [stderr] | ^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#write_literal [INFO] [stderr] [INFO] [stderr] warning: literal with an empty format string [INFO] [stderr] --> src/log.rs:111:17 [INFO] [stderr] | [INFO] [stderr] 111 | "{ ", [INFO] [stderr] | ^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#write_literal [INFO] [stderr] [INFO] [stderr] warning: literal with an empty format string [INFO] [stderr] --> src/log.rs:112:17 [INFO] [stderr] | [INFO] [stderr] 112 | "\"message\" :\"", message, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#write_literal [INFO] [stderr] [INFO] [stderr] warning: literal with an empty format string [INFO] [stderr] --> src/log.rs:113:17 [INFO] [stderr] | [INFO] [stderr] 113 | "\", \"file\": \"", file, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#write_literal [INFO] [stderr] [INFO] [stderr] warning: literal with an empty format string [INFO] [stderr] --> src/log.rs:114:17 [INFO] [stderr] | [INFO] [stderr] 114 | "\" }" [INFO] [stderr] | ^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#write_literal [INFO] [stderr] [INFO] [stderr] warning: literal with an empty format string [INFO] [stderr] --> src/log.rs:141:17 [INFO] [stderr] | [INFO] [stderr] 141 | "{ ", [INFO] [stderr] | ^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#write_literal [INFO] [stderr] [INFO] [stderr] warning: literal with an empty format string [INFO] [stderr] --> src/log.rs:142:17 [INFO] [stderr] | [INFO] [stderr] 142 | "\"message\": \"", message, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#write_literal [INFO] [stderr] [INFO] [stderr] warning: literal with an empty format string [INFO] [stderr] --> src/log.rs:143:17 [INFO] [stderr] | [INFO] [stderr] 143 | "\", \"status_code\": \"", status_code, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#write_literal [INFO] [stderr] [INFO] [stderr] warning: literal with an empty format string [INFO] [stderr] --> src/log.rs:144:17 [INFO] [stderr] | [INFO] [stderr] 144 | "\" }" [INFO] [stderr] | ^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#write_literal [INFO] [stderr] [INFO] [stderr] warning: literal with an empty format string [INFO] [stderr] --> src/log.rs:149:17 [INFO] [stderr] | [INFO] [stderr] 149 | "{ ", [INFO] [stderr] | ^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#write_literal [INFO] [stderr] [INFO] [stderr] warning: literal with an empty format string [INFO] [stderr] --> src/log.rs:150:17 [INFO] [stderr] | [INFO] [stderr] 150 | "\"message\": \"", message, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#write_literal [INFO] [stderr] [INFO] [stderr] warning: literal with an empty format string [INFO] [stderr] --> src/log.rs:151:17 [INFO] [stderr] | [INFO] [stderr] 151 | "\", \"file\": \"", file, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#write_literal [INFO] [stderr] [INFO] [stderr] warning: literal with an empty format string [INFO] [stderr] --> src/log.rs:152:17 [INFO] [stderr] | [INFO] [stderr] 152 | "\", \"status_code\": \"", status_code, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#write_literal [INFO] [stderr] [INFO] [stderr] warning: literal with an empty format string [INFO] [stderr] --> src/log.rs:153:17 [INFO] [stderr] | [INFO] [stderr] 153 | "\" }" [INFO] [stderr] | ^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#write_literal [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/log.rs:159:66 [INFO] [stderr] | [INFO] [stderr] 159 | return StructuredError::Error{ message: message.to_string(), status_code: status_code }; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `status_code` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/log.rs:162:70 [INFO] [stderr] | [INFO] [stderr] 162 | return StructuredError::FileError{ message: message.to_string(), status_code: status_code, file: file.to_string() }; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `status_code` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/log.rs:190:13 [INFO] [stderr] | [INFO] [stderr] 190 | level: level, [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `level` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/log.rs:191:13 [INFO] [stderr] | [INFO] [stderr] 191 | prefix_fatal_error: prefix_fatal_error, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `prefix_fatal_error` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/log.rs:192:13 [INFO] [stderr] | [INFO] [stderr] 192 | prefix_error: prefix_error, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `prefix_error` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/log.rs:193:13 [INFO] [stderr] | [INFO] [stderr] 193 | prefix_warning: prefix_warning, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `prefix_warning` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/log.rs:194:13 [INFO] [stderr] | [INFO] [stderr] 194 | prefix_info: prefix_info, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `prefix_info` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/log.rs:195:13 [INFO] [stderr] | [INFO] [stderr] 195 | prefix_debug: prefix_debug, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `prefix_debug` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/log.rs:196:13 [INFO] [stderr] | [INFO] [stderr] 196 | prefix_trace: prefix_trace, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `prefix_trace` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/log.rs:197:13 [INFO] [stderr] | [INFO] [stderr] 197 | prefix_all: prefix_all [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `prefix_all` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/config.rs:141:13 [INFO] [stderr] | [INFO] [stderr] 141 | i18n: i18n, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `i18n` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/config.rs:201:21 [INFO] [stderr] | [INFO] [stderr] 201 | general: general, [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: replace it with: `general` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/config.rs:207:21 [INFO] [stderr] | [INFO] [stderr] 207 | general: general, [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: replace it with: `general` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/config.rs:230:13 [INFO] [stderr] | [INFO] [stderr] 230 | port: port, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `port` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/config.rs:387:17 [INFO] [stderr] | [INFO] [stderr] 387 | verb: verb, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `verb` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/config.rs:388:17 [INFO] [stderr] | [INFO] [stderr] 388 | path: path, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `path` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/config.rs:389:17 [INFO] [stderr] | [INFO] [stderr] 389 | response: response, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: replace it with: `response` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/config.rs:390:17 [INFO] [stderr] | [INFO] [stderr] 390 | response_type: response_type, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `response_type` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/config.rs:391:17 [INFO] [stderr] | [INFO] [stderr] 391 | hbs_data: hbs_data, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: replace it with: `hbs_data` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/config.rs:392:17 [INFO] [stderr] | [INFO] [stderr] 392 | authentication: authentication, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `authentication` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/config.rs:393:17 [INFO] [stderr] | [INFO] [stderr] 393 | authorization: authorization, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `authorization` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/config.rs:394:17 [INFO] [stderr] | [INFO] [stderr] 394 | logging: logging, [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: replace it with: `logging` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/config.rs:395:17 [INFO] [stderr] | [INFO] [stderr] 395 | headers: headers, [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: replace it with: `headers` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/config.rs:396:17 [INFO] [stderr] | [INFO] [stderr] 396 | cookies: cookies, [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: replace it with: `cookies` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/config.rs:503:13 [INFO] [stderr] | [INFO] [stderr] 503 | expires: expires, [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: replace it with: `expires` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/config.rs:504:13 [INFO] [stderr] | [INFO] [stderr] 504 | max: max [INFO] [stderr] | ^^^^^^^^ help: replace it with: `max` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: unused import: `strings` [INFO] [stderr] --> src/i18n.rs:4:5 [INFO] [stderr] | [INFO] [stderr] 4 | use strings; [INFO] [stderr] | ^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_imports)] on by default [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/i18n.rs:25:9 [INFO] [stderr] | [INFO] [stderr] 25 | return i18n; [INFO] [stderr] | ^^^^^^^^^^^^ help: remove `return` as shown: `i18n` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_return)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/i18n.rs:49:9 [INFO] [stderr] | [INFO] [stderr] 49 | return self.strings[string_id].to_string(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `self.strings[string_id].to_string()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/log.rs:120:5 [INFO] [stderr] | [INFO] [stderr] 120 | return StructuredMessage::Message{ message: message.to_string() }; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `StructuredMessage::Message{ message: message.to_string() }` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/log.rs:124:5 [INFO] [stderr] | [INFO] [stderr] 124 | return StructuredMessage::EntryMessage{ message: entering, verb: verb.to_string(), path: path.to_string() }; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `StructuredMessage::EntryMessage{ message: entering, verb: verb.to_string(), path: path.to_string() }` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/log.rs:128:5 [INFO] [stderr] | [INFO] [stderr] 128 | return StructuredMessage::ExitMessage{ message: exiting, verb: verb.to_string(), path: path.to_string() }; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `StructuredMessage::ExitMessage{ message: exiting, verb: verb.to_string(), path: path.to_string() }` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/log.rs:159:5 [INFO] [stderr] | [INFO] [stderr] 159 | return StructuredError::Error{ message: message.to_string(), status_code: status_code }; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `StructuredError::Error{ message: message.to_string(), status_code: status_code }` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/log.rs:162:5 [INFO] [stderr] | [INFO] [stderr] 162 | return StructuredError::FileError{ message: message.to_string(), status_code: status_code, file: file.to_string() }; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `StructuredError::FileError{ message: message.to_string(), status_code: status_code, file: file.to_string() }` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/log.rs:189:9 [INFO] [stderr] | [INFO] [stderr] 189 | / return Log { [INFO] [stderr] 190 | | level: level, [INFO] [stderr] 191 | | prefix_fatal_error: prefix_fatal_error, [INFO] [stderr] 192 | | prefix_error: prefix_error, [INFO] [stderr] ... | [INFO] [stderr] 197 | | prefix_all: prefix_all [INFO] [stderr] 198 | | }; [INFO] [stderr] | |__________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] help: remove `return` as shown [INFO] [stderr] | [INFO] [stderr] 189 | Log { [INFO] [stderr] 190 | level: level, [INFO] [stderr] 191 | prefix_fatal_error: prefix_fatal_error, [INFO] [stderr] 192 | prefix_error: prefix_error, [INFO] [stderr] 193 | prefix_warning: prefix_warning, [INFO] [stderr] 194 | prefix_info: prefix_info, [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/log.rs:215:24 [INFO] [stderr] | [INFO] [stderr] 215 | "ALL" => { return Level::All; }, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Level::All` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/log.rs:216:26 [INFO] [stderr] | [INFO] [stderr] 216 | "TRACE" => { return Level::Trace; }, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Level::Trace` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/log.rs:217:26 [INFO] [stderr] | [INFO] [stderr] 217 | "DEBUG" => { return Level::Debug; }, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Level::Debug` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/log.rs:218:25 [INFO] [stderr] | [INFO] [stderr] 218 | "INFO" => { return Level::Info; }, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Level::Info` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/log.rs:219:25 [INFO] [stderr] | [INFO] [stderr] 219 | "WARN" => { return Level::Warning; }, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Level::Warning` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/log.rs:220:26 [INFO] [stderr] | [INFO] [stderr] 220 | "ERROR" => { return Level::Error; }, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Level::Error` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/log.rs:221:26 [INFO] [stderr] | [INFO] [stderr] 221 | "FATAL" => { return Level::FatalError; }, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Level::FatalError` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/log.rs:222:20 [INFO] [stderr] | [INFO] [stderr] 222 | _ => { return Level::Off; } [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Level::Off` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/log.rs:226:9 [INFO] [stderr] | [INFO] [stderr] 226 | return level as u8 >= self.level as u8; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `level as u8 >= self.level as u8` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/log.rs:236:9 [INFO] [stderr] | [INFO] [stderr] 236 | return "".to_string(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `"".to_string()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unused import: `std` [INFO] [stderr] --> src/config.rs:5:5 [INFO] [stderr] | [INFO] [stderr] 5 | use std; [INFO] [stderr] | ^^^ [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/config.rs:42:13 [INFO] [stderr] | [INFO] [stderr] 42 | / return General{ [INFO] [stderr] 43 | | port: Some(3000), [INFO] [stderr] 44 | | logging: "WARNING".to_string(), [INFO] [stderr] 45 | | base_path: ".".to_string() [INFO] [stderr] 46 | | }; [INFO] [stderr] | |______________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] help: remove `return` as shown [INFO] [stderr] | [INFO] [stderr] 42 | General{ [INFO] [stderr] 43 | port: Some(3000), [INFO] [stderr] 44 | logging: "WARNING".to_string(), [INFO] [stderr] 45 | base_path: ".".to_string() [INFO] [stderr] 46 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/config.rs:118:13 [INFO] [stderr] | [INFO] [stderr] 118 | / return Config { [INFO] [stderr] 119 | | general: General::new(), [INFO] [stderr] 120 | | mocks: None [INFO] [stderr] 121 | | }; [INFO] [stderr] | |______________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] help: remove `return` as shown [INFO] [stderr] | [INFO] [stderr] 118 | Config { [INFO] [stderr] 119 | general: General::new(), [INFO] [stderr] 120 | mocks: None [INFO] [stderr] 121 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/config.rs:144:9 [INFO] [stderr] | [INFO] [stderr] 144 | return config_builder; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `config_builder` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/config.rs:179:9 [INFO] [stderr] | [INFO] [stderr] 179 | return Ok(contents.to_owned()); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Ok(contents.to_owned())` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/config.rs:183:9 [INFO] [stderr] | [INFO] [stderr] 183 | return from_str(data); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `from_str(data)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/config.rs:198:9 [INFO] [stderr] | [INFO] [stderr] 198 | / return match unwrapped_mocks { [INFO] [stderr] 199 | | Some(p) => { [INFO] [stderr] 200 | | Ok(Config { [INFO] [stderr] 201 | | general: general, [INFO] [stderr] ... | [INFO] [stderr] 210 | | } [INFO] [stderr] 211 | | }; [INFO] [stderr] | |__________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] help: remove `return` as shown [INFO] [stderr] | [INFO] [stderr] 198 | match unwrapped_mocks { [INFO] [stderr] 199 | Some(p) => { [INFO] [stderr] 200 | Ok(Config { [INFO] [stderr] 201 | general: general, [INFO] [stderr] 202 | mocks: Some(p) [INFO] [stderr] 203 | }) [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/config.rs:229:9 [INFO] [stderr] | [INFO] [stderr] 229 | / return General { [INFO] [stderr] 230 | | port: port, [INFO] [stderr] 231 | | logging: logging.to_string(), [INFO] [stderr] 232 | | base_path: base_path.to_string(), [INFO] [stderr] 233 | | }; [INFO] [stderr] | |__________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] help: remove `return` as shown [INFO] [stderr] | [INFO] [stderr] 229 | General { [INFO] [stderr] 230 | port: port, [INFO] [stderr] 231 | logging: logging.to_string(), [INFO] [stderr] 232 | base_path: base_path.to_string(), [INFO] [stderr] 233 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/config.rs:261:9 [INFO] [stderr] | [INFO] [stderr] 261 | return Ok(Some(built_mocks)); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Ok(Some(built_mocks))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/config.rs:385:9 [INFO] [stderr] | [INFO] [stderr] 385 | / return Ok(Some( [INFO] [stderr] 386 | | MockService { [INFO] [stderr] 387 | | verb: verb, [INFO] [stderr] 388 | | path: path, [INFO] [stderr] ... | [INFO] [stderr] 397 | | } [INFO] [stderr] 398 | | )); [INFO] [stderr] | |___________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] help: remove `return` as shown [INFO] [stderr] | [INFO] [stderr] 385 | Ok(Some( [INFO] [stderr] 386 | MockService { [INFO] [stderr] 387 | verb: verb, [INFO] [stderr] 388 | path: path, [INFO] [stderr] 389 | response: response, [INFO] [stderr] 390 | response_type: response_type, [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/config.rs:465:9 [INFO] [stderr] | [INFO] [stderr] 465 | return Ok(Some(header_array)); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Ok(Some(header_array))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/config.rs:547:9 [INFO] [stderr] | [INFO] [stderr] 547 | return Ok(Some(cookie_array)); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Ok(Some(cookie_array))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/config.rs:569:33 [INFO] [stderr] | [INFO] [stderr] 569 | / return Ok(Response { [INFO] [stderr] 570 | | string: None, [INFO] [stderr] 571 | | string_array: Some (ResponseStringArray { [INFO] [stderr] 572 | | response: response_array [INFO] [stderr] ... | [INFO] [stderr] 575 | | json_array: None, [INFO] [stderr] 576 | | }); [INFO] [stderr] | |___________________________________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] help: remove `return` as shown [INFO] [stderr] | [INFO] [stderr] 569 | Ok(Response { [INFO] [stderr] 570 | string: None, [INFO] [stderr] 571 | string_array: Some (ResponseStringArray { [INFO] [stderr] 572 | response: response_array [INFO] [stderr] 573 | }), [INFO] [stderr] 574 | json: None, [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/config.rs:581:33 [INFO] [stderr] | [INFO] [stderr] 581 | / return Ok(Response { [INFO] [stderr] 582 | | string: None, [INFO] [stderr] 583 | | string_array: None, [INFO] [stderr] 584 | | json: None, [INFO] [stderr] ... | [INFO] [stderr] 587 | | }), [INFO] [stderr] 588 | | }); [INFO] [stderr] | |___________________________________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] help: remove `return` as shown [INFO] [stderr] | [INFO] [stderr] 581 | Ok(Response { [INFO] [stderr] 582 | string: None, [INFO] [stderr] 583 | string_array: None, [INFO] [stderr] 584 | json: None, [INFO] [stderr] 585 | json_array: Some (ResponseJSONArray { [INFO] [stderr] 586 | response: response_array [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/config.rs:595:25 [INFO] [stderr] | [INFO] [stderr] 595 | return Err( response_error ); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Err( response_error )` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/config.rs:602:21 [INFO] [stderr] | [INFO] [stderr] 602 | / return Ok(Response { [INFO] [stderr] 603 | | string: Some (ResponseString { response: response_option.as_str().unwrap().to_string( )}), [INFO] [stderr] 604 | | string_array: None, [INFO] [stderr] 605 | | json: None, [INFO] [stderr] 606 | | json_array: None, [INFO] [stderr] 607 | | }); [INFO] [stderr] | |_______________________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] help: remove `return` as shown [INFO] [stderr] | [INFO] [stderr] 602 | Ok(Response { [INFO] [stderr] 603 | string: Some (ResponseString { response: response_option.as_str().unwrap().to_string( )}), [INFO] [stderr] 604 | string_array: None, [INFO] [stderr] 605 | json: None, [INFO] [stderr] 606 | json_array: None, [INFO] [stderr] 607 | }) [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/config.rs:611:21 [INFO] [stderr] | [INFO] [stderr] 611 | / return Ok(Response { [INFO] [stderr] 612 | | string: None, [INFO] [stderr] 613 | | string_array: None, [INFO] [stderr] 614 | | json: Some (ResponseJSON { response: response_option.to_string( )}), [INFO] [stderr] 615 | | json_array: None, [INFO] [stderr] 616 | | }); [INFO] [stderr] | |_______________________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] help: remove `return` as shown [INFO] [stderr] | [INFO] [stderr] 611 | Ok(Response { [INFO] [stderr] 612 | string: None, [INFO] [stderr] 613 | string_array: None, [INFO] [stderr] 614 | json: Some (ResponseJSON { response: response_option.to_string( )}), [INFO] [stderr] 615 | json_array: None, [INFO] [stderr] 616 | }) [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/config.rs:655:9 [INFO] [stderr] | [INFO] [stderr] 655 | / return Ok(Some(Authorization { [INFO] [stderr] 656 | | strategy: strategy.to_string(), [INFO] [stderr] 657 | | groups: group_array, [INFO] [stderr] 658 | | })); [INFO] [stderr] | |____________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] help: remove `return` as shown [INFO] [stderr] | [INFO] [stderr] 655 | Ok(Some(Authorization { [INFO] [stderr] 656 | strategy: strategy.to_string(), [INFO] [stderr] 657 | groups: group_array, [INFO] [stderr] 658 | })) [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: unused import: `config` [INFO] [stderr] --> src/router.rs:1:5 [INFO] [stderr] | [INFO] [stderr] 1 | use config; [INFO] [stderr] | ^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: unused import: `hyper::service::service_fn` [INFO] [stderr] --> src/router.rs:4:5 [INFO] [stderr] | [INFO] [stderr] 4 | use hyper::service::service_fn; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/router.rs:22:30 [INFO] [stderr] | [INFO] [stderr] 22 | pub fn new() -> Router { return Router { routes: HashMap::new( )}} [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Router { routes: HashMap::new( )}` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/router.rs:27:9 [INFO] [stderr] | [INFO] [stderr] 27 | return self.routes.get(route); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `self.routes.get(route)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unused import: `std::fmt` [INFO] [stderr] --> src/mock_handler.rs:6:5 [INFO] [stderr] | [INFO] [stderr] 6 | use std::fmt; [INFO] [stderr] | ^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/mock_handler.rs:26:9 [INFO] [stderr] | [INFO] [stderr] 26 | return UserInfo { username: username.to_string() }; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `UserInfo { username: username.to_string() }` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/mock_handler.rs:44:9 [INFO] [stderr] | [INFO] [stderr] 44 | / return MockRequestInfo { [INFO] [stderr] 45 | | log: log.clone(), [INFO] [stderr] 46 | | base_path: base_path.clone(), [INFO] [stderr] 47 | | user_info: user_info.clone(), [INFO] [stderr] 48 | | mock_service_info: mock_service_info.clone() [INFO] [stderr] 49 | | }; [INFO] [stderr] | |__________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] help: remove `return` as shown [INFO] [stderr] | [INFO] [stderr] 44 | MockRequestInfo { [INFO] [stderr] 45 | log: log.clone(), [INFO] [stderr] 46 | base_path: base_path.clone(), [INFO] [stderr] 47 | user_info: user_info.clone(), [INFO] [stderr] 48 | mock_service_info: mock_service_info.clone() [INFO] [stderr] 49 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/mock_handler.rs:144:9 [INFO] [stderr] | [INFO] [stderr] 144 | return Ok(Some(response)); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Ok(Some(response))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/mock_handler.rs:149:9 [INFO] [stderr] | [INFO] [stderr] 149 | return MockFileHandler {}; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `MockFileHandler {}` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/main.rs:52:21 [INFO] [stderr] | [INFO] [stderr] 52 | return build_response( &req, &p, &I18N ); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `build_response( &req, &p, &I18N )` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/main.rs:56:21 [INFO] [stderr] | [INFO] [stderr] 56 | return Response::new(Body::from( not_found_message )); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Response::new(Body::from( not_found_message ))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/main.rs:95:5 [INFO] [stderr] | [INFO] [stderr] 95 | return build_result.unwrap(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `build_result.unwrap()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/main.rs:125:5 [INFO] [stderr] | [INFO] [stderr] 125 | return router; [INFO] [stderr] | ^^^^^^^^^^^^^^ help: remove `return` as shown: `router` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/main.rs:139:22 [INFO] [stderr] | [INFO] [stderr] 139 | Some(p) => { return p; }, [INFO] [stderr] | ^^^^^^^^^ help: remove `return` as shown: `p` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/main.rs:142:13 [INFO] [stderr] | [INFO] [stderr] 142 | return Response::new( Body::from( message )); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Response::new( Body::from( message ))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/i18n.rs:25:9 [INFO] [stderr] | [INFO] [stderr] 25 | return i18n; [INFO] [stderr] | ^^^^^^^^^^^^ help: remove `return` as shown: `i18n` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_return)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/i18n.rs:49:9 [INFO] [stderr] | [INFO] [stderr] 49 | return self.strings[string_id].to_string(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `self.strings[string_id].to_string()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/log.rs:120:5 [INFO] [stderr] | [INFO] [stderr] 120 | return StructuredMessage::Message{ message: message.to_string() }; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `StructuredMessage::Message{ message: message.to_string() }` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/log.rs:124:5 [INFO] [stderr] | [INFO] [stderr] 124 | return StructuredMessage::EntryMessage{ message: entering, verb: verb.to_string(), path: path.to_string() }; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `StructuredMessage::EntryMessage{ message: entering, verb: verb.to_string(), path: path.to_string() }` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/log.rs:128:5 [INFO] [stderr] | [INFO] [stderr] 128 | return StructuredMessage::ExitMessage{ message: exiting, verb: verb.to_string(), path: path.to_string() }; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `StructuredMessage::ExitMessage{ message: exiting, verb: verb.to_string(), path: path.to_string() }` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/log.rs:159:5 [INFO] [stderr] | [INFO] [stderr] 159 | return StructuredError::Error{ message: message.to_string(), status_code: status_code }; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `StructuredError::Error{ message: message.to_string(), status_code: status_code }` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/log.rs:162:5 [INFO] [stderr] | [INFO] [stderr] 162 | return StructuredError::FileError{ message: message.to_string(), status_code: status_code, file: file.to_string() }; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `StructuredError::FileError{ message: message.to_string(), status_code: status_code, file: file.to_string() }` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/log.rs:189:9 [INFO] [stderr] | [INFO] [stderr] 189 | / return Log { [INFO] [stderr] 190 | | level: level, [INFO] [stderr] 191 | | prefix_fatal_error: prefix_fatal_error, [INFO] [stderr] 192 | | prefix_error: prefix_error, [INFO] [stderr] ... | [INFO] [stderr] 197 | | prefix_all: prefix_all [INFO] [stderr] 198 | | }; [INFO] [stderr] | |__________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] help: remove `return` as shown [INFO] [stderr] | [INFO] [stderr] 189 | Log { [INFO] [stderr] 190 | level: level, [INFO] [stderr] 191 | prefix_fatal_error: prefix_fatal_error, [INFO] [stderr] 192 | prefix_error: prefix_error, [INFO] [stderr] 193 | prefix_warning: prefix_warning, [INFO] [stderr] 194 | prefix_info: prefix_info, [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/log.rs:215:24 [INFO] [stderr] | [INFO] [stderr] 215 | "ALL" => { return Level::All; }, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Level::All` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/log.rs:216:26 [INFO] [stderr] | [INFO] [stderr] 216 | "TRACE" => { return Level::Trace; }, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Level::Trace` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/log.rs:217:26 [INFO] [stderr] | [INFO] [stderr] 217 | "DEBUG" => { return Level::Debug; }, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Level::Debug` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/log.rs:218:25 [INFO] [stderr] | [INFO] [stderr] 218 | "INFO" => { return Level::Info; }, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Level::Info` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/log.rs:219:25 [INFO] [stderr] | [INFO] [stderr] 219 | "WARN" => { return Level::Warning; }, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Level::Warning` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/log.rs:220:26 [INFO] [stderr] | [INFO] [stderr] 220 | "ERROR" => { return Level::Error; }, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Level::Error` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/log.rs:221:26 [INFO] [stderr] | [INFO] [stderr] 221 | "FATAL" => { return Level::FatalError; }, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Level::FatalError` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/log.rs:222:20 [INFO] [stderr] | [INFO] [stderr] 222 | _ => { return Level::Off; } [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Level::Off` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/log.rs:226:9 [INFO] [stderr] | [INFO] [stderr] 226 | return level as u8 >= self.level as u8; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `level as u8 >= self.level as u8` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/log.rs:236:9 [INFO] [stderr] | [INFO] [stderr] 236 | return "".to_string(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `"".to_string()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unused import: `std` [INFO] [stderr] --> src/config.rs:5:5 [INFO] [stderr] | [INFO] [stderr] 5 | use std; [INFO] [stderr] | ^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_imports)] on by default [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/config.rs:42:13 [INFO] [stderr] | [INFO] [stderr] 42 | / return General{ [INFO] [stderr] 43 | | port: Some(3000), [INFO] [stderr] 44 | | logging: "WARNING".to_string(), [INFO] [stderr] 45 | | base_path: ".".to_string() [INFO] [stderr] 46 | | }; [INFO] [stderr] | |______________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] help: remove `return` as shown [INFO] [stderr] | [INFO] [stderr] 42 | General{ [INFO] [stderr] 43 | port: Some(3000), [INFO] [stderr] 44 | logging: "WARNING".to_string(), [INFO] [stderr] 45 | base_path: ".".to_string() [INFO] [stderr] 46 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/config.rs:118:13 [INFO] [stderr] | [INFO] [stderr] 118 | / return Config { [INFO] [stderr] 119 | | general: General::new(), [INFO] [stderr] 120 | | mocks: None [INFO] [stderr] 121 | | }; [INFO] [stderr] | |______________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] help: remove `return` as shown [INFO] [stderr] | [INFO] [stderr] 118 | Config { [INFO] [stderr] 119 | general: General::new(), [INFO] [stderr] 120 | mocks: None [INFO] [stderr] 121 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/config.rs:144:9 [INFO] [stderr] | [INFO] [stderr] 144 | return config_builder; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `config_builder` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/config.rs:179:9 [INFO] [stderr] | [INFO] [stderr] 179 | return Ok(contents.to_owned()); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Ok(contents.to_owned())` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/config.rs:183:9 [INFO] [stderr] | [INFO] [stderr] 183 | return from_str(data); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `from_str(data)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/config.rs:198:9 [INFO] [stderr] | [INFO] [stderr] 198 | / return match unwrapped_mocks { [INFO] [stderr] 199 | | Some(p) => { [INFO] [stderr] 200 | | Ok(Config { [INFO] [stderr] 201 | | general: general, [INFO] [stderr] ... | [INFO] [stderr] 210 | | } [INFO] [stderr] 211 | | }; [INFO] [stderr] | |__________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] help: remove `return` as shown [INFO] [stderr] | [INFO] [stderr] 198 | match unwrapped_mocks { [INFO] [stderr] 199 | Some(p) => { [INFO] [stderr] 200 | Ok(Config { [INFO] [stderr] 201 | general: general, [INFO] [stderr] 202 | mocks: Some(p) [INFO] [stderr] 203 | }) [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/config.rs:229:9 [INFO] [stderr] | [INFO] [stderr] 229 | / return General { [INFO] [stderr] 230 | | port: port, [INFO] [stderr] 231 | | logging: logging.to_string(), [INFO] [stderr] 232 | | base_path: base_path.to_string(), [INFO] [stderr] 233 | | }; [INFO] [stderr] | |__________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] help: remove `return` as shown [INFO] [stderr] | [INFO] [stderr] 229 | General { [INFO] [stderr] 230 | port: port, [INFO] [stderr] 231 | logging: logging.to_string(), [INFO] [stderr] 232 | base_path: base_path.to_string(), [INFO] [stderr] 233 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/config.rs:261:9 [INFO] [stderr] | [INFO] [stderr] 261 | return Ok(Some(built_mocks)); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Ok(Some(built_mocks))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/config.rs:385:9 [INFO] [stderr] | [INFO] [stderr] 385 | / return Ok(Some( [INFO] [stderr] 386 | | MockService { [INFO] [stderr] 387 | | verb: verb, [INFO] [stderr] 388 | | path: path, [INFO] [stderr] ... | [INFO] [stderr] 397 | | } [INFO] [stderr] 398 | | )); [INFO] [stderr] | |___________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] help: remove `return` as shown [INFO] [stderr] | [INFO] [stderr] 385 | Ok(Some( [INFO] [stderr] 386 | MockService { [INFO] [stderr] 387 | verb: verb, [INFO] [stderr] 388 | path: path, [INFO] [stderr] 389 | response: response, [INFO] [stderr] 390 | response_type: response_type, [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/config.rs:465:9 [INFO] [stderr] | [INFO] [stderr] 465 | return Ok(Some(header_array)); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Ok(Some(header_array))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/config.rs:547:9 [INFO] [stderr] | [INFO] [stderr] 547 | return Ok(Some(cookie_array)); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Ok(Some(cookie_array))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/config.rs:569:33 [INFO] [stderr] | [INFO] [stderr] 569 | / return Ok(Response { [INFO] [stderr] 570 | | string: None, [INFO] [stderr] 571 | | string_array: Some (ResponseStringArray { [INFO] [stderr] 572 | | response: response_array [INFO] [stderr] ... | [INFO] [stderr] 575 | | json_array: None, [INFO] [stderr] 576 | | }); [INFO] [stderr] | |___________________________________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] help: remove `return` as shown [INFO] [stderr] | [INFO] [stderr] 569 | Ok(Response { [INFO] [stderr] 570 | string: None, [INFO] [stderr] 571 | string_array: Some (ResponseStringArray { [INFO] [stderr] 572 | response: response_array [INFO] [stderr] 573 | }), [INFO] [stderr] 574 | json: None, [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/config.rs:581:33 [INFO] [stderr] | [INFO] [stderr] 581 | / return Ok(Response { [INFO] [stderr] 582 | | string: None, [INFO] [stderr] 583 | | string_array: None, [INFO] [stderr] 584 | | json: None, [INFO] [stderr] ... | [INFO] [stderr] 587 | | }), [INFO] [stderr] 588 | | }); [INFO] [stderr] | |___________________________________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] help: remove `return` as shown [INFO] [stderr] | [INFO] [stderr] 581 | Ok(Response { [INFO] [stderr] 582 | string: None, [INFO] [stderr] 583 | string_array: None, [INFO] [stderr] 584 | json: None, [INFO] [stderr] 585 | json_array: Some (ResponseJSONArray { [INFO] [stderr] 586 | response: response_array [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/config.rs:595:25 [INFO] [stderr] | [INFO] [stderr] 595 | return Err( response_error ); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Err( response_error )` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/config.rs:602:21 [INFO] [stderr] | [INFO] [stderr] 602 | / return Ok(Response { [INFO] [stderr] 603 | | string: Some (ResponseString { response: response_option.as_str().unwrap().to_string( )}), [INFO] [stderr] 604 | | string_array: None, [INFO] [stderr] 605 | | json: None, [INFO] [stderr] 606 | | json_array: None, [INFO] [stderr] 607 | | }); [INFO] [stderr] | |_______________________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] help: remove `return` as shown [INFO] [stderr] | [INFO] [stderr] 602 | Ok(Response { [INFO] [stderr] 603 | string: Some (ResponseString { response: response_option.as_str().unwrap().to_string( )}), [INFO] [stderr] 604 | string_array: None, [INFO] [stderr] 605 | json: None, [INFO] [stderr] 606 | json_array: None, [INFO] [stderr] 607 | }) [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/config.rs:611:21 [INFO] [stderr] | [INFO] [stderr] 611 | / return Ok(Response { [INFO] [stderr] 612 | | string: None, [INFO] [stderr] 613 | | string_array: None, [INFO] [stderr] 614 | | json: Some (ResponseJSON { response: response_option.to_string( )}), [INFO] [stderr] 615 | | json_array: None, [INFO] [stderr] 616 | | }); [INFO] [stderr] | |_______________________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] help: remove `return` as shown [INFO] [stderr] | [INFO] [stderr] 611 | Ok(Response { [INFO] [stderr] 612 | string: None, [INFO] [stderr] 613 | string_array: None, [INFO] [stderr] 614 | json: Some (ResponseJSON { response: response_option.to_string( )}), [INFO] [stderr] 615 | json_array: None, [INFO] [stderr] 616 | }) [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/config.rs:655:9 [INFO] [stderr] | [INFO] [stderr] 655 | / return Ok(Some(Authorization { [INFO] [stderr] 656 | | strategy: strategy.to_string(), [INFO] [stderr] 657 | | groups: group_array, [INFO] [stderr] 658 | | })); [INFO] [stderr] | |____________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] help: remove `return` as shown [INFO] [stderr] | [INFO] [stderr] 655 | Ok(Some(Authorization { [INFO] [stderr] 656 | strategy: strategy.to_string(), [INFO] [stderr] 657 | groups: group_array, [INFO] [stderr] 658 | })) [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: unused import: `config` [INFO] [stderr] --> src/router.rs:1:5 [INFO] [stderr] | [INFO] [stderr] 1 | use config; [INFO] [stderr] | ^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: unused import: `hyper::service::service_fn` [INFO] [stderr] --> src/router.rs:4:5 [INFO] [stderr] | [INFO] [stderr] 4 | use hyper::service::service_fn; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/router.rs:22:30 [INFO] [stderr] | [INFO] [stderr] 22 | pub fn new() -> Router { return Router { routes: HashMap::new( )}} [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Router { routes: HashMap::new( )}` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/router.rs:27:9 [INFO] [stderr] | [INFO] [stderr] 27 | return self.routes.get(route); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `self.routes.get(route)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unused import: `hyper::Method` [INFO] [stderr] --> src/router.rs:40:9 [INFO] [stderr] | [INFO] [stderr] 40 | use hyper::Method; [INFO] [stderr] | ^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: unused import: `hyper::Uri` [INFO] [stderr] --> src/router.rs:41:9 [INFO] [stderr] | [INFO] [stderr] 41 | use hyper::Uri; [INFO] [stderr] | ^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: unused import: `std::fmt` [INFO] [stderr] --> src/mock_handler.rs:6:5 [INFO] [stderr] | [INFO] [stderr] 6 | use std::fmt; [INFO] [stderr] | ^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/mock_handler.rs:26:9 [INFO] [stderr] | [INFO] [stderr] 26 | return UserInfo { username: username.to_string() }; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `UserInfo { username: username.to_string() }` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/mock_handler.rs:44:9 [INFO] [stderr] | [INFO] [stderr] 44 | / return MockRequestInfo { [INFO] [stderr] 45 | | log: log.clone(), [INFO] [stderr] 46 | | base_path: base_path.clone(), [INFO] [stderr] 47 | | user_info: user_info.clone(), [INFO] [stderr] 48 | | mock_service_info: mock_service_info.clone() [INFO] [stderr] 49 | | }; [INFO] [stderr] | |__________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] help: remove `return` as shown [INFO] [stderr] | [INFO] [stderr] 44 | MockRequestInfo { [INFO] [stderr] 45 | log: log.clone(), [INFO] [stderr] 46 | base_path: base_path.clone(), [INFO] [stderr] 47 | user_info: user_info.clone(), [INFO] [stderr] 48 | mock_service_info: mock_service_info.clone() [INFO] [stderr] 49 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/mock_handler.rs:144:9 [INFO] [stderr] | [INFO] [stderr] 144 | return Ok(Some(response)); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Ok(Some(response))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/mock_handler.rs:149:9 [INFO] [stderr] | [INFO] [stderr] 149 | return MockFileHandler {}; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `MockFileHandler {}` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unused import: `hyper::Method` [INFO] [stderr] --> src/mock_handler.rs:160:9 [INFO] [stderr] | [INFO] [stderr] 160 | use hyper::Method; [INFO] [stderr] | ^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: unused import: `hyper::Uri` [INFO] [stderr] --> src/mock_handler.rs:161:9 [INFO] [stderr] | [INFO] [stderr] 161 | use hyper::Uri; [INFO] [stderr] | ^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/main.rs:52:21 [INFO] [stderr] | [INFO] [stderr] 52 | return build_response( &req, &p, &I18N ); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `build_response( &req, &p, &I18N )` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/main.rs:56:21 [INFO] [stderr] | [INFO] [stderr] 56 | return Response::new(Body::from( not_found_message )); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Response::new(Body::from( not_found_message ))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/main.rs:95:5 [INFO] [stderr] | [INFO] [stderr] 95 | return build_result.unwrap(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `build_result.unwrap()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/main.rs:125:5 [INFO] [stderr] | [INFO] [stderr] 125 | return router; [INFO] [stderr] | ^^^^^^^^^^^^^^ help: remove `return` as shown: `router` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/main.rs:139:22 [INFO] [stderr] | [INFO] [stderr] 139 | Some(p) => { return p; }, [INFO] [stderr] | ^^^^^^^^^ help: remove `return` as shown: `p` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/main.rs:142:13 [INFO] [stderr] | [INFO] [stderr] 142 | return Response::new( Body::from( message )); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Response::new( Body::from( message ))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unused variable: `i18n` [INFO] [stderr] --> src/main.rs:36:9 [INFO] [stderr] | [INFO] [stderr] 36 | let i18n = &I18N; [INFO] [stderr] | ^^^^ help: consider using `_i18n` instead [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_variables)] on by default [INFO] [stderr] [INFO] [stderr] warning: value assigned to `response_type_holder` is never read [INFO] [stderr] --> src/config.rs:307:17 [INFO] [stderr] | [INFO] [stderr] 307 | let mut response_type_holder = "UNKNOWN"; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_assignments)] on by default [INFO] [stderr] [INFO] [stderr] warning: value assigned to `hbs_data_option` is never read [INFO] [stderr] --> src/config.rs:329:17 [INFO] [stderr] | [INFO] [stderr] 329 | let mut hbs_data_option = None; [INFO] [stderr] | ^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: unused variable: `e` [INFO] [stderr] --> src/config.rs:458:21 [INFO] [stderr] | [INFO] [stderr] 458 | Err(e) => { [INFO] [stderr] | ^ help: consider using `_e` instead [INFO] [stderr] [INFO] [stderr] warning: unused variable: `req` [INFO] [stderr] --> src/mock_handler.rs:107:22 [INFO] [stderr] | [INFO] [stderr] 107 | fn handle(&self, req: &Request, res: & mut Response, i18n: & i18n::I18n, request_info: &MockRequestInfo) -> Result>, log::StructuredError> { [INFO] [stderr] | ^^^ help: consider using `_req` instead [INFO] [stderr] [INFO] [stderr] warning: unused variable: `res` [INFO] [stderr] --> src/mock_handler.rs:107:43 [INFO] [stderr] | [INFO] [stderr] 107 | fn handle(&self, req: &Request, res: & mut Response, i18n: & i18n::I18n, request_info: &MockRequestInfo) -> Result>, log::StructuredError> { [INFO] [stderr] | ^^^ help: consider using `_res` instead [INFO] [stderr] [INFO] [stderr] warning: variable does not need to be mutable [INFO] [stderr] --> src/mock_handler.rs:139:13 [INFO] [stderr] | [INFO] [stderr] 139 | let mut response = Response::new(Body::from( contents )); [INFO] [stderr] | ----^^^^^^^^ [INFO] [stderr] | | [INFO] [stderr] | help: remove this `mut` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_mut)] on by default [INFO] [stderr] [INFO] [stderr] warning: method is never used: `init` [INFO] [stderr] --> src/i18n.rs:27:5 [INFO] [stderr] | [INFO] [stderr] 27 | pub fn init(&mut self, locale: String, path: String) { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(dead_code)] on by default [INFO] [stderr] [INFO] [stderr] warning: method is never used: `init` [INFO] [stderr] --> src/log.rs:200:5 [INFO] [stderr] | [INFO] [stderr] 200 | pub fn init(&mut self, level: Level, i18n: &i18n::I18n) { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: method is never used: `set` [INFO] [stderr] --> src/log.rs:210:5 [INFO] [stderr] | [INFO] [stderr] 210 | pub fn set(&mut self, level: Level) { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: static item is never used: `AUTHORIZATION_NOT_CONFIGURED` [INFO] [stderr] --> src/strings.rs:3:1 [INFO] [stderr] | [INFO] [stderr] 3 | pub static AUTHORIZATION_NOT_CONFIGURED: usize = 1; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: static item is never used: `UNAUTHORIZED` [INFO] [stderr] --> src/strings.rs:4:1 [INFO] [stderr] | [INFO] [stderr] 4 | pub static UNAUTHORIZED: usize = 2; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: static item is never used: `LOGIN_REQUIRED` [INFO] [stderr] --> src/strings.rs:5:1 [INFO] [stderr] | [INFO] [stderr] 5 | pub static LOGIN_REQUIRED: usize = 3; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: static item is never used: `INCORRECT_USER_NAME` [INFO] [stderr] --> src/strings.rs:6:1 [INFO] [stderr] | [INFO] [stderr] 6 | pub static INCORRECT_USER_NAME: usize = 4; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: static item is never used: `INCORRECT_PASSWORD` [INFO] [stderr] --> src/strings.rs:7:1 [INFO] [stderr] | [INFO] [stderr] 7 | pub static INCORRECT_PASSWORD: usize = 5; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: static item is never used: `LOGIN_SUCCESSFUL` [INFO] [stderr] --> src/strings.rs:8:1 [INFO] [stderr] | [INFO] [stderr] 8 | pub static LOGIN_SUCCESSFUL: usize = 6; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: static item is never used: `LISTENING_ON_PORT` [INFO] [stderr] --> src/strings.rs:9:1 [INFO] [stderr] | [INFO] [stderr] 9 | pub static LISTENING_ON_PORT: usize = 7; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: static item is never used: `NO_FILE_SPECIFIED` [INFO] [stderr] --> src/strings.rs:28:1 [INFO] [stderr] | [INFO] [stderr] 28 | pub static NO_FILE_SPECIFIED: usize = 26; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: static item is never used: `COUNT` [INFO] [stderr] --> src/strings.rs:33:1 [INFO] [stderr] | [INFO] [stderr] 33 | pub static COUNT: usize = 30; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: writing `&String` instead of `&str` involves a new object where a slice will do. [INFO] [stderr] --> src/log.rs:119:31 [INFO] [stderr] | [INFO] [stderr] 119 | pub fn build_message(message: &String) -> StructuredMessage{ [INFO] [stderr] | ^^^^^^^ help: change this to: `&str` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::ptr_arg)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: writing `&String` instead of `&str` involves a new object where a slice will do. [INFO] [stderr] --> src/log.rs:122:57 [INFO] [stderr] | [INFO] [stderr] 122 | pub fn build_entering_message(i18n: & i18n::I18n, verb: &String, path: &String) -> StructuredMessage { [INFO] [stderr] | ^^^^^^^ help: change this to: `&str` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: writing `&String` instead of `&str` involves a new object where a slice will do. [INFO] [stderr] --> src/log.rs:122:72 [INFO] [stderr] | [INFO] [stderr] 122 | pub fn build_entering_message(i18n: & i18n::I18n, verb: &String, path: &String) -> StructuredMessage { [INFO] [stderr] | ^^^^^^^ help: change this to: `&str` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: writing `&String` instead of `&str` involves a new object where a slice will do. [INFO] [stderr] --> src/log.rs:126:55 [INFO] [stderr] | [INFO] [stderr] 126 | pub fn build_exiting_message(i18n: &i18n::I18n, verb: &String, path: &String) -> StructuredMessage{ [INFO] [stderr] | ^^^^^^^ help: change this to: `&str` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: writing `&String` instead of `&str` involves a new object where a slice will do. [INFO] [stderr] --> src/log.rs:126:70 [INFO] [stderr] | [INFO] [stderr] 126 | pub fn build_exiting_message(i18n: &i18n::I18n, verb: &String, path: &String) -> StructuredMessage{ [INFO] [stderr] | ^^^^^^^ help: change this to: `&str` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: writing `&String` instead of `&str` involves a new object where a slice will do. [INFO] [stderr] --> src/log.rs:158:29 [INFO] [stderr] | [INFO] [stderr] 158 | pub fn build_error(message: &String, status_code: StatusCode) -> StructuredError{ [INFO] [stderr] | ^^^^^^^ help: change this to: `&str` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: writing `&String` instead of `&str` involves a new object where a slice will do. [INFO] [stderr] --> src/log.rs:161:34 [INFO] [stderr] | [INFO] [stderr] 161 | pub fn build_file_error(message: &String, file: &String, status_code: StatusCode) -> StructuredError{ [INFO] [stderr] | ^^^^^^^ help: change this to: `&str` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: writing `&String` instead of `&str` involves a new object where a slice will do. [INFO] [stderr] --> src/log.rs:161:49 [INFO] [stderr] | [INFO] [stderr] 161 | pub fn build_file_error(message: &String, file: &String, status_code: StatusCode) -> StructuredError{ [INFO] [stderr] | ^^^^^^^ help: change this to: `&str` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: useless use of `format!` [INFO] [stderr] --> src/log.rs:229:41 [INFO] [stderr] | [INFO] [stderr] 229 | if Level::All == level { return format!("{}", self.prefix_all); } [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using .to_string(): `self.prefix_all.to_string()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::useless_format)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format [INFO] [stderr] = note: this error originates in a macro outside of the current crate (in Nightly builds, run with -Z external-macro-backtrace for more info) [INFO] [stderr] [INFO] [stderr] warning: useless use of `format!` [INFO] [stderr] --> src/log.rs:230:43 [INFO] [stderr] | [INFO] [stderr] 230 | if Level::Trace == level { return format!("{}", self.prefix_trace); } [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using .to_string(): `self.prefix_trace.to_string()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format [INFO] [stderr] = note: this error originates in a macro outside of the current crate (in Nightly builds, run with -Z external-macro-backtrace for more info) [INFO] [stderr] [INFO] [stderr] warning: useless use of `format!` [INFO] [stderr] --> src/log.rs:231:43 [INFO] [stderr] | [INFO] [stderr] 231 | if Level::Debug == level { return format!("{}", self.prefix_debug); } [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using .to_string(): `self.prefix_debug.to_string()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format [INFO] [stderr] = note: this error originates in a macro outside of the current crate (in Nightly builds, run with -Z external-macro-backtrace for more info) [INFO] [stderr] [INFO] [stderr] warning: useless use of `format!` [INFO] [stderr] --> src/log.rs:232:42 [INFO] [stderr] | [INFO] [stderr] 232 | if Level::Info == level { return format!("{}", self.prefix_info); } [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using .to_string(): `self.prefix_info.to_string()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format [INFO] [stderr] = note: this error originates in a macro outside of the current crate (in Nightly builds, run with -Z external-macro-backtrace for more info) [INFO] [stderr] [INFO] [stderr] warning: useless use of `format!` [INFO] [stderr] --> src/log.rs:233:45 [INFO] [stderr] | [INFO] [stderr] 233 | if Level::Warning == level { return format!("{}", self.prefix_warning); } [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using .to_string(): `self.prefix_warning.to_string()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format [INFO] [stderr] = note: this error originates in a macro outside of the current crate (in Nightly builds, run with -Z external-macro-backtrace for more info) [INFO] [stderr] [INFO] [stderr] warning: useless use of `format!` [INFO] [stderr] --> src/log.rs:234:43 [INFO] [stderr] | [INFO] [stderr] 234 | if Level::Error == level { return format!("{}", self.prefix_error); } [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using .to_string(): `self.prefix_error.to_string()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format [INFO] [stderr] = note: this error originates in a macro outside of the current crate (in Nightly builds, run with -Z external-macro-backtrace for more info) [INFO] [stderr] [INFO] [stderr] warning: useless use of `format!` [INFO] [stderr] --> src/log.rs:235:48 [INFO] [stderr] | [INFO] [stderr] 235 | if Level::FatalError == level { return format!("{}", self.prefix_fatal_error); } [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using .to_string(): `self.prefix_fatal_error.to_string()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format [INFO] [stderr] = note: this error originates in a macro outside of the current crate (in Nightly builds, run with -Z external-macro-backtrace for more info) [INFO] [stderr] [INFO] [stderr] warning: this boolean expression can be simplified [INFO] [stderr] --> src/config.rs:148:12 [INFO] [stderr] | [INFO] [stderr] 148 | if !open_result.is_ok() { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: try: `open_result.is_err()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::nonminimal_bool)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stderr] [INFO] [stderr] warning: this boolean expression can be simplified [INFO] [stderr] --> src/config.rs:165:12 [INFO] [stderr] | [INFO] [stderr] 165 | if !read_result.is_ok() { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: try: `read_result.is_err()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stderr] [INFO] [stderr] warning: this boolean expression can be simplified [INFO] [stderr] --> src/config.rs:188:12 [INFO] [stderr] | [INFO] [stderr] 188 | if !mocks.is_ok() { [INFO] [stderr] | ^^^^^^^^^^^^^^ help: try: `mocks.is_err()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stderr] [INFO] [stderr] warning: this boolean expression can be simplified [INFO] [stderr] --> src/config.rs:245:16 [INFO] [stderr] | [INFO] [stderr] 245 | if !mock.is_ok() { [INFO] [stderr] | ^^^^^^^^^^^^^ help: try: `mock.is_err()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/config.rs:255:13 [INFO] [stderr] | [INFO] [stderr] 255 | / match unwrapped_mock { [INFO] [stderr] 256 | | Some(p) => { built_mocks.push(p); }, [INFO] [stderr] 257 | | None => {} [INFO] [stderr] 258 | | } [INFO] [stderr] | |_____________^ help: try this: `if let Some(p) = unwrapped_mock { built_mocks.push(p); }` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::single_match)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/config.rs:260:12 [INFO] [stderr] | [INFO] [stderr] 260 | if 0 == built_mocks.len() { return Ok(None); } [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `built_mocks.is_empty()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::len_zero)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: this boolean expression can be simplified [INFO] [stderr] --> src/config.rs:301:12 [INFO] [stderr] | [INFO] [stderr] 301 | if !response_result.is_ok() { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `response_result.is_err()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stderr] [INFO] [stderr] warning: this boolean expression can be simplified [INFO] [stderr] --> src/config.rs:360:12 [INFO] [stderr] | [INFO] [stderr] 360 | if !authorization_result.is_ok() { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `authorization_result.is_err()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stderr] [INFO] [stderr] warning: this boolean expression can be simplified [INFO] [stderr] --> src/config.rs:372:12 [INFO] [stderr] | [INFO] [stderr] 372 | if !headers_result.is_ok() { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^ help: try: `headers_result.is_err()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stderr] [INFO] [stderr] warning: this boolean expression can be simplified [INFO] [stderr] --> src/config.rs:379:12 [INFO] [stderr] | [INFO] [stderr] 379 | if !cookies_result.is_ok() { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^ help: try: `cookies_result.is_err()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stderr] [INFO] [stderr] warning: the function has a cyclomatic complexity of 49 [INFO] [stderr] --> src/config.rs:263:5 [INFO] [stderr] | [INFO] [stderr] 263 | / fn build_mock (&self, mock_value: &Value) -> Result, log::StructuredError>{ [INFO] [stderr] 264 | | if mock_value.is_null() { return Ok(None); } [INFO] [stderr] 265 | | let error = log::StructuredError::Error{ [INFO] [stderr] 266 | | message: self.i18n.get(strings::INVALID_MOCK_DATA_IN_CONFIG), [INFO] [stderr] ... | [INFO] [stderr] 398 | | )); [INFO] [stderr] 399 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cyclomatic_complexity)] on by default [INFO] [stderr] = help: you could split it up into multiple smaller functions [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cyclomatic_complexity [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/config.rs:439:13 [INFO] [stderr] | [INFO] [stderr] 439 | / match headers_option.as_array() { [INFO] [stderr] 440 | | Some(ref p) => { [INFO] [stderr] 441 | | for element in p.iter() { [INFO] [stderr] 442 | | match self.build_header(element) { [INFO] [stderr] ... | [INFO] [stderr] 453 | | None => { /* Can't get here from there */ } [INFO] [stderr] 454 | | }; [INFO] [stderr] | |_____________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 439 | if let Some(ref p) = headers_option.as_array() { [INFO] [stderr] 440 | for element in p.iter() { [INFO] [stderr] 441 | match self.build_header(element) { [INFO] [stderr] 442 | Ok(h) => header_array.push(h), [INFO] [stderr] 443 | Err(_e) => { [INFO] [stderr] 444 | structured_error!(self.log, "{}", header_error); [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/config.rs:451:24 [INFO] [stderr] | [INFO] [stderr] 451 | if 0 == header_array.len() { return Ok(None); } [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `header_array.is_empty()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/config.rs:521:13 [INFO] [stderr] | [INFO] [stderr] 521 | / match cookies_option.as_array() { [INFO] [stderr] 522 | | Some(ref p) => { [INFO] [stderr] 523 | | for element in p.iter() { [INFO] [stderr] 524 | | match self.build_cookie(element) { [INFO] [stderr] ... | [INFO] [stderr] 535 | | None => { /* Can't get here from there */ } [INFO] [stderr] 536 | | }; [INFO] [stderr] | |_____________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 521 | if let Some(ref p) = cookies_option.as_array() { [INFO] [stderr] 522 | for element in p.iter() { [INFO] [stderr] 523 | match self.build_cookie(element) { [INFO] [stderr] 524 | Ok(c) => cookie_array.push(c), [INFO] [stderr] 525 | Err(_e) => { [INFO] [stderr] 526 | structured_error!(self.log, "{}", cookie_error); [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/config.rs:533:24 [INFO] [stderr] | [INFO] [stderr] 533 | if 0 == cookie_array.len() { return Ok(None); } [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `cookie_array.is_empty()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to match on a boolean expression [INFO] [stderr] --> src/config.rs:559:9 [INFO] [stderr] | [INFO] [stderr] 559 | / match response_option.is_array() { [INFO] [stderr] 560 | | true => { [INFO] [stderr] 561 | | let a = response_option.as_array(); [INFO] [stderr] 562 | | match a { [INFO] [stderr] ... | [INFO] [stderr] 618 | | }, [INFO] [stderr] 619 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::match_bool)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_bool [INFO] [stderr] help: consider using an if/else expression [INFO] [stderr] | [INFO] [stderr] 559 | if response_option.is_array() { [INFO] [stderr] 560 | let a = response_option.as_array(); [INFO] [stderr] 561 | match a { [INFO] [stderr] 562 | Some(p) => { [INFO] [stderr] 563 | let mut response_array = vec![]; [INFO] [stderr] 564 | match p[0].is_string() { [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to match on a boolean expression [INFO] [stderr] --> src/config.rs:565:25 [INFO] [stderr] | [INFO] [stderr] 565 | / match p[0].is_string() { [INFO] [stderr] 566 | | true => { [INFO] [stderr] 567 | | // println!("STRING ARRAY"); [INFO] [stderr] 568 | | for string_response in p { response_array.push(string_response.as_str().unwrap().to_string()); } [INFO] [stderr] ... | [INFO] [stderr] 589 | | }, [INFO] [stderr] 590 | | } [INFO] [stderr] | |_________________________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_bool [INFO] [stderr] help: consider using an if/else expression [INFO] [stderr] | [INFO] [stderr] 565 | if p[0].is_string() { [INFO] [stderr] 566 | // println!("STRING ARRAY"); [INFO] [stderr] 567 | for string_response in p { response_array.push(string_response.as_str().unwrap().to_string()); } [INFO] [stderr] 568 | return Ok(Response { [INFO] [stderr] 569 | string: None, [INFO] [stderr] 570 | string_array: Some (ResponseStringArray { [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to match on a boolean expression [INFO] [stderr] --> src/config.rs:599:22 [INFO] [stderr] | [INFO] [stderr] 599 | false => match response_option.is_string() { [INFO] [stderr] | ______________________^ [INFO] [stderr] 600 | | true => { [INFO] [stderr] 601 | | // println!("STRING"); [INFO] [stderr] 602 | | return Ok(Response { [INFO] [stderr] ... | [INFO] [stderr] 617 | | }, [INFO] [stderr] 618 | | }, [INFO] [stderr] | |_____________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_bool [INFO] [stderr] help: consider using an if/else expression [INFO] [stderr] | [INFO] [stderr] 599 | false => if response_option.is_string() { [INFO] [stderr] 600 | // println!("STRING"); [INFO] [stderr] 601 | return Ok(Response { [INFO] [stderr] 602 | string: Some (ResponseString { response: response_option.as_str().unwrap().to_string( )}), [INFO] [stderr] 603 | string_array: None, [INFO] [stderr] 604 | json: None, [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/config.rs:650:12 [INFO] [stderr] | [INFO] [stderr] 650 | if 0 == group_array.len() { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `group_array.is_empty()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: writing `&String` instead of `&str` involves a new object where a slice will do. [INFO] [stderr] --> src/mock_handler.rs:25:26 [INFO] [stderr] | [INFO] [stderr] 25 | pub fn new(username: &String) -> UserInfo { [INFO] [stderr] | ^^^^^^^ help: change this to: `&str` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: this boolean expression can be simplified [INFO] [stderr] --> src/mock_handler.rs:118:12 [INFO] [stderr] | [INFO] [stderr] 118 | if !open_result.is_ok() { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: try: `open_result.is_err()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stderr] [INFO] [stderr] warning: this boolean expression can be simplified [INFO] [stderr] --> src/mock_handler.rs:130:12 [INFO] [stderr] | [INFO] [stderr] 130 | if !read_result.is_ok() { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: try: `read_result.is_err()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stderr] [INFO] [stderr] warning: `ref` on an entire `let` pattern is discouraged, take a reference with `&` instead [INFO] [stderr] --> src/mock_handler.rs:111:13 [INFO] [stderr] | [INFO] [stderr] 111 | let ref mock_service = &request_info.mock_service_info; [INFO] [stderr] | ----^^^^^^^^^^^^^^^^----------------------------------- help: try: `let mock_service = &(&request_info.mock_service_info);` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::toplevel_ref_arg)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#toplevel_ref_arg [INFO] [stderr] [INFO] [stderr] warning: this boolean expression can be simplified [INFO] [stderr] --> src/main.rs:74:8 [INFO] [stderr] | [INFO] [stderr] 74 | if !read_result.is_ok(){ [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: try: `read_result.is_err()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stderr] [INFO] [stderr] warning: this boolean expression can be simplified [INFO] [stderr] --> src/main.rs:81:8 [INFO] [stderr] | [INFO] [stderr] 81 | if !parse_result.is_ok(){ [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^ help: try: `parse_result.is_err()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stderr] [INFO] [stderr] warning: this boolean expression can be simplified [INFO] [stderr] --> src/main.rs:89:8 [INFO] [stderr] | [INFO] [stderr] 89 | if !build_result.is_ok(){ [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^ help: try: `build_result.is_err()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/main.rs:102:5 [INFO] [stderr] | [INFO] [stderr] 102 | / match config.mocks { [INFO] [stderr] 103 | | Some(p) => { [INFO] [stderr] 104 | | for mock in p.iter() { [INFO] [stderr] 105 | | let route = router::Route::new( &mock.verb, &mock.path ); [INFO] [stderr] ... | [INFO] [stderr] 123 | | None => {} [INFO] [stderr] 124 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 102 | if let Some(p) = config.mocks { [INFO] [stderr] 103 | for mock in p.iter() { [INFO] [stderr] 104 | let route = router::Route::new( &mock.verb, &mock.path ); [INFO] [stderr] 105 | let user_info = mock_handler::UserInfo::new( &"USER".to_string() ); [INFO] [stderr] 106 | let log_for_mock = match mock.logging.clone() { [INFO] [stderr] 107 | Some(q) => { [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: this boolean expression can be simplified [INFO] [stderr] --> src/main.rs:131:8 [INFO] [stderr] | [INFO] [stderr] 131 | if !result.is_ok() { [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: try: `result.is_err()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stderr] [INFO] [stderr] warning: unused variable: `i18n` [INFO] [stderr] --> src/main.rs:36:9 [INFO] [stderr] | [INFO] [stderr] 36 | let i18n = &I18N; [INFO] [stderr] | ^^^^ help: consider using `_i18n` instead [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_variables)] on by default [INFO] [stderr] [INFO] [stderr] warning: unused variable: `mock3` [INFO] [stderr] --> src/router.rs:82:13 [INFO] [stderr] | [INFO] [stderr] 82 | let mock3 = config::prelude::MockService { [INFO] [stderr] | ^^^^^ help: consider using `_mock3` instead [INFO] [stderr] [INFO] [stderr] warning: unused variable: `some_response` [INFO] [stderr] --> src/mock_handler.rs:194:13 [INFO] [stderr] | [INFO] [stderr] 194 | let some_response = match unwrapped_result { [INFO] [stderr] | ^^^^^^^^^^^^^ help: consider using `_some_response` instead [INFO] [stderr] [INFO] [stderr] warning: value assigned to `response_type_holder` is never read [INFO] [stderr] --> src/config.rs:307:17 [INFO] [stderr] | [INFO] [stderr] 307 | let mut response_type_holder = "UNKNOWN"; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_assignments)] on by default [INFO] [stderr] [INFO] [stderr] warning: value assigned to `hbs_data_option` is never read [INFO] [stderr] --> src/config.rs:329:17 [INFO] [stderr] | [INFO] [stderr] 329 | let mut hbs_data_option = None; [INFO] [stderr] | ^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: unused variable: `e` [INFO] [stderr] --> src/config.rs:458:21 [INFO] [stderr] | [INFO] [stderr] 458 | Err(e) => { [INFO] [stderr] | ^ help: consider using `_e` instead [INFO] [stderr] [INFO] [stderr] warning: unused variable: `req` [INFO] [stderr] --> src/mock_handler.rs:107:22 [INFO] [stderr] | [INFO] [stderr] 107 | fn handle(&self, req: &Request, res: & mut Response, i18n: & i18n::I18n, request_info: &MockRequestInfo) -> Result>, log::StructuredError> { [INFO] [stderr] | ^^^ help: consider using `_req` instead [INFO] [stderr] [INFO] [stderr] warning: unused variable: `res` [INFO] [stderr] --> src/mock_handler.rs:107:43 [INFO] [stderr] | [INFO] [stderr] 107 | fn handle(&self, req: &Request, res: & mut Response, i18n: & i18n::I18n, request_info: &MockRequestInfo) -> Result>, log::StructuredError> { [INFO] [stderr] | ^^^ help: consider using `_res` instead [INFO] [stderr] [INFO] [stderr] warning: variable does not need to be mutable [INFO] [stderr] --> src/mock_handler.rs:139:13 [INFO] [stderr] | [INFO] [stderr] 139 | let mut response = Response::new(Body::from( contents )); [INFO] [stderr] | ----^^^^^^^^ [INFO] [stderr] | | [INFO] [stderr] | help: remove this `mut` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_mut)] on by default [INFO] [stderr] [INFO] [stderr] warning: method is never used: `init` [INFO] [stderr] --> src/i18n.rs:27:5 [INFO] [stderr] | [INFO] [stderr] 27 | pub fn init(&mut self, locale: String, path: String) { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(dead_code)] on by default [INFO] [stderr] [INFO] [stderr] warning: static item is never used: `NO_FILE_SPECIFIED` [INFO] [stderr] --> src/strings.rs:28:1 [INFO] [stderr] | [INFO] [stderr] 28 | pub static NO_FILE_SPECIFIED: usize = 26; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: writing `&String` instead of `&str` involves a new object where a slice will do. [INFO] [stderr] --> src/log.rs:119:31 [INFO] [stderr] | [INFO] [stderr] 119 | pub fn build_message(message: &String) -> StructuredMessage{ [INFO] [stderr] | ^^^^^^^ help: change this to: `&str` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::ptr_arg)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: writing `&String` instead of `&str` involves a new object where a slice will do. [INFO] [stderr] --> src/log.rs:122:57 [INFO] [stderr] | [INFO] [stderr] 122 | pub fn build_entering_message(i18n: & i18n::I18n, verb: &String, path: &String) -> StructuredMessage { [INFO] [stderr] | ^^^^^^^ help: change this to: `&str` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: writing `&String` instead of `&str` involves a new object where a slice will do. [INFO] [stderr] --> src/log.rs:122:72 [INFO] [stderr] | [INFO] [stderr] 122 | pub fn build_entering_message(i18n: & i18n::I18n, verb: &String, path: &String) -> StructuredMessage { [INFO] [stderr] | ^^^^^^^ help: change this to: `&str` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: writing `&String` instead of `&str` involves a new object where a slice will do. [INFO] [stderr] --> src/log.rs:126:55 [INFO] [stderr] | [INFO] [stderr] 126 | pub fn build_exiting_message(i18n: &i18n::I18n, verb: &String, path: &String) -> StructuredMessage{ [INFO] [stderr] | ^^^^^^^ help: change this to: `&str` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: writing `&String` instead of `&str` involves a new object where a slice will do. [INFO] [stderr] --> src/log.rs:126:70 [INFO] [stderr] | [INFO] [stderr] 126 | pub fn build_exiting_message(i18n: &i18n::I18n, verb: &String, path: &String) -> StructuredMessage{ [INFO] [stderr] | ^^^^^^^ help: change this to: `&str` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: writing `&String` instead of `&str` involves a new object where a slice will do. [INFO] [stderr] --> src/log.rs:158:29 [INFO] [stderr] | [INFO] [stderr] 158 | pub fn build_error(message: &String, status_code: StatusCode) -> StructuredError{ [INFO] [stderr] | ^^^^^^^ help: change this to: `&str` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: writing `&String` instead of `&str` involves a new object where a slice will do. [INFO] [stderr] --> src/log.rs:161:34 [INFO] [stderr] | [INFO] [stderr] 161 | pub fn build_file_error(message: &String, file: &String, status_code: StatusCode) -> StructuredError{ [INFO] [stderr] | ^^^^^^^ help: change this to: `&str` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: writing `&String` instead of `&str` involves a new object where a slice will do. [INFO] [stderr] --> src/log.rs:161:49 [INFO] [stderr] | [INFO] [stderr] 161 | pub fn build_file_error(message: &String, file: &String, status_code: StatusCode) -> StructuredError{ [INFO] [stderr] | ^^^^^^^ help: change this to: `&str` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: useless use of `format!` [INFO] [stderr] --> src/log.rs:229:41 [INFO] [stderr] | [INFO] [stderr] 229 | if Level::All == level { return format!("{}", self.prefix_all); } [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using .to_string(): `self.prefix_all.to_string()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::useless_format)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format [INFO] [stderr] = note: this error originates in a macro outside of the current crate (in Nightly builds, run with -Z external-macro-backtrace for more info) [INFO] [stderr] [INFO] [stderr] warning: useless use of `format!` [INFO] [stderr] --> src/log.rs:230:43 [INFO] [stderr] | [INFO] [stderr] 230 | if Level::Trace == level { return format!("{}", self.prefix_trace); } [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using .to_string(): `self.prefix_trace.to_string()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format [INFO] [stderr] = note: this error originates in a macro outside of the current crate (in Nightly builds, run with -Z external-macro-backtrace for more info) [INFO] [stderr] [INFO] [stderr] warning: useless use of `format!` [INFO] [stderr] --> src/log.rs:231:43 [INFO] [stderr] | [INFO] [stderr] 231 | if Level::Debug == level { return format!("{}", self.prefix_debug); } [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using .to_string(): `self.prefix_debug.to_string()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format [INFO] [stderr] = note: this error originates in a macro outside of the current crate (in Nightly builds, run with -Z external-macro-backtrace for more info) [INFO] [stderr] [INFO] [stderr] warning: useless use of `format!` [INFO] [stderr] --> src/log.rs:232:42 [INFO] [stderr] | [INFO] [stderr] 232 | if Level::Info == level { return format!("{}", self.prefix_info); } [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using .to_string(): `self.prefix_info.to_string()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format [INFO] [stderr] = note: this error originates in a macro outside of the current crate (in Nightly builds, run with -Z external-macro-backtrace for more info) [INFO] [stderr] [INFO] [stderr] warning: useless use of `format!` [INFO] [stderr] --> src/log.rs:233:45 [INFO] [stderr] | [INFO] [stderr] 233 | if Level::Warning == level { return format!("{}", self.prefix_warning); } [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using .to_string(): `self.prefix_warning.to_string()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format [INFO] [stderr] = note: this error originates in a macro outside of the current crate (in Nightly builds, run with -Z external-macro-backtrace for more info) [INFO] [stderr] [INFO] [stderr] warning: useless use of `format!` [INFO] [stderr] --> src/log.rs:234:43 [INFO] [stderr] | [INFO] [stderr] 234 | if Level::Error == level { return format!("{}", self.prefix_error); } [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using .to_string(): `self.prefix_error.to_string()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format [INFO] [stderr] = note: this error originates in a macro outside of the current crate (in Nightly builds, run with -Z external-macro-backtrace for more info) [INFO] [stderr] [INFO] [stderr] warning: useless use of `format!` [INFO] [stderr] --> src/log.rs:235:48 [INFO] [stderr] | [INFO] [stderr] 235 | if Level::FatalError == level { return format!("{}", self.prefix_fatal_error); } [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using .to_string(): `self.prefix_fatal_error.to_string()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format [INFO] [stderr] = note: this error originates in a macro outside of the current crate (in Nightly builds, run with -Z external-macro-backtrace for more info) [INFO] [stderr] [INFO] [stderr] warning: the function has a cyclomatic complexity of 57 [INFO] [stderr] --> src/log.rs:299:5 [INFO] [stderr] | [INFO] [stderr] 299 | / fn test_can_and_set() { [INFO] [stderr] 300 | | let i18n = i18n::I18n::new(i18n::DEFAULT_LOCALE.to_string(), i18n::DEFAULT_PATH.to_string()); [INFO] [stderr] 301 | | let mut log = log::Log::new(log::Level::All, &i18n); [INFO] [stderr] 302 | | assert_eq!(log.can( log::Level::FatalError), true); [INFO] [stderr] ... | [INFO] [stderr] 364 | | assert_eq!(log.can( log::Level::All), false); [INFO] [stderr] 365 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cyclomatic_complexity)] on by default [INFO] [stderr] = help: you could split it up into multiple smaller functions [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cyclomatic_complexity [INFO] [stderr] [INFO] [stderr] warning: the function has a cyclomatic complexity of 361 [INFO] [stderr] --> src/log.rs:368:5 [INFO] [stderr] | [INFO] [stderr] 368 | / fn test_macros() { [INFO] [stderr] 369 | | let i18n = i18n::I18n::new(i18n::DEFAULT_LOCALE.to_string(), i18n::DEFAULT_PATH.to_string()); [INFO] [stderr] 370 | | let mut log = log::Log::new(log::Level::All, &i18n); [INFO] [stderr] 371 | | assert_eq!(structured_log!(log, log::Level::FatalError, "FATAL_ERROR" ).ends_with( "\"FATAL ERROR\", \"entry\": FATAL_ERROR }" ), true); [INFO] [stderr] ... | [INFO] [stderr] 516 | | assert_eq!( log_text.ends_with( "\"FATAL ERROR\", \"entry\": Log Text one.two.three.four.five }" ), true); [INFO] [stderr] 517 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = help: you could split it up into multiple smaller functions [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cyclomatic_complexity [INFO] [stderr] [INFO] [stderr] warning: this boolean expression can be simplified [INFO] [stderr] --> src/config.rs:148:12 [INFO] [stderr] | [INFO] [stderr] 148 | if !open_result.is_ok() { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: try: `open_result.is_err()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::nonminimal_bool)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stderr] [INFO] [stderr] warning: this boolean expression can be simplified [INFO] [stderr] --> src/config.rs:165:12 [INFO] [stderr] | [INFO] [stderr] 165 | if !read_result.is_ok() { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: try: `read_result.is_err()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stderr] [INFO] [stderr] warning: this boolean expression can be simplified [INFO] [stderr] --> src/config.rs:188:12 [INFO] [stderr] | [INFO] [stderr] 188 | if !mocks.is_ok() { [INFO] [stderr] | ^^^^^^^^^^^^^^ help: try: `mocks.is_err()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stderr] [INFO] [stderr] warning: this boolean expression can be simplified [INFO] [stderr] --> src/config.rs:245:16 [INFO] [stderr] | [INFO] [stderr] 245 | if !mock.is_ok() { [INFO] [stderr] | ^^^^^^^^^^^^^ help: try: `mock.is_err()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/config.rs:255:13 [INFO] [stderr] | [INFO] [stderr] 255 | / match unwrapped_mock { [INFO] [stderr] 256 | | Some(p) => { built_mocks.push(p); }, [INFO] [stderr] 257 | | None => {} [INFO] [stderr] 258 | | } [INFO] [stderr] | |_____________^ help: try this: `if let Some(p) = unwrapped_mock { built_mocks.push(p); }` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::single_match)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/config.rs:260:12 [INFO] [stderr] | [INFO] [stderr] 260 | if 0 == built_mocks.len() { return Ok(None); } [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `built_mocks.is_empty()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::len_zero)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: this boolean expression can be simplified [INFO] [stderr] --> src/config.rs:301:12 [INFO] [stderr] | [INFO] [stderr] 301 | if !response_result.is_ok() { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `response_result.is_err()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stderr] [INFO] [stderr] warning: this boolean expression can be simplified [INFO] [stderr] --> src/config.rs:360:12 [INFO] [stderr] | [INFO] [stderr] 360 | if !authorization_result.is_ok() { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `authorization_result.is_err()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stderr] [INFO] [stderr] warning: this boolean expression can be simplified [INFO] [stderr] --> src/config.rs:372:12 [INFO] [stderr] | [INFO] [stderr] 372 | if !headers_result.is_ok() { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^ help: try: `headers_result.is_err()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stderr] [INFO] [stderr] warning: this boolean expression can be simplified [INFO] [stderr] --> src/config.rs:379:12 [INFO] [stderr] | [INFO] [stderr] 379 | if !cookies_result.is_ok() { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^ help: try: `cookies_result.is_err()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stderr] [INFO] [stderr] warning: the function has a cyclomatic complexity of 49 [INFO] [stderr] --> src/config.rs:263:5 [INFO] [stderr] | [INFO] [stderr] 263 | / fn build_mock (&self, mock_value: &Value) -> Result, log::StructuredError>{ [INFO] [stderr] 264 | | if mock_value.is_null() { return Ok(None); } [INFO] [stderr] 265 | | let error = log::StructuredError::Error{ [INFO] [stderr] 266 | | message: self.i18n.get(strings::INVALID_MOCK_DATA_IN_CONFIG), [INFO] [stderr] ... | [INFO] [stderr] 398 | | )); [INFO] [stderr] 399 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = help: you could split it up into multiple smaller functions [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cyclomatic_complexity [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/config.rs:439:13 [INFO] [stderr] | [INFO] [stderr] 439 | / match headers_option.as_array() { [INFO] [stderr] 440 | | Some(ref p) => { [INFO] [stderr] 441 | | for element in p.iter() { [INFO] [stderr] 442 | | match self.build_header(element) { [INFO] [stderr] ... | [INFO] [stderr] 453 | | None => { /* Can't get here from there */ } [INFO] [stderr] 454 | | }; [INFO] [stderr] | |_____________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 439 | if let Some(ref p) = headers_option.as_array() { [INFO] [stderr] 440 | for element in p.iter() { [INFO] [stderr] 441 | match self.build_header(element) { [INFO] [stderr] 442 | Ok(h) => header_array.push(h), [INFO] [stderr] 443 | Err(_e) => { [INFO] [stderr] 444 | structured_error!(self.log, "{}", header_error); [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/config.rs:451:24 [INFO] [stderr] | [INFO] [stderr] 451 | if 0 == header_array.len() { return Ok(None); } [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `header_array.is_empty()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/config.rs:521:13 [INFO] [stderr] | [INFO] [stderr] 521 | / match cookies_option.as_array() { [INFO] [stderr] 522 | | Some(ref p) => { [INFO] [stderr] 523 | | for element in p.iter() { [INFO] [stderr] 524 | | match self.build_cookie(element) { [INFO] [stderr] ... | [INFO] [stderr] 535 | | None => { /* Can't get here from there */ } [INFO] [stderr] 536 | | }; [INFO] [stderr] | |_____________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 521 | if let Some(ref p) = cookies_option.as_array() { [INFO] [stderr] 522 | for element in p.iter() { [INFO] [stderr] 523 | match self.build_cookie(element) { [INFO] [stderr] 524 | Ok(c) => cookie_array.push(c), [INFO] [stderr] 525 | Err(_e) => { [INFO] [stderr] 526 | structured_error!(self.log, "{}", cookie_error); [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/config.rs:533:24 [INFO] [stderr] | [INFO] [stderr] 533 | if 0 == cookie_array.len() { return Ok(None); } [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `cookie_array.is_empty()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to match on a boolean expression [INFO] [stderr] --> src/config.rs:559:9 [INFO] [stderr] | [INFO] [stderr] 559 | / match response_option.is_array() { [INFO] [stderr] 560 | | true => { [INFO] [stderr] 561 | | let a = response_option.as_array(); [INFO] [stderr] 562 | | match a { [INFO] [stderr] ... | [INFO] [stderr] 618 | | }, [INFO] [stderr] 619 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::match_bool)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_bool [INFO] [stderr] help: consider using an if/else expression [INFO] [stderr] | [INFO] [stderr] 559 | if response_option.is_array() { [INFO] [stderr] 560 | let a = response_option.as_array(); [INFO] [stderr] 561 | match a { [INFO] [stderr] 562 | Some(p) => { [INFO] [stderr] 563 | let mut response_array = vec![]; [INFO] [stderr] 564 | match p[0].is_string() { [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to match on a boolean expression [INFO] [stderr] --> src/config.rs:565:25 [INFO] [stderr] | [INFO] [stderr] 565 | / match p[0].is_string() { [INFO] [stderr] 566 | | true => { [INFO] [stderr] 567 | | // println!("STRING ARRAY"); [INFO] [stderr] 568 | | for string_response in p { response_array.push(string_response.as_str().unwrap().to_string()); } [INFO] [stderr] ... | [INFO] [stderr] 589 | | }, [INFO] [stderr] 590 | | } [INFO] [stderr] | |_________________________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_bool [INFO] [stderr] help: consider using an if/else expression [INFO] [stderr] | [INFO] [stderr] 565 | if p[0].is_string() { [INFO] [stderr] 566 | // println!("STRING ARRAY"); [INFO] [stderr] 567 | for string_response in p { response_array.push(string_response.as_str().unwrap().to_string()); } [INFO] [stderr] 568 | return Ok(Response { [INFO] [stderr] 569 | string: None, [INFO] [stderr] 570 | string_array: Some (ResponseStringArray { [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to match on a boolean expression [INFO] [stderr] --> src/config.rs:599:22 [INFO] [stderr] | [INFO] [stderr] 599 | false => match response_option.is_string() { [INFO] [stderr] | ______________________^ [INFO] [stderr] 600 | | true => { [INFO] [stderr] 601 | | // println!("STRING"); [INFO] [stderr] 602 | | return Ok(Response { [INFO] [stderr] ... | [INFO] [stderr] 617 | | }, [INFO] [stderr] 618 | | }, [INFO] [stderr] | |_____________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_bool [INFO] [stderr] help: consider using an if/else expression [INFO] [stderr] | [INFO] [stderr] 599 | false => if response_option.is_string() { [INFO] [stderr] 600 | // println!("STRING"); [INFO] [stderr] 601 | return Ok(Response { [INFO] [stderr] 602 | string: Some (ResponseString { response: response_option.as_str().unwrap().to_string( )}), [INFO] [stderr] 603 | string_array: None, [INFO] [stderr] 604 | json: None, [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/config.rs:650:12 [INFO] [stderr] | [INFO] [stderr] 650 | if 0 == group_array.len() { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `group_array.is_empty()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: the function has a cyclomatic complexity of 46 [INFO] [stderr] --> src/config.rs:780:5 [INFO] [stderr] | [INFO] [stderr] 780 | / fn test_build_cookies() { [INFO] [stderr] 781 | | let config_builder = ConfigBuilder::new(i18n::DEFAULT_LOCALE.to_string(), i18n::DEFAULT_PATH.to_string()); [INFO] [stderr] 782 | | let result = config_builder.read_config("./test/config/cookies.json".to_string()); [INFO] [stderr] 783 | | assert_eq!(result.is_ok(), true); [INFO] [stderr] ... | [INFO] [stderr] 870 | | assert_eq!(cookies4.is_ok(), false); [INFO] [stderr] 871 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = help: you could split it up into multiple smaller functions [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cyclomatic_complexity [INFO] [stderr] [INFO] [stderr] warning: the function has a cyclomatic complexity of 59 [INFO] [stderr] --> src/config.rs:874:5 [INFO] [stderr] | [INFO] [stderr] 874 | / fn test_build_response() { [INFO] [stderr] 875 | | let config_builder = ConfigBuilder::new(i18n::DEFAULT_LOCALE.to_string(), i18n::DEFAULT_PATH.to_string()); [INFO] [stderr] 876 | | let result = config_builder.read_config("./test/config/response-string.json".to_string()); [INFO] [stderr] 877 | | assert_eq!(result.is_ok(), true); [INFO] [stderr] ... | [INFO] [stderr] 980 | | }; [INFO] [stderr] 981 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = help: you could split it up into multiple smaller functions [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cyclomatic_complexity [INFO] [stderr] [INFO] [stderr] warning: the function has a cyclomatic complexity of 173 [INFO] [stderr] --> src/config.rs:1031:5 [INFO] [stderr] | [INFO] [stderr] 1031 | / fn test_build_mock() { [INFO] [stderr] 1032 | | let config_builder = ConfigBuilder::new(i18n::DEFAULT_LOCALE.to_string(), i18n::DEFAULT_PATH.to_string()); [INFO] [stderr] 1033 | | let result = config_builder.read_config("./test/config/mock-string.json".to_string()); [INFO] [stderr] 1034 | | assert_eq!(result.is_ok(), true); [INFO] [stderr] ... | [INFO] [stderr] 1348 | | assert_eq!(mock10.is_ok(), false); [INFO] [stderr] 1349 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = help: you could split it up into multiple smaller functions [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cyclomatic_complexity [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/config.rs:1399:9 [INFO] [stderr] | [INFO] [stderr] 1399 | / match unwrapped_config.mocks { [INFO] [stderr] 1400 | | Some(_p) =>{ [INFO] [stderr] 1401 | | assert_eq!(false, true); [INFO] [stderr] 1402 | | return; [INFO] [stderr] 1403 | | }, [INFO] [stderr] 1404 | | None => { } [INFO] [stderr] 1405 | | }; [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 1399 | if let Some(_p) = unwrapped_config.mocks { [INFO] [stderr] 1400 | assert_eq!(false, true); [INFO] [stderr] 1401 | return; [INFO] [stderr] 1402 | }; [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: writing `&String` instead of `&str` involves a new object where a slice will do. [INFO] [stderr] --> src/mock_handler.rs:25:26 [INFO] [stderr] | [INFO] [stderr] 25 | pub fn new(username: &String) -> UserInfo { [INFO] [stderr] | ^^^^^^^ help: change this to: `&str` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: this boolean expression can be simplified [INFO] [stderr] --> src/mock_handler.rs:118:12 [INFO] [stderr] | [INFO] [stderr] 118 | if !open_result.is_ok() { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: try: `open_result.is_err()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stderr] [INFO] [stderr] warning: this boolean expression can be simplified [INFO] [stderr] --> src/mock_handler.rs:130:12 [INFO] [stderr] | [INFO] [stderr] 130 | if !read_result.is_ok() { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: try: `read_result.is_err()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stderr] [INFO] [stderr] warning: `ref` on an entire `let` pattern is discouraged, take a reference with `&` instead [INFO] [stderr] --> src/mock_handler.rs:111:13 [INFO] [stderr] | [INFO] [stderr] 111 | let ref mock_service = &request_info.mock_service_info; [INFO] [stderr] | ----^^^^^^^^^^^^^^^^----------------------------------- help: try: `let mock_service = &(&request_info.mock_service_info);` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::toplevel_ref_arg)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#toplevel_ref_arg [INFO] [stderr] [INFO] [stderr] warning: this boolean expression can be simplified [INFO] [stderr] --> src/main.rs:74:8 [INFO] [stderr] | [INFO] [stderr] 74 | if !read_result.is_ok(){ [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: try: `read_result.is_err()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stderr] [INFO] [stderr] warning: this boolean expression can be simplified [INFO] [stderr] --> src/main.rs:81:8 [INFO] [stderr] | [INFO] [stderr] 81 | if !parse_result.is_ok(){ [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^ help: try: `parse_result.is_err()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stderr] [INFO] [stderr] warning: this boolean expression can be simplified [INFO] [stderr] --> src/main.rs:89:8 [INFO] [stderr] | [INFO] [stderr] 89 | if !build_result.is_ok(){ [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^ help: try: `build_result.is_err()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/main.rs:102:5 [INFO] [stderr] | [INFO] [stderr] 102 | / match config.mocks { [INFO] [stderr] 103 | | Some(p) => { [INFO] [stderr] 104 | | for mock in p.iter() { [INFO] [stderr] 105 | | let route = router::Route::new( &mock.verb, &mock.path ); [INFO] [stderr] ... | [INFO] [stderr] 123 | | None => {} [INFO] [stderr] 124 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 102 | if let Some(p) = config.mocks { [INFO] [stderr] 103 | for mock in p.iter() { [INFO] [stderr] 104 | let route = router::Route::new( &mock.verb, &mock.path ); [INFO] [stderr] 105 | let user_info = mock_handler::UserInfo::new( &"USER".to_string() ); [INFO] [stderr] 106 | let log_for_mock = match mock.logging.clone() { [INFO] [stderr] 107 | Some(q) => { [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: this boolean expression can be simplified [INFO] [stderr] --> src/main.rs:131:8 [INFO] [stderr] | [INFO] [stderr] 131 | if !result.is_ok() { [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: try: `result.is_err()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 39.25s [INFO] running `"docker" "inspect" "d5859f8ec59d34582bd9dbcbe214ef52cc6597867deaa3a557fc31d2b56802b4"` [INFO] running `"docker" "rm" "-f" "d5859f8ec59d34582bd9dbcbe214ef52cc6597867deaa3a557fc31d2b56802b4"` [INFO] [stdout] d5859f8ec59d34582bd9dbcbe214ef52cc6597867deaa3a557fc31d2b56802b4