[INFO] updating cached repository davbo/cryptopals [INFO] running `"git" "fetch" "--all"` [INFO] [stdout] Fetching origin [INFO] [stderr] From git://github.com/davbo/cryptopals [INFO] [stderr] * branch HEAD -> FETCH_HEAD [INFO] running `"git" "clone" "work/cache/sources/gh/davbo/cryptopals" "work/ex/clippy-test-run/sources/stable/gh/davbo/cryptopals"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/davbo/cryptopals'... [INFO] [stderr] done. [INFO] running `"git" "clone" "work/cache/sources/gh/davbo/cryptopals" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/davbo/cryptopals"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/davbo/cryptopals'... [INFO] [stderr] done. [INFO] running `"git" "rev-parse" "HEAD"` [INFO] [stdout] fc44233cda34a14c7f4ef54b5bf8d0bff9e83b85 [INFO] sha for GitHub repo davbo/cryptopals: fc44233cda34a14c7f4ef54b5bf8d0bff9e83b85 [INFO] validating manifest of davbo/cryptopals on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of davbo/cryptopals on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing davbo/cryptopals [INFO] finished frobbing davbo/cryptopals [INFO] frobbed toml for davbo/cryptopals written to work/ex/clippy-test-run/sources/stable/gh/davbo/cryptopals/Cargo.toml [INFO] started frobbing davbo/cryptopals [INFO] finished frobbing davbo/cryptopals [INFO] frobbed toml for davbo/cryptopals written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/davbo/cryptopals/Cargo.toml [INFO] crate davbo/cryptopals has a lockfile. skipping [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting davbo/cryptopals against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-0/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/gh/davbo/cryptopals:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 5bc4122c8a3a2601f363f839eeacb056c0905818d1b467d3f3fba0dcfc9d16e2 [INFO] running `"docker" "start" "-a" "5bc4122c8a3a2601f363f839eeacb056c0905818d1b467d3f3fba0dcfc9d16e2"` [INFO] [stderr] Compiling openssl v0.10.8 [INFO] [stderr] Checking rand v0.5.0 [INFO] [stderr] Checking openssl-sys v0.9.31 [INFO] [stderr] Checking matasano v0.0.1 (/opt/crater/workdir) [INFO] [stderr] warning: unused import: `set1::challenge8::score_ciphertext_for_ecb_mode` [INFO] [stderr] --> src/set2/challenge12.rs:5:5 [INFO] [stderr] | [INFO] [stderr] 5 | use set1::challenge8::score_ciphertext_for_ecb_mode; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_imports)] on by default [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/set2/challenge12.rs:11:17 [INFO] [stderr] | [INFO] [stderr] 11 | const MESSAGE: &'static str = "Um9sbGluJyBpbiBteSA1LjAKV2l0aCBteSByYWctdG9wIGRvd24gc28gbXkg [INFO] [stderr] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::const_static_lifetime)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/set2/challenge12.rs:15:13 [INFO] [stderr] | [INFO] [stderr] 15 | const KEY: &'static [u8] = b"YELLOW SUBMARINE"; [INFO] [stderr] | -^^^^^^^----- help: consider removing `'static`: `&[u8]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/set2/challenge13.rs:6:13 [INFO] [stderr] | [INFO] [stderr] 6 | const KEY: &'static [u8] = b"YELLOW SUBMARINE"; [INFO] [stderr] | -^^^^^^^----- help: consider removing `'static`: `&[u8]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/set2/challenge14.rs:7:17 [INFO] [stderr] | [INFO] [stderr] 7 | const MESSAGE: &'static [u8] = b"Um9sbGluJyBpbiBteSA1LjAKV2l0aCBteSByYWctdG9wIGRvd24gc28gbXkg [INFO] [stderr] | -^^^^^^^----- help: consider removing `'static`: `&[u8]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/set3/challenge17.rs:9:24 [INFO] [stderr] | [INFO] [stderr] 9 | const INPUT_STRINGS: [&'static str; 10] = [ [INFO] [stderr] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/set1/challenge6.rs:74:24 [INFO] [stderr] | [INFO] [stderr] 74 | if key_score > 500000 { [INFO] [stderr] | ^^^^^^ help: consider: `500_000` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::unreadable_literal)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/set2/challenge12.rs:11:17 [INFO] [stderr] | [INFO] [stderr] 11 | const MESSAGE: &'static str = "Um9sbGluJyBpbiBteSA1LjAKV2l0aCBteSByYWctdG9wIGRvd24gc28gbXkg [INFO] [stderr] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::const_static_lifetime)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/set2/challenge12.rs:15:13 [INFO] [stderr] | [INFO] [stderr] 15 | const KEY: &'static [u8] = b"YELLOW SUBMARINE"; [INFO] [stderr] | -^^^^^^^----- help: consider removing `'static`: `&[u8]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/set2/challenge13.rs:6:13 [INFO] [stderr] | [INFO] [stderr] 6 | const KEY: &'static [u8] = b"YELLOW SUBMARINE"; [INFO] [stderr] | -^^^^^^^----- help: consider removing `'static`: `&[u8]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: unnecessary parentheses around `while` condition [INFO] [stderr] --> src/set2/challenge13.rs:72:11 [INFO] [stderr] | [INFO] [stderr] 72 | while (test_len == len_enc) { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^ help: remove these parentheses [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_parens)] on by default [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/set2/challenge14.rs:7:17 [INFO] [stderr] | [INFO] [stderr] 7 | const MESSAGE: &'static [u8] = b"Um9sbGluJyBpbiBteSA1LjAKV2l0aCBteSByYWctdG9wIGRvd24gc28gbXkg [INFO] [stderr] | -^^^^^^^----- help: consider removing `'static`: `&[u8]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/set3/challenge17.rs:9:24 [INFO] [stderr] | [INFO] [stderr] 9 | const INPUT_STRINGS: [&'static str; 10] = [ [INFO] [stderr] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: value assigned to `sanitised_input` is never read [INFO] [stderr] --> src/set2/challenge13.rs:17:17 [INFO] [stderr] | [INFO] [stderr] 17 | let mut sanitised_input = String::new(); [INFO] [stderr] | ^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_assignments)] on by default [INFO] [stderr] [INFO] [stderr] warning: constant item is never used: `KEY` [INFO] [stderr] --> src/set2/challenge13.rs:6:1 [INFO] [stderr] | [INFO] [stderr] 6 | const KEY: &'static [u8] = b"YELLOW SUBMARINE"; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(dead_code)] on by default [INFO] [stderr] [INFO] [stderr] warning: struct is never constructed: `Profile` [INFO] [stderr] --> src/set2/challenge13.rs:8:1 [INFO] [stderr] | [INFO] [stderr] 8 | struct Profile { [INFO] [stderr] | ^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: method is never used: `new` [INFO] [stderr] --> src/set2/challenge13.rs:16:5 [INFO] [stderr] | [INFO] [stderr] 16 | pub fn new(email: String) -> Profile { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: function is never used: `encrypt` [INFO] [stderr] --> src/set2/challenge13.rs:35:1 [INFO] [stderr] | [INFO] [stderr] 35 | fn encrypt(plaintext: String) -> Vec { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: function is never used: `decrypt` [INFO] [stderr] --> src/set2/challenge13.rs:40:1 [INFO] [stderr] | [INFO] [stderr] 40 | fn decrypt(ciphertext: Vec) -> String { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: constant item is never used: `MESSAGE` [INFO] [stderr] --> src/set2/challenge14.rs:7:1 [INFO] [stderr] | [INFO] [stderr] 7 | / const MESSAGE: &'static [u8] = b"Um9sbGluJyBpbiBteSA1LjAKV2l0aCBteSByYWctdG9wIGRvd24gc28gbXkg [INFO] [stderr] 8 | | aGFpciBjYW4gYmxvdwpUaGUgZ2lybGllcyBvbiBzdGFuZGJ5IHdhdmluZyBq [INFO] [stderr] 9 | | dXN0IHRvIHNheSBoaQpEaWQgeW91IHN0b3A/IE5vLCBJIGp1c3QgZHJvdmUg [INFO] [stderr] 10 | | YnkK"; [INFO] [stderr] | |______^ [INFO] [stderr] [INFO] [stderr] warning: function is never used: `random_input` [INFO] [stderr] --> src/set2/challenge14.rs:12:1 [INFO] [stderr] | [INFO] [stderr] 12 | fn random_input() -> Vec { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: function is never used: `encryption_oracle` [INFO] [stderr] --> src/set2/challenge14.rs:20:1 [INFO] [stderr] | [INFO] [stderr] 20 | fn encryption_oracle(attacker_input: &[u8]) -> Vec { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: function is never used: `find_target_permutation` [INFO] [stderr] --> src/set2/challenge14.rs:27:1 [INFO] [stderr] | [INFO] [stderr] 27 | fn find_target_permutation(byte_index: usize, block_size: usize, marker_cipher: Vec, decrypted_bytes: &[u8]) -> Vec { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: function is never used: `test_byte` [INFO] [stderr] --> src/set2/challenge14.rs:56:1 [INFO] [stderr] | [INFO] [stderr] 56 | fn test_byte(candidate: u8, byte_index: usize, block_size: usize, marker_cipher: Vec, target_permutation: Vec, decrypted_bytes: &[u8]) -> bool { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: function is never used: `find_marker_block` [INFO] [stderr] --> src/set2/challenge14.rs:91:1 [INFO] [stderr] | [INFO] [stderr] 91 | fn find_marker_block(block_size: usize) -> Vec { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: constant item is never used: `BLOCK_LENGTH` [INFO] [stderr] --> src/set3/challenge17.rs:7:1 [INFO] [stderr] | [INFO] [stderr] 7 | const BLOCK_LENGTH: usize = 16; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: constant item is never used: `INPUT_STRINGS` [INFO] [stderr] --> src/set3/challenge17.rs:9:1 [INFO] [stderr] | [INFO] [stderr] 9 | / const INPUT_STRINGS: [&'static str; 10] = [ [INFO] [stderr] 10 | | "MDAwMDAwTm93IHRoYXQgdGhlIHBhcnR5IGlzIGp1bXBpbmc=", [INFO] [stderr] 11 | | "MDAwMDAxV2l0aCB0aGUgYmFzcyBraWNrZWQgaW4gYW5kIHRoZSBWZWdhJ3MgYXJlIHB1bXBpbic=", [INFO] [stderr] 12 | | "MDAwMDAyUXVpY2sgdG8gdGhlIHBvaW50LCB0byB0aGUgcG9pbnQsIG5vIGZha2luZw==", [INFO] [stderr] ... | [INFO] [stderr] 19 | | "MDAwMDA5aXRoIG15IHJhZy10b3AgZG93biBzbyBteSBoYWlyIGNhbiBibG93", [INFO] [stderr] 20 | | ]; [INFO] [stderr] | |__^ [INFO] [stderr] [INFO] [stderr] warning: function is never used: `pad` [INFO] [stderr] --> src/set3/challenge17.rs:22:1 [INFO] [stderr] | [INFO] [stderr] 22 | fn pad(mut input: Vec) -> Vec { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: function is never used: `decrypt_and_check_padding` [INFO] [stderr] --> src/set3/challenge17.rs:34:1 [INFO] [stderr] | [INFO] [stderr] 34 | fn decrypt_and_check_padding(ciphertext: Vec, key: &[u8], iv: &[u8]) -> bool { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: function is never used: `test_byte` [INFO] [stderr] --> src/set3/challenge17.rs:42:1 [INFO] [stderr] | [INFO] [stderr] 42 | fn test_byte(guess: u8, target_index: usize, attacking_block: Vec, discovered_bytes: &Vec, key: &[u8]) -> Result { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/set1/challenge3.rs:37:30 [INFO] [stderr] | [INFO] [stderr] 37 | pub fn score_bytes(to_score: &Vec, corpus: &BTreeMap) -> usize { [INFO] [stderr] | ^^^^^^^^ help: change this to: `&[u8]` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::ptr_arg)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u32 may become silently lossy if types change [INFO] [stderr] --> src/set1/challenge3.rs:40:25 [INFO] [stderr] | [INFO] [stderr] 40 | let map_index = *byte as u32; [INFO] [stderr] | ^^^^^^^^^^^^ help: try: `u32::from(*byte)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cast_lossless)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/set1/challenge3.rs:41:9 [INFO] [stderr] | [INFO] [stderr] 41 | / match corpus.get(&map_index) { [INFO] [stderr] 42 | | Some(char_score) => { score += *char_score; } [INFO] [stderr] 43 | | None => {}, [INFO] [stderr] 44 | | } [INFO] [stderr] | |_________^ help: try this: `if let Some(char_score) = corpus.get(&map_index) { score += *char_score; }` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::single_match)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/set1/challenge5.rs:3:32 [INFO] [stderr] | [INFO] [stderr] 3 | pub fn rotating_key_xor(input: &Vec, key: &[u8]) -> Vec { [INFO] [stderr] | ^^^^^^^^ help: change this to: `&[u8]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: this `.fold` can be written more succinctly using another method [INFO] [stderr] --> src/set1/challenge6.rs:9:41 [INFO] [stderr] | [INFO] [stderr] 9 | .map(|xored| xored.count_ones()) [INFO] [stderr] | _________________________________________^ [INFO] [stderr] 10 | | .fold(0, |acc, item| acc + item); [INFO] [stderr] | |________________________________________^ help: try: `.sum()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::unnecessary_fold)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_fold [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/set1/challenge6.rs:15:54 [INFO] [stderr] | [INFO] [stderr] 15 | pub fn score_keysize(keysize: usize, encrypted_data: &Vec) -> usize { [INFO] [stderr] | ^^^^^^^^ help: change this to: `&[u8]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: this `.fold` can be written more succinctly using another method [INFO] [stderr] --> src/set1/challenge6.rs:20:7 [INFO] [stderr] | [INFO] [stderr] 20 | }).fold(0, |acc, item| acc + item); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `.sum()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_fold [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/set1/challenge6.rs:24:57 [INFO] [stderr] | [INFO] [stderr] 24 | pub fn transpose_blocks(keysize: usize, encrypted_data: &Vec) -> Vec> { [INFO] [stderr] | ^^^^^^^^ help: change this to: `&[u8]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: this `.fold` can be written more succinctly using another method [INFO] [stderr] --> src/set1/challenge8.rs:25:11 [INFO] [stderr] | [INFO] [stderr] 25 | summer.fold(0, |acc, item| acc + item) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `.sum()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_fold [INFO] [stderr] [INFO] [stderr] warning: this boolean expression can be simplified [INFO] [stderr] --> src/set2/challenge14.rs:40:16 [INFO] [stderr] | [INFO] [stderr] 40 | if !remaining.peek().is_none() { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `remaining.peek().is_some()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::nonminimal_bool)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stderr] [INFO] [stderr] warning: this boolean expression can be simplified [INFO] [stderr] --> src/set2/challenge14.rs:74:16 [INFO] [stderr] | [INFO] [stderr] 74 | if !remaining.peek().is_none() { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `remaining.peek().is_some()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stderr] [INFO] [stderr] warning: taken reference of right operand [INFO] [stderr] --> src/set2/challenge14.rs:98:12 [INFO] [stderr] | [INFO] [stderr] 98 | if value > &most_repeats { [INFO] [stderr] | ^^^^^^^^------------- [INFO] [stderr] | | [INFO] [stderr] | help: use the right value directly: `most_repeats` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::op_ref)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#op_ref [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/set3/challenge17.rs:42:90 [INFO] [stderr] | [INFO] [stderr] 42 | fn test_byte(guess: u8, target_index: usize, attacking_block: Vec, discovered_bytes: &Vec, key: &[u8]) -> Result { [INFO] [stderr] | ^^^^^^^^ help: change this to: `&[u8]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: value assigned to `sanitised_input` is never read [INFO] [stderr] --> src/set2/challenge13.rs:17:17 [INFO] [stderr] | [INFO] [stderr] 17 | let mut sanitised_input = String::new(); [INFO] [stderr] | ^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_assignments)] on by default [INFO] [stderr] [INFO] [stderr] warning: variable does not need to be mutable [INFO] [stderr] --> src/set2/challenge13.rs:70:9 [INFO] [stderr] | [INFO] [stderr] 70 | let mut len_enc = encrypt(Profile::new(test_email.clone()).to_string()).len(); [INFO] [stderr] | ----^^^^^^^ [INFO] [stderr] | | [INFO] [stderr] | help: remove this `mut` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_mut)] on by default [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/set1/challenge3.rs:37:30 [INFO] [stderr] | [INFO] [stderr] 37 | pub fn score_bytes(to_score: &Vec, corpus: &BTreeMap) -> usize { [INFO] [stderr] | ^^^^^^^^ help: change this to: `&[u8]` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::ptr_arg)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u32 may become silently lossy if types change [INFO] [stderr] --> src/set1/challenge3.rs:40:25 [INFO] [stderr] | [INFO] [stderr] 40 | let map_index = *byte as u32; [INFO] [stderr] | ^^^^^^^^^^^^ help: try: `u32::from(*byte)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cast_lossless)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/set1/challenge3.rs:41:9 [INFO] [stderr] | [INFO] [stderr] 41 | / match corpus.get(&map_index) { [INFO] [stderr] 42 | | Some(char_score) => { score += *char_score; } [INFO] [stderr] 43 | | None => {}, [INFO] [stderr] 44 | | } [INFO] [stderr] | |_________^ help: try this: `if let Some(char_score) = corpus.get(&map_index) { score += *char_score; }` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::single_match)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/set1/challenge4.rs:14:9 [INFO] [stderr] | [INFO] [stderr] 14 | / match encrypted_message { [INFO] [stderr] 15 | | Ok(candidate) => { [INFO] [stderr] 16 | | let mut results = single_character_xor(&candidate.from_hex().unwrap()); [INFO] [stderr] 17 | | if results.len() > 0 { [INFO] [stderr] ... | [INFO] [stderr] 25 | | Err(_) => {} [INFO] [stderr] 26 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 14 | if let Ok(candidate) = encrypted_message { [INFO] [stderr] 15 | let mut results = single_character_xor(&candidate.from_hex().unwrap()); [INFO] [stderr] 16 | if results.len() > 0 { [INFO] [stderr] 17 | let (best_score, _, ref msg) = results.pop().unwrap(); [INFO] [stderr] 18 | if best_score > 6500 { [INFO] [stderr] 19 | assert_eq!("Now that the party is jumping\n", msg); [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/set1/challenge4.rs:17:20 [INFO] [stderr] | [INFO] [stderr] 17 | if results.len() > 0 { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `!results.is_empty()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::len_zero)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/set1/challenge5.rs:3:32 [INFO] [stderr] | [INFO] [stderr] 3 | pub fn rotating_key_xor(input: &Vec, key: &[u8]) -> Vec { [INFO] [stderr] | ^^^^^^^^ help: change this to: `&[u8]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: this `.fold` can be written more succinctly using another method [INFO] [stderr] --> src/set1/challenge6.rs:9:41 [INFO] [stderr] | [INFO] [stderr] 9 | .map(|xored| xored.count_ones()) [INFO] [stderr] | _________________________________________^ [INFO] [stderr] 10 | | .fold(0, |acc, item| acc + item); [INFO] [stderr] | |________________________________________^ help: try: `.sum()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::unnecessary_fold)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_fold [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/set1/challenge6.rs:15:54 [INFO] [stderr] | [INFO] [stderr] 15 | pub fn score_keysize(keysize: usize, encrypted_data: &Vec) -> usize { [INFO] [stderr] | ^^^^^^^^ help: change this to: `&[u8]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: this `.fold` can be written more succinctly using another method [INFO] [stderr] --> src/set1/challenge6.rs:20:7 [INFO] [stderr] | [INFO] [stderr] 20 | }).fold(0, |acc, item| acc + item); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `.sum()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_fold [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/set1/challenge6.rs:24:57 [INFO] [stderr] | [INFO] [stderr] 24 | pub fn transpose_blocks(keysize: usize, encrypted_data: &Vec) -> Vec> { [INFO] [stderr] | ^^^^^^^^ help: change this to: `&[u8]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: the loop variable `i` is only used to index `scored_keysizes`. [INFO] [stderr] --> src/set1/challenge6.rs:58:14 [INFO] [stderr] | [INFO] [stderr] 58 | for i in 0.. 2 { [INFO] [stderr] | ^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_range_loop)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop [INFO] [stderr] help: consider using an iterator [INFO] [stderr] | [INFO] [stderr] 58 | for in scored_keysizes.iter().take(2) { [INFO] [stderr] | ^^^^^^ ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: calling `as_bytes()` on a string literal [INFO] [stderr] --> src/set1/challenge6.rs:83:24 [INFO] [stderr] | [INFO] [stderr] 83 | assert_eq!(hamming("this is a test".as_bytes(), "wokka wokka!!!".as_bytes()), 37); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using a byte string literal instead: `b"this is a test"` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::string_lit_as_bytes)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#string_lit_as_bytes [INFO] [stderr] [INFO] [stderr] warning: calling `as_bytes()` on a string literal [INFO] [stderr] --> src/set1/challenge6.rs:83:53 [INFO] [stderr] | [INFO] [stderr] 83 | assert_eq!(hamming("this is a test".as_bytes(), "wokka wokka!!!".as_bytes()), 37); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using a byte string literal instead: `b"wokka wokka!!!"` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#string_lit_as_bytes [INFO] [stderr] [INFO] [stderr] warning: this `.fold` can be written more succinctly using another method [INFO] [stderr] --> src/set1/challenge8.rs:25:11 [INFO] [stderr] | [INFO] [stderr] 25 | summer.fold(0, |acc, item| acc + item) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `.sum()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unnecessary_fold [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/set1/challenge8.rs:38:9 [INFO] [stderr] | [INFO] [stderr] 38 | / match ciphertext { [INFO] [stderr] 39 | | Ok(candidate) => { [INFO] [stderr] 40 | | scored_ciphertexts.push((candidate.clone(), score_ciphertext_for_ecb_mode(candidate.into_bytes()))); [INFO] [stderr] 41 | | } [INFO] [stderr] 42 | | Err(_) => {} [INFO] [stderr] 43 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 38 | if let Ok(candidate) = ciphertext { [INFO] [stderr] 39 | scored_ciphertexts.push((candidate.clone(), score_ciphertext_for_ecb_mode(candidate.into_bytes()))); [INFO] [stderr] 40 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: this boolean expression can be simplified [INFO] [stderr] --> src/set2/challenge14.rs:40:16 [INFO] [stderr] | [INFO] [stderr] 40 | if !remaining.peek().is_none() { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `remaining.peek().is_some()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::nonminimal_bool)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stderr] [INFO] [stderr] warning: this boolean expression can be simplified [INFO] [stderr] --> src/set2/challenge14.rs:74:16 [INFO] [stderr] | [INFO] [stderr] 74 | if !remaining.peek().is_none() { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `remaining.peek().is_some()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#nonminimal_bool [INFO] [stderr] [INFO] [stderr] warning: taken reference of right operand [INFO] [stderr] --> src/set2/challenge14.rs:98:12 [INFO] [stderr] | [INFO] [stderr] 98 | if value > &most_repeats { [INFO] [stderr] | ^^^^^^^^------------- [INFO] [stderr] | | [INFO] [stderr] | help: use the right value directly: `most_repeats` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::op_ref)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#op_ref [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/set3/challenge17.rs:42:90 [INFO] [stderr] | [INFO] [stderr] 42 | fn test_byte(guess: u8, target_index: usize, attacking_block: Vec, discovered_bytes: &Vec, key: &[u8]) -> Result { [INFO] [stderr] | ^^^^^^^^ help: change this to: `&[u8]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] error: using `clone` on a double-reference; this will copy the reference instead of cloning the inner type [INFO] [stderr] --> src/set3/challenge17.rs:109:31 [INFO] [stderr] | [INFO] [stderr] 109 | let mut inter_block = intermediary_block.clone().to_owned(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[deny(clippy::clone_double_ref)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#clone_double_ref [INFO] [stderr] help: try dereferencing it [INFO] [stderr] | [INFO] [stderr] 109 | let mut inter_block = &(*intermediary_block).clone().to_owned(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] help: or try being explicit about what type to clone [INFO] [stderr] | [INFO] [stderr] 109 | let mut inter_block = &[u8]::clone(intermediary_block).to_owned(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] error: aborting due to previous error [INFO] [stderr] [INFO] [stderr] error: Could not compile `matasano`. [INFO] [stderr] [INFO] [stderr] To learn more, run the command again with --verbose. [INFO] running `"docker" "inspect" "5bc4122c8a3a2601f363f839eeacb056c0905818d1b467d3f3fba0dcfc9d16e2"` [INFO] running `"docker" "rm" "-f" "5bc4122c8a3a2601f363f839eeacb056c0905818d1b467d3f3fba0dcfc9d16e2"` [INFO] [stdout] 5bc4122c8a3a2601f363f839eeacb056c0905818d1b467d3f3fba0dcfc9d16e2