[INFO] updating cached repository data-pup/poc-context-wasm-pack [INFO] running `"git" "fetch" "--all"` [INFO] [stdout] Fetching origin [INFO] [stderr] From git://github.com/data-pup/poc-context-wasm-pack [INFO] [stderr] * branch HEAD -> FETCH_HEAD [INFO] running `"git" "clone" "work/cache/sources/gh/data-pup/poc-context-wasm-pack" "work/ex/clippy-test-run/sources/stable/gh/data-pup/poc-context-wasm-pack"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/data-pup/poc-context-wasm-pack'... [INFO] [stderr] done. [INFO] running `"git" "clone" "work/cache/sources/gh/data-pup/poc-context-wasm-pack" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/data-pup/poc-context-wasm-pack"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/data-pup/poc-context-wasm-pack'... [INFO] [stderr] done. [INFO] running `"git" "rev-parse" "HEAD"` [INFO] [stdout] d82e9bb54b9c5516394a144cf33e9f30271979d1 [INFO] sha for GitHub repo data-pup/poc-context-wasm-pack: d82e9bb54b9c5516394a144cf33e9f30271979d1 [INFO] validating manifest of data-pup/poc-context-wasm-pack on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of data-pup/poc-context-wasm-pack on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing data-pup/poc-context-wasm-pack [INFO] finished frobbing data-pup/poc-context-wasm-pack [INFO] frobbed toml for data-pup/poc-context-wasm-pack written to work/ex/clippy-test-run/sources/stable/gh/data-pup/poc-context-wasm-pack/Cargo.toml [INFO] started frobbing data-pup/poc-context-wasm-pack [INFO] finished frobbing data-pup/poc-context-wasm-pack [INFO] frobbed toml for data-pup/poc-context-wasm-pack written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/data-pup/poc-context-wasm-pack/Cargo.toml [INFO] crate data-pup/poc-context-wasm-pack has a lockfile. skipping [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting data-pup/poc-context-wasm-pack against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-4/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/gh/data-pup/poc-context-wasm-pack:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 50cc3f1059c751579fa710c49efae0427185de5fa5a78e1443869d952057d1f7 [INFO] running `"docker" "start" "-a" "50cc3f1059c751579fa710c49efae0427185de5fa5a78e1443869d952057d1f7"` [INFO] [stderr] Checking serde v1.0.39 [INFO] [stderr] Compiling structopt-derive v0.2.7 [INFO] [stderr] Checking env_logger v0.5.8 [INFO] [stderr] Checking os_type v2.0.0 [INFO] [stderr] Checking console v0.6.1 [INFO] [stderr] Checking rayon v0.9.0 [INFO] [stderr] Compiling serde_derive v1.0.39 [INFO] [stderr] Checking indicatif v0.9.0 [INFO] [stderr] Checking structopt v0.2.7 [INFO] [stderr] Checking toml v0.4.6 [INFO] [stderr] Checking quicli v0.2.0 [INFO] [stderr] Checking serde_json v1.0.15 [INFO] [stderr] Checking human-panic v0.4.0 [INFO] [stderr] Checking wasm-pack v0.2.0 (/opt/crater/workdir) [INFO] [stderr] warning: this if statement can be collapsed [INFO] [stderr] --> src/context/mod.rs:66:9 [INFO] [stderr] | [INFO] [stderr] 66 | / if self.manifest.is_none() { [INFO] [stderr] 67 | | if self.read_manifest(".").is_err() { [INFO] [stderr] 68 | | unimplemented!(); // Something bad happened if we are here. [INFO] [stderr] 69 | | } [INFO] [stderr] 70 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::collapsible_if)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stderr] help: try [INFO] [stderr] | [INFO] [stderr] 66 | if self.manifest.is_none() && self.read_manifest(".").is_err() { [INFO] [stderr] 67 | unimplemented!(); // Something bad happened if we are here. [INFO] [stderr] 68 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: All the struct fields are matched to a wildcard pattern, consider using `..`. [INFO] [stderr] --> src/error.rs:33:13 [INFO] [stderr] | [INFO] [stderr] 33 | / Error::Cli { [INFO] [stderr] 34 | | message: _, [INFO] [stderr] 35 | | stderr: _, [INFO] [stderr] 36 | | } => "There was an error while calling another CLI tool. Details:\n\n", [INFO] [stderr] | |_____________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::unneeded_field_pattern)] on by default [INFO] [stderr] = help: Try with `Cli { .. }` instead [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unneeded_field_pattern [INFO] [stderr] [INFO] [stderr] warning: this if statement can be collapsed [INFO] [stderr] --> src/context/mod.rs:66:9 [INFO] [stderr] | [INFO] [stderr] 66 | / if self.manifest.is_none() { [INFO] [stderr] 67 | | if self.read_manifest(".").is_err() { [INFO] [stderr] 68 | | unimplemented!(); // Something bad happened if we are here. [INFO] [stderr] 69 | | } [INFO] [stderr] 70 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::collapsible_if)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stderr] help: try [INFO] [stderr] | [INFO] [stderr] 66 | if self.manifest.is_none() && self.read_manifest(".").is_err() { [INFO] [stderr] 67 | unimplemented!(); // Something bad happened if we are here. [INFO] [stderr] 68 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: All the struct fields are matched to a wildcard pattern, consider using `..`. [INFO] [stderr] --> src/error.rs:33:13 [INFO] [stderr] | [INFO] [stderr] 33 | / Error::Cli { [INFO] [stderr] 34 | | message: _, [INFO] [stderr] 35 | | stderr: _, [INFO] [stderr] 36 | | } => "There was an error while calling another CLI tool. Details:\n\n", [INFO] [stderr] | |_____________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::unneeded_field_pattern)] on by default [INFO] [stderr] = help: Try with `Cli { .. }` instead [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unneeded_field_pattern [INFO] [stderr] [INFO] [stderr] error: useless lint attribute [INFO] [stderr] --> src/command.rs:1:1 [INFO] [stderr] | [INFO] [stderr] 1 | #[allow(unused)] [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: if you just forgot a `!`, use: `#![allow(unused)]` [INFO] [stderr] | [INFO] [stderr] = note: #[deny(clippy::useless_attribute)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_attribute [INFO] [stderr] [INFO] [stderr] warning: use of `unwrap_or` followed by a function call [INFO] [stderr] --> src/context/from_cli.rs:42:14 [INFO] [stderr] | [INFO] [stderr] 42 | path_arg.unwrap_or(".".to_string()) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `unwrap_or_else(|| ".".to_string())` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::or_fun_call)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] warning: redundant pattern matching, consider using `is_err()` [INFO] [stderr] --> src/context/init.rs:135:16 [INFO] [stderr] | [INFO] [stderr] 135 | if let Err(_) = copy_readme_from_crate(&self.path) { [INFO] [stderr] | _________- ^^^^^^ [INFO] [stderr] 136 | | self.pbar.warn("origin crate has no README"); [INFO] [stderr] 137 | | }; [INFO] [stderr] | |_________- help: try this: `if copy_readme_from_crate(&self.path).is_err()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_pattern_matching)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_pattern_matching [INFO] [stderr] [INFO] [stderr] warning: you should consider adding a `Default` implementation for `context::progressbar::ProgressOutput` [INFO] [stderr] --> src/context/progressbar.rs:11:5 [INFO] [stderr] | [INFO] [stderr] 11 | / pub fn new() -> Self { [INFO] [stderr] 12 | | Self { [INFO] [stderr] 13 | | bar: MultiProgress::new(), [INFO] [stderr] 14 | | } [INFO] [stderr] 15 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::new_without_default)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 10 | impl Default for context::progressbar::ProgressOutput { [INFO] [stderr] 11 | fn default() -> Self { [INFO] [stderr] 12 | Self::new() [INFO] [stderr] 13 | } [INFO] [stderr] 14 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: use of a blacklisted/placeholder name `bar` [INFO] [stderr] --> src/context/progressbar.rs:28:13 [INFO] [stderr] | [INFO] [stderr] 28 | let bar = self.bar.add(Self::progressbar(&info)); [INFO] [stderr] | ^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::blacklisted_name)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#blacklisted_name [INFO] [stderr] [INFO] [stderr] warning: use of a blacklisted/placeholder name `bar` [INFO] [stderr] --> src/context/progressbar.rs:39:13 [INFO] [stderr] | [INFO] [stderr] 39 | let bar = self.bar.add(Self::progressbar(&warn)); [INFO] [stderr] | ^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#blacklisted_name [INFO] [stderr] [INFO] [stderr] warning: use of a blacklisted/placeholder name `bar` [INFO] [stderr] --> src/context/progressbar.rs:50:13 [INFO] [stderr] | [INFO] [stderr] 50 | let bar = self.bar.add(Self::progressbar(&err)); [INFO] [stderr] | ^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#blacklisted_name [INFO] [stderr] [INFO] [stderr] warning: redundant closure found [INFO] [stderr] --> src/context/progressbar.rs:67:43 [INFO] [stderr] | [INFO] [stderr] 67 | self.bar.join_and_clear().map_err(|e| Error::from(e)) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: remove closure as shown: `Error::from` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_closure)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure [INFO] [stderr] [INFO] [stderr] error: useless lint attribute [INFO] [stderr] --> src/command.rs:1:1 [INFO] [stderr] | [INFO] [stderr] 1 | #[allow(unused)] [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: if you just forgot a `!`, use: `#![allow(unused)]` [INFO] [stderr] | [INFO] [stderr] = note: #[deny(clippy::useless_attribute)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_attribute [INFO] [stderr] [INFO] [stderr] warning: use of `unwrap_or` followed by a function call [INFO] [stderr] --> src/context/from_cli.rs:42:14 [INFO] [stderr] | [INFO] [stderr] 42 | path_arg.unwrap_or(".".to_string()) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `unwrap_or_else(|| ".".to_string())` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::or_fun_call)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] warning: redundant pattern matching, consider using `is_err()` [INFO] [stderr] --> src/context/init.rs:135:16 [INFO] [stderr] | [INFO] [stderr] 135 | if let Err(_) = copy_readme_from_crate(&self.path) { [INFO] [stderr] | _________- ^^^^^^ [INFO] [stderr] 136 | | self.pbar.warn("origin crate has no README"); [INFO] [stderr] 137 | | }; [INFO] [stderr] | |_________- help: try this: `if copy_readme_from_crate(&self.path).is_err()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_pattern_matching)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_pattern_matching [INFO] [stderr] [INFO] [stderr] warning: you should consider adding a `Default` implementation for `context::progressbar::ProgressOutput` [INFO] [stderr] --> src/context/progressbar.rs:11:5 [INFO] [stderr] | [INFO] [stderr] 11 | / pub fn new() -> Self { [INFO] [stderr] 12 | | Self { [INFO] [stderr] 13 | | bar: MultiProgress::new(), [INFO] [stderr] 14 | | } [INFO] [stderr] 15 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::new_without_default)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 10 | impl Default for context::progressbar::ProgressOutput { [INFO] [stderr] 11 | fn default() -> Self { [INFO] [stderr] 12 | Self::new() [INFO] [stderr] 13 | } [INFO] [stderr] 14 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: use of a blacklisted/placeholder name `bar` [INFO] [stderr] --> src/context/progressbar.rs:28:13 [INFO] [stderr] | [INFO] [stderr] 28 | let bar = self.bar.add(Self::progressbar(&info)); [INFO] [stderr] | ^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::blacklisted_name)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#blacklisted_name [INFO] [stderr] [INFO] [stderr] warning: use of a blacklisted/placeholder name `bar` [INFO] [stderr] --> src/context/progressbar.rs:39:13 [INFO] [stderr] | [INFO] [stderr] 39 | let bar = self.bar.add(Self::progressbar(&warn)); [INFO] [stderr] | ^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#blacklisted_name [INFO] [stderr] [INFO] [stderr] warning: use of a blacklisted/placeholder name `bar` [INFO] [stderr] --> src/context/progressbar.rs:50:13 [INFO] [stderr] | [INFO] [stderr] 50 | let bar = self.bar.add(Self::progressbar(&err)); [INFO] [stderr] | ^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#blacklisted_name [INFO] [stderr] [INFO] [stderr] warning: redundant closure found [INFO] [stderr] --> src/context/progressbar.rs:67:43 [INFO] [stderr] | [INFO] [stderr] 67 | self.bar.join_and_clear().map_err(|e| Error::from(e)) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: remove closure as shown: `Error::from` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_closure)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure [INFO] [stderr] [INFO] [stderr] error: aborting due to previous error [INFO] [stderr] [INFO] [stderr] error: Could not compile `wasm-pack`. [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stderr] error: aborting due to previous error [INFO] [stderr] [INFO] [stderr] error: Could not compile `wasm-pack`. [INFO] [stderr] [INFO] [stderr] To learn more, run the command again with --verbose. [INFO] running `"docker" "inspect" "50cc3f1059c751579fa710c49efae0427185de5fa5a78e1443869d952057d1f7"` [INFO] running `"docker" "rm" "-f" "50cc3f1059c751579fa710c49efae0427185de5fa5a78e1443869d952057d1f7"` [INFO] [stdout] 50cc3f1059c751579fa710c49efae0427185de5fa5a78e1443869d952057d1f7