[INFO] updating cached repository dat2/yate [INFO] running `"git" "fetch" "--all"` [INFO] [stdout] Fetching origin [INFO] [stderr] From git://github.com/dat2/yate [INFO] [stderr] * branch HEAD -> FETCH_HEAD [INFO] running `"git" "clone" "work/cache/sources/gh/dat2/yate" "work/ex/clippy-test-run/sources/stable/gh/dat2/yate"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/dat2/yate'... [INFO] [stderr] done. [INFO] running `"git" "clone" "work/cache/sources/gh/dat2/yate" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/dat2/yate"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/dat2/yate'... [INFO] [stderr] done. [INFO] running `"git" "rev-parse" "HEAD"` [INFO] [stdout] a124fd6b9d4bd4eae9010903529c8717be97a7d5 [INFO] sha for GitHub repo dat2/yate: a124fd6b9d4bd4eae9010903529c8717be97a7d5 [INFO] validating manifest of dat2/yate on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of dat2/yate on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing dat2/yate [INFO] finished frobbing dat2/yate [INFO] frobbed toml for dat2/yate written to work/ex/clippy-test-run/sources/stable/gh/dat2/yate/Cargo.toml [INFO] started frobbing dat2/yate [INFO] finished frobbing dat2/yate [INFO] frobbed toml for dat2/yate written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/dat2/yate/Cargo.toml [INFO] crate dat2/yate has a lockfile. skipping [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting dat2/yate against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-0/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/gh/dat2/yate:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] eb3b8c6c4659299bb5535d826d7dfad101c673069adc0fd1dd273b2aa2faac30 [INFO] running `"docker" "start" "-a" "eb3b8c6c4659299bb5535d826d7dfad101c673069adc0fd1dd273b2aa2faac30"` [INFO] [stderr] Checking yaml-rust v0.3.4 [INFO] [stderr] Checking net2 v0.2.26 [INFO] [stderr] Checking filetime v0.1.10 [INFO] [stderr] Checking inotify v0.2.3 [INFO] [stderr] Checking termion v1.1.1 [INFO] [stderr] Checking miow v0.1.3 [INFO] [stderr] Checking mio v0.5.1 [INFO] [stderr] Checking clap v2.15.0 [INFO] [stderr] Checking notify v2.6.3 [INFO] [stderr] Checking yate v0.1.0 (/opt/crater/workdir) [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/rope.rs:31:13 [INFO] [stderr] | [INFO] [stderr] 31 | weight: weight, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `weight` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/file_buffer.rs:29:13 [INFO] [stderr] | [INFO] [stderr] 29 | filename: filename, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: replace it with: `filename` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/file_buffer.rs:30:13 [INFO] [stderr] | [INFO] [stderr] 30 | handle: handle, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `handle` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/file_buffer.rs:31:13 [INFO] [stderr] | [INFO] [stderr] 31 | contents: contents, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: replace it with: `contents` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/editor.rs:35:13 [INFO] [stderr] | [INFO] [stderr] 35 | buffer: buffer, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `buffer` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/editor.rs:36:13 [INFO] [stderr] | [INFO] [stderr] 36 | stdout: stdout, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `stdout` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/rope.rs:31:13 [INFO] [stderr] | [INFO] [stderr] 31 | weight: weight, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `weight` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/file_buffer.rs:29:13 [INFO] [stderr] | [INFO] [stderr] 29 | filename: filename, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: replace it with: `filename` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/file_buffer.rs:30:13 [INFO] [stderr] | [INFO] [stderr] 30 | handle: handle, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `handle` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/file_buffer.rs:31:13 [INFO] [stderr] | [INFO] [stderr] 31 | contents: contents, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: replace it with: `contents` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/editor.rs:35:13 [INFO] [stderr] | [INFO] [stderr] 35 | buffer: buffer, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `buffer` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/editor.rs:36:13 [INFO] [stderr] | [INFO] [stderr] 36 | stdout: stdout, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `stdout` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: unused variable: `i` [INFO] [stderr] --> src/rope.rs:53:25 [INFO] [stderr] | [INFO] [stderr] 53 | pub fn split(&self, i: usize) -> (RopeNode, RopeNode) { [INFO] [stderr] | ^ help: consider using `_i` instead [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_variables)] on by default [INFO] [stderr] [INFO] [stderr] warning: unused variable: `i` [INFO] [stderr] --> src/rope.rs:96:26 [INFO] [stderr] | [INFO] [stderr] 96 | pub fn report(&self, i: usize, len: usize) -> RopeNode { [INFO] [stderr] | ^ help: consider using `_i` instead [INFO] [stderr] [INFO] [stderr] warning: unused variable: `len` [INFO] [stderr] --> src/rope.rs:96:36 [INFO] [stderr] | [INFO] [stderr] 96 | pub fn report(&self, i: usize, len: usize) -> RopeNode { [INFO] [stderr] | ^^^ help: consider using `_len` instead [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/editor.rs:132:13 [INFO] [stderr] | [INFO] [stderr] 132 | / match cmd { [INFO] [stderr] 133 | | EditorCommand::Quit => break, [INFO] [stderr] 134 | | _ => {} [INFO] [stderr] 135 | | } [INFO] [stderr] | |_____________^ help: try this: `if let EditorCommand::Quit = cmd { break }` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::single_match)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] [INFO] [stderr] warning: unused variable: `i` [INFO] [stderr] --> src/rope.rs:53:25 [INFO] [stderr] | [INFO] [stderr] 53 | pub fn split(&self, i: usize) -> (RopeNode, RopeNode) { [INFO] [stderr] | ^ help: consider using `_i` instead [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_variables)] on by default [INFO] [stderr] [INFO] [stderr] warning: unused variable: `i` [INFO] [stderr] --> src/rope.rs:96:26 [INFO] [stderr] | [INFO] [stderr] 96 | pub fn report(&self, i: usize, len: usize) -> RopeNode { [INFO] [stderr] | ^ help: consider using `_i` instead [INFO] [stderr] [INFO] [stderr] warning: unused variable: `len` [INFO] [stderr] --> src/rope.rs:96:36 [INFO] [stderr] | [INFO] [stderr] 96 | pub fn report(&self, i: usize, len: usize) -> RopeNode { [INFO] [stderr] | ^^^ help: consider using `_len` instead [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/editor.rs:132:13 [INFO] [stderr] | [INFO] [stderr] 132 | / match cmd { [INFO] [stderr] 133 | | EditorCommand::Quit => break, [INFO] [stderr] 134 | | _ => {} [INFO] [stderr] 135 | | } [INFO] [stderr] | |_____________^ help: try this: `if let EditorCommand::Quit = cmd { break }` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::single_match)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 12.87s [INFO] running `"docker" "inspect" "eb3b8c6c4659299bb5535d826d7dfad101c673069adc0fd1dd273b2aa2faac30"` [INFO] running `"docker" "rm" "-f" "eb3b8c6c4659299bb5535d826d7dfad101c673069adc0fd1dd273b2aa2faac30"` [INFO] [stdout] eb3b8c6c4659299bb5535d826d7dfad101c673069adc0fd1dd273b2aa2faac30