[INFO] updating cached repository dashed/td-transactions-to-ledger [INFO] running `"git" "fetch" "--all"` [INFO] [stdout] Fetching origin [INFO] [stderr] From git://github.com/dashed/td-transactions-to-ledger [INFO] [stderr] * branch HEAD -> FETCH_HEAD [INFO] running `"git" "clone" "work/cache/sources/gh/dashed/td-transactions-to-ledger" "work/ex/clippy-test-run/sources/stable/gh/dashed/td-transactions-to-ledger"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/dashed/td-transactions-to-ledger'... [INFO] [stderr] done. [INFO] running `"git" "clone" "work/cache/sources/gh/dashed/td-transactions-to-ledger" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/dashed/td-transactions-to-ledger"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/dashed/td-transactions-to-ledger'... [INFO] [stderr] done. [INFO] running `"git" "rev-parse" "HEAD"` [INFO] [stdout] 3fc6568646fa3d9af503c3ff806e62f002d6497d [INFO] sha for GitHub repo dashed/td-transactions-to-ledger: 3fc6568646fa3d9af503c3ff806e62f002d6497d [INFO] validating manifest of dashed/td-transactions-to-ledger on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of dashed/td-transactions-to-ledger on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing dashed/td-transactions-to-ledger [INFO] finished frobbing dashed/td-transactions-to-ledger [INFO] frobbed toml for dashed/td-transactions-to-ledger written to work/ex/clippy-test-run/sources/stable/gh/dashed/td-transactions-to-ledger/Cargo.toml [INFO] started frobbing dashed/td-transactions-to-ledger [INFO] finished frobbing dashed/td-transactions-to-ledger [INFO] frobbed toml for dashed/td-transactions-to-ledger written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/dashed/td-transactions-to-ledger/Cargo.toml [INFO] crate dashed/td-transactions-to-ledger has a lockfile. skipping [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting dashed/td-transactions-to-ledger against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-4/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/gh/dashed/td-transactions-to-ledger:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 5ae5c00d5e3f4beea7d35640e593c0944756e93e0223e028f0795c3e02b16acf [INFO] running `"docker" "start" "-a" "5ae5c00d5e3f4beea7d35640e593c0944756e93e0223e028f0795c3e02b16acf"` [INFO] [stderr] Checking memchr v1.0.2 [INFO] [stderr] Checking clap v2.28.0 [INFO] [stderr] Checking csv-core v0.1.3 [INFO] [stderr] Checking csv v1.0.0-beta.5 [INFO] [stderr] Checking td-transactions-to-ledger v0.1.0 (/opt/crater/workdir) [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/main.rs:133:25 [INFO] [stderr] | [INFO] [stderr] 133 | let amount = if debit.len() > 0 { [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `!debit.is_empty()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::len_zero)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: called `.get().unwrap()` on a Vec. Using `[]` is more clear and more concise [INFO] [stderr] --> src/main.rs:153:24 [INFO] [stderr] | [INFO] [stderr] 153 | for transaction in transactions.get(range).unwrap() { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `transactions[range]` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::get_unwrap)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#get_unwrap [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/main.rs:133:25 [INFO] [stderr] | [INFO] [stderr] 133 | let amount = if debit.len() > 0 { [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `!debit.is_empty()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::len_zero)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: called `.get().unwrap()` on a Vec. Using `[]` is more clear and more concise [INFO] [stderr] --> src/main.rs:153:24 [INFO] [stderr] | [INFO] [stderr] 153 | for transaction in transactions.get(range).unwrap() { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `transactions[range]` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::get_unwrap)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#get_unwrap [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 12.73s [INFO] running `"docker" "inspect" "5ae5c00d5e3f4beea7d35640e593c0944756e93e0223e028f0795c3e02b16acf"` [INFO] running `"docker" "rm" "-f" "5ae5c00d5e3f4beea7d35640e593c0944756e93e0223e028f0795c3e02b16acf"` [INFO] [stdout] 5ae5c00d5e3f4beea7d35640e593c0944756e93e0223e028f0795c3e02b16acf