[INFO] updating cached repository darshanparajuli/countcode [INFO] running `"git" "fetch" "--all"` [INFO] [stdout] Fetching origin [INFO] [stderr] From git://github.com/darshanparajuli/countcode [INFO] [stderr] * branch HEAD -> FETCH_HEAD [INFO] running `"git" "clone" "work/cache/sources/gh/darshanparajuli/countcode" "work/ex/clippy-test-run/sources/stable/gh/darshanparajuli/countcode"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/darshanparajuli/countcode'... [INFO] [stderr] done. [INFO] running `"git" "clone" "work/cache/sources/gh/darshanparajuli/countcode" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/darshanparajuli/countcode"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/darshanparajuli/countcode'... [INFO] [stderr] done. [INFO] running `"git" "rev-parse" "HEAD"` [INFO] [stdout] e6ae9ea21920efc0c69a02abe33ded5f56954c30 [INFO] sha for GitHub repo darshanparajuli/countcode: e6ae9ea21920efc0c69a02abe33ded5f56954c30 [INFO] validating manifest of darshanparajuli/countcode on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of darshanparajuli/countcode on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing darshanparajuli/countcode [INFO] finished frobbing darshanparajuli/countcode [INFO] frobbed toml for darshanparajuli/countcode written to work/ex/clippy-test-run/sources/stable/gh/darshanparajuli/countcode/Cargo.toml [INFO] started frobbing darshanparajuli/countcode [INFO] finished frobbing darshanparajuli/countcode [INFO] frobbed toml for darshanparajuli/countcode written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/darshanparajuli/countcode/Cargo.toml [INFO] crate darshanparajuli/countcode has a lockfile. skipping [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting darshanparajuli/countcode against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-7/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/gh/darshanparajuli/countcode:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] a2051b30688350280109a6b19b85d80e06ba6347431d9b81561a72b063b9a8ee [INFO] running `"docker" "start" "-a" "a2051b30688350280109a6b19b85d80e06ba6347431d9b81561a72b063b9a8ee"` [INFO] [stderr] Checking memmap v0.7.0 [INFO] [stderr] Checking globset v0.4.0 [INFO] [stderr] Checking ignore v0.4.2 [INFO] [stderr] Checking countcode v0.1.0 (/opt/crater/workdir) [INFO] [stderr] warning: this if statement can be collapsed [INFO] [stderr] --> src/counter.rs:89:21 [INFO] [stderr] | [INFO] [stderr] 89 | / if self.next_index < length { [INFO] [stderr] 90 | | if self.mmap[self.next_index] == b'\n' { [INFO] [stderr] 91 | | self.next_index += 1; [INFO] [stderr] 92 | | } [INFO] [stderr] 93 | | } [INFO] [stderr] | |_____________________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::collapsible_if)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stderr] help: try [INFO] [stderr] | [INFO] [stderr] 89 | if self.next_index < length && self.mmap[self.next_index] == b'\n' { [INFO] [stderr] 90 | self.next_index += 1; [INFO] [stderr] 91 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: this if statement can be collapsed [INFO] [stderr] --> src/counter.rs:89:21 [INFO] [stderr] | [INFO] [stderr] 89 | / if self.next_index < length { [INFO] [stderr] 90 | | if self.mmap[self.next_index] == b'\n' { [INFO] [stderr] 91 | | self.next_index += 1; [INFO] [stderr] 92 | | } [INFO] [stderr] 93 | | } [INFO] [stderr] | |_____________________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::collapsible_if)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stderr] help: try [INFO] [stderr] | [INFO] [stderr] 89 | if self.next_index < length && self.mmap[self.next_index] == b'\n' { [INFO] [stderr] 90 | self.next_index += 1; [INFO] [stderr] 91 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: this loop could be written as a `while let` loop [INFO] [stderr] --> src/counter.rs:145:17 [INFO] [stderr] | [INFO] [stderr] 145 | / loop { [INFO] [stderr] 146 | | let mut line = match line_reader.read_line() { [INFO] [stderr] 147 | | Some(line) => line, [INFO] [stderr] 148 | | None => break, [INFO] [stderr] ... | [INFO] [stderr] 206 | | } [INFO] [stderr] 207 | | } [INFO] [stderr] | |_________________^ help: try: `while let Some(line) = line_reader.read_line() { .. }` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::while_let_loop)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#while_let_loop [INFO] [stderr] [INFO] [stderr] warning: identical conversion [INFO] [stderr] --> src/scanner.rs:26:26 [INFO] [stderr] | [INFO] [stderr] 26 | for entry in Walk::new(a).into_iter().filter_map(|e| e.ok()) { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: consider removing `.into_iter()`: `Walk::new(a)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::identity_conversion)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_conversion [INFO] [stderr] [INFO] [stderr] warning: called `.get().unwrap()` on a Vec. Using `[]` is more clear and more concise [INFO] [stderr] --> src/main.rs:116:16 [INFO] [stderr] | [INFO] [stderr] 116 | let sloc = slocs.get(len - 1).unwrap(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `slocs[len - 1]` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::get_unwrap)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#get_unwrap [INFO] [stderr] [INFO] [stderr] warning: this loop could be written as a `while let` loop [INFO] [stderr] --> src/counter.rs:145:17 [INFO] [stderr] | [INFO] [stderr] 145 | / loop { [INFO] [stderr] 146 | | let mut line = match line_reader.read_line() { [INFO] [stderr] 147 | | Some(line) => line, [INFO] [stderr] 148 | | None => break, [INFO] [stderr] ... | [INFO] [stderr] 206 | | } [INFO] [stderr] 207 | | } [INFO] [stderr] | |_________________^ help: try: `while let Some(line) = line_reader.read_line() { .. }` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::while_let_loop)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#while_let_loop [INFO] [stderr] [INFO] [stderr] warning: identical conversion [INFO] [stderr] --> src/scanner.rs:26:26 [INFO] [stderr] | [INFO] [stderr] 26 | for entry in Walk::new(a).into_iter().filter_map(|e| e.ok()) { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: consider removing `.into_iter()`: `Walk::new(a)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::identity_conversion)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_conversion [INFO] [stderr] [INFO] [stderr] warning: called `.get().unwrap()` on a Vec. Using `[]` is more clear and more concise [INFO] [stderr] --> src/main.rs:116:16 [INFO] [stderr] | [INFO] [stderr] 116 | let sloc = slocs.get(len - 1).unwrap(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `slocs[len - 1]` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::get_unwrap)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#get_unwrap [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 5.49s [INFO] running `"docker" "inspect" "a2051b30688350280109a6b19b85d80e06ba6347431d9b81561a72b063b9a8ee"` [INFO] running `"docker" "rm" "-f" "a2051b30688350280109a6b19b85d80e06ba6347431d9b81561a72b063b9a8ee"` [INFO] [stdout] a2051b30688350280109a6b19b85d80e06ba6347431d9b81561a72b063b9a8ee