[INFO] updating cached repository darksv/interpreter [INFO] running `"git" "fetch" "--all"` [INFO] [stdout] Fetching origin [INFO] [stderr] From git://github.com/darksv/interpreter [INFO] [stderr] * branch HEAD -> FETCH_HEAD [INFO] running `"git" "clone" "work/cache/sources/gh/darksv/interpreter" "work/ex/clippy-test-run/sources/stable/gh/darksv/interpreter"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/darksv/interpreter'... [INFO] [stderr] done. [INFO] running `"git" "clone" "work/cache/sources/gh/darksv/interpreter" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/darksv/interpreter"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/darksv/interpreter'... [INFO] [stderr] done. [INFO] running `"git" "rev-parse" "HEAD"` [INFO] [stdout] 027c07e623798b6667f73d8c0209db0a0eeeccd6 [INFO] sha for GitHub repo darksv/interpreter: 027c07e623798b6667f73d8c0209db0a0eeeccd6 [INFO] validating manifest of darksv/interpreter on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of darksv/interpreter on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing darksv/interpreter [INFO] finished frobbing darksv/interpreter [INFO] frobbed toml for darksv/interpreter written to work/ex/clippy-test-run/sources/stable/gh/darksv/interpreter/Cargo.toml [INFO] started frobbing darksv/interpreter [INFO] finished frobbing darksv/interpreter [INFO] frobbed toml for darksv/interpreter written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/darksv/interpreter/Cargo.toml [INFO] crate darksv/interpreter has a lockfile. skipping [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting darksv/interpreter against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-4/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/gh/darksv/interpreter:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] d066cb8f2eea448f9c28cd4f36333a16b92aa99ea6175c99daff7a5fc035752c [INFO] running `"docker" "start" "-a" "d066cb8f2eea448f9c28cd4f36333a16b92aa99ea6175c99daff7a5fc035752c"` [INFO] [stderr] Checking vm v0.0.1 (/opt/crater/workdir) [INFO] [stderr] warning: explicit lifetimes given in parameter types where they could be elided (or replaced with `'_` if needed by type declaration) [INFO] [stderr] --> src/assembly.rs:22:5 [INFO] [stderr] | [INFO] [stderr] 22 | / pub fn name<'a>(&'a self) -> &'a str { [INFO] [stderr] 23 | | match self { [INFO] [stderr] 24 | | FuncDef::Managed(ManagedFuncDef { name, .. }) => &name, [INFO] [stderr] 25 | | FuncDef::Native(NativeFuncDef { name, .. }) => &name, [INFO] [stderr] 26 | | } [INFO] [stderr] 27 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_lifetimes)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/instructions.rs:25:9 [INFO] [stderr] | [INFO] [stderr] 25 | / match self { [INFO] [stderr] 26 | | &Inst::add_u => write!(f, "add.u")?, [INFO] [stderr] 27 | | &Inst::add_s => write!(f, "add.s")?, [INFO] [stderr] 28 | | &Inst::sub_u => write!(f, "sub.u")?, [INFO] [stderr] ... | [INFO] [stderr] 40 | | &Inst::call(idx) => write!(f, "call {}", idx)?, [INFO] [stderr] 41 | | }; [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::match_ref_pats)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 25 | match *self { [INFO] [stderr] 26 | Inst::add_u => write!(f, "add.u")?, [INFO] [stderr] 27 | Inst::add_s => write!(f, "add.s")?, [INFO] [stderr] 28 | Inst::sub_u => write!(f, "sub.u")?, [INFO] [stderr] 29 | Inst::sub_s => write!(f, "sub.s")?, [INFO] [stderr] 30 | Inst::mul_u => write!(f, "mul.u")?, [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: explicit lifetimes given in parameter types where they could be elided (or replaced with `'_` if needed by type declaration) [INFO] [stderr] --> src/assembly.rs:22:5 [INFO] [stderr] | [INFO] [stderr] 22 | / pub fn name<'a>(&'a self) -> &'a str { [INFO] [stderr] 23 | | match self { [INFO] [stderr] 24 | | FuncDef::Managed(ManagedFuncDef { name, .. }) => &name, [INFO] [stderr] 25 | | FuncDef::Native(NativeFuncDef { name, .. }) => &name, [INFO] [stderr] 26 | | } [INFO] [stderr] 27 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_lifetimes)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes [INFO] [stderr] [INFO] [stderr] warning: you should consider deriving a `Default` implementation for `loader::Loader` [INFO] [stderr] --> src/loader.rs:17:5 [INFO] [stderr] | [INFO] [stderr] 17 | / pub fn new() -> Self { [INFO] [stderr] 18 | | Self { [INFO] [stderr] 19 | | entry: None, [INFO] [stderr] 20 | | functions: Vec::new(), [INFO] [stderr] ... | [INFO] [stderr] 26 | | } [INFO] [stderr] 27 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::new_without_default_derive)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default_derive [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 6 | #[derive(Default)] [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/instructions.rs:25:9 [INFO] [stderr] | [INFO] [stderr] 25 | / match self { [INFO] [stderr] 26 | | &Inst::add_u => write!(f, "add.u")?, [INFO] [stderr] 27 | | &Inst::add_s => write!(f, "add.s")?, [INFO] [stderr] 28 | | &Inst::sub_u => write!(f, "sub.u")?, [INFO] [stderr] ... | [INFO] [stderr] 40 | | &Inst::call(idx) => write!(f, "call {}", idx)?, [INFO] [stderr] 41 | | }; [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::match_ref_pats)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 25 | match *self { [INFO] [stderr] 26 | Inst::add_u => write!(f, "add.u")?, [INFO] [stderr] 27 | Inst::add_s => write!(f, "add.s")?, [INFO] [stderr] 28 | Inst::sub_u => write!(f, "sub.u")?, [INFO] [stderr] 29 | Inst::sub_s => write!(f, "sub.s")?, [INFO] [stderr] 30 | Inst::mul_u => write!(f, "mul.u")?, [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: you should consider deriving a `Default` implementation for `loader::Loader` [INFO] [stderr] --> src/loader.rs:17:5 [INFO] [stderr] | [INFO] [stderr] 17 | / pub fn new() -> Self { [INFO] [stderr] 18 | | Self { [INFO] [stderr] 19 | | entry: None, [INFO] [stderr] 20 | | functions: Vec::new(), [INFO] [stderr] ... | [INFO] [stderr] 26 | | } [INFO] [stderr] 27 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::new_without_default_derive)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default_derive [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 6 | #[derive(Default)] [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 3.27s [INFO] running `"docker" "inspect" "d066cb8f2eea448f9c28cd4f36333a16b92aa99ea6175c99daff7a5fc035752c"` [INFO] running `"docker" "rm" "-f" "d066cb8f2eea448f9c28cd4f36333a16b92aa99ea6175c99daff7a5fc035752c"` [INFO] [stdout] d066cb8f2eea448f9c28cd4f36333a16b92aa99ea6175c99daff7a5fc035752c