[INFO] updating cached repository darksv/futon [INFO] running `"git" "fetch" "--all"` [INFO] [stdout] Fetching origin [INFO] [stderr] From git://github.com/darksv/futon [INFO] [stderr] * branch HEAD -> FETCH_HEAD [INFO] running `"git" "clone" "work/cache/sources/gh/darksv/futon" "work/ex/clippy-test-run/sources/stable/gh/darksv/futon"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/darksv/futon'... [INFO] [stderr] done. [INFO] running `"git" "clone" "work/cache/sources/gh/darksv/futon" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/darksv/futon"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/darksv/futon'... [INFO] [stderr] done. [INFO] running `"git" "rev-parse" "HEAD"` [INFO] [stdout] c1641aa859df9f05a202bc5e0d9416009fefa051 [INFO] sha for GitHub repo darksv/futon: c1641aa859df9f05a202bc5e0d9416009fefa051 [INFO] validating manifest of darksv/futon on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of darksv/futon on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing darksv/futon [INFO] finished frobbing darksv/futon [INFO] frobbed toml for darksv/futon written to work/ex/clippy-test-run/sources/stable/gh/darksv/futon/Cargo.toml [INFO] started frobbing darksv/futon [INFO] finished frobbing darksv/futon [INFO] frobbed toml for darksv/futon written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/darksv/futon/Cargo.toml [INFO] crate darksv/futon has a lockfile. skipping [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting darksv/futon against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-5/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/gh/darksv/futon:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] bf9460cf56ac677d940fe364448d44b2692dba2777aa1567a6bea098fe5b03c3 [INFO] running `"docker" "start" "-a" "bf9460cf56ac677d940fe364448d44b2692dba2777aa1567a6bea098fe5b03c3"` [INFO] [stderr] Checking untitled v0.1.0 (/opt/crater/workdir) [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/parser.rs:327:9 [INFO] [stderr] | [INFO] [stderr] 327 | return true; [INFO] [stderr] | ^^^^^^^^^^^^ help: remove `return` as shown: `true` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_return)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unused import: `PunctKind` [INFO] [stderr] --> src/lexer.rs:540:87 [INFO] [stderr] | [INFO] [stderr] 540 | use super::{Lexer, LexerError, Token, SourceSpan, TokenType, TokenValue, Keyword, PunctKind}; [INFO] [stderr] | ^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_imports)] on by default [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/parser.rs:327:9 [INFO] [stderr] | [INFO] [stderr] 327 | return true; [INFO] [stderr] | ^^^^^^^^^^^^ help: remove `return` as shown: `true` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_return)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: method is never used: `from_str` [INFO] [stderr] --> src/lexer.rs:235:5 [INFO] [stderr] | [INFO] [stderr] 235 | pub fn from_str(str: &'a str, line: usize, column: usize) -> SourceSpan<'a> { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(dead_code)] on by default [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/lexer.rs:12:17 [INFO] [stderr] | [INFO] [stderr] 12 | / match self { [INFO] [stderr] 13 | | $(&Keyword::$name => write!(f, $val)?),* [INFO] [stderr] 14 | | } [INFO] [stderr] | |_________________^ [INFO] [stderr] ... [INFO] [stderr] 30 | / keywords! { [INFO] [stderr] 31 | | "if" => If, [INFO] [stderr] 32 | | "else" => Else, [INFO] [stderr] 33 | | "for" => For, [INFO] [stderr] ... | [INFO] [stderr] 42 | | "in" => In [INFO] [stderr] 43 | | } [INFO] [stderr] | |_- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::match_ref_pats)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/parser.rs:56:9 [INFO] [stderr] | [INFO] [stderr] 56 | / match self { [INFO] [stderr] 57 | | &ParseError::UnexpectedToken(actual, line, column, None) => { [INFO] [stderr] 58 | | write!(f, "Unexpected {:?} at {}:{}", actual, line, column)? [INFO] [stderr] 59 | | } [INFO] [stderr] ... | [INFO] [stderr] 62 | | } [INFO] [stderr] 63 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 56 | match *self { [INFO] [stderr] 57 | ParseError::UnexpectedToken(actual, line, column, None) => { [INFO] [stderr] 58 | write!(f, "Unexpected {:?} at {}:{}", actual, line, column)? [INFO] [stderr] 59 | } [INFO] [stderr] 60 | ParseError::UnexpectedToken(actual, line, column, Some(expected)) => { [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/lexer.rs:12:17 [INFO] [stderr] | [INFO] [stderr] 12 | / match self { [INFO] [stderr] 13 | | $(&Keyword::$name => write!(f, $val)?),* [INFO] [stderr] 14 | | } [INFO] [stderr] | |_________________^ [INFO] [stderr] ... [INFO] [stderr] 30 | / keywords! { [INFO] [stderr] 31 | | "if" => If, [INFO] [stderr] 32 | | "else" => Else, [INFO] [stderr] 33 | | "for" => For, [INFO] [stderr] ... | [INFO] [stderr] 42 | | "in" => In [INFO] [stderr] 43 | | } [INFO] [stderr] | |_- in this macro invocation [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::match_ref_pats)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/parser.rs:56:9 [INFO] [stderr] | [INFO] [stderr] 56 | / match self { [INFO] [stderr] 57 | | &ParseError::UnexpectedToken(actual, line, column, None) => { [INFO] [stderr] 58 | | write!(f, "Unexpected {:?} at {}:{}", actual, line, column)? [INFO] [stderr] 59 | | } [INFO] [stderr] ... | [INFO] [stderr] 62 | | } [INFO] [stderr] 63 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 56 | match *self { [INFO] [stderr] 57 | ParseError::UnexpectedToken(actual, line, column, None) => { [INFO] [stderr] 58 | write!(f, "Unexpected {:?} at {}:{}", actual, line, column)? [INFO] [stderr] 59 | } [INFO] [stderr] 60 | ParseError::UnexpectedToken(actual, line, column, Some(expected)) => { [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 1.55s [INFO] running `"docker" "inspect" "bf9460cf56ac677d940fe364448d44b2692dba2777aa1567a6bea098fe5b03c3"` [INFO] running `"docker" "rm" "-f" "bf9460cf56ac677d940fe364448d44b2692dba2777aa1567a6bea098fe5b03c3"` [INFO] [stdout] bf9460cf56ac677d940fe364448d44b2692dba2777aa1567a6bea098fe5b03c3