[INFO] updating cached repository daph/lada [INFO] running `"git" "fetch" "--all"` [INFO] [stdout] Fetching origin [INFO] [stderr] From git://github.com/daph/lada [INFO] [stderr] * branch HEAD -> FETCH_HEAD [INFO] running `"git" "clone" "work/cache/sources/gh/daph/lada" "work/ex/clippy-test-run/sources/stable/gh/daph/lada"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/daph/lada'... [INFO] [stderr] done. [INFO] running `"git" "clone" "work/cache/sources/gh/daph/lada" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/daph/lada"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/daph/lada'... [INFO] [stderr] done. [INFO] running `"git" "rev-parse" "HEAD"` [INFO] [stdout] 69ef0421477d9ec357801186e15509c79aa0c8ad [INFO] sha for GitHub repo daph/lada: 69ef0421477d9ec357801186e15509c79aa0c8ad [INFO] validating manifest of daph/lada on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of daph/lada on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing daph/lada [INFO] finished frobbing daph/lada [INFO] frobbed toml for daph/lada written to work/ex/clippy-test-run/sources/stable/gh/daph/lada/Cargo.toml [INFO] started frobbing daph/lada [INFO] finished frobbing daph/lada [INFO] frobbed toml for daph/lada written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/daph/lada/Cargo.toml [INFO] crate daph/lada has a lockfile. skipping [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] [stderr] Blocking waiting for file lock on the registry index [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting daph/lada against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-7/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/gh/daph/lada:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 42bef5a76f8ced4e27d45442521b8e6d8cd01c29f1a590301e387ced2730050a [INFO] running `"docker" "start" "-a" "42bef5a76f8ced4e27d45442521b8e6d8cd01c29f1a590301e387ced2730050a"` [INFO] [stderr] Checking input_buffer v0.2.0 [INFO] [stderr] Checking regex v0.2.11 [INFO] [stderr] Checking sha-1 v0.8.1 [INFO] [stderr] Checking hyper v0.12.14 [INFO] [stderr] Checking tungstenite v0.6.1 [INFO] [stderr] Checking hyper-tls v0.3.1 [INFO] [stderr] Checking reqwest v0.9.5 [INFO] [stderr] Checking slack_api v0.21.0 [INFO] [stderr] Checking slack v0.22.0 [INFO] [stderr] Checking lada v0.2.0 (/opt/crater/workdir) [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/client.rs:26:13 [INFO] [stderr] | [INFO] [stderr] 26 | brain: brain, [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `brain` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/client.rs:27:13 [INFO] [stderr] | [INFO] [stderr] 27 | sentences: sentences [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: replace it with: `sentences` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/client.rs:26:13 [INFO] [stderr] | [INFO] [stderr] 26 | brain: brain, [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `brain` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/client.rs:27:13 [INFO] [stderr] | [INFO] [stderr] 27 | sentences: sentences [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: replace it with: `sentences` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: you should consider deriving a `Default` implementation for `brain::Brain` [INFO] [stderr] --> src/brain.rs:17:5 [INFO] [stderr] | [INFO] [stderr] 17 | / pub fn new() -> Brain { [INFO] [stderr] 18 | | Brain { brain_map: Default::default() } [INFO] [stderr] 19 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::new_without_default_derive)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default_derive [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 12 | #[derive(Default)] [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: use of `or_insert` followed by a function call [INFO] [stderr] --> src/brain.rs:31:56 [INFO] [stderr] | [INFO] [stderr] 31 | let words = self.brain_map.entry((w1, w2)).or_insert(vec![]); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: try this: `or_insert_with(|| vec![])` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::or_fun_call)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/client.rs:35:13 [INFO] [stderr] | [INFO] [stderr] 35 | / match *msg { [INFO] [stderr] 36 | | slack_api::Message::Standard(my_msg) => { [INFO] [stderr] 37 | | let user = my_msg.user.unwrap_or("".to_owned()); [INFO] [stderr] 38 | | let text = my_msg.text.unwrap_or("".to_owned()); [INFO] [stderr] ... | [INFO] [stderr] 83 | | _ => () [INFO] [stderr] 84 | | } [INFO] [stderr] | |_____________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::single_match)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 35 | if let slack_api::Message::Standard(my_msg) = *msg { [INFO] [stderr] 36 | let user = my_msg.user.unwrap_or("".to_owned()); [INFO] [stderr] 37 | let text = my_msg.text.unwrap_or("".to_owned()); [INFO] [stderr] 38 | let channel = my_msg.channel.unwrap_or("".to_owned()); [INFO] [stderr] 39 | [INFO] [stderr] 40 | let re_name = Regex::new(&format!("(?i){}", self.name)).unwrap(); [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: use of `unwrap_or` followed by a function call [INFO] [stderr] --> src/client.rs:37:44 [INFO] [stderr] | [INFO] [stderr] 37 | let user = my_msg.user.unwrap_or("".to_owned()); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `unwrap_or_else(|| "".to_owned())` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] warning: use of `unwrap_or` followed by a function call [INFO] [stderr] --> src/client.rs:38:44 [INFO] [stderr] | [INFO] [stderr] 38 | let text = my_msg.text.unwrap_or("".to_owned()); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `unwrap_or_else(|| "".to_owned())` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] warning: use of `unwrap_or` followed by a function call [INFO] [stderr] --> src/client.rs:39:50 [INFO] [stderr] | [INFO] [stderr] 39 | let channel = my_msg.channel.unwrap_or("".to_owned()); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `unwrap_or_else(|| "".to_owned())` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] warning: you should consider deriving a `Default` implementation for `brain::Brain` [INFO] [stderr] --> src/brain.rs:17:5 [INFO] [stderr] | [INFO] [stderr] 17 | / pub fn new() -> Brain { [INFO] [stderr] 18 | | Brain { brain_map: Default::default() } [INFO] [stderr] 19 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::new_without_default_derive)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default_derive [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 12 | #[derive(Default)] [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: use of `or_insert` followed by a function call [INFO] [stderr] --> src/brain.rs:31:56 [INFO] [stderr] | [INFO] [stderr] 31 | let words = self.brain_map.entry((w1, w2)).or_insert(vec![]); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: try this: `or_insert_with(|| vec![])` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::or_fun_call)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/client.rs:35:13 [INFO] [stderr] | [INFO] [stderr] 35 | / match *msg { [INFO] [stderr] 36 | | slack_api::Message::Standard(my_msg) => { [INFO] [stderr] 37 | | let user = my_msg.user.unwrap_or("".to_owned()); [INFO] [stderr] 38 | | let text = my_msg.text.unwrap_or("".to_owned()); [INFO] [stderr] ... | [INFO] [stderr] 83 | | _ => () [INFO] [stderr] 84 | | } [INFO] [stderr] | |_____________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::single_match)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 35 | if let slack_api::Message::Standard(my_msg) = *msg { [INFO] [stderr] 36 | let user = my_msg.user.unwrap_or("".to_owned()); [INFO] [stderr] 37 | let text = my_msg.text.unwrap_or("".to_owned()); [INFO] [stderr] 38 | let channel = my_msg.channel.unwrap_or("".to_owned()); [INFO] [stderr] 39 | [INFO] [stderr] 40 | let re_name = Regex::new(&format!("(?i){}", self.name)).unwrap(); [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: use of `unwrap_or` followed by a function call [INFO] [stderr] --> src/client.rs:37:44 [INFO] [stderr] | [INFO] [stderr] 37 | let user = my_msg.user.unwrap_or("".to_owned()); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `unwrap_or_else(|| "".to_owned())` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] warning: use of `unwrap_or` followed by a function call [INFO] [stderr] --> src/client.rs:38:44 [INFO] [stderr] | [INFO] [stderr] 38 | let text = my_msg.text.unwrap_or("".to_owned()); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `unwrap_or_else(|| "".to_owned())` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] warning: use of `unwrap_or` followed by a function call [INFO] [stderr] --> src/client.rs:39:50 [INFO] [stderr] | [INFO] [stderr] 39 | let channel = my_msg.channel.unwrap_or("".to_owned()); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `unwrap_or_else(|| "".to_owned())` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] warning: casting u32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/main.rs:64:56 [INFO] [stderr] | [INFO] [stderr] 64 | let elapsed_secs = duration.as_secs() as f64 + duration.subsec_nanos() as f64 * 1e-9; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `f64::from(duration.subsec_nanos())` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cast_lossless)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/main.rs:64:56 [INFO] [stderr] | [INFO] [stderr] 64 | let elapsed_secs = duration.as_secs() as f64 + duration.subsec_nanos() as f64 * 1e-9; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `f64::from(duration.subsec_nanos())` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cast_lossless)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/main.rs:78:56 [INFO] [stderr] | [INFO] [stderr] 78 | let elapsed_secs = duration.as_secs() as f64 + duration.subsec_nanos() as f64 * 1e-9; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `f64::from(duration.subsec_nanos())` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/main.rs:78:56 [INFO] [stderr] | [INFO] [stderr] 78 | let elapsed_secs = duration.as_secs() as f64 + duration.subsec_nanos() as f64 * 1e-9; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `f64::from(duration.subsec_nanos())` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 1m 03s [INFO] running `"docker" "inspect" "42bef5a76f8ced4e27d45442521b8e6d8cd01c29f1a590301e387ced2730050a"` [INFO] running `"docker" "rm" "-f" "42bef5a76f8ced4e27d45442521b8e6d8cd01c29f1a590301e387ced2730050a"` [INFO] [stdout] 42bef5a76f8ced4e27d45442521b8e6d8cd01c29f1a590301e387ced2730050a