[INFO] updating cached repository daogangtang/learn-tokio [INFO] running `"git" "fetch" "--all"` [INFO] [stdout] Fetching origin [INFO] [stderr] From git://github.com/daogangtang/learn-tokio [INFO] [stderr] * branch HEAD -> FETCH_HEAD [INFO] running `"git" "clone" "work/cache/sources/gh/daogangtang/learn-tokio" "work/ex/clippy-test-run/sources/stable/gh/daogangtang/learn-tokio"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/daogangtang/learn-tokio'... [INFO] [stderr] done. [INFO] running `"git" "clone" "work/cache/sources/gh/daogangtang/learn-tokio" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/daogangtang/learn-tokio"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/daogangtang/learn-tokio'... [INFO] [stderr] done. [INFO] running `"git" "rev-parse" "HEAD"` [INFO] [stdout] 98b13be0e474ffb1b6a4f84b3e9caa91d100296a [INFO] sha for GitHub repo daogangtang/learn-tokio: 98b13be0e474ffb1b6a4f84b3e9caa91d100296a [INFO] validating manifest of daogangtang/learn-tokio on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of daogangtang/learn-tokio on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing daogangtang/learn-tokio [INFO] finished frobbing daogangtang/learn-tokio [INFO] frobbed toml for daogangtang/learn-tokio written to work/ex/clippy-test-run/sources/stable/gh/daogangtang/learn-tokio/Cargo.toml [INFO] started frobbing daogangtang/learn-tokio [INFO] finished frobbing daogangtang/learn-tokio [INFO] frobbed toml for daogangtang/learn-tokio written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/daogangtang/learn-tokio/Cargo.toml [INFO] crate daogangtang/learn-tokio has a lockfile. skipping [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting daogangtang/learn-tokio against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-3/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/gh/daogangtang/learn-tokio:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 2ebc9cc8a24693b2c67af1d7a293fda1ef20e8393fadb01caab791f8102e7e8d [INFO] running `"docker" "start" "-a" "2ebc9cc8a24693b2c67af1d7a293fda1ef20e8393fadb01caab791f8102e7e8d"` [INFO] [stderr] Checking learn-tokio0 v0.1.0 (/opt/crater/workdir) [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/concurrent_send_recv.rs:56:9 [INFO] [stderr] | [INFO] [stderr] 56 | rx0: rx0, [INFO] [stderr] | ^^^^^^^^ help: replace it with: `rx0` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/concurrent_send_recv2.rs:66:9 [INFO] [stderr] | [INFO] [stderr] 66 | rx0: rx0, [INFO] [stderr] | ^^^^^^^^ help: replace it with: `rx0` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/concurrent_send_recv2.rs:67:9 [INFO] [stderr] | [INFO] [stderr] 67 | tx1: tx1 [INFO] [stderr] | ^^^^^^^^ help: replace it with: `tx1` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: unused import: `tokio::io` [INFO] [stderr] --> src/tcp_server.rs:5:5 [INFO] [stderr] | [INFO] [stderr] 5 | use tokio::io; [INFO] [stderr] | ^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_imports)] on by default [INFO] [stderr] [INFO] [stderr] warning: unused import: `tokio::prelude` [INFO] [stderr] --> src/tcp_server.rs:7:5 [INFO] [stderr] | [INFO] [stderr] 7 | use tokio::prelude::*; [INFO] [stderr] | ^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: unused variable: `e` [INFO] [stderr] --> src/tcp_server.rs:37:31 [INFO] [stderr] | [INFO] [stderr] 37 | .map_err(|e| std::io::Error::new(std::io::ErrorKind::Other, "oh no!")) [INFO] [stderr] | ^ help: consider using `_e` instead [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_variables)] on by default [INFO] [stderr] [INFO] [stderr] warning: use of `unwrap_or` followed by a function call [INFO] [stderr] --> src/tcp_server.rs:20:10 [INFO] [stderr] | [INFO] [stderr] 20 | .unwrap_or("127.0.0.1:8080".to_string()); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `unwrap_or_else(|| "127.0.0.1:8080".to_string())` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::or_fun_call)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] warning: unused variable: `e` [INFO] [stderr] --> src/tcp_server3.rs:29:31 [INFO] [stderr] | [INFO] [stderr] 29 | .map_err(|e| std::io::Error::new(std::io::ErrorKind::Other, "oh no!")) [INFO] [stderr] | ^ help: consider using `_e` instead [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_variables)] on by default [INFO] [stderr] [INFO] [stderr] warning: use of `unwrap_or` followed by a function call [INFO] [stderr] --> src/tcp_server3.rs:9:10 [INFO] [stderr] | [INFO] [stderr] 9 | .unwrap_or("127.0.0.1:8080".to_string()); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `unwrap_or_else(|| "127.0.0.1:8080".to_string())` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::or_fun_call)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] warning: unused import: `futures::try_ready` [INFO] [stderr] --> src/concurrent_send_recv.rs:7:5 [INFO] [stderr] | [INFO] [stderr] 7 | use futures::try_ready; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_imports)] on by default [INFO] [stderr] [INFO] [stderr] warning: unused variable: `e` [INFO] [stderr] --> src/tcp_server3.rs:29:31 [INFO] [stderr] | [INFO] [stderr] 29 | .map_err(|e| std::io::Error::new(std::io::ErrorKind::Other, "oh no!")) [INFO] [stderr] | ^ help: consider using `_e` instead [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_variables)] on by default [INFO] [stderr] [INFO] [stderr] warning: use of `unwrap_or` followed by a function call [INFO] [stderr] --> src/tcp_server3.rs:9:10 [INFO] [stderr] | [INFO] [stderr] 9 | .unwrap_or("127.0.0.1:8080".to_string()); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `unwrap_or_else(|| "127.0.0.1:8080".to_string())` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::or_fun_call)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] warning: unused import: `futures::try_ready` [INFO] [stderr] --> src/concurrent_send_recv2.rs:7:5 [INFO] [stderr] | [INFO] [stderr] 7 | use futures::try_ready; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_imports)] on by default [INFO] [stderr] [INFO] [stderr] warning: this loop could be written as a `while let` loop [INFO] [stderr] --> src/concurrent_send_recv2.rs:26:9 [INFO] [stderr] | [INFO] [stderr] 26 | / loop { [INFO] [stderr] 27 | | //let msg = try_ready!(self.rx0.poll().unwrap()); [INFO] [stderr] 28 | | match self.rx0.poll().unwrap() { [INFO] [stderr] 29 | | Async::Ready(Some(msg)) => { [INFO] [stderr] ... | [INFO] [stderr] 35 | | [INFO] [stderr] 36 | | } [INFO] [stderr] | |_________^ help: try: `while let Async::Ready(Some(msg)) = self.rx0.poll().unwrap() { .. }` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::while_let_loop)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#while_let_loop [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/concurrent_send_recv2.rs:54:13 [INFO] [stderr] | [INFO] [stderr] 54 | / match rx1.poll().unwrap() { [INFO] [stderr] 55 | | Async::Ready(Some(msg)) => { [INFO] [stderr] 56 | | println!("<=== {:?}", msg); [INFO] [stderr] 57 | | } [INFO] [stderr] 58 | | _ => (), [INFO] [stderr] 59 | | } [INFO] [stderr] | |_____________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::single_match)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 54 | if let Async::Ready(Some(msg)) = rx1.poll().unwrap() { [INFO] [stderr] 55 | println!("<=== {:?}", msg); [INFO] [stderr] 56 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: this loop could be written as a `while let` loop [INFO] [stderr] --> src/concurrent_send_recv.rs:25:9 [INFO] [stderr] | [INFO] [stderr] 25 | / loop { [INFO] [stderr] 26 | | //let msg = try_ready!(self.rx0.poll().unwrap()); [INFO] [stderr] 27 | | match self.rx0.poll().unwrap() { [INFO] [stderr] 28 | | Async::Ready(Some(msg)) => { [INFO] [stderr] ... | [INFO] [stderr] 33 | | [INFO] [stderr] 34 | | } [INFO] [stderr] | |_________^ help: try: `while let Async::Ready(Some(msg)) = self.rx0.poll().unwrap() { .. }` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::while_let_loop)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#while_let_loop [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/concurrent_send_recv.rs:56:9 [INFO] [stderr] | [INFO] [stderr] 56 | rx0: rx0, [INFO] [stderr] | ^^^^^^^^ help: replace it with: `rx0` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] error: redundant field names in struct initialization [INFO] [stderr] --> src/echo_udp.rs:61:9 [INFO] [stderr] | [INFO] [stderr] 61 | socket: socket, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `socket` [INFO] [stderr] | [INFO] [stderr] note: lint level defined here [INFO] [stderr] --> src/echo_udp.rs:13:9 [INFO] [stderr] | [INFO] [stderr] 13 | #![deny(warnings)] [INFO] [stderr] | ^^^^^^^^ [INFO] [stderr] = note: #[deny(clippy::redundant_field_names)] implied by #[deny(warnings)] [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] error: use of `unwrap_or` followed by a function call [INFO] [stderr] --> src/print_each_packet.rs:72:35 [INFO] [stderr] | [INFO] [stderr] 72 | let addr = env::args().nth(1).unwrap_or("127.0.0.1:8080".to_string()); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `unwrap_or_else(|| "127.0.0.1:8080".to_string())` [INFO] [stderr] | [INFO] [stderr] note: lint level defined here [INFO] [stderr] --> src/print_each_packet.rs:55:9 [INFO] [stderr] | [INFO] [stderr] 55 | #![deny(warnings)] [INFO] [stderr] | ^^^^^^^^ [INFO] [stderr] = note: #[deny(clippy::or_fun_call)] implied by #[deny(warnings)] [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] error: aborting due to previous error [INFO] [stderr] [INFO] [stderr] error: Could not compile `learn-tokio0`. [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stderr] error: use of `unwrap_or` followed by a function call [INFO] [stderr] --> src/print_each_packet.rs:72:35 [INFO] [stderr] | [INFO] [stderr] 72 | let addr = env::args().nth(1).unwrap_or("127.0.0.1:8080".to_string()); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `unwrap_or_else(|| "127.0.0.1:8080".to_string())` [INFO] [stderr] | [INFO] [stderr] note: lint level defined here [INFO] [stderr] --> src/print_each_packet.rs:55:9 [INFO] [stderr] | [INFO] [stderr] 55 | #![deny(warnings)] [INFO] [stderr] | ^^^^^^^^ [INFO] [stderr] = note: #[deny(clippy::or_fun_call)] implied by #[deny(warnings)] [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] error: aborting due to previous error [INFO] [stderr] [INFO] [stderr] error: Could not compile `learn-tokio0`. [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stderr] warning: unused import: `tokio::io` [INFO] [stderr] --> src/tcp_server.rs:5:5 [INFO] [stderr] | [INFO] [stderr] 5 | use tokio::io; [INFO] [stderr] | ^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_imports)] on by default [INFO] [stderr] [INFO] [stderr] warning: unused import: `tokio::prelude` [INFO] [stderr] --> src/tcp_server.rs:7:5 [INFO] [stderr] | [INFO] [stderr] 7 | use tokio::prelude::*; [INFO] [stderr] | ^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: unused variable: `e` [INFO] [stderr] --> src/tcp_server.rs:37:31 [INFO] [stderr] | [INFO] [stderr] 37 | .map_err(|e| std::io::Error::new(std::io::ErrorKind::Other, "oh no!")) [INFO] [stderr] | ^ help: consider using `_e` instead [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_variables)] on by default [INFO] [stderr] [INFO] [stderr] error: aborting due to previous error [INFO] [stderr] warning: use of `unwrap_or` followed by a function call [INFO] [stderr] --> src/tcp_server.rs:20:10 [INFO] [stderr] | [INFO] [stderr] 20 | .unwrap_or("127.0.0.1:8080".to_string()); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `unwrap_or_else(|| "127.0.0.1:8080".to_string())` [INFO] [stderr] [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::or_fun_call)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] error: Could not compile `learn-tokio0`. [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stderr] warning: returning the result of a let binding from a block. Consider returning the expression directly. [INFO] [stderr] --> src/tcp_client.rs:27:9 [INFO] [stderr] | [INFO] [stderr] 27 | a [INFO] [stderr] | ^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::let_and_return)] on by default [INFO] [stderr] note: this expression can be directly returned [INFO] [stderr] --> src/tcp_client.rs:18:17 [INFO] [stderr] | [INFO] [stderr] 18 | let a = sink.send("hello, tokio\n".into()) [INFO] [stderr] | _________________^ [INFO] [stderr] 19 | | .and_then(|a_sink|{ [INFO] [stderr] 20 | | let a_stream = stream.map(|msg|{ [INFO] [stderr] 21 | | println!("received msg: {:?}", msg); [INFO] [stderr] ... | [INFO] [stderr] 24 | | a_sink.send_all(a_stream) [INFO] [stderr] 25 | | }); [INFO] [stderr] | |______________^ [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_and_return [INFO] [stderr] [INFO] [stderr] warning: unused variable: `stdout` [INFO] [stderr] --> src/tcp_client.rs:12:13 [INFO] [stderr] | [INFO] [stderr] 12 | let mut stdout = io::stdout(); [INFO] [stderr] | ^^^^^^ help: consider using `_stdout` instead [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_variables)] on by default [INFO] [stderr] [INFO] [stderr] warning: variable does not need to be mutable [INFO] [stderr] --> src/tcp_client.rs:12:9 [INFO] [stderr] | [INFO] [stderr] 12 | let mut stdout = io::stdout(); [INFO] [stderr] | ----^^^^^^ [INFO] [stderr] | | [INFO] [stderr] | help: remove this `mut` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_mut)] on by default [INFO] [stderr] [INFO] [stderr] warning: unused import: `futures::try_ready` [INFO] [stderr] --> src/concurrent_send_recv.rs:7:5 [INFO] [stderr] | [INFO] [stderr] 7 | use futures::try_ready; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_imports)] on by default [INFO] [stderr] [INFO] [stderr] warning: this loop could be written as a `while let` loop [INFO] [stderr] --> src/concurrent_send_recv.rs:25:9 [INFO] [stderr] | [INFO] [stderr] 25 | / loop { [INFO] [stderr] 26 | | //let msg = try_ready!(self.rx0.poll().unwrap()); [INFO] [stderr] 27 | | match self.rx0.poll().unwrap() { [INFO] [stderr] 28 | | Async::Ready(Some(msg)) => { [INFO] [stderr] ... | [INFO] [stderr] 33 | | [INFO] [stderr] 34 | | } [INFO] [stderr] | |_________^ help: try: `while let Async::Ready(Some(msg)) = self.rx0.poll().unwrap() { .. }` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::while_let_loop)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#while_let_loop [INFO] [stderr] [INFO] [stderr] error: build failed [INFO] running `"docker" "inspect" "2ebc9cc8a24693b2c67af1d7a293fda1ef20e8393fadb01caab791f8102e7e8d"` [INFO] running `"docker" "rm" "-f" "2ebc9cc8a24693b2c67af1d7a293fda1ef20e8393fadb01caab791f8102e7e8d"` [INFO] [stdout] 2ebc9cc8a24693b2c67af1d7a293fda1ef20e8393fadb01caab791f8102e7e8d