[INFO] updating cached repository danreeves/todo-rs [INFO] running `"git" "fetch" "--all"` [INFO] [stdout] Fetching origin [INFO] [stderr] From git://github.com/danreeves/todo-rs [INFO] [stderr] * branch HEAD -> FETCH_HEAD [INFO] running `"git" "clone" "work/cache/sources/gh/danreeves/todo-rs" "work/ex/clippy-test-run/sources/stable/gh/danreeves/todo-rs"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/danreeves/todo-rs'... [INFO] [stderr] done. [INFO] running `"git" "clone" "work/cache/sources/gh/danreeves/todo-rs" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/danreeves/todo-rs"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/danreeves/todo-rs'... [INFO] [stderr] done. [INFO] running `"git" "rev-parse" "HEAD"` [INFO] [stdout] 7a6d4352371d88eeaa6a76b6e4b037090571cdc4 [INFO] sha for GitHub repo danreeves/todo-rs: 7a6d4352371d88eeaa6a76b6e4b037090571cdc4 [INFO] validating manifest of danreeves/todo-rs on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of danreeves/todo-rs on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing danreeves/todo-rs [INFO] finished frobbing danreeves/todo-rs [INFO] frobbed toml for danreeves/todo-rs written to work/ex/clippy-test-run/sources/stable/gh/danreeves/todo-rs/Cargo.toml [INFO] started frobbing danreeves/todo-rs [INFO] finished frobbing danreeves/todo-rs [INFO] frobbed toml for danreeves/todo-rs written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/danreeves/todo-rs/Cargo.toml [INFO] crate danreeves/todo-rs has a lockfile. skipping [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting danreeves/todo-rs against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-3/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/gh/danreeves/todo-rs:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 1eed2363b3b09fee58a3ed081d7157f9a40e08bbf503530ef1f52473690f0fb6 [INFO] running `"docker" "start" "-a" "1eed2363b3b09fee58a3ed081d7157f9a40e08bbf503530ef1f52473690f0fb6"` [INFO] [stderr] Checking cassowary v0.3.0 [INFO] [stderr] Checking log v0.4.4 [INFO] [stderr] Checking tui v0.2.3 [INFO] [stderr] Checking todo-rs v0.1.0 (/opt/crater/workdir) [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/editor.rs:5:24 [INFO] [stderr] | [INFO] [stderr] 5 | pub fn handle_key(key: &event::Key, body: &mut String) { [INFO] [stderr] | ^^^^^^^^^^^ help: consider passing by value instead: `event::Key` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::trivially_copy_pass_by_ref)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/editor.rs:13:39 [INFO] [stderr] | [INFO] [stderr] 13 | fn update_text(text: &mut String, ch: &char) { [INFO] [stderr] | ^^^^^ help: consider passing by value instead: `char` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/renderer.rs:6:56 [INFO] [stderr] | [INFO] [stderr] 6 | pub fn draw(terminal: &mut Terminal, size: &Rect, body: &str) { [INFO] [stderr] | ^^^^^ help: consider passing by value instead: `Rect` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/editor.rs:5:24 [INFO] [stderr] | [INFO] [stderr] 5 | pub fn handle_key(key: &event::Key, body: &mut String) { [INFO] [stderr] | ^^^^^^^^^^^ help: consider passing by value instead: `event::Key` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::trivially_copy_pass_by_ref)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/editor.rs:13:39 [INFO] [stderr] | [INFO] [stderr] 13 | fn update_text(text: &mut String, ch: &char) { [INFO] [stderr] | ^^^^^ help: consider passing by value instead: `char` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/renderer.rs:6:56 [INFO] [stderr] | [INFO] [stderr] 6 | pub fn draw(terminal: &mut Terminal, size: &Rect, body: &str) { [INFO] [stderr] | ^^^^^ help: consider passing by value instead: `Rect` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 4.11s [INFO] running `"docker" "inspect" "1eed2363b3b09fee58a3ed081d7157f9a40e08bbf503530ef1f52473690f0fb6"` [INFO] running `"docker" "rm" "-f" "1eed2363b3b09fee58a3ed081d7157f9a40e08bbf503530ef1f52473690f0fb6"` [INFO] [stdout] 1eed2363b3b09fee58a3ed081d7157f9a40e08bbf503530ef1f52473690f0fb6