[INFO] updating cached repository danreeves/now-cli [INFO] running `"git" "fetch" "--all"` [INFO] [stdout] Fetching origin [INFO] [stderr] From git://github.com/danreeves/now-cli [INFO] [stderr] * branch HEAD -> FETCH_HEAD [INFO] running `"git" "clone" "work/cache/sources/gh/danreeves/now-cli" "work/ex/clippy-test-run/sources/stable/gh/danreeves/now-cli"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/danreeves/now-cli'... [INFO] [stderr] done. [INFO] running `"git" "clone" "work/cache/sources/gh/danreeves/now-cli" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/danreeves/now-cli"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/danreeves/now-cli'... [INFO] [stderr] done. [INFO] running `"git" "rev-parse" "HEAD"` [INFO] [stdout] 0b9553a3c912f00b85e20c5c88252022c82430fd [INFO] sha for GitHub repo danreeves/now-cli: 0b9553a3c912f00b85e20c5c88252022c82430fd [INFO] validating manifest of danreeves/now-cli on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of danreeves/now-cli on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing danreeves/now-cli [INFO] finished frobbing danreeves/now-cli [INFO] frobbed toml for danreeves/now-cli written to work/ex/clippy-test-run/sources/stable/gh/danreeves/now-cli/Cargo.toml [INFO] started frobbing danreeves/now-cli [INFO] finished frobbing danreeves/now-cli [INFO] frobbed toml for danreeves/now-cli written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/danreeves/now-cli/Cargo.toml [INFO] crate danreeves/now-cli has a lockfile. skipping [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting danreeves/now-cli against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-2/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/gh/danreeves/now-cli:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 65d2c2185ee75a8db51b505034644977fad2d502d6cfa3aab4dbcce776de6fb3 [INFO] running `"docker" "start" "-a" "65d2c2185ee75a8db51b505034644977fad2d502d6cfa3aab4dbcce776de6fb3"` [INFO] [stderr] Checking rprompt v1.0.3 [INFO] [stderr] Checking directories v1.0.1 [INFO] [stderr] Checking tabular v0.1.2 [INFO] [stderr] Compiling structopt-derive v0.2.10 [INFO] [stderr] Checking chrono-humanize v0.0.11 [INFO] [stderr] Checking console v0.6.2 [INFO] [stderr] Checking reqwest v0.9.1 [INFO] [stderr] Checking dialoguer v0.1.0 [INFO] [stderr] Checking structopt v0.2.10 [INFO] [stderr] Checking now-cli v0.2.1 (/opt/crater/workdir) [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/handlers.rs:31:9 [INFO] [stderr] | [INFO] [stderr] 31 | / return UserData { [INFO] [stderr] 32 | | data: Some(data), [INFO] [stderr] 33 | | project_dir, [INFO] [stderr] 34 | | }; [INFO] [stderr] | |__________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_return)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] help: remove `return` as shown [INFO] [stderr] | [INFO] [stderr] 31 | UserData { [INFO] [stderr] 32 | data: Some(data), [INFO] [stderr] 33 | project_dir, [INFO] [stderr] 34 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/handlers.rs:31:9 [INFO] [stderr] | [INFO] [stderr] 31 | / return UserData { [INFO] [stderr] 32 | | data: Some(data), [INFO] [stderr] 33 | | project_dir, [INFO] [stderr] 34 | | }; [INFO] [stderr] | |__________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_return)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] help: remove `return` as shown [INFO] [stderr] | [INFO] [stderr] 31 | UserData { [INFO] [stderr] 32 | data: Some(data), [INFO] [stderr] 33 | project_dir, [INFO] [stderr] 34 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: unreachable pattern [INFO] [stderr] --> src/main.rs:35:9 [INFO] [stderr] | [INFO] [stderr] 35 | _ => unimplemented!(), [INFO] [stderr] | ^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unreachable_patterns)] on by default [INFO] [stderr] [INFO] [stderr] warning: unreachable pattern [INFO] [stderr] --> src/main.rs:35:9 [INFO] [stderr] | [INFO] [stderr] 35 | _ => unimplemented!(), [INFO] [stderr] | ^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unreachable_patterns)] on by default [INFO] [stderr] [INFO] [stderr] warning: unused `std::result::Result` that must be used [INFO] [stderr] --> src/handlers.rs:44:9 [INFO] [stderr] | [INFO] [stderr] 44 | user_data.load(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_must_use)] on by default [INFO] [stderr] = note: this `Result` may be an `Err` variant, which should be handled [INFO] [stderr] [INFO] [stderr] warning: useless use of `format!` [INFO] [stderr] --> src/handlers.rs:115:27 [INFO] [stderr] | [INFO] [stderr] 115 | if Confirmation::new(&format!("Please confirm once you've authenticated...")) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using .to_string(): `"Please confirm once you've authenticated...".to_string()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::useless_format)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/handlers.rs:164:12 [INFO] [stderr] | [INFO] [stderr] 164 | if deployments.len() > 0 { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `!deployments.is_empty()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::len_zero)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: unused `std::result::Result` that must be used [INFO] [stderr] --> src/handlers.rs:44:9 [INFO] [stderr] | [INFO] [stderr] 44 | user_data.load(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_must_use)] on by default [INFO] [stderr] = note: this `Result` may be an `Err` variant, which should be handled [INFO] [stderr] [INFO] [stderr] warning: useless use of `format!` [INFO] [stderr] --> src/handlers.rs:115:27 [INFO] [stderr] | [INFO] [stderr] 115 | if Confirmation::new(&format!("Please confirm once you've authenticated...")) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using .to_string(): `"Please confirm once you've authenticated...".to_string()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::useless_format)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/handlers.rs:164:12 [INFO] [stderr] | [INFO] [stderr] 164 | if deployments.len() > 0 { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `!deployments.is_empty()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::len_zero)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 12.61s [INFO] running `"docker" "inspect" "65d2c2185ee75a8db51b505034644977fad2d502d6cfa3aab4dbcce776de6fb3"` [INFO] running `"docker" "rm" "-f" "65d2c2185ee75a8db51b505034644977fad2d502d6cfa3aab4dbcce776de6fb3"` [INFO] [stdout] 65d2c2185ee75a8db51b505034644977fad2d502d6cfa3aab4dbcce776de6fb3