[INFO] updating cached repository dannypsnl/rapier [INFO] running `"git" "fetch" "--all"` [INFO] [stdout] Fetching origin [INFO] [stderr] From git://github.com/dannypsnl/rapier [INFO] [stderr] * branch HEAD -> FETCH_HEAD [INFO] running `"git" "clone" "work/cache/sources/gh/dannypsnl/rapier" "work/ex/clippy-test-run/sources/stable/gh/dannypsnl/rapier"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/dannypsnl/rapier'... [INFO] [stderr] done. [INFO] running `"git" "clone" "work/cache/sources/gh/dannypsnl/rapier" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/dannypsnl/rapier"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/dannypsnl/rapier'... [INFO] [stderr] done. [INFO] running `"git" "rev-parse" "HEAD"` [INFO] [stdout] f14cbfe0096fbec7c49c0df436776d02f78d8faa [INFO] sha for GitHub repo dannypsnl/rapier: f14cbfe0096fbec7c49c0df436776d02f78d8faa [INFO] validating manifest of dannypsnl/rapier on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of dannypsnl/rapier on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing dannypsnl/rapier [INFO] finished frobbing dannypsnl/rapier [INFO] frobbed toml for dannypsnl/rapier written to work/ex/clippy-test-run/sources/stable/gh/dannypsnl/rapier/Cargo.toml [INFO] started frobbing dannypsnl/rapier [INFO] finished frobbing dannypsnl/rapier [INFO] frobbed toml for dannypsnl/rapier written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/dannypsnl/rapier/Cargo.toml [INFO] crate dannypsnl/rapier has a lockfile. skipping [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting dannypsnl/rapier against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-5/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/gh/dannypsnl/rapier:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] c821fcb8ed038055bc3517cca8ac7e9c4389d063517c1dac787c6afded4c1602 [INFO] running `"docker" "start" "-a" "c821fcb8ed038055bc3517cca8ac7e9c4389d063517c1dac787c6afded4c1602"` [INFO] [stderr] Checking rapier v0.1.0 (/opt/crater/workdir) [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/lexer.rs:47:13 [INFO] [stderr] | [INFO] [stderr] 47 | code: code, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `code` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/parser.rs:17:13 [INFO] [stderr] | [INFO] [stderr] 17 | tokens: tokens, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `tokens` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/lexer.rs:47:13 [INFO] [stderr] | [INFO] [stderr] 47 | code: code, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `code` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/parser.rs:17:13 [INFO] [stderr] | [INFO] [stderr] 17 | tokens: tokens, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `tokens` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: unused import: `super::lexer` [INFO] [stderr] --> src/parser.rs:2:5 [INFO] [stderr] | [INFO] [stderr] 2 | use super::lexer; [INFO] [stderr] | ^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_imports)] on by default [INFO] [stderr] [INFO] [stderr] warning: unused variable: `tokens` [INFO] [stderr] --> src/main.rs:6:9 [INFO] [stderr] | [INFO] [stderr] 6 | let tokens = lexer::lex("abc"); [INFO] [stderr] | ^^^^^^ help: consider using `_tokens` instead [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_variables)] on by default [INFO] [stderr] [INFO] [stderr] warning: unused variable: `tokens` [INFO] [stderr] --> src/main.rs:6:9 [INFO] [stderr] | [INFO] [stderr] 6 | let tokens = lexer::lex("abc"); [INFO] [stderr] | ^^^^^^ help: consider using `_tokens` instead [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_variables)] on by default [INFO] [stderr] [INFO] [stderr] warning: method is never used: `location` [INFO] [stderr] --> src/lexer.rs:17:5 [INFO] [stderr] | [INFO] [stderr] 17 | pub fn location(&self) -> (u32, u32) { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(dead_code)] on by default [INFO] [stderr] [INFO] [stderr] warning: explicit lifetimes given in parameter types where they could be elided (or replaced with `'_` if needed by type declaration) [INFO] [stderr] --> src/lexer.rs:156:1 [INFO] [stderr] | [INFO] [stderr] 156 | / pub fn lex<'a>(source: &'a str) -> Vec { [INFO] [stderr] 157 | | let mut lexer = Lexer::new(source.to_string()); [INFO] [stderr] 158 | | while let State::Fn(f) = lexer.state_fn { [INFO] [stderr] 159 | | lexer.state_fn = f(&mut lexer); [INFO] [stderr] ... | [INFO] [stderr] 162 | | lexer.tokens [INFO] [stderr] 163 | | } [INFO] [stderr] | |_^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_lifetimes)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes [INFO] [stderr] [INFO] [stderr] warning: variant is never constructed: `Func` [INFO] [stderr] --> src/ast.rs:9:5 [INFO] [stderr] | [INFO] [stderr] 9 | Func(Type, String, Vec), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(dead_code)] on by default [INFO] [stderr] [INFO] [stderr] warning: method is never used: `location` [INFO] [stderr] --> src/lexer.rs:17:5 [INFO] [stderr] | [INFO] [stderr] 17 | pub fn location(&self) -> (u32, u32) { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: method is never used: `tk_type` [INFO] [stderr] --> src/lexer.rs:20:5 [INFO] [stderr] | [INFO] [stderr] 20 | pub fn tk_type(&self) -> &TkType { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: method is never used: `value` [INFO] [stderr] --> src/lexer.rs:23:5 [INFO] [stderr] | [INFO] [stderr] 23 | pub fn value(&self) -> String { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: struct is never constructed: `Parser` [INFO] [stderr] --> src/parser.rs:8:1 [INFO] [stderr] | [INFO] [stderr] 8 | struct Parser { [INFO] [stderr] | ^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: method is never used: `from` [INFO] [stderr] --> src/parser.rs:15:5 [INFO] [stderr] | [INFO] [stderr] 15 | fn from(tokens: Vec) -> Parser { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: method is never used: `peek` [INFO] [stderr] --> src/parser.rs:22:5 [INFO] [stderr] | [INFO] [stderr] 22 | fn peek(&self, n: usize) -> &Token { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: method is never used: `drop` [INFO] [stderr] --> src/parser.rs:26:5 [INFO] [stderr] | [INFO] [stderr] 26 | fn drop(&mut self) { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: method is never used: `take` [INFO] [stderr] --> src/parser.rs:29:5 [INFO] [stderr] | [INFO] [stderr] 29 | fn take(&mut self) -> Token { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: method is never used: `matched` [INFO] [stderr] --> src/parser.rs:34:5 [INFO] [stderr] | [INFO] [stderr] 34 | fn matched(&self, token_type: &TkType, expected_type: &TkType) -> bool { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: method is never used: `predict` [INFO] [stderr] --> src/parser.rs:38:5 [INFO] [stderr] | [INFO] [stderr] 38 | fn predict(&self, wants: Vec) -> i64 { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: function is never used: `parse_type` [INFO] [stderr] --> src/parser.rs:50:1 [INFO] [stderr] | [INFO] [stderr] 50 | fn parse_type(parser: &mut Parser) -> Result { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: function is never used: `parse_parameters` [INFO] [stderr] --> src/parser.rs:61:1 [INFO] [stderr] | [INFO] [stderr] 61 | fn parse_parameters(parser: &mut Parser) -> Result, ParseError> { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: function is never used: `parse_function` [INFO] [stderr] --> src/parser.rs:86:1 [INFO] [stderr] | [INFO] [stderr] 86 | fn parse_function(parser: &mut Parser) -> Result { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: struct is never constructed: `ParseError` [INFO] [stderr] --> src/parser.rs:131:1 [INFO] [stderr] | [INFO] [stderr] 131 | struct ParseError; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: explicit lifetimes given in parameter types where they could be elided (or replaced with `'_` if needed by type declaration) [INFO] [stderr] --> src/lexer.rs:156:1 [INFO] [stderr] | [INFO] [stderr] 156 | / pub fn lex<'a>(source: &'a str) -> Vec { [INFO] [stderr] 157 | | let mut lexer = Lexer::new(source.to_string()); [INFO] [stderr] 158 | | while let State::Fn(f) = lexer.state_fn { [INFO] [stderr] 159 | | lexer.state_fn = f(&mut lexer); [INFO] [stderr] ... | [INFO] [stderr] 162 | | lexer.tokens [INFO] [stderr] 163 | | } [INFO] [stderr] | |_^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_lifetimes)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_lifetimes [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 0.84s [INFO] running `"docker" "inspect" "c821fcb8ed038055bc3517cca8ac7e9c4389d063517c1dac787c6afded4c1602"` [INFO] running `"docker" "rm" "-f" "c821fcb8ed038055bc3517cca8ac7e9c4389d063517c1dac787c6afded4c1602"` [INFO] [stdout] c821fcb8ed038055bc3517cca8ac7e9c4389d063517c1dac787c6afded4c1602