[INFO] updating cached repository danlionis/pwtools [INFO] running `"git" "fetch" "--all"` [INFO] [stdout] Fetching origin [INFO] [stderr] From git://github.com/danlionis/pwtools [INFO] [stderr] * branch HEAD -> FETCH_HEAD [INFO] running `"git" "clone" "work/cache/sources/gh/danlionis/pwtools" "work/ex/clippy-test-run/sources/stable/gh/danlionis/pwtools"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/danlionis/pwtools'... [INFO] [stderr] done. [INFO] running `"git" "clone" "work/cache/sources/gh/danlionis/pwtools" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/danlionis/pwtools"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/danlionis/pwtools'... [INFO] [stderr] done. [INFO] running `"git" "rev-parse" "HEAD"` [INFO] [stdout] e13a45a20ee4fcc87e00624f4b9faba6f0253de9 [INFO] sha for GitHub repo danlionis/pwtools: e13a45a20ee4fcc87e00624f4b9faba6f0253de9 [INFO] validating manifest of danlionis/pwtools on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of danlionis/pwtools on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing danlionis/pwtools [INFO] finished frobbing danlionis/pwtools [INFO] frobbed toml for danlionis/pwtools written to work/ex/clippy-test-run/sources/stable/gh/danlionis/pwtools/Cargo.toml [INFO] started frobbing danlionis/pwtools [INFO] finished frobbing danlionis/pwtools [INFO] frobbed toml for danlionis/pwtools written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/danlionis/pwtools/Cargo.toml [INFO] crate danlionis/pwtools has a lockfile. skipping [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting danlionis/pwtools against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-4/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/gh/danlionis/pwtools:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] a15b71a97db86cebd5aca4c4a75e953326e2ead0876d4c2e8859fdf939c56c7a [INFO] running `"docker" "start" "-a" "a15b71a97db86cebd5aca4c4a75e953326e2ead0876d4c2e8859fdf939c56c7a"` [INFO] [stderr] Checking pwtools v0.1.0 (/opt/crater/workdir) [INFO] [stderr] warning: writing `&String` instead of `&str` involves a new object where a slice will do. [INFO] [stderr] --> src/hasher.rs:13:33 [INFO] [stderr] | [INFO] [stderr] 13 | pub fn hash_password(algorithm: &String, input: &String) { [INFO] [stderr] | ^^^^^^^ help: change this to: `&str` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::ptr_arg)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: writing `&String` instead of `&str` involves a new object where a slice will do. [INFO] [stderr] --> src/hasher.rs:13:49 [INFO] [stderr] | [INFO] [stderr] 13 | pub fn hash_password(algorithm: &String, input: &String) { [INFO] [stderr] | ^^^^^^^ help: change this to: `&str` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: writing `&String` instead of `&str` involves a new object where a slice will do. [INFO] [stderr] --> src/hasher.rs:30:24 [INFO] [stderr] | [INFO] [stderr] 30 | fn get_hash_alg(input: &String) -> Option { [INFO] [stderr] | ^^^^^^^ help: change this to: `&str` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: writing `&String` instead of `&str` involves a new object where a slice will do. [INFO] [stderr] --> src/hasher.rs:13:33 [INFO] [stderr] | [INFO] [stderr] 13 | pub fn hash_password(algorithm: &String, input: &String) { [INFO] [stderr] | ^^^^^^^ help: change this to: `&str` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::ptr_arg)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: writing `&String` instead of `&str` involves a new object where a slice will do. [INFO] [stderr] --> src/hasher.rs:13:49 [INFO] [stderr] | [INFO] [stderr] 13 | pub fn hash_password(algorithm: &String, input: &String) { [INFO] [stderr] | ^^^^^^^ help: change this to: `&str` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: writing `&String` instead of `&str` involves a new object where a slice will do. [INFO] [stderr] --> src/hasher.rs:30:24 [INFO] [stderr] | [INFO] [stderr] 30 | fn get_hash_alg(input: &String) -> Option { [INFO] [stderr] | ^^^^^^^ help: change this to: `&str` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 2.12s [INFO] running `"docker" "inspect" "a15b71a97db86cebd5aca4c4a75e953326e2ead0876d4c2e8859fdf939c56c7a"` [INFO] running `"docker" "rm" "-f" "a15b71a97db86cebd5aca4c4a75e953326e2ead0876d4c2e8859fdf939c56c7a"` [INFO] [stdout] a15b71a97db86cebd5aca4c4a75e953326e2ead0876d4c2e8859fdf939c56c7a