[INFO] updating cached repository danijoo/lj_monte_carlo [INFO] running `"git" "fetch" "--all"` [INFO] [stdout] Fetching origin [INFO] [stderr] From git://github.com/danijoo/lj_monte_carlo [INFO] [stderr] * branch HEAD -> FETCH_HEAD [INFO] running `"git" "clone" "work/cache/sources/gh/danijoo/lj_monte_carlo" "work/ex/clippy-test-run/sources/stable/gh/danijoo/lj_monte_carlo"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/danijoo/lj_monte_carlo'... [INFO] [stderr] done. [INFO] running `"git" "clone" "work/cache/sources/gh/danijoo/lj_monte_carlo" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/danijoo/lj_monte_carlo"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/danijoo/lj_monte_carlo'... [INFO] [stderr] done. [INFO] running `"git" "rev-parse" "HEAD"` [INFO] [stdout] 3637253f841b8e39e1dc78812aef242f6c57c2f2 [INFO] sha for GitHub repo danijoo/lj_monte_carlo: 3637253f841b8e39e1dc78812aef242f6c57c2f2 [INFO] validating manifest of danijoo/lj_monte_carlo on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of danijoo/lj_monte_carlo on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing danijoo/lj_monte_carlo [INFO] finished frobbing danijoo/lj_monte_carlo [INFO] frobbed toml for danijoo/lj_monte_carlo written to work/ex/clippy-test-run/sources/stable/gh/danijoo/lj_monte_carlo/Cargo.toml [INFO] started frobbing danijoo/lj_monte_carlo [INFO] finished frobbing danijoo/lj_monte_carlo [INFO] frobbed toml for danijoo/lj_monte_carlo written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/danijoo/lj_monte_carlo/Cargo.toml [INFO] crate danijoo/lj_monte_carlo has a lockfile. skipping [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting danijoo/lj_monte_carlo against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-6/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/gh/danijoo/lj_monte_carlo:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 57fa9ceb035a79f3cf61cc0ef6a73f88f256e9a384f47d0d0f3e438ce43c19a1 [INFO] running `"docker" "start" "-a" "57fa9ceb035a79f3cf61cc0ef6a73f88f256e9a384f47d0d0f3e438ce43c19a1"` [INFO] [stderr] Checking mclj v0.1.0 (/opt/crater/workdir) [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/trajectory.rs:83:28 [INFO] [stderr] | [INFO] [stderr] 83 | return TrjReader { reader:reader }; [INFO] [stderr] | ^^^^^^^^^^^^^ help: replace it with: `reader` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/trajectory.rs:123:13 [INFO] [stderr] | [INFO] [stderr] 123 | rx : rx, [INFO] [stderr] | ^^^^^^^ help: replace it with: `rx` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/trajectory.rs:124:13 [INFO] [stderr] | [INFO] [stderr] 124 | ry : ry, [INFO] [stderr] | ^^^^^^^ help: replace it with: `ry` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/trajectory.rs:125:13 [INFO] [stderr] | [INFO] [stderr] 125 | rz : rz, [INFO] [stderr] | ^^^^^^^ help: replace it with: `rz` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/trajectory.rs:126:13 [INFO] [stderr] | [INFO] [stderr] 126 | num_particles : num_particles, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `num_particles` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/trajectory.rs:127:13 [INFO] [stderr] | [INFO] [stderr] 127 | box_x : box_x, [INFO] [stderr] | ^^^^^^^^^^^^^ help: replace it with: `box_x` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/trajectory.rs:128:13 [INFO] [stderr] | [INFO] [stderr] 128 | box_y : box_y, [INFO] [stderr] | ^^^^^^^^^^^^^ help: replace it with: `box_y` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/trajectory.rs:129:13 [INFO] [stderr] | [INFO] [stderr] 129 | box_z : box_z, [INFO] [stderr] | ^^^^^^^^^^^^^ help: replace it with: `box_z` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/trajectory.rs:131:13 [INFO] [stderr] | [INFO] [stderr] 131 | lj_eps : lj_eps, [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: replace it with: `lj_eps` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/trajectory.rs:132:13 [INFO] [stderr] | [INFO] [stderr] 132 | lj_sig : lj_sig, [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: replace it with: `lj_sig` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/trajectory.rs:133:13 [INFO] [stderr] | [INFO] [stderr] 133 | lj_cutoff : lj_cutoff, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `lj_cutoff` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/trajectory.rs:83:28 [INFO] [stderr] | [INFO] [stderr] 83 | return TrjReader { reader:reader }; [INFO] [stderr] | ^^^^^^^^^^^^^ help: replace it with: `reader` [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/trajectory.rs:83:28 [INFO] [stderr] | [INFO] [stderr] 83 | return TrjReader { reader:reader }; [INFO] [stderr] | ^^^^^^^^^^^^^ help: replace it with: `reader` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/trajectory.rs:123:13 [INFO] [stderr] | [INFO] [stderr] 123 | rx : rx, [INFO] [stderr] | ^^^^^^^ help: replace it with: `rx` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/trajectory.rs:124:13 [INFO] [stderr] | [INFO] [stderr] 124 | ry : ry, [INFO] [stderr] | ^^^^^^^ help: replace it with: `ry` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/trajectory.rs:125:13 [INFO] [stderr] | [INFO] [stderr] 125 | rz : rz, [INFO] [stderr] | ^^^^^^^ help: replace it with: `rz` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/trajectory.rs:126:13 [INFO] [stderr] | [INFO] [stderr] 126 | num_particles : num_particles, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `num_particles` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/trajectory.rs:127:13 [INFO] [stderr] | [INFO] [stderr] 127 | box_x : box_x, [INFO] [stderr] | ^^^^^^^^^^^^^ help: replace it with: `box_x` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/trajectory.rs:128:13 [INFO] [stderr] | [INFO] [stderr] 128 | box_y : box_y, [INFO] [stderr] | ^^^^^^^^^^^^^ help: replace it with: `box_y` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/trajectory.rs:129:13 [INFO] [stderr] | [INFO] [stderr] 129 | box_z : box_z, [INFO] [stderr] | ^^^^^^^^^^^^^ help: replace it with: `box_z` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/trajectory.rs:131:13 [INFO] [stderr] | [INFO] [stderr] 131 | lj_eps : lj_eps, [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: replace it with: `lj_eps` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/trajectory.rs:132:13 [INFO] [stderr] | [INFO] [stderr] 132 | lj_sig : lj_sig, [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: replace it with: `lj_sig` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/trajectory.rs:133:13 [INFO] [stderr] | [INFO] [stderr] 133 | lj_cutoff : lj_cutoff, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `lj_cutoff` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/trajectory.rs:123:13 [INFO] [stderr] | [INFO] [stderr] 123 | rx : rx, [INFO] [stderr] | ^^^^^^^ help: replace it with: `rx` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/trajectory.rs:124:13 [INFO] [stderr] | [INFO] [stderr] 124 | ry : ry, [INFO] [stderr] | ^^^^^^^ help: replace it with: `ry` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/trajectory.rs:125:13 [INFO] [stderr] | [INFO] [stderr] 125 | rz : rz, [INFO] [stderr] | ^^^^^^^ help: replace it with: `rz` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/trajectory.rs:126:13 [INFO] [stderr] | [INFO] [stderr] 126 | num_particles : num_particles, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `num_particles` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/trajectory.rs:127:13 [INFO] [stderr] | [INFO] [stderr] 127 | box_x : box_x, [INFO] [stderr] | ^^^^^^^^^^^^^ help: replace it with: `box_x` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/trajectory.rs:128:13 [INFO] [stderr] | [INFO] [stderr] 128 | box_y : box_y, [INFO] [stderr] | ^^^^^^^^^^^^^ help: replace it with: `box_y` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/trajectory.rs:129:13 [INFO] [stderr] | [INFO] [stderr] 129 | box_z : box_z, [INFO] [stderr] | ^^^^^^^^^^^^^ help: replace it with: `box_z` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/trajectory.rs:131:13 [INFO] [stderr] | [INFO] [stderr] 131 | lj_eps : lj_eps, [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: replace it with: `lj_eps` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/trajectory.rs:132:13 [INFO] [stderr] | [INFO] [stderr] 132 | lj_sig : lj_sig, [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: replace it with: `lj_sig` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/trajectory.rs:133:13 [INFO] [stderr] | [INFO] [stderr] 133 | lj_cutoff : lj_cutoff, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `lj_cutoff` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/trajectory.rs:83:28 [INFO] [stderr] | [INFO] [stderr] 83 | return TrjReader { reader:reader }; [INFO] [stderr] | ^^^^^^^^^^^^^ help: replace it with: `reader` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/trajectory.rs:123:13 [INFO] [stderr] | [INFO] [stderr] 123 | rx : rx, [INFO] [stderr] | ^^^^^^^ help: replace it with: `rx` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/trajectory.rs:124:13 [INFO] [stderr] | [INFO] [stderr] 124 | ry : ry, [INFO] [stderr] | ^^^^^^^ help: replace it with: `ry` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/trajectory.rs:125:13 [INFO] [stderr] | [INFO] [stderr] 125 | rz : rz, [INFO] [stderr] | ^^^^^^^ help: replace it with: `rz` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/trajectory.rs:126:13 [INFO] [stderr] | [INFO] [stderr] 126 | num_particles : num_particles, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `num_particles` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/trajectory.rs:127:13 [INFO] [stderr] | [INFO] [stderr] 127 | box_x : box_x, [INFO] [stderr] | ^^^^^^^^^^^^^ help: replace it with: `box_x` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/trajectory.rs:128:13 [INFO] [stderr] | [INFO] [stderr] 128 | box_y : box_y, [INFO] [stderr] | ^^^^^^^^^^^^^ help: replace it with: `box_y` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/trajectory.rs:129:13 [INFO] [stderr] | [INFO] [stderr] 129 | box_z : box_z, [INFO] [stderr] | ^^^^^^^^^^^^^ help: replace it with: `box_z` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/trajectory.rs:131:13 [INFO] [stderr] | [INFO] [stderr] 131 | lj_eps : lj_eps, [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: replace it with: `lj_eps` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/trajectory.rs:132:13 [INFO] [stderr] | [INFO] [stderr] 132 | lj_sig : lj_sig, [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: replace it with: `lj_sig` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/trajectory.rs:133:13 [INFO] [stderr] | [INFO] [stderr] 133 | lj_cutoff : lj_cutoff, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `lj_cutoff` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/trajectory.rs:83:28 [INFO] [stderr] | [INFO] [stderr] 83 | return TrjReader { reader:reader }; [INFO] [stderr] | ^^^^^^^^^^^^^ help: replace it with: `reader` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/trajectory.rs:123:13 [INFO] [stderr] | [INFO] [stderr] 123 | rx : rx, [INFO] [stderr] | ^^^^^^^ help: replace it with: `rx` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/trajectory.rs:124:13 [INFO] [stderr] | [INFO] [stderr] 124 | ry : ry, [INFO] [stderr] | ^^^^^^^ help: replace it with: `ry` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/trajectory.rs:125:13 [INFO] [stderr] | [INFO] [stderr] 125 | rz : rz, [INFO] [stderr] | ^^^^^^^ help: replace it with: `rz` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/trajectory.rs:126:13 [INFO] [stderr] | [INFO] [stderr] 126 | num_particles : num_particles, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `num_particles` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/trajectory.rs:127:13 [INFO] [stderr] | [INFO] [stderr] 127 | box_x : box_x, [INFO] [stderr] | ^^^^^^^^^^^^^ help: replace it with: `box_x` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/trajectory.rs:128:13 [INFO] [stderr] | [INFO] [stderr] 128 | box_y : box_y, [INFO] [stderr] | ^^^^^^^^^^^^^ help: replace it with: `box_y` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/trajectory.rs:129:13 [INFO] [stderr] | [INFO] [stderr] 129 | box_z : box_z, [INFO] [stderr] | ^^^^^^^^^^^^^ help: replace it with: `box_z` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/trajectory.rs:131:13 [INFO] [stderr] | [INFO] [stderr] 131 | lj_eps : lj_eps, [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: replace it with: `lj_eps` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/trajectory.rs:132:13 [INFO] [stderr] | [INFO] [stderr] 132 | lj_sig : lj_sig, [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: replace it with: `lj_sig` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/trajectory.rs:133:13 [INFO] [stderr] | [INFO] [stderr] 133 | lj_cutoff : lj_cutoff, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `lj_cutoff` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/trajectory.rs:83:28 [INFO] [stderr] | [INFO] [stderr] 83 | return TrjReader { reader:reader }; [INFO] [stderr] | ^^^^^^^^^^^^^ help: replace it with: `reader` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/trajectory.rs:123:13 [INFO] [stderr] | [INFO] [stderr] 123 | rx : rx, [INFO] [stderr] | ^^^^^^^ help: replace it with: `rx` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/trajectory.rs:124:13 [INFO] [stderr] | [INFO] [stderr] 124 | ry : ry, [INFO] [stderr] | ^^^^^^^ help: replace it with: `ry` [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/trajectory.rs:83:28 [INFO] [stderr] | [INFO] [stderr] 83 | return TrjReader { reader:reader }; [INFO] [stderr] | ^^^^^^^^^^^^^ help: replace it with: `reader` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/trajectory.rs:123:13 [INFO] [stderr] | [INFO] [stderr] 123 | rx : rx, [INFO] [stderr] | ^^^^^^^ help: replace it with: `rx` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/trajectory.rs:124:13 [INFO] [stderr] | [INFO] [stderr] 124 | ry : ry, [INFO] [stderr] | ^^^^^^^ help: replace it with: `ry` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/trajectory.rs:125:13 [INFO] [stderr] | [INFO] [stderr] 125 | rz : rz, [INFO] [stderr] | ^^^^^^^ help: replace it with: `rz` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/trajectory.rs:126:13 [INFO] [stderr] | [INFO] [stderr] 126 | num_particles : num_particles, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `num_particles` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/trajectory.rs:127:13 [INFO] [stderr] | [INFO] [stderr] 127 | box_x : box_x, [INFO] [stderr] | ^^^^^^^^^^^^^ help: replace it with: `box_x` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/trajectory.rs:128:13 [INFO] [stderr] | [INFO] [stderr] 128 | box_y : box_y, [INFO] [stderr] | ^^^^^^^^^^^^^ help: replace it with: `box_y` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/trajectory.rs:129:13 [INFO] [stderr] | [INFO] [stderr] 129 | box_z : box_z, [INFO] [stderr] | ^^^^^^^^^^^^^ help: replace it with: `box_z` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/trajectory.rs:131:13 [INFO] [stderr] | [INFO] [stderr] 131 | lj_eps : lj_eps, [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: replace it with: `lj_eps` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/trajectory.rs:132:13 [INFO] [stderr] | [INFO] [stderr] 132 | lj_sig : lj_sig, [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: replace it with: `lj_sig` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/trajectory.rs:133:13 [INFO] [stderr] | [INFO] [stderr] 133 | lj_cutoff : lj_cutoff, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `lj_cutoff` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/trajectory.rs:83:28 [INFO] [stderr] | [INFO] [stderr] 83 | return TrjReader { reader:reader }; [INFO] [stderr] | ^^^^^^^^^^^^^ help: replace it with: `reader` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/trajectory.rs:123:13 [INFO] [stderr] | [INFO] [stderr] 123 | rx : rx, [INFO] [stderr] | ^^^^^^^ help: replace it with: `rx` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/trajectory.rs:124:13 [INFO] [stderr] | [INFO] [stderr] 124 | ry : ry, [INFO] [stderr] | ^^^^^^^ help: replace it with: `ry` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/trajectory.rs:125:13 [INFO] [stderr] | [INFO] [stderr] 125 | rz : rz, [INFO] [stderr] | ^^^^^^^ help: replace it with: `rz` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/trajectory.rs:126:13 [INFO] [stderr] | [INFO] [stderr] 126 | num_particles : num_particles, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `num_particles` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/trajectory.rs:127:13 [INFO] [stderr] | [INFO] [stderr] 127 | box_x : box_x, [INFO] [stderr] | ^^^^^^^^^^^^^ help: replace it with: `box_x` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/trajectory.rs:128:13 [INFO] [stderr] | [INFO] [stderr] 128 | box_y : box_y, [INFO] [stderr] | ^^^^^^^^^^^^^ help: replace it with: `box_y` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/trajectory.rs:129:13 [INFO] [stderr] | [INFO] [stderr] 129 | box_z : box_z, [INFO] [stderr] | ^^^^^^^^^^^^^ help: replace it with: `box_z` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/trajectory.rs:131:13 [INFO] [stderr] | [INFO] [stderr] 131 | lj_eps : lj_eps, [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: replace it with: `lj_eps` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/trajectory.rs:132:13 [INFO] [stderr] | [INFO] [stderr] 132 | lj_sig : lj_sig, [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: replace it with: `lj_sig` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/trajectory.rs:133:13 [INFO] [stderr] | [INFO] [stderr] 133 | lj_cutoff : lj_cutoff, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `lj_cutoff` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/trajectory.rs:125:13 [INFO] [stderr] | [INFO] [stderr] 125 | rz : rz, [INFO] [stderr] | ^^^^^^^ help: replace it with: `rz` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/trajectory.rs:126:13 [INFO] [stderr] | [INFO] [stderr] 126 | num_particles : num_particles, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `num_particles` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/trajectory.rs:127:13 [INFO] [stderr] | [INFO] [stderr] 127 | box_x : box_x, [INFO] [stderr] | ^^^^^^^^^^^^^ help: replace it with: `box_x` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/trajectory.rs:128:13 [INFO] [stderr] | [INFO] [stderr] 128 | box_y : box_y, [INFO] [stderr] | ^^^^^^^^^^^^^ help: replace it with: `box_y` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/trajectory.rs:129:13 [INFO] [stderr] | [INFO] [stderr] 129 | box_z : box_z, [INFO] [stderr] | ^^^^^^^^^^^^^ help: replace it with: `box_z` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/trajectory.rs:131:13 [INFO] [stderr] | [INFO] [stderr] 131 | lj_eps : lj_eps, [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: replace it with: `lj_eps` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/trajectory.rs:132:13 [INFO] [stderr] | [INFO] [stderr] 132 | lj_sig : lj_sig, [INFO] [stderr] | ^^^^^^^^^^^^^^^ help: replace it with: `lj_sig` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/trajectory.rs:133:13 [INFO] [stderr] | [INFO] [stderr] 133 | lj_cutoff : lj_cutoff, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `lj_cutoff` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/trajectory.rs:83:9 [INFO] [stderr] | [INFO] [stderr] 83 | return TrjReader { reader:reader }; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `TrjReader { reader:reader }` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_return)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/trajectory.rs:135:9 [INFO] [stderr] | [INFO] [stderr] 135 | return frame; [INFO] [stderr] | ^^^^^^^^^^^^^ help: remove `return` as shown: `frame` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/trajectory.rs:176:9 [INFO] [stderr] | [INFO] [stderr] 176 | return true; [INFO] [stderr] | ^^^^^^^^^^^^ help: remove `return` as shown: `true` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/density_z.rs:68:5 [INFO] [stderr] | [INFO] [stderr] 68 | return slab; [INFO] [stderr] | ^^^^^^^^^^^^ help: remove `return` as shown: `slab` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/trajectory.rs:83:9 [INFO] [stderr] | [INFO] [stderr] 83 | return TrjReader { reader:reader }; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `TrjReader { reader:reader }` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_return)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/trajectory.rs:135:9 [INFO] [stderr] | [INFO] [stderr] 135 | return frame; [INFO] [stderr] | ^^^^^^^^^^^^^ help: remove `return` as shown: `frame` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/trajectory.rs:176:9 [INFO] [stderr] | [INFO] [stderr] 176 | return true; [INFO] [stderr] | ^^^^^^^^^^^^ help: remove `return` as shown: `true` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/energy.rs:22:5 [INFO] [stderr] | [INFO] [stderr] 22 | return (energy, virial); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `(energy, virial)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/energy.rs:43:5 [INFO] [stderr] | [INFO] [stderr] 43 | return (energy, virial); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `(energy, virial)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/energy.rs:58:5 [INFO] [stderr] | [INFO] [stderr] 58 | return dx*dx + dy*dy + dz*dz; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `dx*dx + dy*dy + dz*dz` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/energy.rs:66:5 [INFO] [stderr] | [INFO] [stderr] 66 | return d; [INFO] [stderr] | ^^^^^^^^^ help: remove `return` as shown: `d` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/energy.rs:81:26 [INFO] [stderr] | [INFO] [stderr] 81 | let (x3, y3, z3) = ( 0.948369102634727,1.4018028642626956,2.6884871697542323); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: consider: `0.948_369_102_634_727` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::unreadable_literal)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/energy.rs:81:44 [INFO] [stderr] | [INFO] [stderr] 81 | let (x3, y3, z3) = ( 0.948369102634727,1.4018028642626956,2.6884871697542323); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: consider: `1.401_802_864_262_695_6` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/energy.rs:81:63 [INFO] [stderr] | [INFO] [stderr] 81 | let (x3, y3, z3) = ( 0.948369102634727,1.4018028642626956,2.6884871697542323); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: consider: `2.688_487_169_754_232_3` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/energy.rs:82:26 [INFO] [stderr] | [INFO] [stderr] 82 | let (x4, y4, z4) = ( 0.4924652252404308,0.27903672240586597,1.258265555104697); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: consider: `0.492_465_225_240_430_8` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/energy.rs:82:45 [INFO] [stderr] | [INFO] [stderr] 82 | let (x4, y4, z4) = ( 0.4924652252404308,0.27903672240586597,1.258265555104697); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ help: consider: `0.279_036_722_405_865_97` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/energy.rs:82:65 [INFO] [stderr] | [INFO] [stderr] 82 | let (x4, y4, z4) = ( 0.4924652252404308,0.27903672240586597,1.258265555104697); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: consider: `1.258_265_555_104_697` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/energy.rs:83:62 [INFO] [stderr] | [INFO] [stderr] 83 | let a = get_particle_distance_squared(x3,y3,z3,x4,y4,z4, 1.418983411970384,1.418983411970384,2.83796682394076,0.709491705985192,0.709491705985192,1.418983411970384); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: consider: `1.418_983_411_970_384` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/energy.rs:83:80 [INFO] [stderr] | [INFO] [stderr] 83 | let a = get_particle_distance_squared(x3,y3,z3,x4,y4,z4, 1.418983411970384,1.418983411970384,2.83796682394076,0.709491705985192,0.709491705985192,1.418983411970384); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: consider: `1.418_983_411_970_384` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/energy.rs:83:98 [INFO] [stderr] | [INFO] [stderr] 83 | let a = get_particle_distance_squared(x3,y3,z3,x4,y4,z4, 1.418983411970384,1.418983411970384,2.83796682394076,0.709491705985192,0.709491705985192,1.418983411970384); [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: consider: `2.837_966_823_940_76` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/energy.rs:83:115 [INFO] [stderr] | [INFO] [stderr] 83 | let a = get_particle_distance_squared(x3,y3,z3,x4,y4,z4, 1.418983411970384,1.418983411970384,2.83796682394076,0.709491705985192,0.709491705985192,1.418983411970384); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: consider: `0.709_491_705_985_192` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/energy.rs:83:133 [INFO] [stderr] | [INFO] [stderr] 83 | let a = get_particle_distance_squared(x3,y3,z3,x4,y4,z4, 1.418983411970384,1.418983411970384,2.83796682394076,0.709491705985192,0.709491705985192,1.418983411970384); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: consider: `0.709_491_705_985_192` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/energy.rs:83:151 [INFO] [stderr] | [INFO] [stderr] 83 | let a = get_particle_distance_squared(x3,y3,z3,x4,y4,z4, 1.418983411970384,1.418983411970384,2.83796682394076,0.709491705985192,0.709491705985192,1.418983411970384); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: consider: `1.418_983_411_970_384` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/energy.rs:84:62 [INFO] [stderr] | [INFO] [stderr] 84 | let b = get_particle_distance_squared(x4,y4,z4,x3,y3,z3, 1.418983411970384,1.418983411970384,2.83796682394076,0.709491705985192,0.709491705985192,1.418983411970384); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: consider: `1.418_983_411_970_384` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/energy.rs:84:80 [INFO] [stderr] | [INFO] [stderr] 84 | let b = get_particle_distance_squared(x4,y4,z4,x3,y3,z3, 1.418983411970384,1.418983411970384,2.83796682394076,0.709491705985192,0.709491705985192,1.418983411970384); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: consider: `1.418_983_411_970_384` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/energy.rs:84:98 [INFO] [stderr] | [INFO] [stderr] 84 | let b = get_particle_distance_squared(x4,y4,z4,x3,y3,z3, 1.418983411970384,1.418983411970384,2.83796682394076,0.709491705985192,0.709491705985192,1.418983411970384); [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: consider: `2.837_966_823_940_76` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/energy.rs:84:115 [INFO] [stderr] | [INFO] [stderr] 84 | let b = get_particle_distance_squared(x4,y4,z4,x3,y3,z3, 1.418983411970384,1.418983411970384,2.83796682394076,0.709491705985192,0.709491705985192,1.418983411970384); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: consider: `0.709_491_705_985_192` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/energy.rs:84:133 [INFO] [stderr] | [INFO] [stderr] 84 | let b = get_particle_distance_squared(x4,y4,z4,x3,y3,z3, 1.418983411970384,1.418983411970384,2.83796682394076,0.709491705985192,0.709491705985192,1.418983411970384); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: consider: `0.709_491_705_985_192` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/energy.rs:84:151 [INFO] [stderr] | [INFO] [stderr] 84 | let b = get_particle_distance_squared(x4,y4,z4,x3,y3,z3, 1.418983411970384,1.418983411970384,2.83796682394076,0.709491705985192,0.709491705985192,1.418983411970384); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: consider: `1.418_983_411_970_384` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/energy.rs:85:28 [INFO] [stderr] | [INFO] [stderr] 85 | assert!( (a-b).abs() < 0.0000000001); [INFO] [stderr] | ^^^^^^^^^^^^ help: consider: `0.000_000_000_1` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/energy.rs:99:5 [INFO] [stderr] | [INFO] [stderr] 99 | return (energy, virial); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `(energy, virial)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/energy.rs:119:5 [INFO] [stderr] | [INFO] [stderr] 119 | return 24.0 * lj_eps / lj_sig * ( r7-2.0*r13 ); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `24.0 * lj_eps / lj_sig * ( r7-2.0*r13 )` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/energy.rs:126:20 [INFO] [stderr] | [INFO] [stderr] 126 | let expected = 1.1580288; [INFO] [stderr] | ^^^^^^^^^ help: consider: `1.158_028_8` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/widom.rs:169:5 [INFO] [stderr] | [INFO] [stderr] 169 | return energy; [INFO] [stderr] | ^^^^^^^^^^^^^^ help: remove `return` as shown: `energy` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/widom.rs:175:5 [INFO] [stderr] | [INFO] [stderr] 175 | return -temperature/lj_eps * ( density*thermal_wavelength3 ).ln(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `-temperature/lj_eps * ( density*thermal_wavelength3 ).ln()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/widom.rs:180:20 [INFO] [stderr] | [INFO] [stderr] 180 | let expected = 12.476649; [INFO] [stderr] | ^^^^^^^^^ help: consider: `12.476_649` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/trajectory.rs:83:9 [INFO] [stderr] | [INFO] [stderr] 83 | return TrjReader { reader:reader }; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `TrjReader { reader:reader }` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_return)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/trajectory.rs:135:9 [INFO] [stderr] | [INFO] [stderr] 135 | return frame; [INFO] [stderr] | ^^^^^^^^^^^^^ help: remove `return` as shown: `frame` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/trajectory.rs:176:9 [INFO] [stderr] | [INFO] [stderr] 176 | return true; [INFO] [stderr] | ^^^^^^^^^^^^ help: remove `return` as shown: `true` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/density_z.rs:68:5 [INFO] [stderr] | [INFO] [stderr] 68 | return slab; [INFO] [stderr] | ^^^^^^^^^^^^ help: remove `return` as shown: `slab` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/density_z.rs:90:13 [INFO] [stderr] | [INFO] [stderr] 90 | let z = 0.19999999_f64; [INFO] [stderr] | ^^^^^^^^^^^^^^ help: consider: `0.199_999_99_f64` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::unreadable_literal)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/trajectory.rs:83:9 [INFO] [stderr] | [INFO] [stderr] 83 | return TrjReader { reader:reader }; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `TrjReader { reader:reader }` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_return)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/trajectory.rs:135:9 [INFO] [stderr] | [INFO] [stderr] 135 | return frame; [INFO] [stderr] | ^^^^^^^^^^^^^ help: remove `return` as shown: `frame` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/trajectory.rs:176:9 [INFO] [stderr] | [INFO] [stderr] 176 | return true; [INFO] [stderr] | ^^^^^^^^^^^^ help: remove `return` as shown: `true` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/energy.rs:22:5 [INFO] [stderr] | [INFO] [stderr] 22 | return (energy, virial); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `(energy, virial)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/energy.rs:43:5 [INFO] [stderr] | [INFO] [stderr] 43 | return (energy, virial); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `(energy, virial)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/energy.rs:58:5 [INFO] [stderr] | [INFO] [stderr] 58 | return dx*dx + dy*dy + dz*dz; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `dx*dx + dy*dy + dz*dz` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/energy.rs:66:5 [INFO] [stderr] | [INFO] [stderr] 66 | return d; [INFO] [stderr] | ^^^^^^^^^ help: remove `return` as shown: `d` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/energy.rs:99:5 [INFO] [stderr] | [INFO] [stderr] 99 | return (energy, virial); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `(energy, virial)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/energy.rs:119:5 [INFO] [stderr] | [INFO] [stderr] 119 | return 24.0 * lj_eps / lj_sig * ( r7-2.0*r13 ); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `24.0 * lj_eps / lj_sig * ( r7-2.0*r13 )` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/surface_tension.rs:89:5 [INFO] [stderr] | [INFO] [stderr] 89 | return box_z / 2.0 * (p_zz - p_xy); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `box_z / 2.0 * (p_zz - p_xy)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unreachable expression [INFO] [stderr] --> src/trajectory.rs:119:27 [INFO] [stderr] | [INFO] [stderr] 119 | Err(e) => return panic!("no new frame!") [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unreachable_code)] on by default [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/trajectory.rs:83:9 [INFO] [stderr] | [INFO] [stderr] 83 | return TrjReader { reader:reader }; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `TrjReader { reader:reader }` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_return)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/trajectory.rs:135:9 [INFO] [stderr] | [INFO] [stderr] 135 | return frame; [INFO] [stderr] | ^^^^^^^^^^^^^ help: remove `return` as shown: `frame` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/trajectory.rs:176:9 [INFO] [stderr] | [INFO] [stderr] 176 | return true; [INFO] [stderr] | ^^^^^^^^^^^^ help: remove `return` as shown: `true` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/energy.rs:22:5 [INFO] [stderr] | [INFO] [stderr] 22 | return (energy, virial); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `(energy, virial)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/energy.rs:43:5 [INFO] [stderr] | [INFO] [stderr] 43 | return (energy, virial); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `(energy, virial)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/energy.rs:58:5 [INFO] [stderr] | [INFO] [stderr] 58 | return dx*dx + dy*dy + dz*dz; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `dx*dx + dy*dy + dz*dz` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/energy.rs:66:5 [INFO] [stderr] | [INFO] [stderr] 66 | return d; [INFO] [stderr] | ^^^^^^^^^ help: remove `return` as shown: `d` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/energy.rs:81:26 [INFO] [stderr] | [INFO] [stderr] 81 | let (x3, y3, z3) = ( 0.948369102634727,1.4018028642626956,2.6884871697542323); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: consider: `0.948_369_102_634_727` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::unreadable_literal)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/energy.rs:81:44 [INFO] [stderr] | [INFO] [stderr] 81 | let (x3, y3, z3) = ( 0.948369102634727,1.4018028642626956,2.6884871697542323); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: consider: `1.401_802_864_262_695_6` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/energy.rs:81:63 [INFO] [stderr] | [INFO] [stderr] 81 | let (x3, y3, z3) = ( 0.948369102634727,1.4018028642626956,2.6884871697542323); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: consider: `2.688_487_169_754_232_3` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/energy.rs:82:26 [INFO] [stderr] | [INFO] [stderr] 82 | let (x4, y4, z4) = ( 0.4924652252404308,0.27903672240586597,1.258265555104697); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: consider: `0.492_465_225_240_430_8` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/energy.rs:82:45 [INFO] [stderr] | [INFO] [stderr] 82 | let (x4, y4, z4) = ( 0.4924652252404308,0.27903672240586597,1.258265555104697); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ help: consider: `0.279_036_722_405_865_97` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/energy.rs:82:65 [INFO] [stderr] | [INFO] [stderr] 82 | let (x4, y4, z4) = ( 0.4924652252404308,0.27903672240586597,1.258265555104697); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: consider: `1.258_265_555_104_697` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/energy.rs:83:62 [INFO] [stderr] | [INFO] [stderr] 83 | let a = get_particle_distance_squared(x3,y3,z3,x4,y4,z4, 1.418983411970384,1.418983411970384,2.83796682394076,0.709491705985192,0.709491705985192,1.418983411970384); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: consider: `1.418_983_411_970_384` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/energy.rs:83:80 [INFO] [stderr] | [INFO] [stderr] 83 | let a = get_particle_distance_squared(x3,y3,z3,x4,y4,z4, 1.418983411970384,1.418983411970384,2.83796682394076,0.709491705985192,0.709491705985192,1.418983411970384); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: consider: `1.418_983_411_970_384` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/energy.rs:83:98 [INFO] [stderr] | [INFO] [stderr] 83 | let a = get_particle_distance_squared(x3,y3,z3,x4,y4,z4, 1.418983411970384,1.418983411970384,2.83796682394076,0.709491705985192,0.709491705985192,1.418983411970384); [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: consider: `2.837_966_823_940_76` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/energy.rs:83:115 [INFO] [stderr] | [INFO] [stderr] 83 | let a = get_particle_distance_squared(x3,y3,z3,x4,y4,z4, 1.418983411970384,1.418983411970384,2.83796682394076,0.709491705985192,0.709491705985192,1.418983411970384); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: consider: `0.709_491_705_985_192` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/energy.rs:83:133 [INFO] [stderr] | [INFO] [stderr] 83 | let a = get_particle_distance_squared(x3,y3,z3,x4,y4,z4, 1.418983411970384,1.418983411970384,2.83796682394076,0.709491705985192,0.709491705985192,1.418983411970384); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: consider: `0.709_491_705_985_192` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/energy.rs:83:151 [INFO] [stderr] | [INFO] [stderr] 83 | let a = get_particle_distance_squared(x3,y3,z3,x4,y4,z4, 1.418983411970384,1.418983411970384,2.83796682394076,0.709491705985192,0.709491705985192,1.418983411970384); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: consider: `1.418_983_411_970_384` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/energy.rs:84:62 [INFO] [stderr] | [INFO] [stderr] 84 | let b = get_particle_distance_squared(x4,y4,z4,x3,y3,z3, 1.418983411970384,1.418983411970384,2.83796682394076,0.709491705985192,0.709491705985192,1.418983411970384); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: consider: `1.418_983_411_970_384` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/energy.rs:84:80 [INFO] [stderr] | [INFO] [stderr] 84 | let b = get_particle_distance_squared(x4,y4,z4,x3,y3,z3, 1.418983411970384,1.418983411970384,2.83796682394076,0.709491705985192,0.709491705985192,1.418983411970384); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: consider: `1.418_983_411_970_384` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/energy.rs:84:98 [INFO] [stderr] | [INFO] [stderr] 84 | let b = get_particle_distance_squared(x4,y4,z4,x3,y3,z3, 1.418983411970384,1.418983411970384,2.83796682394076,0.709491705985192,0.709491705985192,1.418983411970384); [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: consider: `2.837_966_823_940_76` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/energy.rs:84:115 [INFO] [stderr] | [INFO] [stderr] 84 | let b = get_particle_distance_squared(x4,y4,z4,x3,y3,z3, 1.418983411970384,1.418983411970384,2.83796682394076,0.709491705985192,0.709491705985192,1.418983411970384); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: consider: `0.709_491_705_985_192` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/energy.rs:84:133 [INFO] [stderr] | [INFO] [stderr] 84 | let b = get_particle_distance_squared(x4,y4,z4,x3,y3,z3, 1.418983411970384,1.418983411970384,2.83796682394076,0.709491705985192,0.709491705985192,1.418983411970384); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: consider: `0.709_491_705_985_192` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/energy.rs:84:151 [INFO] [stderr] | [INFO] [stderr] 84 | let b = get_particle_distance_squared(x4,y4,z4,x3,y3,z3, 1.418983411970384,1.418983411970384,2.83796682394076,0.709491705985192,0.709491705985192,1.418983411970384); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: consider: `1.418_983_411_970_384` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/energy.rs:85:28 [INFO] [stderr] | [INFO] [stderr] 85 | assert!( (a-b).abs() < 0.0000000001); [INFO] [stderr] | ^^^^^^^^^^^^ help: consider: `0.000_000_000_1` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/energy.rs:99:5 [INFO] [stderr] | [INFO] [stderr] 99 | return (energy, virial); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `(energy, virial)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/energy.rs:119:5 [INFO] [stderr] | [INFO] [stderr] 119 | return 24.0 * lj_eps / lj_sig * ( r7-2.0*r13 ); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `24.0 * lj_eps / lj_sig * ( r7-2.0*r13 )` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/energy.rs:126:20 [INFO] [stderr] | [INFO] [stderr] 126 | let expected = 1.1580288; [INFO] [stderr] | ^^^^^^^^^ help: consider: `1.158_028_8` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/surface_tension.rs:89:5 [INFO] [stderr] | [INFO] [stderr] 89 | return box_z / 2.0 * (p_zz - p_xy); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `box_z / 2.0 * (p_zz - p_xy)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/trajectory.rs:83:9 [INFO] [stderr] | [INFO] [stderr] 83 | return TrjReader { reader:reader }; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `TrjReader { reader:reader }` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_return)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/trajectory.rs:135:9 [INFO] [stderr] | [INFO] [stderr] 135 | return frame; [INFO] [stderr] | ^^^^^^^^^^^^^ help: remove `return` as shown: `frame` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/trajectory.rs:176:9 [INFO] [stderr] | [INFO] [stderr] 176 | return true; [INFO] [stderr] | ^^^^^^^^^^^^ help: remove `return` as shown: `true` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/energy.rs:22:5 [INFO] [stderr] | [INFO] [stderr] 22 | return (energy, virial); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `(energy, virial)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/energy.rs:43:5 [INFO] [stderr] | [INFO] [stderr] 43 | return (energy, virial); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `(energy, virial)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/energy.rs:58:5 [INFO] [stderr] | [INFO] [stderr] 58 | return dx*dx + dy*dy + dz*dz; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `dx*dx + dy*dy + dz*dz` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/energy.rs:66:5 [INFO] [stderr] | [INFO] [stderr] 66 | return d; [INFO] [stderr] | ^^^^^^^^^ help: remove `return` as shown: `d` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/energy.rs:99:5 [INFO] [stderr] | [INFO] [stderr] 99 | return (energy, virial); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `(energy, virial)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/energy.rs:119:5 [INFO] [stderr] | [INFO] [stderr] 119 | return 24.0 * lj_eps / lj_sig * ( r7-2.0*r13 ); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `24.0 * lj_eps / lj_sig * ( r7-2.0*r13 )` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/widom.rs:169:5 [INFO] [stderr] | [INFO] [stderr] 169 | return energy; [INFO] [stderr] | ^^^^^^^^^^^^^^ help: remove `return` as shown: `energy` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/widom.rs:175:5 [INFO] [stderr] | [INFO] [stderr] 175 | return -temperature/lj_eps * ( density*thermal_wavelength3 ).ln(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `-temperature/lj_eps * ( density*thermal_wavelength3 ).ln()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unreachable expression [INFO] [stderr] --> src/trajectory.rs:119:27 [INFO] [stderr] | [INFO] [stderr] 119 | Err(e) => return panic!("no new frame!") [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unreachable_code)] on by default [INFO] [stderr] [INFO] [stderr] warning: writing `&String` instead of `&str` involves a new object where a slice will do. [INFO] [stderr] --> src/trajectory.rs:18:26 [INFO] [stderr] | [INFO] [stderr] 18 | pub fn new(filename: &String) -> XYZTrajectory { [INFO] [stderr] | ^^^^^^^ help: change this to: `&str` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::ptr_arg)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: this function has too many arguments (13/7) [INFO] [stderr] --> src/trajectory.rs:33:5 [INFO] [stderr] | [INFO] [stderr] 33 | / pub fn write(&mut self, rx: &[f64], ry: &[f64], rz: &[f64], num_particles: usize, box_x : f64, box_y : f64, box_z : f64, temp: f64 ,lj_eps : f64, lj_sig : f64, lj_cutoff : f64, flush: bool) { [INFO] [stderr] 34 | | self.file.write(format!("{} ## Box: {} {} {} Temp: {} LJ: {}/{}/{}\n", num_particles, box_x,box_y,box_z,temp, lj_eps, lj_sig, lj_cutoff).as_bytes()); [INFO] [stderr] 35 | | for i in 0..num_particles { [INFO] [stderr] 36 | | let formatted = format!("atom{} {} {} {}\n", [INFO] [stderr] ... | [INFO] [stderr] 43 | | [INFO] [stderr] 44 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::too_many_arguments)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#too_many_arguments [INFO] [stderr] [INFO] [stderr] warning: writing `&String` instead of `&str` involves a new object where a slice will do. [INFO] [stderr] --> src/trajectory.rs:80:26 [INFO] [stderr] | [INFO] [stderr] 80 | pub fn new(filename: &String) -> TrjReader { [INFO] [stderr] | ^^^^^^^ help: change this to: `&str` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: single-character string constant used as pattern [INFO] [stderr] --> src/trajectory.rs:103:54 [INFO] [stderr] | [INFO] [stderr] 103 | let lj : Vec<&str> = first_line_vec[9].split("/").collect(); [INFO] [stderr] | ^^^ help: try using a char instead: `'/'` [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/energy.rs:22:5 [INFO] [stderr] | [INFO] [stderr] 22 | return (energy, virial); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `(energy, virial)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_return)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/energy.rs:43:5 [INFO] [stderr] | [INFO] [stderr] 43 | return (energy, virial); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `(energy, virial)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/energy.rs:58:5 [INFO] [stderr] | [INFO] [stderr] 58 | return dx*dx + dy*dy + dz*dz; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `dx*dx + dy*dy + dz*dz` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/energy.rs:66:5 [INFO] [stderr] | [INFO] [stderr] 66 | return d; [INFO] [stderr] | ^^^^^^^^^ help: remove `return` as shown: `d` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/energy.rs:99:5 [INFO] [stderr] | [INFO] [stderr] 99 | return (energy, virial); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `(energy, virial)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/energy.rs:119:5 [INFO] [stderr] | [INFO] [stderr] 119 | return 24.0 * lj_eps / lj_sig * ( r7-2.0*r13 ); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `24.0 * lj_eps / lj_sig * ( r7-2.0*r13 )` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/trajectory.rs:83:9 [INFO] [stderr] | [INFO] [stderr] 83 | return TrjReader { reader:reader }; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `TrjReader { reader:reader }` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/trajectory.rs:135:9 [INFO] [stderr] | [INFO] [stderr] 135 | return frame; [INFO] [stderr] | ^^^^^^^^^^^^^ help: remove `return` as shown: `frame` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/trajectory.rs:176:9 [INFO] [stderr] | [INFO] [stderr] 176 | return true; [INFO] [stderr] | ^^^^^^^^^^^^ help: remove `return` as shown: `true` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: doc comment not used by rustdoc [INFO] [stderr] --> src/main.rs:43:5 [INFO] [stderr] | [INFO] [stderr] 43 | /** Definition of default run parameters **/ [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_doc_comments)] on by default [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/main.rs:44:25 [INFO] [stderr] | [INFO] [stderr] 44 | let mut eq_steps = 1000000; [INFO] [stderr] | ^^^^^^^ help: consider: `1_000_000` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::unreadable_literal)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/main.rs:45:28 [INFO] [stderr] | [INFO] [stderr] 45 | let mut sample_steps = 100000; [INFO] [stderr] | ^^^^^^ help: consider: `100_000` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: doc comment not used by rustdoc [INFO] [stderr] --> src/main.rs:75:5 [INFO] [stderr] | [INFO] [stderr] 75 | /** Initialize the system **/ [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: unreachable expression [INFO] [stderr] --> src/trajectory.rs:119:27 [INFO] [stderr] | [INFO] [stderr] 119 | Err(e) => return panic!("no new frame!") [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unreachable_code)] on by default [INFO] [stderr] [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::single_char_pattern)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern [INFO] [stderr] [INFO] [stderr] warning: single-character string constant used as pattern [INFO] [stderr] --> src/trajectory.rs:155:54 [INFO] [stderr] | [INFO] [stderr] 155 | let lj : Vec<&str> = first_line_vec[9].split("/").collect(); [INFO] [stderr] | ^^^ help: try using a char instead: `'/'` [INFO] [stderr] warning: this if statement can be collapsed [INFO] [stderr] --> src/main.rs:245:9 [INFO] [stderr] | [INFO] [stderr] 245 | / if step as i64 % output_interval == 0 { [INFO] [stderr] 246 | | if step > eq_steps || output_minim { [INFO] [stderr] 247 | | trajectory.write(&rx, &ry, &rz, num_particles, l_x, l_y, l_z, temperature, LJ_EPS, LJ_SIG, cutoff, true); [INFO] [stderr] 248 | | } [INFO] [stderr] 249 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::collapsible_if)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stderr] help: try [INFO] [stderr] | [INFO] [stderr] 245 | if step as i64 % output_interval == 0 && (step > eq_steps || output_minim) { [INFO] [stderr] 246 | trajectory.write(&rx, &ry, &rz, num_particles, l_x, l_y, l_z, temperature, LJ_EPS, LJ_SIG, cutoff, true); [INFO] [stderr] 247 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern [INFO] [stderr] [INFO] [stderr] warning: unreachable expression [INFO] [stderr] --> src/trajectory.rs:119:27 [INFO] [stderr] | [INFO] [stderr] 119 | Err(e) => return panic!("no new frame!") [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unreachable_code)] on by default [INFO] [stderr] [INFO] [stderr] warning: the loop variable `i` is used to index `slab_particles_sum` [INFO] [stderr] --> src/density_z.rs:51:14 [INFO] [stderr] | [INFO] [stderr] 51 | for i in 0..slabs { [INFO] [stderr] | ^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_range_loop)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop [INFO] [stderr] help: consider using an iterator [INFO] [stderr] | [INFO] [stderr] 51 | for (i, ) in slab_particles_sum.iter().enumerate().take(slabs) { [INFO] [stderr] | ^^^^^^^^^^^ ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: unreachable expression [INFO] [stderr] --> src/trajectory.rs:119:27 [INFO] [stderr] | [INFO] [stderr] 119 | Err(e) => return panic!("no new frame!") [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unreachable_code)] on by default [INFO] [stderr] [INFO] [stderr] warning: writing `&String` instead of `&str` involves a new object where a slice will do. [INFO] [stderr] --> src/trajectory.rs:18:26 [INFO] [stderr] | [INFO] [stderr] 18 | pub fn new(filename: &String) -> XYZTrajectory { [INFO] [stderr] | ^^^^^^^ help: change this to: `&str` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::ptr_arg)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: this function has too many arguments (13/7) [INFO] [stderr] --> src/trajectory.rs:33:5 [INFO] [stderr] | [INFO] [stderr] 33 | / pub fn write(&mut self, rx: &[f64], ry: &[f64], rz: &[f64], num_particles: usize, box_x : f64, box_y : f64, box_z : f64, temp: f64 ,lj_eps : f64, lj_sig : f64, lj_cutoff : f64, flush: bool) { [INFO] [stderr] 34 | | self.file.write(format!("{} ## Box: {} {} {} Temp: {} LJ: {}/{}/{}\n", num_particles, box_x,box_y,box_z,temp, lj_eps, lj_sig, lj_cutoff).as_bytes()); [INFO] [stderr] 35 | | for i in 0..num_particles { [INFO] [stderr] 36 | | let formatted = format!("atom{} {} {} {}\n", [INFO] [stderr] ... | [INFO] [stderr] 43 | | [INFO] [stderr] 44 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::too_many_arguments)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#too_many_arguments [INFO] [stderr] [INFO] [stderr] warning: writing `&String` instead of `&str` involves a new object where a slice will do. [INFO] [stderr] --> src/trajectory.rs:80:26 [INFO] [stderr] | [INFO] [stderr] 80 | pub fn new(filename: &String) -> TrjReader { [INFO] [stderr] | ^^^^^^^ help: change this to: `&str` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: single-character string constant used as pattern [INFO] [stderr] --> src/trajectory.rs:103:54 [INFO] [stderr] | [INFO] [stderr] 103 | let lj : Vec<&str> = first_line_vec[9].split("/").collect(); [INFO] [stderr] | ^^^ help: try using a char instead: `'/'` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::single_char_pattern)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern [INFO] [stderr] [INFO] [stderr] warning: writing `&String` instead of `&str` involves a new object where a slice will do. [INFO] [stderr] --> src/trajectory.rs:18:26 [INFO] [stderr] | [INFO] [stderr] 18 | pub fn new(filename: &String) -> XYZTrajectory { [INFO] [stderr] | ^^^^^^^ help: change this to: `&str` [INFO] [stderr] warning: single-character string constant used as pattern [INFO] [stderr] --> src/trajectory.rs:155:54 [INFO] [stderr] | [INFO] [stderr] 155 | let lj : Vec<&str> = first_line_vec[9].split("/").collect(); [INFO] [stderr] | ^^^ help: try using a char instead: `'/'` [INFO] [stderr] | [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern [INFO] [stderr] [INFO] [stderr] = note: #[warn(clippy::ptr_arg)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: this function has too many arguments (13/7) [INFO] [stderr] --> src/trajectory.rs:33:5 [INFO] [stderr] | [INFO] [stderr] 33 | / pub fn write(&mut self, rx: &[f64], ry: &[f64], rz: &[f64], num_particles: usize, box_x : f64, box_y : f64, box_z : f64, temp: f64 ,lj_eps : f64, lj_sig : f64, lj_cutoff : f64, flush: bool) { [INFO] [stderr] 34 | | self.file.write(format!("{} ## Box: {} {} {} Temp: {} LJ: {}/{}/{}\n", num_particles, box_x,box_y,box_z,temp, lj_eps, lj_sig, lj_cutoff).as_bytes()); [INFO] [stderr] 35 | | for i in 0..num_particles { [INFO] [stderr] 36 | | let formatted = format!("atom{} {} {} {}\n", [INFO] [stderr] ... | [INFO] [stderr] 43 | | [INFO] [stderr] 44 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::too_many_arguments)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#too_many_arguments [INFO] [stderr] [INFO] [stderr] warning: writing `&String` instead of `&str` involves a new object where a slice will do. [INFO] [stderr] --> src/trajectory.rs:18:26 [INFO] [stderr] | [INFO] [stderr] 18 | pub fn new(filename: &String) -> XYZTrajectory { [INFO] [stderr] | ^^^^^^^ help: change this to: `&str` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::ptr_arg)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/energy.rs:22:5 [INFO] [stderr] | [INFO] [stderr] 22 | return (energy, virial); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `(energy, virial)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_return)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/energy.rs:43:5 [INFO] [stderr] | [INFO] [stderr] 43 | return (energy, virial); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `(energy, virial)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/energy.rs:58:5 [INFO] [stderr] | [INFO] [stderr] 58 | return dx*dx + dy*dy + dz*dz; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `dx*dx + dy*dy + dz*dz` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/energy.rs:66:5 [INFO] [stderr] | [INFO] [stderr] 66 | return d; [INFO] [stderr] | ^^^^^^^^^ help: remove `return` as shown: `d` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/energy.rs:81:26 [INFO] [stderr] | [INFO] [stderr] 81 | let (x3, y3, z3) = ( 0.948369102634727,1.4018028642626956,2.6884871697542323); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: consider: `0.948_369_102_634_727` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::unreadable_literal)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/energy.rs:81:44 [INFO] [stderr] | [INFO] [stderr] 81 | let (x3, y3, z3) = ( 0.948369102634727,1.4018028642626956,2.6884871697542323); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: consider: `1.401_802_864_262_695_6` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/energy.rs:81:63 [INFO] [stderr] | [INFO] [stderr] 81 | let (x3, y3, z3) = ( 0.948369102634727,1.4018028642626956,2.6884871697542323); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: consider: `2.688_487_169_754_232_3` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/energy.rs:82:26 [INFO] [stderr] | [INFO] [stderr] 82 | let (x4, y4, z4) = ( 0.4924652252404308,0.27903672240586597,1.258265555104697); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: consider: `0.492_465_225_240_430_8` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/energy.rs:82:45 [INFO] [stderr] | [INFO] [stderr] 82 | let (x4, y4, z4) = ( 0.4924652252404308,0.27903672240586597,1.258265555104697); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ help: consider: `0.279_036_722_405_865_97` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/energy.rs:82:65 [INFO] [stderr] | [INFO] [stderr] 82 | let (x4, y4, z4) = ( 0.4924652252404308,0.27903672240586597,1.258265555104697); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: consider: `1.258_265_555_104_697` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/energy.rs:83:62 [INFO] [stderr] | [INFO] [stderr] 83 | let a = get_particle_distance_squared(x3,y3,z3,x4,y4,z4, 1.418983411970384,1.418983411970384,2.83796682394076,0.709491705985192,0.709491705985192,1.418983411970384); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: consider: `1.418_983_411_970_384` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/energy.rs:83:80 [INFO] [stderr] | [INFO] [stderr] 83 | let a = get_particle_distance_squared(x3,y3,z3,x4,y4,z4, 1.418983411970384,1.418983411970384,2.83796682394076,0.709491705985192,0.709491705985192,1.418983411970384); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: consider: `1.418_983_411_970_384` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/energy.rs:83:98 [INFO] [stderr] | [INFO] [stderr] 83 | let a = get_particle_distance_squared(x3,y3,z3,x4,y4,z4, 1.418983411970384,1.418983411970384,2.83796682394076,0.709491705985192,0.709491705985192,1.418983411970384); [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: consider: `2.837_966_823_940_76` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/energy.rs:83:115 [INFO] [stderr] | [INFO] [stderr] 83 | let a = get_particle_distance_squared(x3,y3,z3,x4,y4,z4, 1.418983411970384,1.418983411970384,2.83796682394076,0.709491705985192,0.709491705985192,1.418983411970384); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: consider: `0.709_491_705_985_192` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/energy.rs:83:133 [INFO] [stderr] | [INFO] [stderr] 83 | let a = get_particle_distance_squared(x3,y3,z3,x4,y4,z4, 1.418983411970384,1.418983411970384,2.83796682394076,0.709491705985192,0.709491705985192,1.418983411970384); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: consider: `0.709_491_705_985_192` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/energy.rs:83:151 [INFO] [stderr] | [INFO] [stderr] 83 | let a = get_particle_distance_squared(x3,y3,z3,x4,y4,z4, 1.418983411970384,1.418983411970384,2.83796682394076,0.709491705985192,0.709491705985192,1.418983411970384); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: consider: `1.418_983_411_970_384` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/energy.rs:84:62 [INFO] [stderr] | [INFO] [stderr] 84 | let b = get_particle_distance_squared(x4,y4,z4,x3,y3,z3, 1.418983411970384,1.418983411970384,2.83796682394076,0.709491705985192,0.709491705985192,1.418983411970384); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: consider: `1.418_983_411_970_384` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/energy.rs:84:80 [INFO] [stderr] | [INFO] [stderr] 84 | let b = get_particle_distance_squared(x4,y4,z4,x3,y3,z3, 1.418983411970384,1.418983411970384,2.83796682394076,0.709491705985192,0.709491705985192,1.418983411970384); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: consider: `1.418_983_411_970_384` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/energy.rs:84:98 [INFO] [stderr] | [INFO] [stderr] 84 | let b = get_particle_distance_squared(x4,y4,z4,x3,y3,z3, 1.418983411970384,1.418983411970384,2.83796682394076,0.709491705985192,0.709491705985192,1.418983411970384); [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: consider: `2.837_966_823_940_76` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/energy.rs:84:115 [INFO] [stderr] | [INFO] [stderr] 84 | let b = get_particle_distance_squared(x4,y4,z4,x3,y3,z3, 1.418983411970384,1.418983411970384,2.83796682394076,0.709491705985192,0.709491705985192,1.418983411970384); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: consider: `0.709_491_705_985_192` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: this function has too many arguments (13/7) [INFO] [stderr] --> src/trajectory.rs:33:5 [INFO] [stderr] | [INFO] [stderr] 33 | / pub fn write(&mut self, rx: &[f64], ry: &[f64], rz: &[f64], num_particles: usize, box_x : f64, box_y : f64, box_z : f64, temp: f64 ,lj_eps : f64, lj_sig : f64, lj_cutoff : f64, flush: bool) { [INFO] [stderr] 34 | | self.file.write(format!("{} ## Box: {} {} {} Temp: {} LJ: {}/{}/{}\n", num_particles, box_x,box_y,box_z,temp, lj_eps, lj_sig, lj_cutoff).as_bytes()); [INFO] [stderr] 35 | | for i in 0..num_particles { [INFO] [stderr] 36 | | let formatted = format!("atom{} {} {} {}\n", [INFO] [stderr] ... | [INFO] [stderr] 43 | | [INFO] [stderr] 44 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::too_many_arguments)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#too_many_arguments [INFO] [stderr] [INFO] [stderr] warning: the loop variable `i` is used to index `slab_particles_sum` [INFO] [stderr] --> src/density_z.rs:51:14 [INFO] [stderr] | [INFO] [stderr] 51 | for i in 0..slabs { [INFO] [stderr] | ^^^^^^^^ [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/energy.rs:84:133 [INFO] [stderr] | [INFO] [stderr] 84 | let b = get_particle_distance_squared(x4,y4,z4,x3,y3,z3, 1.418983411970384,1.418983411970384,2.83796682394076,0.709491705985192,0.709491705985192,1.418983411970384); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: consider: `0.709_491_705_985_192` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/energy.rs:84:151 [INFO] [stderr] | [INFO] [stderr] 84 | let b = get_particle_distance_squared(x4,y4,z4,x3,y3,z3, 1.418983411970384,1.418983411970384,2.83796682394076,0.709491705985192,0.709491705985192,1.418983411970384); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: consider: `1.418_983_411_970_384` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/energy.rs:85:28 [INFO] [stderr] | [INFO] [stderr] 85 | assert!( (a-b).abs() < 0.0000000001); [INFO] [stderr] | ^^^^^^^^^^^^ help: consider: `0.000_000_000_1` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/energy.rs:99:5 [INFO] [stderr] | [INFO] [stderr] 99 | return (energy, virial); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `(energy, virial)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/energy.rs:119:5 [INFO] [stderr] | [INFO] [stderr] 119 | return 24.0 * lj_eps / lj_sig * ( r7-2.0*r13 ); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `24.0 * lj_eps / lj_sig * ( r7-2.0*r13 )` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/energy.rs:126:20 [INFO] [stderr] | [INFO] [stderr] 126 | let expected = 1.1580288; [INFO] [stderr] | ^^^^^^^^^ help: consider: `1.158_028_8` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/trajectory.rs:83:9 [INFO] [stderr] | [INFO] [stderr] 83 | return TrjReader { reader:reader }; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `TrjReader { reader:reader }` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/trajectory.rs:135:9 [INFO] [stderr] | [INFO] [stderr] 135 | return frame; [INFO] [stderr] | ^^^^^^^^^^^^^ help: remove `return` as shown: `frame` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/trajectory.rs:176:9 [INFO] [stderr] | [INFO] [stderr] 176 | return true; [INFO] [stderr] | ^^^^^^^^^^^^ help: remove `return` as shown: `true` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: doc comment not used by rustdoc [INFO] [stderr] --> src/main.rs:43:5 [INFO] [stderr] | [INFO] [stderr] 43 | /** Definition of default run parameters **/ [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_doc_comments)] on by default [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/main.rs:44:25 [INFO] [stderr] | [INFO] [stderr] 44 | let mut eq_steps = 1000000; [INFO] [stderr] | ^^^^^^^ help: consider: `1_000_000` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/main.rs:45:28 [INFO] [stderr] | [INFO] [stderr] 45 | let mut sample_steps = 100000; [INFO] [stderr] | ^^^^^^ help: consider: `100_000` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: doc comment not used by rustdoc [INFO] [stderr] --> src/main.rs:75:5 [INFO] [stderr] | [INFO] [stderr] 75 | /** Initialize the system **/ [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: this if statement can be collapsed [INFO] [stderr] --> src/main.rs:245:9 [INFO] [stderr] | [INFO] [stderr] 245 | / if step as i64 % output_interval == 0 { [INFO] [stderr] 246 | | if step > eq_steps || output_minim { [INFO] [stderr] 247 | | trajectory.write(&rx, &ry, &rz, num_particles, l_x, l_y, l_z, temperature, LJ_EPS, LJ_SIG, cutoff, true); [INFO] [stderr] 248 | | } [INFO] [stderr] 249 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::collapsible_if)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stderr] help: try [INFO] [stderr] | [INFO] [stderr] 245 | if step as i64 % output_interval == 0 && (step > eq_steps || output_minim) { [INFO] [stderr] 246 | trajectory.write(&rx, &ry, &rz, num_particles, l_x, l_y, l_z, temperature, LJ_EPS, LJ_SIG, cutoff, true); [INFO] [stderr] 247 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: writing `&String` instead of `&str` involves a new object where a slice will do. [INFO] [stderr] --> src/trajectory.rs:80:26 [INFO] [stderr] | [INFO] [stderr] 80 | pub fn new(filename: &String) -> TrjReader { [INFO] [stderr] | ^^^^^^^ help: change this to: `&str` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: writing `&String` instead of `&str` involves a new object where a slice will do. [INFO] [stderr] --> src/trajectory.rs:80:26 [INFO] [stderr] | [INFO] [stderr] 80 | pub fn new(filename: &String) -> TrjReader { [INFO] [stderr] | ^^^^^^^ help: change this to: `&str` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: single-character string constant used as pattern [INFO] [stderr] --> src/trajectory.rs:103:54 [INFO] [stderr] | [INFO] [stderr] 103 | let lj : Vec<&str> = first_line_vec[9].split("/").collect(); [INFO] [stderr] | ^^^ help: try using a char instead: `'/'` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::single_char_pattern)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern [INFO] [stderr] [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_range_loop)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop [INFO] [stderr] help: consider using an iterator [INFO] [stderr] | [INFO] [stderr] 51 | for (i, ) in slab_particles_sum.iter().enumerate().take(slabs) { [INFO] [stderr] | ^^^^^^^^^^^ ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: single-character string constant used as pattern [INFO] [stderr] --> src/trajectory.rs:155:54 [INFO] [stderr] | [INFO] [stderr] 155 | let lj : Vec<&str> = first_line_vec[9].split("/").collect(); [INFO] [stderr] | ^^^ help: try using a char instead: `'/'` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern [INFO] [stderr] [INFO] [stderr] warning: single-character string constant used as pattern [INFO] [stderr] --> src/trajectory.rs:103:54 [INFO] [stderr] | [INFO] [stderr] 103 | let lj : Vec<&str> = first_line_vec[9].split("/").collect(); [INFO] [stderr] | ^^^ help: try using a char instead: `'/'` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::single_char_pattern)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern [INFO] [stderr] [INFO] [stderr] warning: this function has too many arguments (10/7) [INFO] [stderr] --> src/energy.rs:5:1 [INFO] [stderr] | [INFO] [stderr] 5 | / pub fn get_total_energy(rx: &[f64], ry: &[f64], rz: &[f64], num_particles: usize, l_x: f64, l_y: f64, l_z: f64, cutoff_squared: f64, e_corr: f64, e_shift: f64) -> (f64, f64) { [INFO] [stderr] 6 | | let mut energy = 0.0; [INFO] [stderr] 7 | | let mut virial = 0.0; [INFO] [stderr] 8 | | let hl_x = l_x / 2.0; [INFO] [stderr] ... | [INFO] [stderr] 22 | | return (energy, virial); [INFO] [stderr] 23 | | } [INFO] [stderr] | |_^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#too_many_arguments [INFO] [stderr] [INFO] [stderr] warning: this function has too many arguments (10/7) [INFO] [stderr] --> src/energy.rs:27:1 [INFO] [stderr] | [INFO] [stderr] 27 | / pub fn get_particle_energy(rx: &[f64], ry: &[f64], rz: &[f64], p_index: usize, num_particles: usize, l_x: f64, l_y: f64, l_z: f64, cutoff_squared: f64, e_shift: f64) -> (f64, f64) { [INFO] [stderr] 28 | | let mut energy = 0.0; [INFO] [stderr] 29 | | let mut virial = 0.0; [INFO] [stderr] 30 | | let hl_x = l_x / 2.0; [INFO] [stderr] ... | [INFO] [stderr] 43 | | return (energy, virial); [INFO] [stderr] 44 | | } [INFO] [stderr] | |_^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#too_many_arguments [INFO] [stderr] [INFO] [stderr] warning: this function has too many arguments (12/7) [INFO] [stderr] --> src/energy.rs:47:1 [INFO] [stderr] | [INFO] [stderr] 47 | / pub fn get_particle_distance_squared(x1: f64,y1: f64,z1: f64,x2: f64,y2: f64,z2: f64, l_x: f64, l_y: f64, l_z: f64, hl_x: f64, hl_y: f64, hl_z: f64) -> f64 { [INFO] [stderr] 48 | | let mut dx = (x1 - x2).abs(); [INFO] [stderr] 49 | | let mut dy = (y1 - y2).abs(); [INFO] [stderr] 50 | | let mut dz = (z1 - z2).abs(); [INFO] [stderr] ... | [INFO] [stderr] 58 | | return dx*dx + dy*dy + dz*dz; [INFO] [stderr] 59 | | } [INFO] [stderr] | |_^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#too_many_arguments [INFO] [stderr] [INFO] [stderr] warning: single-character string constant used as pattern [INFO] [stderr] --> src/trajectory.rs:155:54 [INFO] [stderr] | [INFO] [stderr] 155 | let lj : Vec<&str> = first_line_vec[9].split("/").collect(); [INFO] [stderr] | ^^^ help: try using a char instead: `'/'` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern [INFO] [stderr] [INFO] [stderr] warning: this function has too many arguments (10/7) [INFO] [stderr] --> src/energy.rs:5:1 [INFO] [stderr] | [INFO] [stderr] 5 | / pub fn get_total_energy(rx: &[f64], ry: &[f64], rz: &[f64], num_particles: usize, l_x: f64, l_y: f64, l_z: f64, cutoff_squared: f64, e_corr: f64, e_shift: f64) -> (f64, f64) { [INFO] [stderr] 6 | | let mut energy = 0.0; [INFO] [stderr] 7 | | let mut virial = 0.0; [INFO] [stderr] 8 | | let hl_x = l_x / 2.0; [INFO] [stderr] ... | [INFO] [stderr] 22 | | return (energy, virial); [INFO] [stderr] 23 | | } [INFO] [stderr] | |_^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#too_many_arguments [INFO] [stderr] [INFO] [stderr] warning: this function has too many arguments (10/7) [INFO] [stderr] --> src/energy.rs:27:1 [INFO] [stderr] | [INFO] [stderr] 27 | / pub fn get_particle_energy(rx: &[f64], ry: &[f64], rz: &[f64], p_index: usize, num_particles: usize, l_x: f64, l_y: f64, l_z: f64, cutoff_squared: f64, e_shift: f64) -> (f64, f64) { [INFO] [stderr] 28 | | let mut energy = 0.0; [INFO] [stderr] 29 | | let mut virial = 0.0; [INFO] [stderr] 30 | | let hl_x = l_x / 2.0; [INFO] [stderr] ... | [INFO] [stderr] 43 | | return (energy, virial); [INFO] [stderr] 44 | | } [INFO] [stderr] | |_^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#too_many_arguments [INFO] [stderr] [INFO] [stderr] warning: this function has too many arguments (12/7) [INFO] [stderr] --> src/energy.rs:47:1 [INFO] [stderr] | [INFO] [stderr] 47 | / pub fn get_particle_distance_squared(x1: f64,y1: f64,z1: f64,x2: f64,y2: f64,z2: f64, l_x: f64, l_y: f64, l_z: f64, hl_x: f64, hl_y: f64, hl_z: f64) -> f64 { [INFO] [stderr] 48 | | let mut dx = (x1 - x2).abs(); [INFO] [stderr] 49 | | let mut dy = (y1 - y2).abs(); [INFO] [stderr] 50 | | let mut dz = (z1 - z2).abs(); [INFO] [stderr] ... | [INFO] [stderr] 58 | | return dx*dx + dy*dy + dz*dz; [INFO] [stderr] 59 | | } [INFO] [stderr] | |_^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#too_many_arguments [INFO] [stderr] [INFO] [stderr] warning: unreachable expression [INFO] [stderr] --> src/trajectory.rs:119:27 [INFO] [stderr] | [INFO] [stderr] 119 | Err(e) => return panic!("no new frame!") [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unreachable_code)] on by default [INFO] [stderr] [INFO] [stderr] warning: writing `&String` instead of `&str` involves a new object where a slice will do. [INFO] [stderr] --> src/trajectory.rs:18:26 [INFO] [stderr] | [INFO] [stderr] 18 | pub fn new(filename: &String) -> XYZTrajectory { [INFO] [stderr] | ^^^^^^^ help: change this to: `&str` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::ptr_arg)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: this function has too many arguments (13/7) [INFO] [stderr] --> src/trajectory.rs:33:5 [INFO] [stderr] | [INFO] [stderr] 33 | / pub fn write(&mut self, rx: &[f64], ry: &[f64], rz: &[f64], num_particles: usize, box_x : f64, box_y : f64, box_z : f64, temp: f64 ,lj_eps : f64, lj_sig : f64, lj_cutoff : f64, flush: bool) { [INFO] [stderr] 34 | | self.file.write(format!("{} ## Box: {} {} {} Temp: {} LJ: {}/{}/{}\n", num_particles, box_x,box_y,box_z,temp, lj_eps, lj_sig, lj_cutoff).as_bytes()); [INFO] [stderr] 35 | | for i in 0..num_particles { [INFO] [stderr] 36 | | let formatted = format!("atom{} {} {} {}\n", [INFO] [stderr] ... | [INFO] [stderr] 43 | | [INFO] [stderr] 44 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::too_many_arguments)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#too_many_arguments [INFO] [stderr] [INFO] [stderr] warning: writing `&String` instead of `&str` involves a new object where a slice will do. [INFO] [stderr] --> src/trajectory.rs:80:26 [INFO] [stderr] | [INFO] [stderr] 80 | pub fn new(filename: &String) -> TrjReader { [INFO] [stderr] | ^^^^^^^ help: change this to: `&str` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: single-character string constant used as pattern [INFO] [stderr] --> src/trajectory.rs:103:54 [INFO] [stderr] | [INFO] [stderr] 103 | let lj : Vec<&str> = first_line_vec[9].split("/").collect(); [INFO] [stderr] | ^^^ help: try using a char instead: `'/'` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::single_char_pattern)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern [INFO] [stderr] [INFO] [stderr] warning: single-character string constant used as pattern [INFO] [stderr] --> src/trajectory.rs:155:54 [INFO] [stderr] | [INFO] [stderr] 155 | let lj : Vec<&str> = first_line_vec[9].split("/").collect(); [INFO] [stderr] | ^^^ help: try using a char instead: `'/'` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern [INFO] [stderr] [INFO] [stderr] warning: this function has too many arguments (10/7) [INFO] [stderr] --> src/energy.rs:5:1 [INFO] [stderr] | [INFO] [stderr] 5 | / pub fn get_total_energy(rx: &[f64], ry: &[f64], rz: &[f64], num_particles: usize, l_x: f64, l_y: f64, l_z: f64, cutoff_squared: f64, e_corr: f64, e_shift: f64) -> (f64, f64) { [INFO] [stderr] 6 | | let mut energy = 0.0; [INFO] [stderr] 7 | | let mut virial = 0.0; [INFO] [stderr] 8 | | let hl_x = l_x / 2.0; [INFO] [stderr] ... | [INFO] [stderr] 22 | | return (energy, virial); [INFO] [stderr] 23 | | } [INFO] [stderr] | |_^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#too_many_arguments [INFO] [stderr] [INFO] [stderr] warning: this function has too many arguments (10/7) [INFO] [stderr] --> src/energy.rs:27:1 [INFO] [stderr] | [INFO] [stderr] 27 | / pub fn get_particle_energy(rx: &[f64], ry: &[f64], rz: &[f64], p_index: usize, num_particles: usize, l_x: f64, l_y: f64, l_z: f64, cutoff_squared: f64, e_shift: f64) -> (f64, f64) { [INFO] [stderr] 28 | | let mut energy = 0.0; [INFO] [stderr] 29 | | let mut virial = 0.0; [INFO] [stderr] 30 | | let hl_x = l_x / 2.0; [INFO] [stderr] ... | [INFO] [stderr] 43 | | return (energy, virial); [INFO] [stderr] 44 | | } [INFO] [stderr] | |_^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#too_many_arguments [INFO] [stderr] [INFO] [stderr] warning: this function has too many arguments (12/7) [INFO] [stderr] --> src/energy.rs:47:1 [INFO] [stderr] | [INFO] [stderr] 47 | / pub fn get_particle_distance_squared(x1: f64,y1: f64,z1: f64,x2: f64,y2: f64,z2: f64, l_x: f64, l_y: f64, l_z: f64, hl_x: f64, hl_y: f64, hl_z: f64) -> f64 { [INFO] [stderr] 48 | | let mut dx = (x1 - x2).abs(); [INFO] [stderr] 49 | | let mut dy = (y1 - y2).abs(); [INFO] [stderr] 50 | | let mut dz = (z1 - z2).abs(); [INFO] [stderr] ... | [INFO] [stderr] 58 | | return dx*dx + dy*dy + dz*dz; [INFO] [stderr] 59 | | } [INFO] [stderr] | |_^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#too_many_arguments [INFO] [stderr] [INFO] [stderr] warning: unreachable expression [INFO] [stderr] --> src/trajectory.rs:119:27 [INFO] [stderr] | [INFO] [stderr] 119 | Err(e) => return panic!("no new frame!") [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] warning: this function has too many arguments (12/7) [INFO] [stderr] --> src/widom.rs:157:1 [INFO] [stderr] | [INFO] [stderr] 157 | / fn get_particle_insertion_energy(rx: &[f64], ry: &[f64], rz: &[f64], num_particles: usize, x: f64, y: f64, z: f64, l_x: f64,l_y: f64, l_z: f64, cutoff_sqr: f64, e_shift: f64) -> f64 { [INFO] [stderr] 158 | | let mut energy = 0.0; [INFO] [stderr] 159 | | let half_l_x = l_x/2.0; [INFO] [stderr] 160 | | let half_l_y = l_y/2.0; [INFO] [stderr] ... | [INFO] [stderr] 169 | | return energy; [INFO] [stderr] 170 | | } [INFO] [stderr] | |_^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#too_many_arguments [INFO] [stderr] [INFO] [stderr] warning: this function has too many arguments (10/7) [INFO] [stderr] --> src/energy.rs:5:1 [INFO] [stderr] | [INFO] [stderr] 5 | / pub fn get_total_energy(rx: &[f64], ry: &[f64], rz: &[f64], num_particles: usize, l_x: f64, l_y: f64, l_z: f64, cutoff_squared: f64, e_corr: f64, e_shift: f64) -> (f64, f64) { [INFO] [stderr] 6 | | let mut energy = 0.0; [INFO] [stderr] 7 | | let mut virial = 0.0; [INFO] [stderr] 8 | | let hl_x = l_x / 2.0; [INFO] [stderr] ... | [INFO] [stderr] 22 | | return (energy, virial); [INFO] [stderr] 23 | | } [INFO] [stderr] | |_^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::too_many_arguments)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#too_many_arguments [INFO] [stderr] [INFO] [stderr] warning: this function has too many arguments (10/7) [INFO] [stderr] --> src/energy.rs:27:1 [INFO] [stderr] | [INFO] [stderr] 27 | / pub fn get_particle_energy(rx: &[f64], ry: &[f64], rz: &[f64], p_index: usize, num_particles: usize, l_x: f64, l_y: f64, l_z: f64, cutoff_squared: f64, e_shift: f64) -> (f64, f64) { [INFO] [stderr] 28 | | let mut energy = 0.0; [INFO] [stderr] 29 | | let mut virial = 0.0; [INFO] [stderr] 30 | | let hl_x = l_x / 2.0; [INFO] [stderr] ... | [INFO] [stderr] 43 | | return (energy, virial); [INFO] [stderr] 44 | | } [INFO] [stderr] | |_^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#too_many_arguments [INFO] [stderr] [INFO] [stderr] warning: this function has too many arguments (12/7) [INFO] [stderr] --> src/energy.rs:47:1 [INFO] [stderr] | [INFO] [stderr] 47 | / pub fn get_particle_distance_squared(x1: f64,y1: f64,z1: f64,x2: f64,y2: f64,z2: f64, l_x: f64, l_y: f64, l_z: f64, hl_x: f64, hl_y: f64, hl_z: f64) -> f64 { [INFO] [stderr] 48 | | let mut dx = (x1 - x2).abs(); [INFO] [stderr] 49 | | let mut dy = (y1 - y2).abs(); [INFO] [stderr] 50 | | let mut dz = (z1 - z2).abs(); [INFO] [stderr] ... | [INFO] [stderr] 58 | | return dx*dx + dy*dy + dz*dz; [INFO] [stderr] 59 | | } [INFO] [stderr] | |_^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#too_many_arguments [INFO] [stderr] [INFO] [stderr] warning: writing `&String` instead of `&str` involves a new object where a slice will do. [INFO] [stderr] --> src/trajectory.rs:18:26 [INFO] [stderr] | [INFO] [stderr] 18 | pub fn new(filename: &String) -> XYZTrajectory { [INFO] [stderr] | ^^^^^^^ help: change this to: `&str` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::ptr_arg)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unreachable_code)] on by default [INFO] [stderr] [INFO] [stderr] warning: this function has too many arguments (13/7) [INFO] [stderr] --> src/trajectory.rs:33:5 [INFO] [stderr] | [INFO] [stderr] 33 | / pub fn write(&mut self, rx: &[f64], ry: &[f64], rz: &[f64], num_particles: usize, box_x : f64, box_y : f64, box_z : f64, temp: f64 ,lj_eps : f64, lj_sig : f64, lj_cutoff : f64, flush: bool) { [INFO] [stderr] 34 | | self.file.write(format!("{} ## Box: {} {} {} Temp: {} LJ: {}/{}/{}\n", num_particles, box_x,box_y,box_z,temp, lj_eps, lj_sig, lj_cutoff).as_bytes()); [INFO] [stderr] 35 | | for i in 0..num_particles { [INFO] [stderr] 36 | | let formatted = format!("atom{} {} {} {}\n", [INFO] [stderr] ... | [INFO] [stderr] 43 | | [INFO] [stderr] 44 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#too_many_arguments [INFO] [stderr] [INFO] [stderr] warning: writing `&String` instead of `&str` involves a new object where a slice will do. [INFO] [stderr] --> src/trajectory.rs:80:26 [INFO] [stderr] | [INFO] [stderr] 80 | pub fn new(filename: &String) -> TrjReader { [INFO] [stderr] | ^^^^^^^ help: change this to: `&str` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: single-character string constant used as pattern [INFO] [stderr] --> src/trajectory.rs:103:54 [INFO] [stderr] | [INFO] [stderr] 103 | let lj : Vec<&str> = first_line_vec[9].split("/").collect(); [INFO] [stderr] | ^^^ help: try using a char instead: `'/'` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::single_char_pattern)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern [INFO] [stderr] [INFO] [stderr] warning: single-character string constant used as pattern [INFO] [stderr] --> src/trajectory.rs:155:54 [INFO] [stderr] | [INFO] [stderr] 155 | let lj : Vec<&str> = first_line_vec[9].split("/").collect(); [INFO] [stderr] | ^^^ help: try using a char instead: `'/'` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern [INFO] [stderr] [INFO] [stderr] warning: the loop variable `i` is only used to index `rz`. [INFO] [stderr] --> src/main.rs:107:18 [INFO] [stderr] | [INFO] [stderr] 107 | for i in 0..num_particles { [INFO] [stderr] | ^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_range_loop)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop [INFO] [stderr] help: consider using an iterator [INFO] [stderr] | [INFO] [stderr] 107 | for in rz.iter_mut().take(num_particles) { [INFO] [stderr] | ^^^^^^ ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: casting i32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/main.rs:216:61 [INFO] [stderr] | [INFO] [stderr] 216 | let tries_per_step : f64 = step_counter as f64 /accept_counter as f64; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^ help: try: `f64::from(accept_counter)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cast_lossless)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting i32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/main.rs:225:61 [INFO] [stderr] | [INFO] [stderr] 225 | let tries_per_step : f64 = step_counter as f64 /accept_counter as f64; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^ help: try: `f64::from(accept_counter)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting i32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/main.rs:260:38 [INFO] [stderr] | [INFO] [stderr] 260 | let final_acceptance_rate = 1.0/((accept_counter as f64)/(step_counter as f64)) * 100.0; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^ help: try: `f64::from(accept_counter)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: this function has too many arguments (14/7) [INFO] [stderr] --> src/main.rs:307:1 [INFO] [stderr] | [INFO] [stderr] 307 | / fn parse_cmd_args(NUM_STEPS: &mut usize, NUM_eq_steps: &mut usize, [INFO] [stderr] 308 | | NUM_PARTICLES: &mut usize, DENSITY: &mut f64, TEMPERATURE: &mut f64, [INFO] [stderr] 309 | | CUTOFF: &mut f64, MAX_DISP_START: &mut f64, SCALE: &mut bool, TAILCORR: &mut bool, SHIFT: &mut bool, [INFO] [stderr] 310 | | OUTPUT_PREFIX: &mut String, OUTPUT_INTERVAL: &mut i64, OUTPUT_MINIM: &mut bool, [INFO] [stderr] ... | [INFO] [stderr] 356 | | ap.parse_args_or_exit(); [INFO] [stderr] 357 | | } [INFO] [stderr] | |_^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#too_many_arguments [INFO] [stderr] [INFO] [stderr] warning: unreachable expression [INFO] [stderr] --> src/trajectory.rs:119:27 [INFO] [stderr] | [INFO] [stderr] 119 | Err(e) => return panic!("no new frame!") [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unreachable_code)] on by default [INFO] [stderr] [INFO] [stderr] warning: writing `&String` instead of `&str` involves a new object where a slice will do. [INFO] [stderr] --> src/trajectory.rs:18:26 [INFO] [stderr] | [INFO] [stderr] 18 | pub fn new(filename: &String) -> XYZTrajectory { [INFO] [stderr] | ^^^^^^^ help: change this to: `&str` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::ptr_arg)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: this function has too many arguments (13/7) [INFO] [stderr] --> src/trajectory.rs:33:5 [INFO] [stderr] | [INFO] [stderr] 33 | / pub fn write(&mut self, rx: &[f64], ry: &[f64], rz: &[f64], num_particles: usize, box_x : f64, box_y : f64, box_z : f64, temp: f64 ,lj_eps : f64, lj_sig : f64, lj_cutoff : f64, flush: bool) { [INFO] [stderr] 34 | | self.file.write(format!("{} ## Box: {} {} {} Temp: {} LJ: {}/{}/{}\n", num_particles, box_x,box_y,box_z,temp, lj_eps, lj_sig, lj_cutoff).as_bytes()); [INFO] [stderr] 35 | | for i in 0..num_particles { [INFO] [stderr] 36 | | let formatted = format!("atom{} {} {} {}\n", [INFO] [stderr] ... | [INFO] [stderr] 43 | | [INFO] [stderr] 44 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::too_many_arguments)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#too_many_arguments [INFO] [stderr] [INFO] [stderr] warning: writing `&String` instead of `&str` involves a new object where a slice will do. [INFO] [stderr] --> src/trajectory.rs:80:26 [INFO] [stderr] | [INFO] [stderr] 80 | pub fn new(filename: &String) -> TrjReader { [INFO] [stderr] | ^^^^^^^ help: change this to: `&str` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: single-character string constant used as pattern [INFO] [stderr] --> src/trajectory.rs:103:54 [INFO] [stderr] | [INFO] [stderr] 103 | let lj : Vec<&str> = first_line_vec[9].split("/").collect(); [INFO] [stderr] | ^^^ help: try using a char instead: `'/'` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::single_char_pattern)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern [INFO] [stderr] [INFO] [stderr] warning: single-character string constant used as pattern [INFO] [stderr] --> src/trajectory.rs:155:54 [INFO] [stderr] | [INFO] [stderr] 155 | let lj : Vec<&str> = first_line_vec[9].split("/").collect(); [INFO] [stderr] | ^^^ help: try using a char instead: `'/'` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern [INFO] [stderr] [INFO] [stderr] warning: this function has too many arguments (10/7) [INFO] [stderr] --> src/energy.rs:5:1 [INFO] [stderr] | [INFO] [stderr] 5 | / pub fn get_total_energy(rx: &[f64], ry: &[f64], rz: &[f64], num_particles: usize, l_x: f64, l_y: f64, l_z: f64, cutoff_squared: f64, e_corr: f64, e_shift: f64) -> (f64, f64) { [INFO] [stderr] 6 | | let mut energy = 0.0; [INFO] [stderr] 7 | | let mut virial = 0.0; [INFO] [stderr] 8 | | let hl_x = l_x / 2.0; [INFO] [stderr] ... | [INFO] [stderr] 22 | | return (energy, virial); [INFO] [stderr] 23 | | } [INFO] [stderr] | |_^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#too_many_arguments [INFO] [stderr] [INFO] [stderr] warning: this function has too many arguments (10/7) [INFO] [stderr] --> src/energy.rs:27:1 [INFO] [stderr] | [INFO] [stderr] 27 | / pub fn get_particle_energy(rx: &[f64], ry: &[f64], rz: &[f64], p_index: usize, num_particles: usize, l_x: f64, l_y: f64, l_z: f64, cutoff_squared: f64, e_shift: f64) -> (f64, f64) { [INFO] [stderr] 28 | | let mut energy = 0.0; [INFO] [stderr] 29 | | let mut virial = 0.0; [INFO] [stderr] 30 | | let hl_x = l_x / 2.0; [INFO] [stderr] ... | [INFO] [stderr] 43 | | return (energy, virial); [INFO] [stderr] 44 | | } [INFO] [stderr] | |_^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#too_many_arguments [INFO] [stderr] [INFO] [stderr] warning: this function has too many arguments (12/7) [INFO] [stderr] --> src/energy.rs:47:1 [INFO] [stderr] | [INFO] [stderr] 47 | / pub fn get_particle_distance_squared(x1: f64,y1: f64,z1: f64,x2: f64,y2: f64,z2: f64, l_x: f64, l_y: f64, l_z: f64, hl_x: f64, hl_y: f64, hl_z: f64) -> f64 { [INFO] [stderr] 48 | | let mut dx = (x1 - x2).abs(); [INFO] [stderr] 49 | | let mut dy = (y1 - y2).abs(); [INFO] [stderr] 50 | | let mut dz = (z1 - z2).abs(); [INFO] [stderr] ... | [INFO] [stderr] 58 | | return dx*dx + dy*dy + dz*dz; [INFO] [stderr] 59 | | } [INFO] [stderr] | |_^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#too_many_arguments [INFO] [stderr] [INFO] [stderr] warning: this function has too many arguments (12/7) [INFO] [stderr] --> src/widom.rs:157:1 [INFO] [stderr] | [INFO] [stderr] 157 | / fn get_particle_insertion_energy(rx: &[f64], ry: &[f64], rz: &[f64], num_particles: usize, x: f64, y: f64, z: f64, l_x: f64,l_y: f64, l_z: f64, cutoff_sqr: f64, e_shift: f64) -> f64 { [INFO] [stderr] 158 | | let mut energy = 0.0; [INFO] [stderr] 159 | | let half_l_x = l_x/2.0; [INFO] [stderr] 160 | | let half_l_y = l_y/2.0; [INFO] [stderr] ... | [INFO] [stderr] 169 | | return energy; [INFO] [stderr] 170 | | } [INFO] [stderr] | |_^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#too_many_arguments [INFO] [stderr] [INFO] [stderr] warning: this function has too many arguments (10/7) [INFO] [stderr] --> src/energy.rs:5:1 [INFO] [stderr] | [INFO] [stderr] 5 | / pub fn get_total_energy(rx: &[f64], ry: &[f64], rz: &[f64], num_particles: usize, l_x: f64, l_y: f64, l_z: f64, cutoff_squared: f64, e_corr: f64, e_shift: f64) -> (f64, f64) { [INFO] [stderr] 6 | | let mut energy = 0.0; [INFO] [stderr] 7 | | let mut virial = 0.0; [INFO] [stderr] 8 | | let hl_x = l_x / 2.0; [INFO] [stderr] ... | [INFO] [stderr] 22 | | return (energy, virial); [INFO] [stderr] 23 | | } [INFO] [stderr] | |_^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::too_many_arguments)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#too_many_arguments [INFO] [stderr] [INFO] [stderr] warning: this function has too many arguments (10/7) [INFO] [stderr] --> src/energy.rs:27:1 [INFO] [stderr] | [INFO] [stderr] 27 | / pub fn get_particle_energy(rx: &[f64], ry: &[f64], rz: &[f64], p_index: usize, num_particles: usize, l_x: f64, l_y: f64, l_z: f64, cutoff_squared: f64, e_shift: f64) -> (f64, f64) { [INFO] [stderr] 28 | | let mut energy = 0.0; [INFO] [stderr] 29 | | let mut virial = 0.0; [INFO] [stderr] 30 | | let hl_x = l_x / 2.0; [INFO] [stderr] ... | [INFO] [stderr] 43 | | return (energy, virial); [INFO] [stderr] 44 | | } [INFO] [stderr] | |_^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#too_many_arguments [INFO] [stderr] [INFO] [stderr] warning: this function has too many arguments (12/7) [INFO] [stderr] --> src/energy.rs:47:1 [INFO] [stderr] | [INFO] [stderr] 47 | / pub fn get_particle_distance_squared(x1: f64,y1: f64,z1: f64,x2: f64,y2: f64,z2: f64, l_x: f64, l_y: f64, l_z: f64, hl_x: f64, hl_y: f64, hl_z: f64) -> f64 { [INFO] [stderr] 48 | | let mut dx = (x1 - x2).abs(); [INFO] [stderr] 49 | | let mut dy = (y1 - y2).abs(); [INFO] [stderr] 50 | | let mut dz = (z1 - z2).abs(); [INFO] [stderr] ... | [INFO] [stderr] 58 | | return dx*dx + dy*dy + dz*dz; [INFO] [stderr] 59 | | } [INFO] [stderr] | |_^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#too_many_arguments [INFO] [stderr] [INFO] [stderr] warning: writing `&String` instead of `&str` involves a new object where a slice will do. [INFO] [stderr] --> src/trajectory.rs:18:26 [INFO] [stderr] | [INFO] [stderr] 18 | pub fn new(filename: &String) -> XYZTrajectory { [INFO] [stderr] | ^^^^^^^ help: change this to: `&str` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::ptr_arg)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: this function has too many arguments (13/7) [INFO] [stderr] --> src/trajectory.rs:33:5 [INFO] [stderr] | [INFO] [stderr] 33 | / pub fn write(&mut self, rx: &[f64], ry: &[f64], rz: &[f64], num_particles: usize, box_x : f64, box_y : f64, box_z : f64, temp: f64 ,lj_eps : f64, lj_sig : f64, lj_cutoff : f64, flush: bool) { [INFO] [stderr] 34 | | self.file.write(format!("{} ## Box: {} {} {} Temp: {} LJ: {}/{}/{}\n", num_particles, box_x,box_y,box_z,temp, lj_eps, lj_sig, lj_cutoff).as_bytes()); [INFO] [stderr] 35 | | for i in 0..num_particles { [INFO] [stderr] 36 | | let formatted = format!("atom{} {} {} {}\n", [INFO] [stderr] ... | [INFO] [stderr] 43 | | [INFO] [stderr] 44 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#too_many_arguments [INFO] [stderr] [INFO] [stderr] warning: writing `&String` instead of `&str` involves a new object where a slice will do. [INFO] [stderr] --> src/trajectory.rs:80:26 [INFO] [stderr] | [INFO] [stderr] 80 | pub fn new(filename: &String) -> TrjReader { [INFO] [stderr] | ^^^^^^^ help: change this to: `&str` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: single-character string constant used as pattern [INFO] [stderr] --> src/trajectory.rs:103:54 [INFO] [stderr] | [INFO] [stderr] 103 | let lj : Vec<&str> = first_line_vec[9].split("/").collect(); [INFO] [stderr] | ^^^ help: try using a char instead: `'/'` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::single_char_pattern)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern [INFO] [stderr] [INFO] [stderr] warning: single-character string constant used as pattern [INFO] [stderr] --> src/trajectory.rs:155:54 [INFO] [stderr] | [INFO] [stderr] 155 | let lj : Vec<&str> = first_line_vec[9].split("/").collect(); [INFO] [stderr] | ^^^ help: try using a char instead: `'/'` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern [INFO] [stderr] [INFO] [stderr] warning: the loop variable `i` is only used to index `rz`. [INFO] [stderr] --> src/main.rs:107:18 [INFO] [stderr] | [INFO] [stderr] 107 | for i in 0..num_particles { [INFO] [stderr] | ^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_range_loop)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop [INFO] [stderr] help: consider using an iterator [INFO] [stderr] | [INFO] [stderr] 107 | for in rz.iter_mut().take(num_particles) { [INFO] [stderr] | ^^^^^^ ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: casting i32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/main.rs:216:61 [INFO] [stderr] | [INFO] [stderr] 216 | let tries_per_step : f64 = step_counter as f64 /accept_counter as f64; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^ help: try: `f64::from(accept_counter)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cast_lossless)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting i32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/main.rs:225:61 [INFO] [stderr] | [INFO] [stderr] 225 | let tries_per_step : f64 = step_counter as f64 /accept_counter as f64; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^ help: try: `f64::from(accept_counter)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting i32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/main.rs:260:38 [INFO] [stderr] | [INFO] [stderr] 260 | let final_acceptance_rate = 1.0/((accept_counter as f64)/(step_counter as f64)) * 100.0; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^ help: try: `f64::from(accept_counter)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: this function has too many arguments (14/7) [INFO] [stderr] --> src/main.rs:307:1 [INFO] [stderr] | [INFO] [stderr] 307 | / fn parse_cmd_args(NUM_STEPS: &mut usize, NUM_eq_steps: &mut usize, [INFO] [stderr] 308 | | NUM_PARTICLES: &mut usize, DENSITY: &mut f64, TEMPERATURE: &mut f64, [INFO] [stderr] 309 | | CUTOFF: &mut f64, MAX_DISP_START: &mut f64, SCALE: &mut bool, TAILCORR: &mut bool, SHIFT: &mut bool, [INFO] [stderr] 310 | | OUTPUT_PREFIX: &mut String, OUTPUT_INTERVAL: &mut i64, OUTPUT_MINIM: &mut bool, [INFO] [stderr] ... | [INFO] [stderr] 356 | | ap.parse_args_or_exit(); [INFO] [stderr] 357 | | } [INFO] [stderr] | |_^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#too_many_arguments [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 3.91s [INFO] running `"docker" "inspect" "57fa9ceb035a79f3cf61cc0ef6a73f88f256e9a384f47d0d0f3e438ce43c19a1"` [INFO] running `"docker" "rm" "-f" "57fa9ceb035a79f3cf61cc0ef6a73f88f256e9a384f47d0d0f3e438ce43c19a1"` [INFO] [stdout] 57fa9ceb035a79f3cf61cc0ef6a73f88f256e9a384f47d0d0f3e438ce43c19a1