[INFO] updating cached repository danielwelch/zigbee2mqtt-hassio-updater [INFO] running `"git" "fetch" "--all"` [INFO] [stdout] Fetching origin [INFO] [stderr] From git://github.com/danielwelch/zigbee2mqtt-hassio-updater [INFO] [stderr] * branch HEAD -> FETCH_HEAD [INFO] running `"git" "clone" "work/cache/sources/gh/danielwelch/zigbee2mqtt-hassio-updater" "work/ex/clippy-test-run/sources/stable/gh/danielwelch/zigbee2mqtt-hassio-updater"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/danielwelch/zigbee2mqtt-hassio-updater'... [INFO] [stderr] done. [INFO] running `"git" "clone" "work/cache/sources/gh/danielwelch/zigbee2mqtt-hassio-updater" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/danielwelch/zigbee2mqtt-hassio-updater"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/danielwelch/zigbee2mqtt-hassio-updater'... [INFO] [stderr] done. [INFO] running `"git" "rev-parse" "HEAD"` [INFO] [stdout] 5bef041c3dd7175ffef6642379325bb5086372d7 [INFO] sha for GitHub repo danielwelch/zigbee2mqtt-hassio-updater: 5bef041c3dd7175ffef6642379325bb5086372d7 [INFO] validating manifest of danielwelch/zigbee2mqtt-hassio-updater on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of danielwelch/zigbee2mqtt-hassio-updater on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing danielwelch/zigbee2mqtt-hassio-updater [INFO] finished frobbing danielwelch/zigbee2mqtt-hassio-updater [INFO] frobbed toml for danielwelch/zigbee2mqtt-hassio-updater written to work/ex/clippy-test-run/sources/stable/gh/danielwelch/zigbee2mqtt-hassio-updater/Cargo.toml [INFO] started frobbing danielwelch/zigbee2mqtt-hassio-updater [INFO] finished frobbing danielwelch/zigbee2mqtt-hassio-updater [INFO] frobbed toml for danielwelch/zigbee2mqtt-hassio-updater written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/danielwelch/zigbee2mqtt-hassio-updater/Cargo.toml [INFO] crate danielwelch/zigbee2mqtt-hassio-updater has a lockfile. skipping [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting danielwelch/zigbee2mqtt-hassio-updater against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-6/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/gh/danielwelch/zigbee2mqtt-hassio-updater:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 9c90afd61093ed6b70e4bbf7c4b784b0814e4d5785eaef70b61489502f9cccff [INFO] running `"docker" "start" "-a" "9c90afd61093ed6b70e4bbf7c4b784b0814e4d5785eaef70b61489502f9cccff"` [INFO] [stderr] Compiling serde v1.0.63 [INFO] [stderr] Checking hostname v0.1.5 [INFO] [stderr] Compiling backtrace-sys v0.1.22 [INFO] [stderr] Compiling actix-web v0.6.10 [INFO] [stderr] Compiling num_cpus v1.8.0 [INFO] [stderr] Checking miniz-sys v0.1.10 [INFO] [stderr] Checking brotli-sys v0.3.2 [INFO] [stderr] Checking http v0.1.5 [INFO] [stderr] Checking rust-crypto v0.2.36 [INFO] [stderr] Checking regex v1.0.0 [INFO] [stderr] Checking flate2 v1.0.1 [INFO] [stderr] Checking brotli2 v0.3.2 [INFO] [stderr] Checking resolv-conf v0.6.1 [INFO] [stderr] Checking crossbeam-channel v0.1.3 [INFO] [stderr] Compiling serde_derive v1.0.63 [INFO] [stderr] Compiling rayon-core v1.4.0 [INFO] [stderr] Checking tokio-signal v0.1.5 [INFO] [stderr] Compiling rayon v0.8.2 [INFO] [stderr] Compiling backtrace v0.3.8 [INFO] [stderr] Checking backtrace v0.2.3 [INFO] [stderr] Checking h2 v0.1.8 [INFO] [stderr] Checking failure v0.1.1 [INFO] [stderr] Checking error-chain v0.1.12 [INFO] [stderr] Compiling error-chain v0.11.0 [INFO] [stderr] Checking trust-dns-proto v0.3.3 [INFO] [stderr] Compiling ring v0.12.1 [INFO] [stderr] Checking trust-dns-resolver v0.8.2 [INFO] [stderr] Compiling semver v0.9.0 [INFO] [stderr] Compiling serde_json v1.0.18 [INFO] [stderr] Checking serde_urlencoded v0.5.2 [INFO] [stderr] Checking cookie v0.10.1 [INFO] [stderr] Checking reqwest v0.8.5 [INFO] [stderr] Compiling cargo_metadata v0.5.4 [INFO] [stderr] Compiling skeptic v0.13.3 [INFO] [stderr] Compiling actix v0.5.7 [INFO] [stderr] Checking zigbee2mqtt-updater v0.1.0 (/opt/crater/workdir) [INFO] [stderr] warning: unused import: `hyper::header::Headers` [INFO] [stderr] --> src/main.rs:50:5 [INFO] [stderr] | [INFO] [stderr] 50 | use hyper::header::Headers; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_imports)] on by default [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/main.rs:59:13 [INFO] [stderr] | [INFO] [stderr] 59 | return Err(self.e.unwrap()); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Err(self.e.unwrap())` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_return)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unused import: `ToSocketAddrs` [INFO] [stderr] --> src/main.rs:179:32 [INFO] [stderr] | [INFO] [stderr] 179 | use std::net::{SocketAddr, ToSocketAddrs}; [INFO] [stderr] | ^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: unused import: `hyper::header::Headers` [INFO] [stderr] --> src/main.rs:50:5 [INFO] [stderr] | [INFO] [stderr] 50 | use hyper::header::Headers; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_imports)] on by default [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/main.rs:59:13 [INFO] [stderr] | [INFO] [stderr] 59 | return Err(self.e.unwrap()); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `Err(self.e.unwrap())` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_return)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unused import: `ToSocketAddrs` [INFO] [stderr] --> src/main.rs:179:32 [INFO] [stderr] | [INFO] [stderr] 179 | use std::net::{SocketAddr, ToSocketAddrs}; [INFO] [stderr] | ^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: use of `ok_or` followed by a function call [INFO] [stderr] --> src/main.rs:94:14 [INFO] [stderr] | [INFO] [stderr] 94 | .ok_or(ErrorUnauthorized(ParseError::Header))? [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `ok_or_else(|| ErrorUnauthorized(ParseError::Header))` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::or_fun_call)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] warning: unused variable: `data` [INFO] [stderr] --> src/tests.rs:22:9 [INFO] [stderr] | [INFO] [stderr] 22 | let data: PushEvent = serde_json::from_reader(payload).unwrap(); [INFO] [stderr] | ^^^^ help: consider using `_data` instead [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_variables)] on by default [INFO] [stderr] [INFO] [stderr] warning: unused variable: `req` [INFO] [stderr] --> src/tests.rs:36:14 [INFO] [stderr] | [INFO] [stderr] 36 | fn index(req: HttpRequest) -> &'static str { [INFO] [stderr] | ^^^ help: consider using `_req` instead [INFO] [stderr] [INFO] [stderr] warning: use of `ok_or` followed by a function call [INFO] [stderr] --> src/main.rs:94:14 [INFO] [stderr] | [INFO] [stderr] 94 | .ok_or(ErrorUnauthorized(ParseError::Header))? [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `ok_or_else(|| ErrorUnauthorized(ParseError::Header))` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::or_fun_call)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 1m 30s [INFO] running `"docker" "inspect" "9c90afd61093ed6b70e4bbf7c4b784b0814e4d5785eaef70b61489502f9cccff"` [INFO] running `"docker" "rm" "-f" "9c90afd61093ed6b70e4bbf7c4b784b0814e4d5785eaef70b61489502f9cccff"` [INFO] [stdout] 9c90afd61093ed6b70e4bbf7c4b784b0814e4d5785eaef70b61489502f9cccff