[INFO] updating cached repository danielpclark/bench_ruby_ffi_example [INFO] running `"git" "fetch" "--all"` [INFO] [stdout] Fetching origin [INFO] [stderr] From git://github.com/danielpclark/bench_ruby_ffi_example [INFO] [stderr] * branch HEAD -> FETCH_HEAD [INFO] running `"git" "clone" "work/cache/sources/gh/danielpclark/bench_ruby_ffi_example" "work/ex/clippy-test-run/sources/stable/gh/danielpclark/bench_ruby_ffi_example"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/danielpclark/bench_ruby_ffi_example'... [INFO] [stderr] done. [INFO] running `"git" "clone" "work/cache/sources/gh/danielpclark/bench_ruby_ffi_example" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/danielpclark/bench_ruby_ffi_example"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/danielpclark/bench_ruby_ffi_example'... [INFO] [stderr] done. [INFO] running `"git" "rev-parse" "HEAD"` [INFO] [stdout] 2f8fae8311f8d69695d428e538201c98ba2c67c2 [INFO] sha for GitHub repo danielpclark/bench_ruby_ffi_example: 2f8fae8311f8d69695d428e538201c98ba2c67c2 [INFO] validating manifest of danielpclark/bench_ruby_ffi_example on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of danielpclark/bench_ruby_ffi_example on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing danielpclark/bench_ruby_ffi_example [INFO] finished frobbing danielpclark/bench_ruby_ffi_example [INFO] frobbed toml for danielpclark/bench_ruby_ffi_example written to work/ex/clippy-test-run/sources/stable/gh/danielpclark/bench_ruby_ffi_example/Cargo.toml [INFO] started frobbing danielpclark/bench_ruby_ffi_example [INFO] finished frobbing danielpclark/bench_ruby_ffi_example [INFO] frobbed toml for danielpclark/bench_ruby_ffi_example written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/danielpclark/bench_ruby_ffi_example/Cargo.toml [INFO] crate danielpclark/bench_ruby_ffi_example has a lockfile. skipping [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting danielpclark/bench_ruby_ffi_example against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-3/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/gh/danielpclark/bench_ruby_ffi_example:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 30bb6169908e8b09d6ae0af359cc79f79215f873d59f921aea54d5f19990a7f8 [INFO] running `"docker" "start" "-a" "30bb6169908e8b09d6ae0af359cc79f79215f873d59f921aea54d5f19990a7f8"` [INFO] [stderr] Checking array_tool v0.4.1 [INFO] [stderr] Checking ruby-sys v0.2.20 [INFO] [stderr] Checking ruru v0.9.3 [INFO] [stderr] Checking ffi_example v0.0.1 (/opt/crater/workdir) [INFO] [stderr] warning: unused import: `self::array_tool::string::Squeeze` [INFO] [stderr] --> src/lib.rs:11:7 [INFO] [stderr] | [INFO] [stderr] 11 | use self::array_tool::string::Squeeze; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_imports)] on by default [INFO] [stderr] [INFO] [stderr] warning: unused import: `self::array_tool::string::Squeeze` [INFO] [stderr] --> src/lib.rs:11:7 [INFO] [stderr] | [INFO] [stderr] 11 | use self::array_tool::string::Squeeze; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_imports)] on by default [INFO] [stderr] [INFO] [stderr] error: this public function dereferences a raw pointer but is not marked `unsafe` [INFO] [stderr] --> src/lib.rs:59:20 [INFO] [stderr] | [INFO] [stderr] 59 | CStr::from_ptr(c_pth).to_str().unwrap() [INFO] [stderr] | ^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[deny(clippy::not_unsafe_ptr_arg_deref)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#not_unsafe_ptr_arg_deref [INFO] [stderr] [INFO] [stderr] error: this public function dereferences a raw pointer but is not marked `unsafe` [INFO] [stderr] --> src/lib.rs:63:20 [INFO] [stderr] | [INFO] [stderr] 63 | CStr::from_ptr(c_ext).to_str().unwrap() [INFO] [stderr] | ^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#not_unsafe_ptr_arg_deref [INFO] [stderr] [INFO] [stderr] error: this public function dereferences a raw pointer but is not marked `unsafe` [INFO] [stderr] --> src/lib.rs:75:23 [INFO] [stderr] | [INFO] [stderr] 75 | CString::from_raw(s) [INFO] [stderr] | ^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#not_unsafe_ptr_arg_deref [INFO] [stderr] [INFO] [stderr] error: this public function dereferences a raw pointer but is not marked `unsafe` [INFO] [stderr] --> src/lib.rs:84:37 [INFO] [stderr] | [INFO] [stderr] 84 | let pth = unsafe { CStr::from_ptr(c_pth) }.to_str().unwrap(); [INFO] [stderr] | ^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#not_unsafe_ptr_arg_deref [INFO] [stderr] [INFO] [stderr] error: this public function dereferences a raw pointer but is not marked `unsafe` [INFO] [stderr] --> src/lib.rs:85:37 [INFO] [stderr] | [INFO] [stderr] 85 | let ext = unsafe { CStr::from_ptr(c_ext) }.to_str().unwrap(); [INFO] [stderr] | ^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#not_unsafe_ptr_arg_deref [INFO] [stderr] [INFO] [stderr] warning: use of `unwrap_or` followed by a function call [INFO] [stderr] --> src/lib.rs:100:18 [INFO] [stderr] | [INFO] [stderr] 100 | pth.ok().unwrap_or(RString::new("")).to_str(), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `unwrap_or_else(|| RString::new(""))` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::or_fun_call)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] warning: use of `unwrap_or` followed by a function call [INFO] [stderr] --> src/lib.rs:101:18 [INFO] [stderr] | [INFO] [stderr] 101 | ext.ok().unwrap_or(RString::new("")).to_str() [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `unwrap_or_else(|| RString::new(""))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] error: aborting due to 5 previous errors [INFO] [stderr] [INFO] [stderr] error: Could not compile `ffi_example`. [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stderr] error: this public function dereferences a raw pointer but is not marked `unsafe` [INFO] [stderr] --> src/lib.rs:59:20 [INFO] [stderr] | [INFO] [stderr] 59 | CStr::from_ptr(c_pth).to_str().unwrap() [INFO] [stderr] | ^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[deny(clippy::not_unsafe_ptr_arg_deref)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#not_unsafe_ptr_arg_deref [INFO] [stderr] [INFO] [stderr] error: this public function dereferences a raw pointer but is not marked `unsafe` [INFO] [stderr] --> src/lib.rs:63:20 [INFO] [stderr] | [INFO] [stderr] 63 | CStr::from_ptr(c_ext).to_str().unwrap() [INFO] [stderr] | ^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#not_unsafe_ptr_arg_deref [INFO] [stderr] [INFO] [stderr] error: this public function dereferences a raw pointer but is not marked `unsafe` [INFO] [stderr] --> src/lib.rs:75:23 [INFO] [stderr] | [INFO] [stderr] 75 | CString::from_raw(s) [INFO] [stderr] | ^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#not_unsafe_ptr_arg_deref [INFO] [stderr] [INFO] [stderr] error: this public function dereferences a raw pointer but is not marked `unsafe` [INFO] [stderr] --> src/lib.rs:84:37 [INFO] [stderr] | [INFO] [stderr] 84 | let pth = unsafe { CStr::from_ptr(c_pth) }.to_str().unwrap(); [INFO] [stderr] | ^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#not_unsafe_ptr_arg_deref [INFO] [stderr] [INFO] [stderr] error: this public function dereferences a raw pointer but is not marked `unsafe` [INFO] [stderr] --> src/lib.rs:85:37 [INFO] [stderr] | [INFO] [stderr] 85 | let ext = unsafe { CStr::from_ptr(c_ext) }.to_str().unwrap(); [INFO] [stderr] | ^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#not_unsafe_ptr_arg_deref [INFO] [stderr] [INFO] [stderr] warning: use of `unwrap_or` followed by a function call [INFO] [stderr] --> src/lib.rs:100:18 [INFO] [stderr] | [INFO] [stderr] 100 | pth.ok().unwrap_or(RString::new("")).to_str(), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `unwrap_or_else(|| RString::new(""))` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::or_fun_call)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] warning: use of `unwrap_or` followed by a function call [INFO] [stderr] --> src/lib.rs:101:18 [INFO] [stderr] | [INFO] [stderr] 101 | ext.ok().unwrap_or(RString::new("")).to_str() [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `unwrap_or_else(|| RString::new(""))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] error: aborting due to 5 previous errors [INFO] [stderr] [INFO] [stderr] error: Could not compile `ffi_example`. [INFO] [stderr] [INFO] [stderr] To learn more, run the command again with --verbose. [INFO] running `"docker" "inspect" "30bb6169908e8b09d6ae0af359cc79f79215f873d59f921aea54d5f19990a7f8"` [INFO] running `"docker" "rm" "-f" "30bb6169908e8b09d6ae0af359cc79f79215f873d59f921aea54d5f19990a7f8"` [INFO] [stdout] 30bb6169908e8b09d6ae0af359cc79f79215f873d59f921aea54d5f19990a7f8