[INFO] updating cached repository danieldk/conllx-utils [INFO] running `"git" "fetch" "--all"` [INFO] [stdout] Fetching origin [INFO] [stderr] From git://github.com/danieldk/conllx-utils [INFO] [stderr] * branch HEAD -> FETCH_HEAD [INFO] running `"git" "clone" "work/cache/sources/gh/danieldk/conllx-utils" "work/ex/clippy-test-run/sources/stable/gh/danieldk/conllx-utils"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/danieldk/conllx-utils'... [INFO] [stderr] done. [INFO] running `"git" "clone" "work/cache/sources/gh/danieldk/conllx-utils" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/danieldk/conllx-utils"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/danieldk/conllx-utils'... [INFO] [stderr] done. [INFO] running `"git" "rev-parse" "HEAD"` [INFO] [stdout] 0e7e027228bf2f9465e5a4041c9853af735cc16d [INFO] sha for GitHub repo danieldk/conllx-utils: 0e7e027228bf2f9465e5a4041c9853af735cc16d [INFO] validating manifest of danieldk/conllx-utils on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of danieldk/conllx-utils on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing danieldk/conllx-utils [INFO] finished frobbing danieldk/conllx-utils [INFO] frobbed toml for danieldk/conllx-utils written to work/ex/clippy-test-run/sources/stable/gh/danieldk/conllx-utils/Cargo.toml [INFO] started frobbing danieldk/conllx-utils [INFO] finished frobbing danieldk/conllx-utils [INFO] frobbed toml for danieldk/conllx-utils written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/danieldk/conllx-utils/Cargo.toml [INFO] crate danieldk/conllx-utils has a lockfile. skipping [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting danieldk/conllx-utils against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-0/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/gh/danieldk/conllx-utils:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 052d7e2de8ec74161693183bea2334a5283669520dedadd1892dd019be92446e [INFO] running `"docker" "start" "-a" "052d7e2de8ec74161693183bea2334a5283669520dedadd1892dd019be92446e"` [INFO] [stderr] Checking maplit v0.1.6 [INFO] [stderr] Checking stdinout v0.4.0 [INFO] [stderr] Checking itertools v0.6.5 [INFO] [stderr] Checking pretty_assertions v0.3.4 [INFO] [stderr] Checking reservoir v0.2.0 [INFO] [stderr] Checking flate2 v0.2.20 [INFO] [stderr] Compiling synstructure v0.10.1 [INFO] [stderr] Compiling failure_derive v0.1.3 [INFO] [stderr] Checking failure v0.1.3 [INFO] [stderr] Checking conllx v0.10.2 [INFO] [stderr] Checking conllx-utils v0.4.2 (/opt/crater/workdir) [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/graph.rs:22:17 [INFO] [stderr] | [INFO] [stderr] 22 | token: token, [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `token` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/graph.rs:23:17 [INFO] [stderr] | [INFO] [stderr] 23 | offset: offset, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `offset` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/graph.rs:22:17 [INFO] [stderr] | [INFO] [stderr] 22 | token: token, [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `token` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/graph.rs:23:17 [INFO] [stderr] | [INFO] [stderr] 23 | offset: offset, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `offset` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/tdz_morph.rs:30:29 [INFO] [stderr] | [INFO] [stderr] 30 | const UNDERSPECIFIED_LONG: &'static str = "underspecified"; [INFO] [stderr] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::const_static_lifetime)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: Constants have by default a `'static` lifetime [INFO] [stderr] --> src/tdz_morph.rs:30:29 [INFO] [stderr] | [INFO] [stderr] 30 | const UNDERSPECIFIED_LONG: &'static str = "underspecified"; [INFO] [stderr] | -^^^^^^^---- help: consider removing `'static`: `&str` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::const_static_lifetime)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#const_static_lifetime [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/graph.rs:14:36 [INFO] [stderr] | [INFO] [stderr] 14 | pub fn sentence_to_graph(sentence: &Sentence, projective: bool) -> DependencyGraph { [INFO] [stderr] | ^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::ptr_arg)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/pp_reattach.rs:60:33 [INFO] [stderr] | [INFO] [stderr] 60 | fn find_reattachments(sentence: &Sentence) -> Vec<(usize, usize)> { [INFO] [stderr] | ^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/graph.rs:14:36 [INFO] [stderr] | [INFO] [stderr] 14 | pub fn sentence_to_graph(sentence: &Sentence, projective: bool) -> DependencyGraph { [INFO] [stderr] | ^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::ptr_arg)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/pp_reattach.rs:60:33 [INFO] [stderr] | [INFO] [stderr] 60 | fn find_reattachments(sentence: &Sentence) -> Vec<(usize, usize)> { [INFO] [stderr] | ^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: unused `std::result::Result` that must be used [INFO] [stderr] --> src/bin/conllx-triples.rs:64:13 [INFO] [stderr] | [INFO] [stderr] 64 | / writeln!( [INFO] [stderr] 65 | | writer, [INFO] [stderr] 66 | | "{}\t{}\t{}\t{}\t{}", [INFO] [stderr] 67 | | head, [INFO] [stderr] ... | [INFO] [stderr] 71 | | dep.form() [INFO] [stderr] 72 | | ); [INFO] [stderr] | |______________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_must_use)] on by default [INFO] [stderr] = note: this `Result` may be an `Err` variant, which should be handled [INFO] [stderr] = note: this error originates in a macro outside of the current crate (in Nightly builds, run with -Z external-macro-backtrace for more info) [INFO] [stderr] [INFO] [stderr] warning: use of `unwrap_or` followed by a function call [INFO] [stderr] --> src/bin/conllx-text.rs:71:59 [INFO] [stderr] | [INFO] [stderr] 71 | .map(|t| callback(t).map(Cow::into_owned).unwrap_or("_".to_owned())) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `unwrap_or_else(|| "_".to_owned())` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::or_fun_call)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/bin/conllx-merge.rs:45:61 [INFO] [stderr] | [INFO] [stderr] 45 | fn copy_sents(writer: &mut conllx::Writer, filenames: &Vec) [INFO] [stderr] | ^^^^^^^^^^^^ help: change this to: `&[String]` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::ptr_arg)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: redundant closure found [INFO] [stderr] --> src/bin/conllx-sample.rs:66:32 [INFO] [stderr] | [INFO] [stderr] 66 | reader.sentences().map(|s| or_exit(s)), [INFO] [stderr] | ^^^^^^^^^^^^^^ help: remove closure as shown: `or_exit` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_closure)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/bin/conllx-merge.rs:45:61 [INFO] [stderr] | [INFO] [stderr] 45 | fn copy_sents(writer: &mut conllx::Writer, filenames: &Vec) [INFO] [stderr] | ^^^^^^^^^^^^ help: change this to: `&[String]` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::ptr_arg)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/bin/conllx-grep.rs:64:8 [INFO] [stderr] | [INFO] [stderr] 64 | if matches.free.len() == 0 || matches.free.len() > 3 { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `matches.free.is_empty()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::len_zero)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: use of `unwrap_or` followed by a call to `new` [INFO] [stderr] --> src/bin/conllx-grep.rs:85:36 [INFO] [stderr] | [INFO] [stderr] 85 | let mut features = sentence[idx] [INFO] [stderr] | ____________________________________^ [INFO] [stderr] 86 | | .features() [INFO] [stderr] 87 | | .map(|f| f.as_map().clone()) [INFO] [stderr] 88 | | .unwrap_or(BTreeMap::new()); [INFO] [stderr] | |_______________________________________________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::or_fun_call)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 85 | let mut features = sentence[idx] [INFO] [stderr] 86 | .features() [INFO] [stderr] 87 | .map(|f| f.as_map().clone()).unwrap_or_default(); [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/bin/conllx-grep.rs:98:66 [INFO] [stderr] | [INFO] [stderr] 98 | fn match_indexes(re: &Regex, callback: &LayerCallback, sentence: &Sentence) -> HashSet { [INFO] [stderr] | ^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::ptr_arg)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/bin/conllx-grep.rs:98:40 [INFO] [stderr] | [INFO] [stderr] 98 | fn match_indexes(re: &Regex, callback: &LayerCallback, sentence: &Sentence) -> HashSet { [INFO] [stderr] | ^^^^^^^^^^^^^^ help: consider passing by value instead: `LayerCallback` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::trivially_copy_pass_by_ref)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: redundant closure found [INFO] [stderr] --> src/bin/conllx-sample.rs:66:32 [INFO] [stderr] | [INFO] [stderr] 66 | reader.sentences().map(|s| or_exit(s)), [INFO] [stderr] | ^^^^^^^^^^^^^^ help: remove closure as shown: `or_exit` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_closure)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_closure [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/bin/conllx-grep.rs:64:8 [INFO] [stderr] | [INFO] [stderr] 64 | if matches.free.len() == 0 || matches.free.len() > 3 { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `matches.free.is_empty()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::len_zero)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: use of `unwrap_or` followed by a call to `new` [INFO] [stderr] --> src/bin/conllx-grep.rs:85:36 [INFO] [stderr] | [INFO] [stderr] 85 | let mut features = sentence[idx] [INFO] [stderr] | ____________________________________^ [INFO] [stderr] 86 | | .features() [INFO] [stderr] 87 | | .map(|f| f.as_map().clone()) [INFO] [stderr] 88 | | .unwrap_or(BTreeMap::new()); [INFO] [stderr] | |_______________________________________________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::or_fun_call)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 85 | let mut features = sentence[idx] [INFO] [stderr] 86 | .features() [INFO] [stderr] 87 | .map(|f| f.as_map().clone()).unwrap_or_default(); [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/bin/conllx-grep.rs:98:66 [INFO] [stderr] | [INFO] [stderr] 98 | fn match_indexes(re: &Regex, callback: &LayerCallback, sentence: &Sentence) -> HashSet { [INFO] [stderr] | ^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::ptr_arg)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/bin/conllx-grep.rs:98:40 [INFO] [stderr] | [INFO] [stderr] 98 | fn match_indexes(re: &Regex, callback: &LayerCallback, sentence: &Sentence) -> HashSet { [INFO] [stderr] | ^^^^^^^^^^^^^^ help: consider passing by value instead: `LayerCallback` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::trivially_copy_pass_by_ref)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: unused `std::result::Result` that must be used [INFO] [stderr] --> src/bin/conllx-triples.rs:64:13 [INFO] [stderr] | [INFO] [stderr] 64 | / writeln!( [INFO] [stderr] 65 | | writer, [INFO] [stderr] 66 | | "{}\t{}\t{}\t{}\t{}", [INFO] [stderr] 67 | | head, [INFO] [stderr] ... | [INFO] [stderr] 71 | | dep.form() [INFO] [stderr] 72 | | ); [INFO] [stderr] | |______________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_must_use)] on by default [INFO] [stderr] = note: this `Result` may be an `Err` variant, which should be handled [INFO] [stderr] = note: this error originates in a macro outside of the current crate (in Nightly builds, run with -Z external-macro-backtrace for more info) [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/bin/conllx-cycle.rs:51:27 [INFO] [stderr] | [INFO] [stderr] 51 | fn check_cycles(sentence: &Sentence, projective: bool) { [INFO] [stderr] | ^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::ptr_arg)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/bin/conllx-cycle.rs:51:27 [INFO] [stderr] | [INFO] [stderr] 51 | fn check_cycles(sentence: &Sentence, projective: bool) { [INFO] [stderr] | ^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::ptr_arg)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: use of `unwrap_or` followed by a function call [INFO] [stderr] --> src/bin/conllx-text.rs:71:59 [INFO] [stderr] | [INFO] [stderr] 71 | .map(|t| callback(t).map(Cow::into_owned).unwrap_or("_".to_owned())) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `unwrap_or_else(|| "_".to_owned())` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::or_fun_call)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 24.85s [INFO] running `"docker" "inspect" "052d7e2de8ec74161693183bea2334a5283669520dedadd1892dd019be92446e"` [INFO] running `"docker" "rm" "-f" "052d7e2de8ec74161693183bea2334a5283669520dedadd1892dd019be92446e"` [INFO] [stdout] 052d7e2de8ec74161693183bea2334a5283669520dedadd1892dd019be92446e