[INFO] updating cached repository danielcannell/advent-of-code-2018 [INFO] running `"git" "fetch" "--all"` [INFO] [stdout] Fetching origin [INFO] [stderr] From git://github.com/danielcannell/advent-of-code-2018 [INFO] [stderr] * branch HEAD -> FETCH_HEAD [INFO] running `"git" "clone" "work/cache/sources/gh/danielcannell/advent-of-code-2018" "work/ex/clippy-test-run/sources/stable/gh/danielcannell/advent-of-code-2018"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/danielcannell/advent-of-code-2018'... [INFO] [stderr] done. [INFO] running `"git" "clone" "work/cache/sources/gh/danielcannell/advent-of-code-2018" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/danielcannell/advent-of-code-2018"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/danielcannell/advent-of-code-2018'... [INFO] [stderr] done. [INFO] running `"git" "rev-parse" "HEAD"` [INFO] [stdout] 6da417334b04aea1dd1f412c570a4d59b258b273 [INFO] sha for GitHub repo danielcannell/advent-of-code-2018: 6da417334b04aea1dd1f412c570a4d59b258b273 [INFO] validating manifest of danielcannell/advent-of-code-2018 on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of danielcannell/advent-of-code-2018 on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing danielcannell/advent-of-code-2018 [INFO] finished frobbing danielcannell/advent-of-code-2018 [INFO] frobbed toml for danielcannell/advent-of-code-2018 written to work/ex/clippy-test-run/sources/stable/gh/danielcannell/advent-of-code-2018/Cargo.toml [INFO] started frobbing danielcannell/advent-of-code-2018 [INFO] finished frobbing danielcannell/advent-of-code-2018 [INFO] frobbed toml for danielcannell/advent-of-code-2018 written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/danielcannell/advent-of-code-2018/Cargo.toml [INFO] crate danielcannell/advent-of-code-2018 has a lockfile. skipping [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting danielcannell/advent-of-code-2018 against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-5/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/gh/danielcannell/advent-of-code-2018:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] d6001e10322d8b651d8e96cd8b79c1530ee4756ffef7ce4d09a9b24ca3f348c6 [INFO] running `"docker" "start" "-a" "d6001e10322d8b651d8e96cd8b79c1530ee4756ffef7ce4d09a9b24ca3f348c6"` [INFO] [stderr] Compiling libc v0.2.44 [INFO] [stderr] Checking memchr v2.1.1 [INFO] [stderr] Checking backtrace-sys v0.1.24 [INFO] [stderr] Checking time v0.1.40 [INFO] [stderr] Checking backtrace v0.3.9 [INFO] [stderr] Checking chrono v0.4.6 [INFO] [stderr] Checking failure v0.1.3 [INFO] [stderr] Checking aho-corasick v0.6.9 [INFO] [stderr] Checking regex v1.1.0 [INFO] [stderr] Checking docopt v1.0.2 [INFO] [stderr] Checking advent-of-code-2018 v0.1.0 (/opt/crater/workdir) [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/day9.rs:50:13 [INFO] [stderr] | [INFO] [stderr] 50 | setup: setup, [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `setup` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/day9.rs:50:13 [INFO] [stderr] | [INFO] [stderr] 50 | setup: setup, [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `setup` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/day7.rs:63:9 [INFO] [stderr] | [INFO] [stderr] 63 | / if let &mut Elf::Busy(c, t) = self { [INFO] [stderr] 64 | | if t == 1 { [INFO] [stderr] 65 | | *self = Elf::Idle; [INFO] [stderr] 66 | | return Some(c); [INFO] [stderr] ... | [INFO] [stderr] 69 | | } [INFO] [stderr] 70 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::match_ref_pats)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 63 | if let Elf::Busy(c, t) = *self { [INFO] [stderr] | ^^^^^^^^^^^^^^^ ^^^^^ [INFO] [stderr] [INFO] [stderr] warning: you don't need to add `&` to all patterns [INFO] [stderr] --> src/day7.rs:63:9 [INFO] [stderr] | [INFO] [stderr] 63 | / if let &mut Elf::Busy(c, t) = self { [INFO] [stderr] 64 | | if t == 1 { [INFO] [stderr] 65 | | *self = Elf::Idle; [INFO] [stderr] 66 | | return Some(c); [INFO] [stderr] ... | [INFO] [stderr] 69 | | } [INFO] [stderr] 70 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::match_ref_pats)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#match_ref_pats [INFO] [stderr] help: instead of prefixing all patterns with `&`, you can dereference the expression [INFO] [stderr] | [INFO] [stderr] 63 | if let Elf::Busy(c, t) = *self { [INFO] [stderr] | ^^^^^^^^^^^^^^^ ^^^^^ [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 15.64s [INFO] running `"docker" "inspect" "d6001e10322d8b651d8e96cd8b79c1530ee4756ffef7ce4d09a9b24ca3f348c6"` [INFO] running `"docker" "rm" "-f" "d6001e10322d8b651d8e96cd8b79c1530ee4756ffef7ce4d09a9b24ca3f348c6"` [INFO] [stdout] d6001e10322d8b651d8e96cd8b79c1530ee4756ffef7ce4d09a9b24ca3f348c6