[INFO] updating cached repository daniel-junior-dube/3d_renderer_rs [INFO] running `"git" "fetch" "--all"` [INFO] [stdout] Fetching origin [INFO] [stderr] From git://github.com/daniel-junior-dube/3d_renderer_rs [INFO] [stderr] * branch HEAD -> FETCH_HEAD [INFO] running `"git" "clone" "work/cache/sources/gh/daniel-junior-dube/3d_renderer_rs" "work/ex/clippy-test-run/sources/stable/gh/daniel-junior-dube/3d_renderer_rs"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/daniel-junior-dube/3d_renderer_rs'... [INFO] [stderr] done. [INFO] running `"git" "clone" "work/cache/sources/gh/daniel-junior-dube/3d_renderer_rs" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/daniel-junior-dube/3d_renderer_rs"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/daniel-junior-dube/3d_renderer_rs'... [INFO] [stderr] done. [INFO] running `"git" "rev-parse" "HEAD"` [INFO] [stdout] 22ec07fcca8478c0fe8e57e7f31fe4ef07ff70b4 [INFO] sha for GitHub repo daniel-junior-dube/3d_renderer_rs: 22ec07fcca8478c0fe8e57e7f31fe4ef07ff70b4 [INFO] validating manifest of daniel-junior-dube/3d_renderer_rs on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of daniel-junior-dube/3d_renderer_rs on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing daniel-junior-dube/3d_renderer_rs [INFO] finished frobbing daniel-junior-dube/3d_renderer_rs [INFO] frobbed toml for daniel-junior-dube/3d_renderer_rs written to work/ex/clippy-test-run/sources/stable/gh/daniel-junior-dube/3d_renderer_rs/Cargo.toml [INFO] started frobbing daniel-junior-dube/3d_renderer_rs [INFO] finished frobbing daniel-junior-dube/3d_renderer_rs [INFO] frobbed toml for daniel-junior-dube/3d_renderer_rs written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/daniel-junior-dube/3d_renderer_rs/Cargo.toml [INFO] crate daniel-junior-dube/3d_renderer_rs has a lockfile. skipping [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting daniel-junior-dube/3d_renderer_rs against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-3/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/gh/daniel-junior-dube/3d_renderer_rs:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 018ea8e987207480c040eb6eb9a002023a34f94b2573beb93b748d41ae538e93 [INFO] running `"docker" "start" "-a" "018ea8e987207480c040eb6eb9a002023a34f94b2573beb93b748d41ae538e93"` [INFO] [stderr] Checking tobj v0.1.6 [INFO] [stderr] Compiling glfw-sys v3.2.2 [INFO] [stderr] Checking num-complex v0.2.0 [INFO] [stderr] Compiling gfx_macros v0.2.1 [INFO] [stderr] Compiling syn v0.15.13 [INFO] [stderr] Checking num-bigint v0.2.0 [INFO] [stderr] Checking smithay-client-toolkit v0.3.0 [INFO] [stderr] Checking num-rational v0.2.1 [INFO] [stderr] Checking winit v0.17.2 [INFO] [stderr] Checking num v0.2.0 [INFO] [stderr] Compiling num-derive v0.2.3 [INFO] [stderr] Checking glfw v0.25.0 [INFO] [stderr] Checking glutin v0.18.0 [INFO] [stderr] Checking tiff v0.2.1 [INFO] [stderr] Checking gfx_window_glutin v0.26.0 [INFO] [stderr] Checking image v0.20.0 [INFO] [stderr] Checking renderer_3d v0.1.0 (/opt/crater/workdir) [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/scene/material.rs:68:13 [INFO] [stderr] | [INFO] [stderr] 68 | shininess: shininess, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: replace it with: `shininess` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/scene/material.rs:69:13 [INFO] [stderr] | [INFO] [stderr] 69 | dissolve: dissolve, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: replace it with: `dissolve` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/scene/material.rs:68:13 [INFO] [stderr] | [INFO] [stderr] 68 | shininess: shininess, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: replace it with: `shininess` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/scene/material.rs:69:13 [INFO] [stderr] | [INFO] [stderr] 69 | dissolve: dissolve, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: replace it with: `dissolve` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: unused import: `gfx::buffer::Role` [INFO] [stderr] --> src/main.rs:14:5 [INFO] [stderr] | [INFO] [stderr] 14 | use gfx::buffer::Role; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_imports)] on by default [INFO] [stderr] [INFO] [stderr] warning: unused import: `time::precise_time_s` [INFO] [stderr] --> src/main.rs:18:5 [INFO] [stderr] | [INFO] [stderr] 18 | use time::precise_time_s; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: unused imports: `Deg`, `Matrix4`, `vec3` [INFO] [stderr] --> src/scene/entity.rs:2:19 [INFO] [stderr] | [INFO] [stderr] 2 | use cgmath::{Rad, Deg, Matrix4, vec3, Vector3}; [INFO] [stderr] | ^^^ ^^^^^^^ ^^^^ [INFO] [stderr] [INFO] [stderr] warning: unused imports: `Point3`, `perspective` [INFO] [stderr] --> src/scene/light_source.rs:2:14 [INFO] [stderr] | [INFO] [stderr] 2 | use cgmath::{perspective, Deg, Matrix4, Point3, vec3, Rad, Vector3}; [INFO] [stderr] | ^^^^^^^^^^^ ^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: unused import: `gfx::shade::ToUniform` [INFO] [stderr] --> src/scene/light_source.rs:3:5 [INFO] [stderr] | [INFO] [stderr] 3 | use gfx::shade::ToUniform; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: unused import: `gfx::shade::core::UniformValue` [INFO] [stderr] --> src/scene/light_source.rs:4:5 [INFO] [stderr] | [INFO] [stderr] 4 | use gfx::shade::core::UniformValue; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: unused import: `common::*` [INFO] [stderr] --> src/scene/material.rs:2:5 [INFO] [stderr] | [INFO] [stderr] 2 | use common::*; [INFO] [stderr] | ^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: unused import: `std::path::Path` [INFO] [stderr] --> src/scene/object.rs:1:5 [INFO] [stderr] | [INFO] [stderr] 1 | use std::path::Path; [INFO] [stderr] | ^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: returning the result of a let binding from a block. Consider returning the expression directly. [INFO] [stderr] --> src/scene/object.rs:170:3 [INFO] [stderr] | [INFO] [stderr] 170 | normal [INFO] [stderr] | ^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::let_and_return)] on by default [INFO] [stderr] note: this expression can be directly returned [INFO] [stderr] --> src/scene/object.rs:169:16 [INFO] [stderr] | [INFO] [stderr] 169 | let normal = v1.cross(*v2).normalize(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_and_return [INFO] [stderr] [INFO] [stderr] warning: unused import: `self::entity::Entity3D` [INFO] [stderr] --> src/scene/mod.rs:18:5 [INFO] [stderr] | [INFO] [stderr] 18 | use self::entity::Entity3D; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: unused imports: `Deg`, `Matrix4`, `Rad`, `Vector3`, `vec3` [INFO] [stderr] --> src/common/mod.rs:3:14 [INFO] [stderr] | [INFO] [stderr] 3 | use cgmath::{Deg, Matrix4, vec3, Vector3, Rad}; [INFO] [stderr] | ^^^ ^^^^^^^ ^^^^ ^^^^^^^ ^^^ [INFO] [stderr] [INFO] [stderr] warning: unused import: `gfx::buffer::Role` [INFO] [stderr] --> src/main.rs:14:5 [INFO] [stderr] | [INFO] [stderr] 14 | use gfx::buffer::Role; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_imports)] on by default [INFO] [stderr] [INFO] [stderr] warning: unused import: `time::precise_time_s` [INFO] [stderr] --> src/main.rs:18:5 [INFO] [stderr] | [INFO] [stderr] 18 | use time::precise_time_s; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: unused imports: `Deg`, `Matrix4`, `vec3` [INFO] [stderr] --> src/scene/entity.rs:2:19 [INFO] [stderr] | [INFO] [stderr] 2 | use cgmath::{Rad, Deg, Matrix4, vec3, Vector3}; [INFO] [stderr] | ^^^ ^^^^^^^ ^^^^ [INFO] [stderr] [INFO] [stderr] warning: unused imports: `Point3`, `perspective` [INFO] [stderr] --> src/scene/light_source.rs:2:14 [INFO] [stderr] | [INFO] [stderr] 2 | use cgmath::{perspective, Deg, Matrix4, Point3, vec3, Rad, Vector3}; [INFO] [stderr] | ^^^^^^^^^^^ ^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: unused import: `gfx::shade::ToUniform` [INFO] [stderr] --> src/scene/light_source.rs:3:5 [INFO] [stderr] | [INFO] [stderr] 3 | use gfx::shade::ToUniform; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: unused import: `gfx::shade::core::UniformValue` [INFO] [stderr] --> src/scene/light_source.rs:4:5 [INFO] [stderr] | [INFO] [stderr] 4 | use gfx::shade::core::UniformValue; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: unused import: `common::*` [INFO] [stderr] --> src/scene/material.rs:2:5 [INFO] [stderr] | [INFO] [stderr] 2 | use common::*; [INFO] [stderr] | ^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: unused import: `std::path::Path` [INFO] [stderr] --> src/scene/object.rs:1:5 [INFO] [stderr] | [INFO] [stderr] 1 | use std::path::Path; [INFO] [stderr] | ^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: returning the result of a let binding from a block. Consider returning the expression directly. [INFO] [stderr] --> src/scene/object.rs:170:3 [INFO] [stderr] | [INFO] [stderr] 170 | normal [INFO] [stderr] | ^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::let_and_return)] on by default [INFO] [stderr] note: this expression can be directly returned [INFO] [stderr] --> src/scene/object.rs:169:16 [INFO] [stderr] | [INFO] [stderr] 169 | let normal = v1.cross(*v2).normalize(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_and_return [INFO] [stderr] [INFO] [stderr] warning: unused import: `self::entity::Entity3D` [INFO] [stderr] --> src/scene/mod.rs:18:5 [INFO] [stderr] | [INFO] [stderr] 18 | use self::entity::Entity3D; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: unused imports: `Deg`, `Matrix4`, `Rad`, `Vector3`, `vec3` [INFO] [stderr] --> src/common/mod.rs:3:14 [INFO] [stderr] | [INFO] [stderr] 3 | use cgmath::{Deg, Matrix4, vec3, Vector3, Rad}; [INFO] [stderr] | ^^^ ^^^^^^^ ^^^^ ^^^^^^^ ^^^ [INFO] [stderr] [INFO] [stderr] warning: method is never used: `vp_matrix` [INFO] [stderr] --> src/scene/camera.rs:33:2 [INFO] [stderr] | [INFO] [stderr] 33 | pub fn vp_matrix(&self) -> Matrix4 { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(dead_code)] on by default [INFO] [stderr] [INFO] [stderr] warning: method is never used: `model_matrix` [INFO] [stderr] --> src/scene/light_source.rs:45:2 [INFO] [stderr] | [INFO] [stderr] 45 | pub fn model_matrix(&self) -> Matrix4 { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: enum is never used: `IlluminationModel` [INFO] [stderr] --> src/scene/material.rs:22:1 [INFO] [stderr] | [INFO] [stderr] 22 | pub enum IlluminationModel { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: method is never used: `new_cube` [INFO] [stderr] --> src/scene/object.rs:97:2 [INFO] [stderr] | [INFO] [stderr] 97 | pub fn new_cube() -> Self { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: method is never used: `evaluate_vertex_normals` [INFO] [stderr] --> src/scene/object.rs:138:2 [INFO] [stderr] | [INFO] [stderr] 138 | fn evaluate_vertex_normals(vertices: &mut Vec<[f32; 3]>, indices: &Vec) -> Vec<[f32; 3]> { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: method is never used: `normal` [INFO] [stderr] --> src/scene/object.rs:168:2 [INFO] [stderr] | [INFO] [stderr] 168 | fn normal(v1: &Vector3, v2: &Vector3) -> Vector3 { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: method is never used: `new_default` [INFO] [stderr] --> src/common/mod.rs:46:5 [INFO] [stderr] | [INFO] [stderr] 46 | pub fn new_default(pos: [f32; 3]) -> Vertex { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: variant is never constructed: `Running` [INFO] [stderr] --> src/main.rs:39:2 [INFO] [stderr] | [INFO] [stderr] 39 | Running, [INFO] [stderr] | ^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: this function has too many arguments (12/7) [INFO] [stderr] --> src/scene/material.rs:62:5 [INFO] [stderr] | [INFO] [stderr] 62 | / pub fn new(name: String, ambient: [f32; 3], diffuse: [f32; 3], specular: [f32; 3], shininess: f32, dissolve: f32, optical_density: f32, ambient_texture: String, diffuse_texture: String, specular_texture: String, normal_texture: String, dissolve_texture: String) -> Self { [INFO] [stderr] 63 | | Material { [INFO] [stderr] 64 | | name, [INFO] [stderr] 65 | | ambient: [ambient[0], ambient[1], ambient[2], 1.0], [INFO] [stderr] ... | [INFO] [stderr] 77 | | } [INFO] [stderr] 78 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::too_many_arguments)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#too_many_arguments [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/scene/material.rs:97:48 [INFO] [stderr] | [INFO] [stderr] 97 | pub fn from_tobj_materials(tobj_materials: &Vec) -> Vec { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: change this to: `&[TObjMaterial]` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::ptr_arg)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/scene/object.rs:93:34 [INFO] [stderr] | [INFO] [stderr] 93 | pub fn from_tobj_models(models: &Vec) -> Vec { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: change this to: `&[tobj::Model]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/scene/object.rs:138:68 [INFO] [stderr] | [INFO] [stderr] 138 | fn evaluate_vertex_normals(vertices: &mut Vec<[f32; 3]>, indices: &Vec) -> Vec<[f32; 3]> { [INFO] [stderr] | ^^^^^^^^^ help: change this to: `&[u32]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: this .into_iter() call is equivalent to .iter_mut() and will not move the Vec [INFO] [stderr] --> src/scene/object.rs:140:48 [INFO] [stderr] | [INFO] [stderr] 140 | let mut normals:Vec> = vertices.into_iter().map(|_vertex| vec3(0.0, 0.0, 0.0)).collect(); [INFO] [stderr] | ^^^^^^^^^ help: call directly: `iter_mut` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::into_iter_on_ref)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#into_iter_on_ref [INFO] [stderr] [INFO] [stderr] warning: manual implementation of an assign operation [INFO] [stderr] --> src/scene/mod.rs:119:6 [INFO] [stderr] | [INFO] [stderr] 119 | *material_id = *material_id + self.materials.len(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `*material_id += self.materials.len()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::assign_op_pattern)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stderr] [INFO] [stderr] warning: method is never used: `vp_matrix` [INFO] [stderr] --> src/scene/camera.rs:33:2 [INFO] [stderr] | [INFO] [stderr] 33 | pub fn vp_matrix(&self) -> Matrix4 { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(dead_code)] on by default [INFO] [stderr] [INFO] [stderr] warning: method is never used: `model_matrix` [INFO] [stderr] --> src/scene/light_source.rs:45:2 [INFO] [stderr] | [INFO] [stderr] 45 | pub fn model_matrix(&self) -> Matrix4 { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: enum is never used: `IlluminationModel` [INFO] [stderr] --> src/scene/material.rs:22:1 [INFO] [stderr] | [INFO] [stderr] 22 | pub enum IlluminationModel { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: method is never used: `new_cube` [INFO] [stderr] --> src/scene/object.rs:97:2 [INFO] [stderr] | [INFO] [stderr] 97 | pub fn new_cube() -> Self { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: method is never used: `evaluate_vertex_normals` [INFO] [stderr] --> src/scene/object.rs:138:2 [INFO] [stderr] | [INFO] [stderr] 138 | fn evaluate_vertex_normals(vertices: &mut Vec<[f32; 3]>, indices: &Vec) -> Vec<[f32; 3]> { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: method is never used: `normal` [INFO] [stderr] --> src/scene/object.rs:168:2 [INFO] [stderr] | [INFO] [stderr] 168 | fn normal(v1: &Vector3, v2: &Vector3) -> Vector3 { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: method is never used: `new_default` [INFO] [stderr] --> src/common/mod.rs:46:5 [INFO] [stderr] | [INFO] [stderr] 46 | pub fn new_default(pos: [f32; 3]) -> Vertex { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: variant is never constructed: `Running` [INFO] [stderr] --> src/main.rs:39:2 [INFO] [stderr] | [INFO] [stderr] 39 | Running, [INFO] [stderr] | ^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: this function has too many arguments (12/7) [INFO] [stderr] --> src/scene/material.rs:62:5 [INFO] [stderr] | [INFO] [stderr] 62 | / pub fn new(name: String, ambient: [f32; 3], diffuse: [f32; 3], specular: [f32; 3], shininess: f32, dissolve: f32, optical_density: f32, ambient_texture: String, diffuse_texture: String, specular_texture: String, normal_texture: String, dissolve_texture: String) -> Self { [INFO] [stderr] 63 | | Material { [INFO] [stderr] 64 | | name, [INFO] [stderr] 65 | | ambient: [ambient[0], ambient[1], ambient[2], 1.0], [INFO] [stderr] ... | [INFO] [stderr] 77 | | } [INFO] [stderr] 78 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::too_many_arguments)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#too_many_arguments [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/scene/material.rs:97:48 [INFO] [stderr] | [INFO] [stderr] 97 | pub fn from_tobj_materials(tobj_materials: &Vec) -> Vec { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: change this to: `&[TObjMaterial]` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::ptr_arg)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/scene/object.rs:93:34 [INFO] [stderr] | [INFO] [stderr] 93 | pub fn from_tobj_models(models: &Vec) -> Vec { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: change this to: `&[tobj::Model]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/scene/object.rs:138:68 [INFO] [stderr] | [INFO] [stderr] 138 | fn evaluate_vertex_normals(vertices: &mut Vec<[f32; 3]>, indices: &Vec) -> Vec<[f32; 3]> { [INFO] [stderr] | ^^^^^^^^^ help: change this to: `&[u32]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: this .into_iter() call is equivalent to .iter_mut() and will not move the Vec [INFO] [stderr] --> src/scene/object.rs:140:48 [INFO] [stderr] | [INFO] [stderr] 140 | let mut normals:Vec> = vertices.into_iter().map(|_vertex| vec3(0.0, 0.0, 0.0)).collect(); [INFO] [stderr] | ^^^^^^^^^ help: call directly: `iter_mut` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::into_iter_on_ref)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#into_iter_on_ref [INFO] [stderr] [INFO] [stderr] warning: manual implementation of an assign operation [INFO] [stderr] --> src/scene/mod.rs:119:6 [INFO] [stderr] | [INFO] [stderr] 119 | *material_id = *material_id + self.materials.len(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: replace it with: `*material_id += self.materials.len()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::assign_op_pattern)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#assign_op_pattern [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 30.89s [INFO] running `"docker" "inspect" "018ea8e987207480c040eb6eb9a002023a34f94b2573beb93b748d41ae538e93"` [INFO] running `"docker" "rm" "-f" "018ea8e987207480c040eb6eb9a002023a34f94b2573beb93b748d41ae538e93"` [INFO] [stdout] 018ea8e987207480c040eb6eb9a002023a34f94b2573beb93b748d41ae538e93