[INFO] updating cached repository danellis/webarc [INFO] running `"git" "fetch" "--all"` [INFO] [stdout] Fetching origin [INFO] [stderr] From git://github.com/danellis/webarc [INFO] [stderr] * branch HEAD -> FETCH_HEAD [INFO] running `"git" "clone" "work/cache/sources/gh/danellis/webarc" "work/ex/clippy-test-run/sources/stable/gh/danellis/webarc"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/danellis/webarc'... [INFO] [stderr] done. [INFO] running `"git" "clone" "work/cache/sources/gh/danellis/webarc" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/danellis/webarc"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/danellis/webarc'... [INFO] [stderr] done. [INFO] running `"git" "rev-parse" "HEAD"` [INFO] [stdout] bd029ae5ecb66eeae1d3e6d4aaf5071d0bbb9d58 [INFO] sha for GitHub repo danellis/webarc: bd029ae5ecb66eeae1d3e6d4aaf5071d0bbb9d58 [INFO] validating manifest of danellis/webarc on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of danellis/webarc on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing danellis/webarc [INFO] finished frobbing danellis/webarc [INFO] frobbed toml for danellis/webarc written to work/ex/clippy-test-run/sources/stable/gh/danellis/webarc/Cargo.toml [INFO] started frobbing danellis/webarc [INFO] finished frobbing danellis/webarc [INFO] frobbed toml for danellis/webarc written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/danellis/webarc/Cargo.toml [INFO] crate danellis/webarc has a lockfile. skipping [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting danellis/webarc against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-2/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/gh/danellis/webarc:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 514f1323d6c9fc1f865203f99766c2580225c0749440fb0b095e014232cf39b8 [INFO] running `"docker" "start" "-a" "514f1323d6c9fc1f865203f99766c2580225c0749440fb0b095e014232cf39b8"` [INFO] [stderr] Checking webarc v0.1.0 (/opt/crater/workdir) [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/webarc/cpu.rs:15:20 [INFO] [stderr] | [INFO] [stderr] 15 | const N_BIT: u32 = 0x80000000; [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0x8000_0000` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::unreadable_literal)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/webarc/cpu.rs:16:20 [INFO] [stderr] | [INFO] [stderr] 16 | const Z_BIT: u32 = 0x40000000; [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0x4000_0000` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/webarc/cpu.rs:17:20 [INFO] [stderr] | [INFO] [stderr] 17 | const C_BIT: u32 = 0x20000000; [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0x2000_0000` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/webarc/cpu.rs:18:20 [INFO] [stderr] | [INFO] [stderr] 18 | const V_BIT: u32 = 0x10000000; [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0x1000_0000` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/webarc/registers.rs:75:34 [INFO] [stderr] | [INFO] [stderr] 75 | self.registers[15] & 0x03fffffc [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0x03ff_fffc` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/webarc/registers.rs:84:57 [INFO] [stderr] | [INFO] [stderr] 84 | self.registers[15] = (self.registers[15] & !0x03fffffc) | (value & 0x03fffffc); [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0x03ff_fffc` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/webarc/registers.rs:84:80 [INFO] [stderr] | [INFO] [stderr] 84 | self.registers[15] = (self.registers[15] & !0x03fffffc) | (value & 0x03fffffc); [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0x03ff_fffc` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/webarc/memory.rs:21:40 [INFO] [stderr] | [INFO] [stderr] 21 | let masked_address = address & 0x03fffffc; [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0x03ff_fffc` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/webarc/memory.rs:24:29 [INFO] [stderr] | [INFO] [stderr] 24 | if masked_address < 0x02000000 { [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0x0200_0000` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/webarc/memory.rs:33:36 [INFO] [stderr] | [INFO] [stderr] 33 | } else if masked_address < 0x03000000 { [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0x0300_0000` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/webarc/memory.rs:36:41 [INFO] [stderr] | [INFO] [stderr] 36 | self.ram[((masked_address - 0x02000000) / 4) as usize] [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0x0200_0000` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/webarc/memory.rs:37:36 [INFO] [stderr] | [INFO] [stderr] 37 | } else if masked_address < 0x03400000 { [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0x0340_0000` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/webarc/memory.rs:40:36 [INFO] [stderr] | [INFO] [stderr] 40 | } else if masked_address < 0x03800000 { [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0x0380_0000` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/webarc/memory.rs:47:41 [INFO] [stderr] | [INFO] [stderr] 47 | self.rom[((masked_address - 0x03800000) / 4) as usize] [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0x0380_0000` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/webarc/memory.rs:52:40 [INFO] [stderr] | [INFO] [stderr] 52 | let masked_address = address & 0x03fffffc; [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0x03ff_fffc` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/webarc/memory.rs:56:29 [INFO] [stderr] | [INFO] [stderr] 56 | if masked_address < 0x02000000 { [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0x0200_0000` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/webarc/memory.rs:58:36 [INFO] [stderr] | [INFO] [stderr] 58 | } else if masked_address < 0x03000000 { [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0x0300_0000` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/webarc/memory.rs:60:36 [INFO] [stderr] | [INFO] [stderr] 60 | } else if masked_address < 0x03400000 { [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0x0340_0000` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/webarc/memory.rs:63:36 [INFO] [stderr] | [INFO] [stderr] 63 | } else if masked_address < 0x03600000 { [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0x0360_0000` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/webarc/memory.rs:65:36 [INFO] [stderr] | [INFO] [stderr] 65 | } else if masked_address < 0x03800000 { [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0x0380_0000` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/webarc/memory.rs:76:31 [INFO] [stderr] | [INFO] [stderr] 76 | let field = address & 0x00000003; [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0x0000_0003` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/webarc/memory.rs:81:32 [INFO] [stderr] | [INFO] [stderr] 81 | let field = (address & 0x00000003) as u8; [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0x0000_0003` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: unused import: `std::ops::Shr` [INFO] [stderr] --> src/webarc/instructions.rs:2:5 [INFO] [stderr] | [INFO] [stderr] 2 | use std::ops::Shr; [INFO] [stderr] | ^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_imports)] on by default [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/webarc/instructions.rs:23:5 [INFO] [stderr] | [INFO] [stderr] 23 | return formatter(address, cond_string, instruction); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `formatter(address, cond_string, instruction)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_return)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/webarc/instructions.rs:31:22 [INFO] [stderr] | [INFO] [stderr] 31 | if instruction & 0x01000000 != 0 { [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0x0100_0000` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/webarc/instructions.rs:35:33 [INFO] [stderr] | [INFO] [stderr] 35 | let offset = (instruction & 0x00ffffff).shl(2); [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0x00ff_ffff` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/webarc/instructions.rs:37:52 [INFO] [stderr] | [INFO] [stderr] 37 | registers.set_reg_no_flags(15, (pc + offset) & 0x03ffffffu32); [INFO] [stderr] | ^^^^^^^^^^^^^ help: consider: `0x03ff_ffffu32` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/webarc/instructions.rs:42:41 [INFO] [stderr] | [INFO] [stderr] 42 | let offset = u32::shl(instruction & 0x00ffffff, 2); [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0x00ff_ffff` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/webarc/instructions.rs:43:44 [INFO] [stderr] | [INFO] [stderr] 43 | let dest = (address + offset + 8u32) & 0x03ffffffu32; [INFO] [stderr] | ^^^^^^^^^^^^^ help: consider: `0x03ff_ffffu32` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/webarc/instructions.rs:45:22 [INFO] [stderr] | [INFO] [stderr] 45 | if instruction & 0x01000000 != 0 { [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0x0100_0000` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: this `else { if .. }` block can be collapsed [INFO] [stderr] --> src/webarc/instructions.rs:214:12 [INFO] [stderr] | [INFO] [stderr] 214 | } else { [INFO] [stderr] | ____________^ [INFO] [stderr] 215 | | if is_load { [INFO] [stderr] 216 | | registers.set_reg_no_flags(sd_reg, memory.load(address)); [INFO] [stderr] 217 | | } else { [INFO] [stderr] 218 | | memory.store(address, registers.reg(sd_reg)); [INFO] [stderr] 219 | | } [INFO] [stderr] 220 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::collapsible_if)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stderr] help: try [INFO] [stderr] | [INFO] [stderr] 214 | } else if is_load { [INFO] [stderr] 215 | registers.set_reg_no_flags(sd_reg, memory.load(address)); [INFO] [stderr] 216 | } else { [INFO] [stderr] 217 | memory.store(address, registers.reg(sd_reg)); [INFO] [stderr] 218 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: this `else { if .. }` block can be collapsed [INFO] [stderr] --> src/webarc/instructions.rs:267:16 [INFO] [stderr] | [INFO] [stderr] 267 | } else { [INFO] [stderr] | ________________^ [INFO] [stderr] 268 | | if offset == 0 { [INFO] [stderr] 269 | | format!("[R{}]", base_reg) [INFO] [stderr] 270 | | } else { [INFO] [stderr] 271 | | format!("[R{}], {}{}", base_reg, minus, offset) [INFO] [stderr] 272 | | } [INFO] [stderr] 273 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stderr] help: try [INFO] [stderr] | [INFO] [stderr] 267 | } else if offset == 0 { [INFO] [stderr] 268 | format!("[R{}]", base_reg) [INFO] [stderr] 269 | } else { [INFO] [stderr] 270 | format!("[R{}], {}{}", base_reg, minus, offset) [INFO] [stderr] 271 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/webarc/cpu.rs:15:20 [INFO] [stderr] | [INFO] [stderr] 15 | const N_BIT: u32 = 0x80000000; [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0x8000_0000` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::unreadable_literal)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/webarc/cpu.rs:16:20 [INFO] [stderr] | [INFO] [stderr] 16 | const Z_BIT: u32 = 0x40000000; [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0x4000_0000` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/webarc/cpu.rs:17:20 [INFO] [stderr] | [INFO] [stderr] 17 | const C_BIT: u32 = 0x20000000; [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0x2000_0000` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/webarc/cpu.rs:18:20 [INFO] [stderr] | [INFO] [stderr] 18 | const V_BIT: u32 = 0x10000000; [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0x1000_0000` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/webarc/registers.rs:75:34 [INFO] [stderr] | [INFO] [stderr] 75 | self.registers[15] & 0x03fffffc [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0x03ff_fffc` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/webarc/registers.rs:84:57 [INFO] [stderr] | [INFO] [stderr] 84 | self.registers[15] = (self.registers[15] & !0x03fffffc) | (value & 0x03fffffc); [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0x03ff_fffc` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/webarc/registers.rs:84:80 [INFO] [stderr] | [INFO] [stderr] 84 | self.registers[15] = (self.registers[15] & !0x03fffffc) | (value & 0x03fffffc); [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0x03ff_fffc` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/webarc/memory.rs:21:40 [INFO] [stderr] | [INFO] [stderr] 21 | let masked_address = address & 0x03fffffc; [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0x03ff_fffc` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/webarc/memory.rs:24:29 [INFO] [stderr] | [INFO] [stderr] 24 | if masked_address < 0x02000000 { [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0x0200_0000` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/webarc/memory.rs:33:36 [INFO] [stderr] | [INFO] [stderr] 33 | } else if masked_address < 0x03000000 { [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0x0300_0000` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/webarc/memory.rs:36:41 [INFO] [stderr] | [INFO] [stderr] 36 | self.ram[((masked_address - 0x02000000) / 4) as usize] [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0x0200_0000` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/webarc/memory.rs:37:36 [INFO] [stderr] | [INFO] [stderr] 37 | } else if masked_address < 0x03400000 { [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0x0340_0000` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/webarc/memory.rs:40:36 [INFO] [stderr] | [INFO] [stderr] 40 | } else if masked_address < 0x03800000 { [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0x0380_0000` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/webarc/memory.rs:47:41 [INFO] [stderr] | [INFO] [stderr] 47 | self.rom[((masked_address - 0x03800000) / 4) as usize] [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0x0380_0000` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/webarc/memory.rs:52:40 [INFO] [stderr] | [INFO] [stderr] 52 | let masked_address = address & 0x03fffffc; [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0x03ff_fffc` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/webarc/memory.rs:56:29 [INFO] [stderr] | [INFO] [stderr] 56 | if masked_address < 0x02000000 { [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0x0200_0000` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/webarc/memory.rs:58:36 [INFO] [stderr] | [INFO] [stderr] 58 | } else if masked_address < 0x03000000 { [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0x0300_0000` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/webarc/memory.rs:60:36 [INFO] [stderr] | [INFO] [stderr] 60 | } else if masked_address < 0x03400000 { [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0x0340_0000` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/webarc/memory.rs:63:36 [INFO] [stderr] | [INFO] [stderr] 63 | } else if masked_address < 0x03600000 { [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0x0360_0000` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/webarc/memory.rs:65:36 [INFO] [stderr] | [INFO] [stderr] 65 | } else if masked_address < 0x03800000 { [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0x0380_0000` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/webarc/memory.rs:76:31 [INFO] [stderr] | [INFO] [stderr] 76 | let field = address & 0x00000003; [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0x0000_0003` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/webarc/memory.rs:81:32 [INFO] [stderr] | [INFO] [stderr] 81 | let field = (address & 0x00000003) as u8; [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0x0000_0003` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: unused import: `std::ops::Shr` [INFO] [stderr] --> src/webarc/instructions.rs:2:5 [INFO] [stderr] | [INFO] [stderr] 2 | use std::ops::Shr; [INFO] [stderr] | ^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_imports)] on by default [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/webarc/instructions.rs:23:5 [INFO] [stderr] | [INFO] [stderr] 23 | return formatter(address, cond_string, instruction); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `formatter(address, cond_string, instruction)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_return)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/webarc/instructions.rs:31:22 [INFO] [stderr] | [INFO] [stderr] 31 | if instruction & 0x01000000 != 0 { [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0x0100_0000` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/webarc/instructions.rs:35:33 [INFO] [stderr] | [INFO] [stderr] 35 | let offset = (instruction & 0x00ffffff).shl(2); [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0x00ff_ffff` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/webarc/instructions.rs:37:52 [INFO] [stderr] | [INFO] [stderr] 37 | registers.set_reg_no_flags(15, (pc + offset) & 0x03ffffffu32); [INFO] [stderr] | ^^^^^^^^^^^^^ help: consider: `0x03ff_ffffu32` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/webarc/instructions.rs:42:41 [INFO] [stderr] | [INFO] [stderr] 42 | let offset = u32::shl(instruction & 0x00ffffff, 2); [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0x00ff_ffff` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/webarc/instructions.rs:43:44 [INFO] [stderr] | [INFO] [stderr] 43 | let dest = (address + offset + 8u32) & 0x03ffffffu32; [INFO] [stderr] | ^^^^^^^^^^^^^ help: consider: `0x03ff_ffffu32` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/webarc/instructions.rs:45:22 [INFO] [stderr] | [INFO] [stderr] 45 | if instruction & 0x01000000 != 0 { [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0x0100_0000` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: this `else { if .. }` block can be collapsed [INFO] [stderr] --> src/webarc/instructions.rs:214:12 [INFO] [stderr] | [INFO] [stderr] 214 | } else { [INFO] [stderr] | ____________^ [INFO] [stderr] 215 | | if is_load { [INFO] [stderr] 216 | | registers.set_reg_no_flags(sd_reg, memory.load(address)); [INFO] [stderr] 217 | | } else { [INFO] [stderr] 218 | | memory.store(address, registers.reg(sd_reg)); [INFO] [stderr] 219 | | } [INFO] [stderr] 220 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::collapsible_if)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stderr] help: try [INFO] [stderr] | [INFO] [stderr] 214 | } else if is_load { [INFO] [stderr] 215 | registers.set_reg_no_flags(sd_reg, memory.load(address)); [INFO] [stderr] 216 | } else { [INFO] [stderr] 217 | memory.store(address, registers.reg(sd_reg)); [INFO] [stderr] 218 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: this `else { if .. }` block can be collapsed [INFO] [stderr] --> src/webarc/instructions.rs:267:16 [INFO] [stderr] | [INFO] [stderr] 267 | } else { [INFO] [stderr] | ________________^ [INFO] [stderr] 268 | | if offset == 0 { [INFO] [stderr] 269 | | format!("[R{}]", base_reg) [INFO] [stderr] 270 | | } else { [INFO] [stderr] 271 | | format!("[R{}], {}{}", base_reg, minus, offset) [INFO] [stderr] 272 | | } [INFO] [stderr] 273 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stderr] help: try [INFO] [stderr] | [INFO] [stderr] 267 | } else if offset == 0 { [INFO] [stderr] 268 | format!("[R{}]", base_reg) [INFO] [stderr] 269 | } else { [INFO] [stderr] 270 | format!("[R{}], {}{}", base_reg, minus, offset) [INFO] [stderr] 271 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: unused variable: `memory` [INFO] [stderr] --> src/webarc/instructions.rs:28:46 [INFO] [stderr] | [INFO] [stderr] 28 | fn exec_branch(registers: &mut RegisterFile, memory: &mut Memory, instruction: u32) -> Action { [INFO] [stderr] | ^^^^^^ help: consider using `_memory` instead [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_variables)] on by default [INFO] [stderr] [INFO] [stderr] warning: unused variable: `address` [INFO] [stderr] --> src/webarc/instructions.rs:123:15 [INFO] [stderr] | [INFO] [stderr] 123 | fn format_alu(address: u32, cond: &str, instruction: u32) -> String { [INFO] [stderr] | ^^^^^^^ help: consider using `_address` instead [INFO] [stderr] [INFO] [stderr] warning: unused variable: `memory` [INFO] [stderr] --> src/webarc/instructions.rs:165:47 [INFO] [stderr] | [INFO] [stderr] 165 | fn exec_alu_add(registers: &mut RegisterFile, memory: &mut Memory, rd: u32, op1: u32, op2: u32) -> Action { [INFO] [stderr] | ^^^^^^ help: consider using `_memory` instead [INFO] [stderr] [INFO] [stderr] warning: unused variable: `rd` [INFO] [stderr] --> src/webarc/instructions.rs:170:78 [INFO] [stderr] | [INFO] [stderr] 170 | fn exec_alu_unimplemented(registers: &mut RegisterFile, memory: &mut Memory, rd: u32, op1: u32, op2: u32) -> Action { [INFO] [stderr] | ^^ help: consider using `_rd` instead [INFO] [stderr] [INFO] [stderr] warning: unused variable: `op1` [INFO] [stderr] --> src/webarc/instructions.rs:170:87 [INFO] [stderr] | [INFO] [stderr] 170 | fn exec_alu_unimplemented(registers: &mut RegisterFile, memory: &mut Memory, rd: u32, op1: u32, op2: u32) -> Action { [INFO] [stderr] | ^^^ help: consider using `_op1` instead [INFO] [stderr] [INFO] [stderr] warning: unused variable: `op2` [INFO] [stderr] --> src/webarc/instructions.rs:170:97 [INFO] [stderr] | [INFO] [stderr] 170 | fn exec_alu_unimplemented(registers: &mut RegisterFile, memory: &mut Memory, rd: u32, op1: u32, op2: u32) -> Action { [INFO] [stderr] | ^^^ help: consider using `_op2` instead [INFO] [stderr] [INFO] [stderr] warning: unused variable: `address` [INFO] [stderr] --> src/webarc/instructions.rs:229:19 [INFO] [stderr] | [INFO] [stderr] 229 | fn format_ldr_str(address: u32, cond: &str, instruction: u32) -> String { [INFO] [stderr] | ^^^^^^^ help: consider using `_address` instead [INFO] [stderr] [INFO] [stderr] warning: unused variable: `registers` [INFO] [stderr] --> src/webarc/instructions.rs:283:23 [INFO] [stderr] | [INFO] [stderr] 283 | fn exec_unimplemented(registers: &mut RegisterFile, memory: &mut Memory, instruction: u32) -> Action { [INFO] [stderr] | ^^^^^^^^^ help: consider using `_registers` instead [INFO] [stderr] [INFO] [stderr] warning: unused variable: `memory` [INFO] [stderr] --> src/webarc/instructions.rs:283:53 [INFO] [stderr] | [INFO] [stderr] 283 | fn exec_unimplemented(registers: &mut RegisterFile, memory: &mut Memory, instruction: u32) -> Action { [INFO] [stderr] | ^^^^^^ help: consider using `_memory` instead [INFO] [stderr] [INFO] [stderr] warning: unused variable: `instruction` [INFO] [stderr] --> src/webarc/instructions.rs:283:74 [INFO] [stderr] | [INFO] [stderr] 283 | fn exec_unimplemented(registers: &mut RegisterFile, memory: &mut Memory, instruction: u32) -> Action { [INFO] [stderr] | ^^^^^^^^^^^ help: consider using `_instruction` instead [INFO] [stderr] [INFO] [stderr] warning: unused variable: `address` [INFO] [stderr] --> src/webarc/instructions.rs:287:25 [INFO] [stderr] | [INFO] [stderr] 287 | fn format_unimplemented(address: u32, cond: &str, instruction: u32) -> String { [INFO] [stderr] | ^^^^^^^ help: consider using `_address` instead [INFO] [stderr] [INFO] [stderr] warning: unused variable: `instruction` [INFO] [stderr] --> src/webarc/instructions.rs:287:51 [INFO] [stderr] | [INFO] [stderr] 287 | fn format_unimplemented(address: u32, cond: &str, instruction: u32) -> String { [INFO] [stderr] | ^^^^^^^^^^^ help: consider using `_instruction` instead [INFO] [stderr] [INFO] [stderr] warning: constant item is never used: `UNDEFINED_INSTRUCTION_VECTOR` [INFO] [stderr] --> src/webarc/cpu.rs:7:1 [INFO] [stderr] | [INFO] [stderr] 7 | const UNDEFINED_INSTRUCTION_VECTOR: u32 = 0x04; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(dead_code)] on by default [INFO] [stderr] [INFO] [stderr] warning: constant item is never used: `SWI_VECTOR` [INFO] [stderr] --> src/webarc/cpu.rs:8:1 [INFO] [stderr] | [INFO] [stderr] 8 | const SWI_VECTOR: u32 = 0x08; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: constant item is never used: `PREFETCH_ABORT_VECTOR` [INFO] [stderr] --> src/webarc/cpu.rs:9:1 [INFO] [stderr] | [INFO] [stderr] 9 | const PREFETCH_ABORT_VECTOR: u32 = 0x0c; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: constant item is never used: `DATA_ABORT_VECTOR` [INFO] [stderr] --> src/webarc/cpu.rs:10:1 [INFO] [stderr] | [INFO] [stderr] 10 | const DATA_ABORT_VECTOR: u32 = 0x10; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: constant item is never used: `ADDRESS_EXCEPTION_VECTOR` [INFO] [stderr] --> src/webarc/cpu.rs:11:1 [INFO] [stderr] | [INFO] [stderr] 11 | const ADDRESS_EXCEPTION_VECTOR: u32 = 0x14; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: constant item is never used: `IRQ_VECTOR` [INFO] [stderr] --> src/webarc/cpu.rs:12:1 [INFO] [stderr] | [INFO] [stderr] 12 | const IRQ_VECTOR: u32 = 0x18; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: constant item is never used: `FIRQ_VECTOR` [INFO] [stderr] --> src/webarc/cpu.rs:13:1 [INFO] [stderr] | [INFO] [stderr] 13 | const FIRQ_VECTOR: u32 = 0x1c; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: the operation is ineffective. Consider reducing it to `1024` [INFO] [stderr] --> src/webarc/memory.rs:13:26 [INFO] [stderr] | [INFO] [stderr] 13 | ram: vec![0; 1 * 1024 * 1024].into_boxed_slice(), [INFO] [stderr] | ^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::identity_op)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_op [INFO] [stderr] [INFO] [stderr] warning: the operation is ineffective. Consider reducing it to `data` [INFO] [stderr] --> src/webarc/memory.rs:82:20 [INFO] [stderr] | [INFO] [stderr] 82 | let word = (data & 0xff).shl(field * 8); [INFO] [stderr] | ^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_op [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u32 may become silently lossy if types change [INFO] [stderr] --> src/webarc/memory.rs:83:29 [INFO] [stderr] | [INFO] [stderr] 83 | self.store(address, word as u32); [INFO] [stderr] | ^^^^^^^^^^^ help: try: `u32::from(word)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cast_lossless)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u32 may become silently lossy if types change [INFO] [stderr] --> src/webarc/instructions.rs:210:48 [INFO] [stderr] | [INFO] [stderr] 210 | registers.set_reg_no_flags(sd_reg, memory.load_byte(address) as u32); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u32::from(memory.load_byte(address))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: the operation is ineffective. Consider reducing it to `1024` [INFO] [stderr] --> src/main.rs:10:37 [INFO] [stderr] | [INFO] [stderr] 10 | let mut rom: Vec = vec![0; 1 * 1024 * 1024]; [INFO] [stderr] | ^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_op [INFO] [stderr] [INFO] [stderr] warning: unused `std::result::Result` that must be used [INFO] [stderr] --> src/main.rs:16:5 [INFO] [stderr] | [INFO] [stderr] 16 | f.read(as_u8_slice(&mut rom)); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_must_use)] on by default [INFO] [stderr] = note: this `Result` may be an `Err` variant, which should be handled [INFO] [stderr] [INFO] [stderr] warning: unused variable: `memory` [INFO] [stderr] --> src/webarc/instructions.rs:28:46 [INFO] [stderr] | [INFO] [stderr] 28 | fn exec_branch(registers: &mut RegisterFile, memory: &mut Memory, instruction: u32) -> Action { [INFO] [stderr] | ^^^^^^ help: consider using `_memory` instead [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_variables)] on by default [INFO] [stderr] [INFO] [stderr] warning: unused variable: `address` [INFO] [stderr] --> src/webarc/instructions.rs:123:15 [INFO] [stderr] | [INFO] [stderr] 123 | fn format_alu(address: u32, cond: &str, instruction: u32) -> String { [INFO] [stderr] | ^^^^^^^ help: consider using `_address` instead [INFO] [stderr] [INFO] [stderr] warning: unused variable: `memory` [INFO] [stderr] --> src/webarc/instructions.rs:165:47 [INFO] [stderr] | [INFO] [stderr] 165 | fn exec_alu_add(registers: &mut RegisterFile, memory: &mut Memory, rd: u32, op1: u32, op2: u32) -> Action { [INFO] [stderr] | ^^^^^^ help: consider using `_memory` instead [INFO] [stderr] [INFO] [stderr] warning: unused variable: `rd` [INFO] [stderr] --> src/webarc/instructions.rs:170:78 [INFO] [stderr] | [INFO] [stderr] 170 | fn exec_alu_unimplemented(registers: &mut RegisterFile, memory: &mut Memory, rd: u32, op1: u32, op2: u32) -> Action { [INFO] [stderr] | ^^ help: consider using `_rd` instead [INFO] [stderr] [INFO] [stderr] warning: unused variable: `op1` [INFO] [stderr] --> src/webarc/instructions.rs:170:87 [INFO] [stderr] | [INFO] [stderr] 170 | fn exec_alu_unimplemented(registers: &mut RegisterFile, memory: &mut Memory, rd: u32, op1: u32, op2: u32) -> Action { [INFO] [stderr] | ^^^ help: consider using `_op1` instead [INFO] [stderr] [INFO] [stderr] warning: unused variable: `op2` [INFO] [stderr] --> src/webarc/instructions.rs:170:97 [INFO] [stderr] | [INFO] [stderr] 170 | fn exec_alu_unimplemented(registers: &mut RegisterFile, memory: &mut Memory, rd: u32, op1: u32, op2: u32) -> Action { [INFO] [stderr] | ^^^ help: consider using `_op2` instead [INFO] [stderr] [INFO] [stderr] warning: unused variable: `address` [INFO] [stderr] --> src/webarc/instructions.rs:229:19 [INFO] [stderr] | [INFO] [stderr] 229 | fn format_ldr_str(address: u32, cond: &str, instruction: u32) -> String { [INFO] [stderr] | ^^^^^^^ help: consider using `_address` instead [INFO] [stderr] [INFO] [stderr] warning: unused variable: `registers` [INFO] [stderr] --> src/webarc/instructions.rs:283:23 [INFO] [stderr] | [INFO] [stderr] 283 | fn exec_unimplemented(registers: &mut RegisterFile, memory: &mut Memory, instruction: u32) -> Action { [INFO] [stderr] | ^^^^^^^^^ help: consider using `_registers` instead [INFO] [stderr] [INFO] [stderr] warning: unused variable: `memory` [INFO] [stderr] --> src/webarc/instructions.rs:283:53 [INFO] [stderr] | [INFO] [stderr] 283 | fn exec_unimplemented(registers: &mut RegisterFile, memory: &mut Memory, instruction: u32) -> Action { [INFO] [stderr] | ^^^^^^ help: consider using `_memory` instead [INFO] [stderr] [INFO] [stderr] warning: unused variable: `instruction` [INFO] [stderr] --> src/webarc/instructions.rs:283:74 [INFO] [stderr] | [INFO] [stderr] 283 | fn exec_unimplemented(registers: &mut RegisterFile, memory: &mut Memory, instruction: u32) -> Action { [INFO] [stderr] | ^^^^^^^^^^^ help: consider using `_instruction` instead [INFO] [stderr] [INFO] [stderr] warning: unused variable: `address` [INFO] [stderr] --> src/webarc/instructions.rs:287:25 [INFO] [stderr] | [INFO] [stderr] 287 | fn format_unimplemented(address: u32, cond: &str, instruction: u32) -> String { [INFO] [stderr] | ^^^^^^^ help: consider using `_address` instead [INFO] [stderr] [INFO] [stderr] warning: unused variable: `instruction` [INFO] [stderr] --> src/webarc/instructions.rs:287:51 [INFO] [stderr] | [INFO] [stderr] 287 | fn format_unimplemented(address: u32, cond: &str, instruction: u32) -> String { [INFO] [stderr] | ^^^^^^^^^^^ help: consider using `_instruction` instead [INFO] [stderr] [INFO] [stderr] warning: constant item is never used: `UNDEFINED_INSTRUCTION_VECTOR` [INFO] [stderr] --> src/webarc/cpu.rs:7:1 [INFO] [stderr] | [INFO] [stderr] 7 | const UNDEFINED_INSTRUCTION_VECTOR: u32 = 0x04; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(dead_code)] on by default [INFO] [stderr] [INFO] [stderr] warning: constant item is never used: `SWI_VECTOR` [INFO] [stderr] --> src/webarc/cpu.rs:8:1 [INFO] [stderr] | [INFO] [stderr] 8 | const SWI_VECTOR: u32 = 0x08; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: constant item is never used: `PREFETCH_ABORT_VECTOR` [INFO] [stderr] --> src/webarc/cpu.rs:9:1 [INFO] [stderr] | [INFO] [stderr] 9 | const PREFETCH_ABORT_VECTOR: u32 = 0x0c; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: constant item is never used: `DATA_ABORT_VECTOR` [INFO] [stderr] --> src/webarc/cpu.rs:10:1 [INFO] [stderr] | [INFO] [stderr] 10 | const DATA_ABORT_VECTOR: u32 = 0x10; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: constant item is never used: `ADDRESS_EXCEPTION_VECTOR` [INFO] [stderr] --> src/webarc/cpu.rs:11:1 [INFO] [stderr] | [INFO] [stderr] 11 | const ADDRESS_EXCEPTION_VECTOR: u32 = 0x14; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: constant item is never used: `IRQ_VECTOR` [INFO] [stderr] --> src/webarc/cpu.rs:12:1 [INFO] [stderr] | [INFO] [stderr] 12 | const IRQ_VECTOR: u32 = 0x18; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: constant item is never used: `FIRQ_VECTOR` [INFO] [stderr] --> src/webarc/cpu.rs:13:1 [INFO] [stderr] | [INFO] [stderr] 13 | const FIRQ_VECTOR: u32 = 0x1c; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: the operation is ineffective. Consider reducing it to `1024` [INFO] [stderr] --> src/webarc/memory.rs:13:26 [INFO] [stderr] | [INFO] [stderr] 13 | ram: vec![0; 1 * 1024 * 1024].into_boxed_slice(), [INFO] [stderr] | ^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::identity_op)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_op [INFO] [stderr] [INFO] [stderr] warning: the operation is ineffective. Consider reducing it to `data` [INFO] [stderr] --> src/webarc/memory.rs:82:20 [INFO] [stderr] | [INFO] [stderr] 82 | let word = (data & 0xff).shl(field * 8); [INFO] [stderr] | ^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_op [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u32 may become silently lossy if types change [INFO] [stderr] --> src/webarc/memory.rs:83:29 [INFO] [stderr] | [INFO] [stderr] 83 | self.store(address, word as u32); [INFO] [stderr] | ^^^^^^^^^^^ help: try: `u32::from(word)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cast_lossless)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting u8 to u32 may become silently lossy if types change [INFO] [stderr] --> src/webarc/instructions.rs:210:48 [INFO] [stderr] | [INFO] [stderr] 210 | registers.set_reg_no_flags(sd_reg, memory.load_byte(address) as u32); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `u32::from(memory.load_byte(address))` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: the operation is ineffective. Consider reducing it to `1024` [INFO] [stderr] --> src/main.rs:10:37 [INFO] [stderr] | [INFO] [stderr] 10 | let mut rom: Vec = vec![0; 1 * 1024 * 1024]; [INFO] [stderr] | ^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_op [INFO] [stderr] [INFO] [stderr] warning: unused `std::result::Result` that must be used [INFO] [stderr] --> src/main.rs:16:5 [INFO] [stderr] | [INFO] [stderr] 16 | f.read(as_u8_slice(&mut rom)); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_must_use)] on by default [INFO] [stderr] = note: this `Result` may be an `Err` variant, which should be handled [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 1.32s [INFO] running `"docker" "inspect" "514f1323d6c9fc1f865203f99766c2580225c0749440fb0b095e014232cf39b8"` [INFO] running `"docker" "rm" "-f" "514f1323d6c9fc1f865203f99766c2580225c0749440fb0b095e014232cf39b8"` [INFO] [stdout] 514f1323d6c9fc1f865203f99766c2580225c0749440fb0b095e014232cf39b8