[INFO] updating cached repository dandro/rust-playground [INFO] running `"git" "fetch" "--all"` [INFO] [stdout] Fetching origin [INFO] [stderr] From git://github.com/dandro/rust-playground [INFO] [stderr] * branch HEAD -> FETCH_HEAD [INFO] running `"git" "clone" "work/cache/sources/gh/dandro/rust-playground" "work/ex/clippy-test-run/sources/stable/gh/dandro/rust-playground"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/dandro/rust-playground'... [INFO] [stderr] done. [INFO] running `"git" "clone" "work/cache/sources/gh/dandro/rust-playground" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/dandro/rust-playground"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/dandro/rust-playground'... [INFO] [stderr] done. [INFO] running `"git" "rev-parse" "HEAD"` [INFO] [stdout] 7add5f89ada861e2b5efecc43861e03fd189d999 [INFO] sha for GitHub repo dandro/rust-playground: 7add5f89ada861e2b5efecc43861e03fd189d999 [INFO] validating manifest of dandro/rust-playground on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of dandro/rust-playground on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing dandro/rust-playground [INFO] finished frobbing dandro/rust-playground [INFO] frobbed toml for dandro/rust-playground written to work/ex/clippy-test-run/sources/stable/gh/dandro/rust-playground/Cargo.toml [INFO] started frobbing dandro/rust-playground [INFO] finished frobbing dandro/rust-playground [INFO] frobbed toml for dandro/rust-playground written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/dandro/rust-playground/Cargo.toml [INFO] crate dandro/rust-playground has a lockfile. skipping [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting dandro/rust-playground against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-5/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/gh/dandro/rust-playground:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 07d25de273315cbe15d243679aea00c141f1a8d239bf58bf707468d5cab54240 [INFO] running `"docker" "start" "-a" "07d25de273315cbe15d243679aea00c141f1a8d239bf58bf707468d5cab54240"` [INFO] [stderr] Checking playground v0.1.0 (/opt/crater/workdir) [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/main.rs:87:5 [INFO] [stderr] | [INFO] [stderr] 87 | return x; [INFO] [stderr] | ^^^^^^^^^ help: remove `return` as shown: `x` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_return)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/main.rs:141:28 [INFO] [stderr] | [INFO] [stderr] 141 | let large_float: f64 = 2.3234767234987234; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: consider: `2.323_476_723_498_723_4` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::unreadable_literal)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/main.rs:87:5 [INFO] [stderr] | [INFO] [stderr] 87 | return x; [INFO] [stderr] | ^^^^^^^^^ help: remove `return` as shown: `x` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_return)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/main.rs:141:28 [INFO] [stderr] | [INFO] [stderr] 141 | let large_float: f64 = 2.3234767234987234; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: consider: `2.323_476_723_498_723_4` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::unreadable_literal)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: useless use of `format!` [INFO] [stderr] --> src/main.rs:23:14 [INFO] [stderr] | [INFO] [stderr] 23 | add_line(format!("bindings are immutable by default")); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using .to_string(): `"bindings are immutable by default".to_string()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::useless_format)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format [INFO] [stderr] [INFO] [stderr] warning: useless use of `format!` [INFO] [stderr] --> src/main.rs:24:14 [INFO] [stderr] | [INFO] [stderr] 24 | add_line(format!("x = 10; :: This would throw an error")); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using .to_string(): `"x = 10; :: This would throw an error".to_string()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format [INFO] [stderr] [INFO] [stderr] warning: float has excessive precision [INFO] [stderr] --> src/main.rs:141:28 [INFO] [stderr] | [INFO] [stderr] 141 | let large_float: f64 = 2.3234767234987234; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: consider changing the type or truncating it to: `2.323_476_723_498_723_5` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::excessive_precision)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#excessive_precision [INFO] [stderr] [INFO] [stderr] warning: useless use of `format!` [INFO] [stderr] --> src/main.rs:187:14 [INFO] [stderr] | [INFO] [stderr] 187 | add_line(format!("{}", printing_fn())) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using .to_string(): `printing_fn().to_string()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format [INFO] [stderr] = note: this error originates in a macro outside of the current crate (in Nightly builds, run with -Z external-macro-backtrace for more info) [INFO] [stderr] [INFO] [stderr] warning: useless use of `format!` [INFO] [stderr] --> src/main.rs:217:18 [INFO] [stderr] | [INFO] [stderr] 217 | add_line(format!("x is 9")); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: consider using .to_string(): `"x is 9".to_string()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format [INFO] [stderr] [INFO] [stderr] warning: useless use of `format!` [INFO] [stderr] --> src/main.rs:219:18 [INFO] [stderr] | [INFO] [stderr] 219 | add_line(format!("x is 6")); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: consider using .to_string(): `"x is 6".to_string()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format [INFO] [stderr] [INFO] [stderr] warning: useless use of `format!` [INFO] [stderr] --> src/main.rs:221:18 [INFO] [stderr] | [INFO] [stderr] 221 | add_line(format!("x is not 9")); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^ help: consider using .to_string(): `"x is not 9".to_string()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format [INFO] [stderr] [INFO] [stderr] warning: useless use of `format!` [INFO] [stderr] --> src/main.rs:245:14 [INFO] [stderr] | [INFO] [stderr] 245 | add_line(format!("The keyword loop will create an infinite loop")); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using .to_string(): `"The keyword loop will create an infinite loop".to_string()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format [INFO] [stderr] [INFO] [stderr] warning: useless use of `format!` [INFO] [stderr] --> src/main.rs:282:14 [INFO] [stderr] | [INFO] [stderr] 282 | add_line(format!("Enumerating")); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: consider using .to_string(): `"Enumerating".to_string()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format [INFO] [stderr] [INFO] [stderr] warning: useless use of `format!` [INFO] [stderr] --> src/main.rs:290:14 [INFO] [stderr] | [INFO] [stderr] 290 | add_line(format!("You can end a loop with the break keyword")); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using .to_string(): `"You can end a loop with the break keyword".to_string()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format [INFO] [stderr] [INFO] [stderr] warning: unused label `'width` [INFO] [stderr] --> src/main.rs:316:9 [INFO] [stderr] | [INFO] [stderr] 316 | / 'width: for inner in 0..right_wall { [INFO] [stderr] 317 | | if out == 0 { [INFO] [stderr] 318 | | continue 'height; [INFO] [stderr] 319 | | } [INFO] [stderr] ... | [INFO] [stderr] 322 | | star = format!("{}{}", star, filler); [INFO] [stderr] 323 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::unused_label)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_label [INFO] [stderr] [INFO] [stderr] warning: useless use of `format!` [INFO] [stderr] --> src/main.rs:324:18 [INFO] [stderr] | [INFO] [stderr] 324 | add_line(format!("{}", star)); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ help: consider using .to_string(): `star.to_string()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format [INFO] [stderr] = note: this error originates in a macro outside of the current crate (in Nightly builds, run with -Z external-macro-backtrace for more info) [INFO] [stderr] [INFO] [stderr] warning: useless use of `format!` [INFO] [stderr] --> src/main.rs:23:14 [INFO] [stderr] | [INFO] [stderr] 23 | add_line(format!("bindings are immutable by default")); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using .to_string(): `"bindings are immutable by default".to_string()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::useless_format)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format [INFO] [stderr] [INFO] [stderr] warning: useless use of `format!` [INFO] [stderr] --> src/main.rs:24:14 [INFO] [stderr] | [INFO] [stderr] 24 | add_line(format!("x = 10; :: This would throw an error")); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using .to_string(): `"x = 10; :: This would throw an error".to_string()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format [INFO] [stderr] [INFO] [stderr] warning: float has excessive precision [INFO] [stderr] --> src/main.rs:141:28 [INFO] [stderr] | [INFO] [stderr] 141 | let large_float: f64 = 2.3234767234987234; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: consider changing the type or truncating it to: `2.323_476_723_498_723_5` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::excessive_precision)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#excessive_precision [INFO] [stderr] [INFO] [stderr] warning: useless use of `format!` [INFO] [stderr] --> src/main.rs:187:14 [INFO] [stderr] | [INFO] [stderr] 187 | add_line(format!("{}", printing_fn())) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using .to_string(): `printing_fn().to_string()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format [INFO] [stderr] = note: this error originates in a macro outside of the current crate (in Nightly builds, run with -Z external-macro-backtrace for more info) [INFO] [stderr] [INFO] [stderr] warning: useless use of `format!` [INFO] [stderr] --> src/main.rs:217:18 [INFO] [stderr] | [INFO] [stderr] 217 | add_line(format!("x is 9")); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: consider using .to_string(): `"x is 9".to_string()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format [INFO] [stderr] [INFO] [stderr] warning: useless use of `format!` [INFO] [stderr] --> src/main.rs:219:18 [INFO] [stderr] | [INFO] [stderr] 219 | add_line(format!("x is 6")); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: consider using .to_string(): `"x is 6".to_string()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format [INFO] [stderr] [INFO] [stderr] warning: useless use of `format!` [INFO] [stderr] --> src/main.rs:221:18 [INFO] [stderr] | [INFO] [stderr] 221 | add_line(format!("x is not 9")); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^ help: consider using .to_string(): `"x is not 9".to_string()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format [INFO] [stderr] [INFO] [stderr] warning: useless use of `format!` [INFO] [stderr] --> src/main.rs:245:14 [INFO] [stderr] | [INFO] [stderr] 245 | add_line(format!("The keyword loop will create an infinite loop")); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using .to_string(): `"The keyword loop will create an infinite loop".to_string()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format [INFO] [stderr] [INFO] [stderr] warning: useless use of `format!` [INFO] [stderr] --> src/main.rs:282:14 [INFO] [stderr] | [INFO] [stderr] 282 | add_line(format!("Enumerating")); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: consider using .to_string(): `"Enumerating".to_string()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format [INFO] [stderr] [INFO] [stderr] warning: useless use of `format!` [INFO] [stderr] --> src/main.rs:290:14 [INFO] [stderr] | [INFO] [stderr] 290 | add_line(format!("You can end a loop with the break keyword")); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using .to_string(): `"You can end a loop with the break keyword".to_string()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format [INFO] [stderr] [INFO] [stderr] warning: unused label `'width` [INFO] [stderr] --> src/main.rs:316:9 [INFO] [stderr] | [INFO] [stderr] 316 | / 'width: for inner in 0..right_wall { [INFO] [stderr] 317 | | if out == 0 { [INFO] [stderr] 318 | | continue 'height; [INFO] [stderr] 319 | | } [INFO] [stderr] ... | [INFO] [stderr] 322 | | star = format!("{}{}", star, filler); [INFO] [stderr] 323 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::unused_label)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_label [INFO] [stderr] [INFO] [stderr] warning: useless use of `format!` [INFO] [stderr] --> src/main.rs:324:18 [INFO] [stderr] | [INFO] [stderr] 324 | add_line(format!("{}", star)); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ help: consider using .to_string(): `star.to_string()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format [INFO] [stderr] = note: this error originates in a macro outside of the current crate (in Nightly builds, run with -Z external-macro-backtrace for more info) [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 1.11s [INFO] running `"docker" "inspect" "07d25de273315cbe15d243679aea00c141f1a8d239bf58bf707468d5cab54240"` [INFO] running `"docker" "rm" "-f" "07d25de273315cbe15d243679aea00c141f1a8d239bf58bf707468d5cab54240"` [INFO] [stdout] 07d25de273315cbe15d243679aea00c141f1a8d239bf58bf707468d5cab54240