[INFO] updating cached repository dan-f/blockchain [INFO] running `"git" "fetch" "--all"` [INFO] [stdout] Fetching origin [INFO] [stderr] From git://github.com/dan-f/blockchain [INFO] [stderr] * branch HEAD -> FETCH_HEAD [INFO] running `"git" "clone" "work/cache/sources/gh/dan-f/blockchain" "work/ex/clippy-test-run/sources/stable/gh/dan-f/blockchain"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/dan-f/blockchain'... [INFO] [stderr] done. [INFO] running `"git" "clone" "work/cache/sources/gh/dan-f/blockchain" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/dan-f/blockchain"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/dan-f/blockchain'... [INFO] [stderr] done. [INFO] running `"git" "rev-parse" "HEAD"` [INFO] [stdout] 4d86b044e1da1625b51e69c1564b6c388c9c8834 [INFO] sha for GitHub repo dan-f/blockchain: 4d86b044e1da1625b51e69c1564b6c388c9c8834 [INFO] validating manifest of dan-f/blockchain on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of dan-f/blockchain on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing dan-f/blockchain [INFO] finished frobbing dan-f/blockchain [INFO] frobbed toml for dan-f/blockchain written to work/ex/clippy-test-run/sources/stable/gh/dan-f/blockchain/Cargo.toml [INFO] started frobbing dan-f/blockchain [INFO] finished frobbing dan-f/blockchain [INFO] frobbed toml for dan-f/blockchain written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/dan-f/blockchain/Cargo.toml [INFO] crate dan-f/blockchain has a lockfile. skipping [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting dan-f/blockchain against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-5/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/gh/dan-f/blockchain:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] d43ed0a34f3182df0a69efe9037e23f738ebf6f36341455dd2e05872b7d43305 [INFO] running `"docker" "start" "-a" "d43ed0a34f3182df0a69efe9037e23f738ebf6f36341455dd2e05872b7d43305"` [INFO] [stderr] Blocking waiting for file lock on the registry index [INFO] [stderr] Compiling openssl v0.10.10 [INFO] [stderr] Checking bincode v1.0.0 [INFO] [stderr] Checking crypto-hash v0.3.1 [INFO] [stderr] Checking blockchain v0.1.0 (/opt/crater/workdir) [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/block.rs:4:28 [INFO] [stderr] | [INFO] [stderr] 4 | const GENESIS_NONCE: u64 = 151771; [INFO] [stderr] | ^^^^^^ help: consider: `151_771` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::unreadable_literal)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/block.rs:19:24 [INFO] [stderr] | [INFO] [stderr] 19 | timestamp: 1528749153, [INFO] [stderr] | ^^^^^^^^^^ help: consider: `1_528_749_153` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/block.rs:4:28 [INFO] [stderr] | [INFO] [stderr] 4 | const GENESIS_NONCE: u64 = 151771; [INFO] [stderr] | ^^^^^^ help: consider: `151_771` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::unreadable_literal)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/block.rs:19:24 [INFO] [stderr] | [INFO] [stderr] 19 | timestamp: 1528749153, [INFO] [stderr] | ^^^^^^^^^^ help: consider: `1_528_749_153` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: you should consider deriving a `Default` implementation for `block::GenesisBlock` [INFO] [stderr] --> src/block.rs:16:5 [INFO] [stderr] | [INFO] [stderr] 16 | / pub fn new() -> Self { [INFO] [stderr] 17 | | let genesis = GenesisBlock { [INFO] [stderr] 18 | | block_num: 0, [INFO] [stderr] 19 | | timestamp: 1528749153, [INFO] [stderr] ... | [INFO] [stderr] 27 | | genesis [INFO] [stderr] 28 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::new_without_default_derive)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default_derive [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 8 | #[derive(Default)] [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: you should consider adding a `Default` implementation for `blockchain::BlockChain` [INFO] [stderr] --> src/blockchain.rs:27:5 [INFO] [stderr] | [INFO] [stderr] 27 | / pub fn new() -> Self { [INFO] [stderr] 28 | | let genesis = GenesisBlock::new(); [INFO] [stderr] 29 | | let genesis_hash = genesis.hash(); [INFO] [stderr] 30 | | BlockChain { [INFO] [stderr] ... | [INFO] [stderr] 34 | | } [INFO] [stderr] 35 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::new_without_default)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 26 | impl Default for blockchain::BlockChain { [INFO] [stderr] 27 | fn default() -> Self { [INFO] [stderr] 28 | Self::new() [INFO] [stderr] 29 | } [INFO] [stderr] 30 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: item `list::List` has a public `len` method but no corresponding `is_empty` method [INFO] [stderr] --> src/list.rs:17:1 [INFO] [stderr] | [INFO] [stderr] 17 | / impl List { [INFO] [stderr] 18 | | pub fn new() -> Self { [INFO] [stderr] 19 | | List { head: None, len: 0 } [INFO] [stderr] 20 | | } [INFO] [stderr] ... | [INFO] [stderr] 38 | | } [INFO] [stderr] 39 | | } [INFO] [stderr] | |_^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::len_without_is_empty)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_without_is_empty [INFO] [stderr] [INFO] [stderr] warning: you should consider deriving a `Default` implementation for `list::List` [INFO] [stderr] --> src/list.rs:18:5 [INFO] [stderr] | [INFO] [stderr] 18 | / pub fn new() -> Self { [INFO] [stderr] 19 | | List { head: None, len: 0 } [INFO] [stderr] 20 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default_derive [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 12 | #[derive(Default)] [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: you should consider deriving a `Default` implementation for `block::GenesisBlock` [INFO] [stderr] --> src/block.rs:16:5 [INFO] [stderr] | [INFO] [stderr] 16 | / pub fn new() -> Self { [INFO] [stderr] 17 | | let genesis = GenesisBlock { [INFO] [stderr] 18 | | block_num: 0, [INFO] [stderr] 19 | | timestamp: 1528749153, [INFO] [stderr] ... | [INFO] [stderr] 27 | | genesis [INFO] [stderr] 28 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::new_without_default_derive)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default_derive [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 8 | #[derive(Default)] [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: you should consider adding a `Default` implementation for `blockchain::BlockChain` [INFO] [stderr] --> src/blockchain.rs:27:5 [INFO] [stderr] | [INFO] [stderr] 27 | / pub fn new() -> Self { [INFO] [stderr] 28 | | let genesis = GenesisBlock::new(); [INFO] [stderr] 29 | | let genesis_hash = genesis.hash(); [INFO] [stderr] 30 | | BlockChain { [INFO] [stderr] ... | [INFO] [stderr] 34 | | } [INFO] [stderr] 35 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::new_without_default)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 26 | impl Default for blockchain::BlockChain { [INFO] [stderr] 27 | fn default() -> Self { [INFO] [stderr] 28 | Self::new() [INFO] [stderr] 29 | } [INFO] [stderr] 30 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: item `list::List` has a public `len` method but no corresponding `is_empty` method [INFO] [stderr] --> src/list.rs:17:1 [INFO] [stderr] | [INFO] [stderr] 17 | / impl List { [INFO] [stderr] 18 | | pub fn new() -> Self { [INFO] [stderr] 19 | | List { head: None, len: 0 } [INFO] [stderr] 20 | | } [INFO] [stderr] ... | [INFO] [stderr] 38 | | } [INFO] [stderr] 39 | | } [INFO] [stderr] | |_^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::len_without_is_empty)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_without_is_empty [INFO] [stderr] [INFO] [stderr] warning: you should consider deriving a `Default` implementation for `list::List` [INFO] [stderr] --> src/list.rs:18:5 [INFO] [stderr] | [INFO] [stderr] 18 | / pub fn new() -> Self { [INFO] [stderr] 19 | | List { head: None, len: 0 } [INFO] [stderr] 20 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default_derive [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 12 | #[derive(Default)] [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 8.31s [INFO] running `"docker" "inspect" "d43ed0a34f3182df0a69efe9037e23f738ebf6f36341455dd2e05872b7d43305"` [INFO] running `"docker" "rm" "-f" "d43ed0a34f3182df0a69efe9037e23f738ebf6f36341455dd2e05872b7d43305"` [INFO] [stdout] d43ed0a34f3182df0a69efe9037e23f738ebf6f36341455dd2e05872b7d43305