[INFO] updating cached repository damnever/game-rs [INFO] running `"git" "fetch" "--all"` [INFO] [stdout] Fetching origin [INFO] [stderr] From git://github.com/damnever/game-rs [INFO] [stderr] * branch HEAD -> FETCH_HEAD [INFO] running `"git" "clone" "work/cache/sources/gh/damnever/game-rs" "work/ex/clippy-test-run/sources/stable/gh/damnever/game-rs"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/damnever/game-rs'... [INFO] [stderr] done. [INFO] running `"git" "clone" "work/cache/sources/gh/damnever/game-rs" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/damnever/game-rs"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/damnever/game-rs'... [INFO] [stderr] done. [INFO] running `"git" "rev-parse" "HEAD"` [INFO] [stdout] 4ecb5a496206535d4051107eb57ad32b3e9c9799 [INFO] sha for GitHub repo damnever/game-rs: 4ecb5a496206535d4051107eb57ad32b3e9c9799 [INFO] validating manifest of damnever/game-rs on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of damnever/game-rs on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing damnever/game-rs [INFO] finished frobbing damnever/game-rs [INFO] frobbed toml for damnever/game-rs written to work/ex/clippy-test-run/sources/stable/gh/damnever/game-rs/Cargo.toml [INFO] started frobbing damnever/game-rs [INFO] finished frobbing damnever/game-rs [INFO] frobbed toml for damnever/game-rs written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/damnever/game-rs/Cargo.toml [INFO] crate damnever/game-rs has a lockfile. skipping [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting damnever/game-rs against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-5/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/gh/damnever/game-rs:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 99054fd3b4fb2518ecd6beffc1e82b784728239a4de6d12ddbd9ffde53a91c7e [INFO] running `"docker" "start" "-a" "99054fd3b4fb2518ecd6beffc1e82b784728239a4de6d12ddbd9ffde53a91c7e"` [INFO] [stderr] Checking termion v1.3.0 [INFO] [stderr] Checking game-rs v0.1.0 (/opt/crater/workdir) [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/2048/main.rs:47:9 [INFO] [stderr] | [INFO] [stderr] 47 | bgs: bgs, [INFO] [stderr] | ^^^^^^^^ help: replace it with: `bgs` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/2048/main.rs:49:9 [INFO] [stderr] | [INFO] [stderr] 49 | stdout: stdout, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `stdout` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/2048/main.rs:47:9 [INFO] [stderr] | [INFO] [stderr] 47 | bgs: bgs, [INFO] [stderr] | ^^^^^^^^ help: replace it with: `bgs` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/2048/main.rs:49:9 [INFO] [stderr] | [INFO] [stderr] 49 | stdout: stdout, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `stdout` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/2048/main.rs:194:9 [INFO] [stderr] | [INFO] [stderr] 194 | return true; [INFO] [stderr] | ^^^^^^^^^^^^ help: remove `return` as shown: `true` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_return)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/2048/main.rs:308:9 [INFO] [stderr] | [INFO] [stderr] 308 | return self.merge(xs, ys, fget, fset); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `self.merge(xs, ys, fget, fset)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/2048/main.rs:316:9 [INFO] [stderr] | [INFO] [stderr] 316 | return self.merge(xs, ys, fget, fset); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `self.merge(xs, ys, fget, fset)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/2048/main.rs:324:9 [INFO] [stderr] | [INFO] [stderr] 324 | return self.merge(xs, ys, fget, fset); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `self.merge(xs, ys, fget, fset)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/2048/main.rs:332:9 [INFO] [stderr] | [INFO] [stderr] 332 | return self.merge(xs, ys, fget, fset); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `self.merge(xs, ys, fget, fset)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/2048/main.rs:194:9 [INFO] [stderr] | [INFO] [stderr] 194 | return true; [INFO] [stderr] | ^^^^^^^^^^^^ help: remove `return` as shown: `true` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_return)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/2048/main.rs:308:9 [INFO] [stderr] | [INFO] [stderr] 308 | return self.merge(xs, ys, fget, fset); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `self.merge(xs, ys, fget, fset)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/2048/main.rs:316:9 [INFO] [stderr] | [INFO] [stderr] 316 | return self.merge(xs, ys, fget, fset); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `self.merge(xs, ys, fget, fset)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/2048/main.rs:324:9 [INFO] [stderr] | [INFO] [stderr] 324 | return self.merge(xs, ys, fget, fset); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `self.merge(xs, ys, fget, fset)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/2048/main.rs:332:9 [INFO] [stderr] | [INFO] [stderr] 332 | return self.merge(xs, ys, fget, fset); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `self.merge(xs, ys, fget, fset)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: value assigned to `moved` is never read [INFO] [stderr] --> src/2048/main.rs:88:21 [INFO] [stderr] | [INFO] [stderr] 88 | let mut moved = false; [INFO] [stderr] | ^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_assignments)] on by default [INFO] [stderr] [INFO] [stderr] warning: value assigned to `moved` is never read [INFO] [stderr] --> src/2048/main.rs:88:21 [INFO] [stderr] | [INFO] [stderr] 88 | let mut moved = false; [INFO] [stderr] | ^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_assignments)] on by default [INFO] [stderr] [INFO] [stderr] warning: the loop variable `i` is used to index `colors` [INFO] [stderr] --> src/2048/main.rs:40:14 [INFO] [stderr] | [INFO] [stderr] 40 | for i in 1..17 { [INFO] [stderr] | ^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_range_loop)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop [INFO] [stderr] help: consider using an iterator [INFO] [stderr] | [INFO] [stderr] 40 | for (i, ) in colors.iter().enumerate().skip(1) { [INFO] [stderr] | ^^^^^^^^^^^ ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] error: this loop never actually loops [INFO] [stderr] --> src/2048/main.rs:162:9 [INFO] [stderr] | [INFO] [stderr] 162 | / for idx in holes.iter() { // use HashSet's random feature directly.. [INFO] [stderr] 163 | | // self.grid[*idx] = 1u32 << (*idx as u32 % 2u32 + 1u32); // whatever... [INFO] [stderr] 164 | | let mut threhold = 222u8; [INFO] [stderr] 165 | | if len <= 4 { [INFO] [stderr] ... | [INFO] [stderr] 173 | | break; [INFO] [stderr] 174 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = note: #[deny(clippy::never_loop)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#never_loop [INFO] [stderr] [INFO] [stderr] warning: `if _ { .. } else { .. }` is an expression [INFO] [stderr] --> src/2048/main.rs:164:13 [INFO] [stderr] | [INFO] [stderr] 164 | / let mut threhold = 222u8; [INFO] [stderr] 165 | | if len <= 4 { [INFO] [stderr] 166 | | threhold = 127u8; [INFO] [stderr] 167 | | } [INFO] [stderr] | |_____________^ help: it is more idiomatic to write: `let threhold = if len <= 4 { 127u8 } else { 222u8 };` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::useless_let_if_seq)] on by default [INFO] [stderr] = note: you might not need `mut` at all [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_let_if_seq [INFO] [stderr] [INFO] [stderr] error: handle written amount returned or use `Write::write_all` instead [INFO] [stderr] --> src/2048/main.rs:241:13 [INFO] [stderr] | [INFO] [stderr] 241 | self.stdout.write(up_line.as_bytes()).unwrap(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[deny(clippy::unused_io_amount)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_io_amount [INFO] [stderr] [INFO] [stderr] error: handle written amount returned or use `Write::write_all` instead [INFO] [stderr] --> src/2048/main.rs:242:13 [INFO] [stderr] | [INFO] [stderr] 242 | self.stdout.write(mid_line.as_bytes()).unwrap(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_io_amount [INFO] [stderr] [INFO] [stderr] error: handle written amount returned or use `Write::write_all` instead [INFO] [stderr] --> src/2048/main.rs:243:13 [INFO] [stderr] | [INFO] [stderr] 243 | self.stdout.write(down_line.as_bytes()).unwrap(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_io_amount [INFO] [stderr] [INFO] [stderr] error: handle written amount returned or use `Write::write_all` instead [INFO] [stderr] --> src/2048/main.rs:244:13 [INFO] [stderr] | [INFO] [stderr] 244 | self.stdout.write(format!("{:32}\n\r", " ").as_bytes()).unwrap(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_io_amount [INFO] [stderr] [INFO] [stderr] error: aborting due to 5 previous errors [INFO] [stderr] [INFO] [stderr] error: Could not compile `game-rs`. [INFO] [stderr] warning: build failed, waiting for other jobs to finish... [INFO] [stderr] warning: the loop variable `i` is used to index `colors` [INFO] [stderr] --> src/2048/main.rs:40:14 [INFO] [stderr] | [INFO] [stderr] 40 | for i in 1..17 { [INFO] [stderr] | ^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_range_loop)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_range_loop [INFO] [stderr] help: consider using an iterator [INFO] [stderr] | [INFO] [stderr] 40 | for (i, ) in colors.iter().enumerate().skip(1) { [INFO] [stderr] | ^^^^^^^^^^^ ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] error: this loop never actually loops [INFO] [stderr] --> src/2048/main.rs:162:9 [INFO] [stderr] | [INFO] [stderr] 162 | / for idx in holes.iter() { // use HashSet's random feature directly.. [INFO] [stderr] 163 | | // self.grid[*idx] = 1u32 << (*idx as u32 % 2u32 + 1u32); // whatever... [INFO] [stderr] 164 | | let mut threhold = 222u8; [INFO] [stderr] 165 | | if len <= 4 { [INFO] [stderr] ... | [INFO] [stderr] 173 | | break; [INFO] [stderr] 174 | | } [INFO] [stderr] | |_________^ [INFO] [stderr] | [INFO] [stderr] = note: #[deny(clippy::never_loop)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#never_loop [INFO] [stderr] [INFO] [stderr] warning: `if _ { .. } else { .. }` is an expression [INFO] [stderr] --> src/2048/main.rs:164:13 [INFO] [stderr] | [INFO] [stderr] 164 | / let mut threhold = 222u8; [INFO] [stderr] 165 | | if len <= 4 { [INFO] [stderr] 166 | | threhold = 127u8; [INFO] [stderr] 167 | | } [INFO] [stderr] | |_____________^ help: it is more idiomatic to write: `let threhold = if len <= 4 { 127u8 } else { 222u8 };` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::useless_let_if_seq)] on by default [INFO] [stderr] = note: you might not need `mut` at all [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_let_if_seq [INFO] [stderr] [INFO] [stderr] error: handle written amount returned or use `Write::write_all` instead [INFO] [stderr] --> src/2048/main.rs:241:13 [INFO] [stderr] | [INFO] [stderr] 241 | self.stdout.write(up_line.as_bytes()).unwrap(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[deny(clippy::unused_io_amount)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_io_amount [INFO] [stderr] [INFO] [stderr] error: handle written amount returned or use `Write::write_all` instead [INFO] [stderr] --> src/2048/main.rs:242:13 [INFO] [stderr] | [INFO] [stderr] 242 | self.stdout.write(mid_line.as_bytes()).unwrap(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_io_amount [INFO] [stderr] [INFO] [stderr] error: handle written amount returned or use `Write::write_all` instead [INFO] [stderr] --> src/2048/main.rs:243:13 [INFO] [stderr] | [INFO] [stderr] 243 | self.stdout.write(down_line.as_bytes()).unwrap(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_io_amount [INFO] [stderr] [INFO] [stderr] error: handle written amount returned or use `Write::write_all` instead [INFO] [stderr] --> src/2048/main.rs:244:13 [INFO] [stderr] | [INFO] [stderr] 244 | self.stdout.write(format!("{:32}\n\r", " ").as_bytes()).unwrap(); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unused_io_amount [INFO] [stderr] [INFO] [stderr] error: aborting due to 5 previous errors [INFO] [stderr] [INFO] [stderr] error: Could not compile `game-rs`. [INFO] [stderr] [INFO] [stderr] To learn more, run the command again with --verbose. [INFO] running `"docker" "inspect" "99054fd3b4fb2518ecd6beffc1e82b784728239a4de6d12ddbd9ffde53a91c7e"` [INFO] running `"docker" "rm" "-f" "99054fd3b4fb2518ecd6beffc1e82b784728239a4de6d12ddbd9ffde53a91c7e"` [INFO] [stdout] 99054fd3b4fb2518ecd6beffc1e82b784728239a4de6d12ddbd9ffde53a91c7e