[INFO] updating cached repository dallaselynn/dseq-rs [INFO] running `"git" "fetch" "--all"` [INFO] [stdout] Fetching origin [INFO] [stderr] From git://github.com/dallaselynn/dseq-rs [INFO] [stderr] * branch HEAD -> FETCH_HEAD [INFO] running `"git" "clone" "work/cache/sources/gh/dallaselynn/dseq-rs" "work/ex/clippy-test-run/sources/stable/gh/dallaselynn/dseq-rs"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/dallaselynn/dseq-rs'... [INFO] [stderr] done. [INFO] running `"git" "clone" "work/cache/sources/gh/dallaselynn/dseq-rs" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/dallaselynn/dseq-rs"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/dallaselynn/dseq-rs'... [INFO] [stderr] done. [INFO] running `"git" "rev-parse" "HEAD"` [INFO] [stdout] a63c2797d5892eb162c40d21221730c5b95d84ae [INFO] sha for GitHub repo dallaselynn/dseq-rs: a63c2797d5892eb162c40d21221730c5b95d84ae [INFO] validating manifest of dallaselynn/dseq-rs on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of dallaselynn/dseq-rs on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing dallaselynn/dseq-rs [INFO] finished frobbing dallaselynn/dseq-rs [INFO] frobbed toml for dallaselynn/dseq-rs written to work/ex/clippy-test-run/sources/stable/gh/dallaselynn/dseq-rs/Cargo.toml [INFO] started frobbing dallaselynn/dseq-rs [INFO] finished frobbing dallaselynn/dseq-rs [INFO] frobbed toml for dallaselynn/dseq-rs written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/dallaselynn/dseq-rs/Cargo.toml [INFO] crate dallaselynn/dseq-rs has a lockfile. skipping [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting dallaselynn/dseq-rs against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-7/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/gh/dallaselynn/dseq-rs:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 1d97064d19d251fc0b0ebf407629af625bf76131ead229615e5932d010535c12 [INFO] running `"docker" "start" "-a" "1d97064d19d251fc0b0ebf407629af625bf76131ead229615e5932d010535c12"` [INFO] [stderr] Checking dseq v0.1.0 (/opt/crater/workdir) [INFO] [stderr] warning: using `println!("")` [INFO] [stderr] --> src/lib.rs:128:5 [INFO] [stderr] | [INFO] [stderr] 128 | println!(""); [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `println!()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::println_empty_string)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#println_empty_string [INFO] [stderr] [INFO] [stderr] warning: using `println!("")` [INFO] [stderr] --> src/lib.rs:128:5 [INFO] [stderr] | [INFO] [stderr] 128 | println!(""); [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `println!()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::println_empty_string)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#println_empty_string [INFO] [stderr] [INFO] [stderr] warning: value assigned to `start_date` is never read [INFO] [stderr] --> src/lib.rs:29:17 [INFO] [stderr] | [INFO] [stderr] 29 | let mut start_date = today; [INFO] [stderr] | ^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_assignments)] on by default [INFO] [stderr] [INFO] [stderr] warning: value assigned to `end_date` is never read [INFO] [stderr] --> src/lib.rs:30:17 [INFO] [stderr] | [INFO] [stderr] 30 | let mut end_date = today; [INFO] [stderr] | ^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: this if-then-else expression returns a bool literal [INFO] [stderr] --> src/lib.rs:104:9 [INFO] [stderr] | [INFO] [stderr] 104 | / if (c.step_size > 0 && next > c.end_date) || (c.step_size < 0 && next < c.end_date) { [INFO] [stderr] 105 | | true [INFO] [stderr] 106 | | } else { [INFO] [stderr] 107 | | false [INFO] [stderr] 108 | | } [INFO] [stderr] | |_________^ help: you can reduce it to: `(c.step_size > 0 && next > c.end_date) || (c.step_size < 0 && next < c.end_date)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_bool)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_bool [INFO] [stderr] [INFO] [stderr] warning: value assigned to `start_date` is never read [INFO] [stderr] --> src/lib.rs:29:17 [INFO] [stderr] | [INFO] [stderr] 29 | let mut start_date = today; [INFO] [stderr] | ^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_assignments)] on by default [INFO] [stderr] [INFO] [stderr] warning: value assigned to `end_date` is never read [INFO] [stderr] --> src/lib.rs:30:17 [INFO] [stderr] | [INFO] [stderr] 30 | let mut end_date = today; [INFO] [stderr] | ^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: this if-then-else expression returns a bool literal [INFO] [stderr] --> src/lib.rs:104:9 [INFO] [stderr] | [INFO] [stderr] 104 | / if (c.step_size > 0 && next > c.end_date) || (c.step_size < 0 && next < c.end_date) { [INFO] [stderr] 105 | | true [INFO] [stderr] 106 | | } else { [INFO] [stderr] 107 | | false [INFO] [stderr] 108 | | } [INFO] [stderr] | |_________^ help: you can reduce it to: `(c.step_size > 0 && next > c.end_date) || (c.step_size < 0 && next < c.end_date)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_bool)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_bool [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 3.27s [INFO] running `"docker" "inspect" "1d97064d19d251fc0b0ebf407629af625bf76131ead229615e5932d010535c12"` [INFO] running `"docker" "rm" "-f" "1d97064d19d251fc0b0ebf407629af625bf76131ead229615e5932d010535c12"` [INFO] [stdout] 1d97064d19d251fc0b0ebf407629af625bf76131ead229615e5932d010535c12