[INFO] updating cached repository dalen/ecs-run [INFO] running `"git" "fetch" "--all"` [INFO] [stdout] Fetching origin [INFO] [stderr] From git://github.com/dalen/ecs-run [INFO] [stderr] * branch HEAD -> FETCH_HEAD [INFO] running `"git" "clone" "work/cache/sources/gh/dalen/ecs-run" "work/ex/clippy-test-run/sources/stable/gh/dalen/ecs-run"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/dalen/ecs-run'... [INFO] [stderr] done. [INFO] running `"git" "clone" "work/cache/sources/gh/dalen/ecs-run" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/dalen/ecs-run"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/dalen/ecs-run'... [INFO] [stderr] done. [INFO] running `"git" "rev-parse" "HEAD"` [INFO] [stdout] 3d3e933cb266c36008f4f647c048c818aaf5911a [INFO] sha for GitHub repo dalen/ecs-run: 3d3e933cb266c36008f4f647c048c818aaf5911a [INFO] validating manifest of dalen/ecs-run on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of dalen/ecs-run on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing dalen/ecs-run [INFO] finished frobbing dalen/ecs-run [INFO] frobbed toml for dalen/ecs-run written to work/ex/clippy-test-run/sources/stable/gh/dalen/ecs-run/Cargo.toml [INFO] started frobbing dalen/ecs-run [INFO] finished frobbing dalen/ecs-run [INFO] frobbed toml for dalen/ecs-run written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/dalen/ecs-run/Cargo.toml [INFO] crate dalen/ecs-run has a lockfile. skipping [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting dalen/ecs-run against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-7/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/gh/dalen/ecs-run:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 7ebe6dee68cb43355aff46da60665a515763e4928b6b2324c7259ef09fc2ddbd [INFO] running `"docker" "start" "-a" "7ebe6dee68cb43355aff46da60665a515763e4928b6b2324c7259ef09fc2ddbd"` [INFO] [stderr] Checking dirs v1.0.4 [INFO] [stderr] Checking log v0.4.6 [INFO] [stderr] Checking crossbeam-utils v0.6.3 [INFO] [stderr] Checking thread_local v0.3.6 [INFO] [stderr] Compiling openssl-sys v0.9.39 [INFO] [stderr] Checking regex-syntax v0.6.4 [INFO] [stderr] Checking aho-corasick v0.6.9 [INFO] [stderr] Checking http v0.1.14 [INFO] [stderr] Compiling quote v0.6.3 [INFO] [stderr] Compiling rusoto_core v0.36.0 [INFO] [stderr] Checking mio v0.6.14 [INFO] [stderr] Checking tokio-io v0.1.6 [INFO] [stderr] Checking want v0.0.6 [INFO] [stderr] Checking tokio-threadpool v0.1.4 [INFO] [stderr] Checking chrono v0.4.3 [INFO] [stderr] Checking tokio-timer v0.2.8 [INFO] [stderr] Compiling syn v0.14.2 [INFO] [stderr] Compiling openssl v0.10.15 [INFO] [stderr] Compiling native-tls v0.2.2 [INFO] [stderr] Checking tokio-reactor v0.1.1 [INFO] [stderr] Checking tokio-fs v0.1.0 [INFO] [stderr] Checking tokio-udp v0.1.0 [INFO] [stderr] Checking tokio-tcp v0.1.0 [INFO] [stderr] Checking regex v1.1.0 [INFO] [stderr] Checking tokio v0.1.7 [INFO] [stderr] Checking h2 v0.1.14 [INFO] [stderr] Compiling serde_derive v1.0.66 [INFO] [stderr] Checking hyper v0.12.18 [INFO] [stderr] Checking hyper-tls v0.3.1 [INFO] [stderr] Checking rusoto_credential v0.15.0 [INFO] [stderr] Checking rusoto_logs v0.36.0 [INFO] [stderr] Checking rusoto_ecs v0.36.0 [INFO] [stderr] Checking ecs-run v0.2.3 (/opt/crater/workdir) [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/main.rs:190:8 [INFO] [stderr] | [INFO] [stderr] 190 | if tasks.len() == 0 { [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `tasks.is_empty()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::len_zero)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: use of `expect` followed by a function call [INFO] [stderr] --> src/main.rs:211:14 [INFO] [stderr] | [INFO] [stderr] 211 | .expect(&format!("No container called {} found in task", &n)) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `unwrap_or_else(|| panic!("No container called {} found in task", &n))` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::expect_fun_call)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#expect_fun_call [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/main.rs:262:8 [INFO] [stderr] | [INFO] [stderr] 262 | if tasks.len() == 0 { [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `tasks.is_empty()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/main.rs:294:20 [INFO] [stderr] | [INFO] [stderr] 294 | if services.len() == 0 { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `services.is_empty()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/main.rs:190:8 [INFO] [stderr] | [INFO] [stderr] 190 | if tasks.len() == 0 { [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `tasks.is_empty()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::len_zero)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: use of `expect` followed by a function call [INFO] [stderr] --> src/main.rs:211:14 [INFO] [stderr] | [INFO] [stderr] 211 | .expect(&format!("No container called {} found in task", &n)) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try this: `unwrap_or_else(|| panic!("No container called {} found in task", &n))` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::expect_fun_call)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#expect_fun_call [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/main.rs:262:8 [INFO] [stderr] | [INFO] [stderr] 262 | if tasks.len() == 0 { [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `tasks.is_empty()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/main.rs:294:20 [INFO] [stderr] | [INFO] [stderr] 294 | if services.len() == 0 { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `services.is_empty()` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 1m 19s [INFO] running `"docker" "inspect" "7ebe6dee68cb43355aff46da60665a515763e4928b6b2324c7259ef09fc2ddbd"` [INFO] running `"docker" "rm" "-f" "7ebe6dee68cb43355aff46da60665a515763e4928b6b2324c7259ef09fc2ddbd"` [INFO] [stdout] 7ebe6dee68cb43355aff46da60665a515763e4928b6b2324c7259ef09fc2ddbd