[INFO] updating cached repository dalecgu/jd_comments
[INFO] running `"git" "fetch" "--all"`
[INFO] [stdout] Fetching origin
[INFO] [stderr] From git://github.com/dalecgu/jd_comments
[INFO] [stderr]  * branch            HEAD       -> FETCH_HEAD
[INFO] running `"git" "clone" "work/cache/sources/gh/dalecgu/jd_comments" "work/ex/clippy-test-run/sources/stable/gh/dalecgu/jd_comments"`
[INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/dalecgu/jd_comments'...
[INFO] [stderr] done.
[INFO] running `"git" "clone" "work/cache/sources/gh/dalecgu/jd_comments" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/dalecgu/jd_comments"`
[INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/dalecgu/jd_comments'...
[INFO] [stderr] done.
[INFO] running `"git" "rev-parse" "HEAD"`
[INFO] [stdout] f4cf98b2dae80266c9dcf0fc055afc88d64fae2a
[INFO] sha for GitHub repo dalecgu/jd_comments: f4cf98b2dae80266c9dcf0fc055afc88d64fae2a
[INFO] validating manifest of dalecgu/jd_comments on toolchain stable
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"`
[INFO] validating manifest of dalecgu/jd_comments on toolchain stable+rustflags=-Dclippy::into_iter_on_array
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"`
[INFO] started frobbing dalecgu/jd_comments
[INFO] finished frobbing dalecgu/jd_comments
[INFO] frobbed toml for dalecgu/jd_comments written to work/ex/clippy-test-run/sources/stable/gh/dalecgu/jd_comments/Cargo.toml
[INFO] started frobbing dalecgu/jd_comments
[INFO] finished frobbing dalecgu/jd_comments
[INFO] frobbed toml for dalecgu/jd_comments written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/dalecgu/jd_comments/Cargo.toml
[INFO] crate dalecgu/jd_comments has a lockfile. skipping
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"`
[INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"`
[INFO] linting dalecgu/jd_comments against stable for clippy-test-run
[INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-3/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/gh/dalecgu/jd_comments:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"`
[INFO] [stdout] 6ef433cbf73188042bde758310114ee4955547f374eefd6292bcf2fd172dc594
[INFO] running `"docker" "start" "-a" "6ef433cbf73188042bde758310114ee4955547f374eefd6292bcf2fd172dc594"`
[INFO] [stderr]     Checking scan_fmt v0.1.1
[INFO] [stderr]     Checking separator v0.3.1
[INFO] [stderr]     Checking data-encoding v1.2.0
[INFO] [stderr]     Checking hostname v0.1.3
[INFO] [stderr]     Checking atoi v0.2.2
[INFO] [stderr]     Checking nix v0.9.0
[INFO] [stderr]     Checking serde_json v1.0.4
[INFO] [stderr]     Checking toml v0.4.5
[INFO] [stderr]     Checking semver v0.8.0
[INFO] [stderr]     Checking aho-corasick v0.6.3
[INFO] [stderr]     Checking nom v3.2.0
[INFO] [stderr]     Checking twox-hash v1.1.0
[INFO] [stderr]     Checking thread_local v0.3.4
[INFO] [stderr]     Checking rust-crypto v0.2.36
[INFO] [stderr]     Checking textnonce v0.6.3
[INFO] [stderr]     Checking regex v0.2.2
[INFO] [stderr]     Checking config v0.7.0
[INFO] [stderr]     Checking mysql_common v0.2.0
[INFO] [stderr]     Checking env_logger v0.4.3
[INFO] [stderr]     Checking mysql v12.0.3
[INFO] [stderr]     Checking bson v0.10.0
[INFO] [stderr]     Checking mongodb v0.3.7
[INFO] [stderr]     Checking jd_comments v0.1.0 (/opt/crater/workdir)
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]   --> src/main.rs:51:5
[INFO] [stderr]    |
[INFO] [stderr] 51 |     return count.unwrap();
[INFO] [stderr]    |     ^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `count.unwrap()`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::needless_return)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]   --> src/main.rs:68:5
[INFO] [stderr]    |
[INFO] [stderr] 68 |     return selected_goods;
[INFO] [stderr]    |     ^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `selected_goods`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]   --> src/main.rs:51:5
[INFO] [stderr]    |
[INFO] [stderr] 51 |     return count.unwrap();
[INFO] [stderr]    |     ^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `count.unwrap()`
[INFO] [stderr]    |
[INFO] [stderr]    = note: #[warn(clippy::needless_return)] on by default
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] 
[INFO] [stderr] warning: unneeded return statement
[INFO] [stderr]   --> src/main.rs:68:5
[INFO] [stderr]    |
[INFO] [stderr] 68 |     return selected_goods;
[INFO] [stderr]    |     ^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `selected_goods`
[INFO] [stderr]    |
[INFO] [stderr]    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
[INFO] [stderr] 
[INFO] [stderr] warning: identical conversion
[INFO] [stderr]    --> src/main.rs:104:43
[INFO] [stderr]     |
[INFO] [stderr] 104 |                 doc_with_id.insert("_id", Bson::from(id.clone()));
[INFO] [stderr]     |                                           ^^^^^^^^^^^^^^^^^^^^^^ help: consider removing `Bson::from()`: `id.clone()`
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::identity_conversion)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_conversion
[INFO] [stderr] 
[INFO] [stderr] warning: identical conversion
[INFO] [stderr]    --> src/main.rs:104:43
[INFO] [stderr]     |
[INFO] [stderr] 104 |                 doc_with_id.insert("_id", Bson::from(id.clone()));
[INFO] [stderr]     |                                           ^^^^^^^^^^^^^^^^^^^^^^ help: consider removing `Bson::from()`: `id.clone()`
[INFO] [stderr]     |
[INFO] [stderr]     = note: #[warn(clippy::identity_conversion)] on by default
[INFO] [stderr]     = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#identity_conversion
[INFO] [stderr] 
[INFO] [stderr]     Finished dev [unoptimized + debuginfo] target(s) in 36.10s
[INFO] running `"docker" "inspect" "6ef433cbf73188042bde758310114ee4955547f374eefd6292bcf2fd172dc594"`
[INFO] running `"docker" "rm" "-f" "6ef433cbf73188042bde758310114ee4955547f374eefd6292bcf2fd172dc594"`
[INFO] [stdout] 6ef433cbf73188042bde758310114ee4955547f374eefd6292bcf2fd172dc594