[INFO] updating cached repository dalance/prosafe_exporter [INFO] running `"git" "fetch" "--all"` [INFO] [stdout] Fetching origin [INFO] [stderr] From git://github.com/dalance/prosafe_exporter [INFO] [stderr] * branch HEAD -> FETCH_HEAD [INFO] running `"git" "clone" "work/cache/sources/gh/dalance/prosafe_exporter" "work/ex/clippy-test-run/sources/stable/gh/dalance/prosafe_exporter"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/dalance/prosafe_exporter'... [INFO] [stderr] done. [INFO] running `"git" "clone" "work/cache/sources/gh/dalance/prosafe_exporter" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/dalance/prosafe_exporter"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/dalance/prosafe_exporter'... [INFO] [stderr] done. [INFO] running `"git" "rev-parse" "HEAD"` [INFO] [stdout] 0c9f597bb4a80b8c0bae8e5c0b9bd07110620b94 [INFO] sha for GitHub repo dalance/prosafe_exporter: 0c9f597bb4a80b8c0bae8e5c0b9bd07110620b94 [INFO] validating manifest of dalance/prosafe_exporter on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of dalance/prosafe_exporter on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing dalance/prosafe_exporter [INFO] finished frobbing dalance/prosafe_exporter [INFO] frobbed toml for dalance/prosafe_exporter written to work/ex/clippy-test-run/sources/stable/gh/dalance/prosafe_exporter/Cargo.toml [INFO] started frobbing dalance/prosafe_exporter [INFO] finished frobbing dalance/prosafe_exporter [INFO] frobbed toml for dalance/prosafe_exporter written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/dalance/prosafe_exporter/Cargo.toml [INFO] crate dalance/prosafe_exporter has a lockfile. skipping [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting dalance/prosafe_exporter against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-5/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/gh/dalance/prosafe_exporter:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 34533cf0dc23ba030227f5fe1321b7cd205efa26b0c39997d11788ef158cfea6 [INFO] running `"docker" "start" "-a" "34533cf0dc23ba030227f5fe1321b7cd205efa26b0c39997d11788ef158cfea6"` [INFO] [stderr] Compiling quick-error v1.2.2 [INFO] [stderr] Compiling proc-macro-hack-impl v0.4.1 [INFO] [stderr] Compiling prometheus v0.4.2 [INFO] [stderr] Compiling protobuf v2.0.5 [INFO] [stderr] Checking nix v0.10.0 [INFO] [stderr] Checking combine v3.5.2 [INFO] [stderr] Checking tokio-threadpool v0.1.7 [INFO] [stderr] Checking tokio-reactor v0.1.6 [INFO] [stderr] Compiling handlebars v0.29.1 [INFO] [stderr] Compiling proc-macro-hack v0.4.1 [INFO] [stderr] Compiling hex-literal-impl v0.1.1 [INFO] [stderr] Checking tokio-uds v0.2.2 [INFO] [stderr] Checking tokio-tcp v0.1.2 [INFO] [stderr] Checking tokio-udp v0.1.2 [INFO] [stderr] Checking hex-literal v0.1.1 [INFO] [stderr] Checking tokio-fs v0.1.3 [INFO] [stderr] Checking tokio v0.1.11 [INFO] [stderr] Checking hyper v0.12.11 [INFO] [stderr] Compiling interfaces2 v0.0.5 [INFO] [stderr] Checking prosafe_exporter v0.2.2-pre (/opt/crater/workdir) [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/prosafe_switch.rs:174:17 [INFO] [stderr] | [INFO] [stderr] 174 | port_no: port_no, [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: replace it with: `port_no` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/prosafe_switch.rs:182:24 [INFO] [stderr] | [INFO] [stderr] 182 | Ok(PortStats { stats: stats }) [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `stats` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/prosafe_switch.rs:232:17 [INFO] [stderr] | [INFO] [stderr] 232 | port_no: port_no, [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: replace it with: `port_no` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/prosafe_switch.rs:233:17 [INFO] [stderr] | [INFO] [stderr] 233 | link: link, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `link` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/prosafe_switch.rs:238:25 [INFO] [stderr] | [INFO] [stderr] 238 | Ok(SpeedStats { stats: stats }) [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `stats` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/prosafe_switch.rs:174:17 [INFO] [stderr] | [INFO] [stderr] 174 | port_no: port_no, [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: replace it with: `port_no` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/prosafe_switch.rs:182:24 [INFO] [stderr] | [INFO] [stderr] 182 | Ok(PortStats { stats: stats }) [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `stats` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/prosafe_switch.rs:232:17 [INFO] [stderr] | [INFO] [stderr] 232 | port_no: port_no, [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: replace it with: `port_no` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/prosafe_switch.rs:233:17 [INFO] [stderr] | [INFO] [stderr] 233 | link: link, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `link` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/prosafe_switch.rs:238:25 [INFO] [stderr] | [INFO] [stderr] 238 | Ok(SpeedStats { stats: stats }) [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `stats` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: unused `#[macro_use]` import [INFO] [stderr] --> src/main.rs:13:1 [INFO] [stderr] | [INFO] [stderr] 13 | #[macro_use] [INFO] [stderr] | ^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_imports)] on by default [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/prosafe_switch.rs:18:16 [INFO] [stderr] | [INFO] [stderr] 18 | PortStat = 0x10000000, [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0x1000_0000` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::unreadable_literal)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/prosafe_switch.rs:19:17 [INFO] [stderr] | [INFO] [stderr] 19 | SpeedStat = 0x0c000000, [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0x0c00_0000` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/prosafe_switch.rs:20:11 [INFO] [stderr] | [INFO] [stderr] 20 | End = 0xffff0000, [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0xffff_0000` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: unused `#[macro_use]` import [INFO] [stderr] --> src/main.rs:13:1 [INFO] [stderr] | [INFO] [stderr] 13 | #[macro_use] [INFO] [stderr] | ^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_imports)] on by default [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/prosafe_switch.rs:18:16 [INFO] [stderr] | [INFO] [stderr] 18 | PortStat = 0x10000000, [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0x1000_0000` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::unreadable_literal)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/prosafe_switch.rs:19:17 [INFO] [stderr] | [INFO] [stderr] 19 | SpeedStat = 0x0c000000, [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0x0c00_0000` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/prosafe_switch.rs:20:11 [INFO] [stderr] | [INFO] [stderr] 20 | End = 0xffff0000, [INFO] [stderr] | ^^^^^^^^^^ help: consider: `0xffff_0000` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: single-character string constant used as pattern [INFO] [stderr] --> src/exporter.rs:120:48 [INFO] [stderr] | [INFO] [stderr] 120 | if k == "target" && v.contains(":") { [INFO] [stderr] | ^^^ help: try using a char instead: `':'` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::single_char_pattern)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern [INFO] [stderr] [INFO] [stderr] warning: single-character string constant used as pattern [INFO] [stderr] --> src/exporter.rs:125:54 [INFO] [stderr] | [INFO] [stderr] 125 | let target: Vec<&str> = target.split(":").collect(); [INFO] [stderr] | ^^^ help: try using a char instead: `':'` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/prosafe_switch.rs:343:33 [INFO] [stderr] | [INFO] [stderr] 343 | recv_bytes: 122379777938, [INFO] [stderr] | ^^^^^^^^^^^^ help: consider: `122_379_777_938` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/prosafe_switch.rs:344:33 [INFO] [stderr] | [INFO] [stderr] 344 | send_bytes: 145970553284, [INFO] [stderr] | ^^^^^^^^^^^^ help: consider: `145_970_553_284` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/prosafe_switch.rs:349:33 [INFO] [stderr] | [INFO] [stderr] 349 | recv_bytes: 360768403270, [INFO] [stderr] | ^^^^^^^^^^^^ help: consider: `360_768_403_270` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/prosafe_switch.rs:350:33 [INFO] [stderr] | [INFO] [stderr] 350 | send_bytes: 229813089479, [INFO] [stderr] | ^^^^^^^^^^^^ help: consider: `229_813_089_479` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/prosafe_switch.rs:351:33 [INFO] [stderr] | [INFO] [stderr] 351 | error_pkts: 904790, [INFO] [stderr] | ^^^^^^ help: consider: `904_790` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/prosafe_switch.rs:373:33 [INFO] [stderr] | [INFO] [stderr] 373 | recv_bytes: 1614511703913, [INFO] [stderr] | ^^^^^^^^^^^^^ help: consider: `1_614_511_703_913` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/prosafe_switch.rs:374:33 [INFO] [stderr] | [INFO] [stderr] 374 | send_bytes: 1970932966073, [INFO] [stderr] | ^^^^^^^^^^^^^ help: consider: `1_970_932_966_073` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/prosafe_switch.rs:385:33 [INFO] [stderr] | [INFO] [stderr] 385 | recv_bytes: 670418679, [INFO] [stderr] | ^^^^^^^^^ help: consider: `670_418_679` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/prosafe_switch.rs:386:33 [INFO] [stderr] | [INFO] [stderr] 386 | send_bytes: 1158571965, [INFO] [stderr] | ^^^^^^^^^^ help: consider: `1_158_571_965` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: casting i32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/exporter.rs:168:38 [INFO] [stderr] | [INFO] [stderr] 168 | .set(speed as f64); [INFO] [stderr] | ^^^^^^^^^^^^ help: try: `f64::from(speed)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cast_lossless)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/prosafe_switch.rs:36:31 [INFO] [stderr] | [INFO] [stderr] 36 | fn new(cmd: Cmd, src_mac: &HardwareAddr, dst_mac: &HardwareAddr) -> Self { [INFO] [stderr] | ^^^^^^^^^^^^^ help: consider passing by value instead: `HardwareAddr` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::trivially_copy_pass_by_ref)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/prosafe_switch.rs:36:55 [INFO] [stderr] | [INFO] [stderr] 36 | fn new(cmd: Cmd, src_mac: &HardwareAddr, dst_mac: &HardwareAddr) -> Self { [INFO] [stderr] | ^^^^^^^^^^^^^ help: consider passing by value instead: `HardwareAddr` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/prosafe_switch.rs:125:15 [INFO] [stderr] | [INFO] [stderr] 125 | while buf.len() != 0 { [INFO] [stderr] | ^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `!buf.is_empty()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::len_zero)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: use of `ok_or` followed by a function call [INFO] [stderr] --> src/prosafe_switch.rs:264:60 [INFO] [stderr] | [INFO] [stderr] 264 | let iface = Interface::get_by_name(&self.if_name)?.ok_or(format_err!( [INFO] [stderr] | ____________________________________________________________^ [INFO] [stderr] 265 | | "failed to get network interface '{}'", [INFO] [stderr] 266 | | self.if_name [INFO] [stderr] 267 | | ))?; [INFO] [stderr] | |__________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::or_fun_call)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 264 | let iface = Interface::get_by_name(&self.if_name)?.ok_or_else(|| format_err!( [INFO] [stderr] 265 | "failed to get network interface '{}'", [INFO] [stderr] 266 | self.if_name [INFO] [stderr] 267 | ))?; [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/prosafe_switch.rs:270:13 [INFO] [stderr] | [INFO] [stderr] 270 | / match address.kind { [INFO] [stderr] 271 | | Kind::Ipv4 => iface_addr = Some(address.addr.unwrap().ip()), [INFO] [stderr] 272 | | _ => (), [INFO] [stderr] 273 | | } [INFO] [stderr] | |_____________^ help: try this: `if let Kind::Ipv4 = address.kind { iface_addr = Some(address.addr.unwrap().ip()) }` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::single_match)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] [INFO] [stderr] warning: use of `ok_or` followed by a function call [INFO] [stderr] --> src/prosafe_switch.rs:275:37 [INFO] [stderr] | [INFO] [stderr] 275 | let iface_addr = iface_addr.ok_or(format_err!( [INFO] [stderr] | _____________________________________^ [INFO] [stderr] 276 | | "failed to get IPv4 address of network interface '{}'", [INFO] [stderr] 277 | | self.if_name [INFO] [stderr] 278 | | ))?; [INFO] [stderr] | |__________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 275 | let iface_addr = iface_addr.ok_or_else(|| format_err!( [INFO] [stderr] 276 | "failed to get IPv4 address of network interface '{}'", [INFO] [stderr] 277 | self.if_name [INFO] [stderr] 278 | ))?; [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/main.rs:62:5 [INFO] [stderr] | [INFO] [stderr] 62 | / match run() { [INFO] [stderr] 63 | | Err(x) => { [INFO] [stderr] 64 | | println!("{}", x); [INFO] [stderr] 65 | | } [INFO] [stderr] 66 | | _ => (), [INFO] [stderr] 67 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 62 | if let Err(x) = run() { [INFO] [stderr] 63 | println!("{}", x); [INFO] [stderr] 64 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: single-character string constant used as pattern [INFO] [stderr] --> src/exporter.rs:120:48 [INFO] [stderr] | [INFO] [stderr] 120 | if k == "target" && v.contains(":") { [INFO] [stderr] | ^^^ help: try using a char instead: `':'` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::single_char_pattern)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern [INFO] [stderr] [INFO] [stderr] warning: single-character string constant used as pattern [INFO] [stderr] --> src/exporter.rs:125:54 [INFO] [stderr] | [INFO] [stderr] 125 | let target: Vec<&str> = target.split(":").collect(); [INFO] [stderr] | ^^^ help: try using a char instead: `':'` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern [INFO] [stderr] [INFO] [stderr] warning: casting i32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/exporter.rs:168:38 [INFO] [stderr] | [INFO] [stderr] 168 | .set(speed as f64); [INFO] [stderr] | ^^^^^^^^^^^^ help: try: `f64::from(speed)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cast_lossless)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/prosafe_switch.rs:36:31 [INFO] [stderr] | [INFO] [stderr] 36 | fn new(cmd: Cmd, src_mac: &HardwareAddr, dst_mac: &HardwareAddr) -> Self { [INFO] [stderr] | ^^^^^^^^^^^^^ help: consider passing by value instead: `HardwareAddr` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::trivially_copy_pass_by_ref)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: this argument is passed by reference, but would be more efficient if passed by value [INFO] [stderr] --> src/prosafe_switch.rs:36:55 [INFO] [stderr] | [INFO] [stderr] 36 | fn new(cmd: Cmd, src_mac: &HardwareAddr, dst_mac: &HardwareAddr) -> Self { [INFO] [stderr] | ^^^^^^^^^^^^^ help: consider passing by value instead: `HardwareAddr` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivially_copy_pass_by_ref [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/prosafe_switch.rs:125:15 [INFO] [stderr] | [INFO] [stderr] 125 | while buf.len() != 0 { [INFO] [stderr] | ^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `!buf.is_empty()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::len_zero)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: use of `ok_or` followed by a function call [INFO] [stderr] --> src/prosafe_switch.rs:264:60 [INFO] [stderr] | [INFO] [stderr] 264 | let iface = Interface::get_by_name(&self.if_name)?.ok_or(format_err!( [INFO] [stderr] | ____________________________________________________________^ [INFO] [stderr] 265 | | "failed to get network interface '{}'", [INFO] [stderr] 266 | | self.if_name [INFO] [stderr] 267 | | ))?; [INFO] [stderr] | |__________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::or_fun_call)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 264 | let iface = Interface::get_by_name(&self.if_name)?.ok_or_else(|| format_err!( [INFO] [stderr] 265 | "failed to get network interface '{}'", [INFO] [stderr] 266 | self.if_name [INFO] [stderr] 267 | ))?; [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/prosafe_switch.rs:270:13 [INFO] [stderr] | [INFO] [stderr] 270 | / match address.kind { [INFO] [stderr] 271 | | Kind::Ipv4 => iface_addr = Some(address.addr.unwrap().ip()), [INFO] [stderr] 272 | | _ => (), [INFO] [stderr] 273 | | } [INFO] [stderr] | |_____________^ help: try this: `if let Kind::Ipv4 = address.kind { iface_addr = Some(address.addr.unwrap().ip()) }` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::single_match)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] [INFO] [stderr] warning: use of `ok_or` followed by a function call [INFO] [stderr] --> src/prosafe_switch.rs:275:37 [INFO] [stderr] | [INFO] [stderr] 275 | let iface_addr = iface_addr.ok_or(format_err!( [INFO] [stderr] | _____________________________________^ [INFO] [stderr] 276 | | "failed to get IPv4 address of network interface '{}'", [INFO] [stderr] 277 | | self.if_name [INFO] [stderr] 278 | | ))?; [INFO] [stderr] | |__________^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 275 | let iface_addr = iface_addr.ok_or_else(|| format_err!( [INFO] [stderr] 276 | "failed to get IPv4 address of network interface '{}'", [INFO] [stderr] 277 | self.if_name [INFO] [stderr] 278 | ))?; [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/main.rs:62:5 [INFO] [stderr] | [INFO] [stderr] 62 | / match run() { [INFO] [stderr] 63 | | Err(x) => { [INFO] [stderr] 64 | | println!("{}", x); [INFO] [stderr] 65 | | } [INFO] [stderr] 66 | | _ => (), [INFO] [stderr] 67 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 62 | if let Err(x) = run() { [INFO] [stderr] 63 | println!("{}", x); [INFO] [stderr] 64 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 50.29s [INFO] running `"docker" "inspect" "34533cf0dc23ba030227f5fe1321b7cd205efa26b0c39997d11788ef158cfea6"` [INFO] running `"docker" "rm" "-f" "34533cf0dc23ba030227f5fe1321b7cd205efa26b0c39997d11788ef158cfea6"` [INFO] [stdout] 34533cf0dc23ba030227f5fe1321b7cd205efa26b0c39997d11788ef158cfea6