[INFO] updating cached repository dalance/gip [INFO] running `"git" "fetch" "--all"` [INFO] [stdout] Fetching origin [INFO] [stderr] From git://github.com/dalance/gip [INFO] [stderr] * branch HEAD -> FETCH_HEAD [INFO] running `"git" "clone" "work/cache/sources/gh/dalance/gip" "work/ex/clippy-test-run/sources/stable/gh/dalance/gip"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/dalance/gip'... [INFO] [stderr] done. [INFO] running `"git" "clone" "work/cache/sources/gh/dalance/gip" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/dalance/gip"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/dalance/gip'... [INFO] [stderr] done. [INFO] running `"git" "rev-parse" "HEAD"` [INFO] [stdout] fd2d5aac0af62ad93326dd3f6c36309bba43bd06 [INFO] sha for GitHub repo dalance/gip: fd2d5aac0af62ad93326dd3f6c36309bba43bd06 [INFO] validating manifest of dalance/gip on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of dalance/gip on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing dalance/gip [INFO] finished frobbing dalance/gip [INFO] frobbed toml for dalance/gip written to work/ex/clippy-test-run/sources/stable/gh/dalance/gip/Cargo.toml [INFO] started frobbing dalance/gip [INFO] finished frobbing dalance/gip [INFO] frobbed toml for dalance/gip written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/dalance/gip/Cargo.toml [INFO] crate dalance/gip has a lockfile. skipping [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting dalance/gip against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-0/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/gh/dalance/gip:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] abd2e3eaff2413af506a39d589023b1e6a017cea9f084690e66882a3aca51e9d [INFO] running `"docker" "start" "-a" "abd2e3eaff2413af506a39d589023b1e6a017cea9f084690e66882a3aca51e9d"` [INFO] [stderr] Checking log v0.4.1 [INFO] [stderr] Checking dirs v1.0.3 [INFO] [stderr] Checking memchr v2.1.0 [INFO] [stderr] Checking cookie v0.2.5 [INFO] [stderr] Checking backtrace v0.3.5 [INFO] [stderr] Checking log v0.3.9 [INFO] [stderr] Checking error-chain v0.11.0 [INFO] [stderr] Checking aho-corasick v0.6.8 [INFO] [stderr] Checking hpack v0.2.0 [INFO] [stderr] Checking mime v0.2.6 [INFO] [stderr] Checking solicit v0.4.4 [INFO] [stderr] Checking regex v1.0.5 [INFO] [stderr] Checking hyper v0.9.18 [INFO] [stderr] Checking gip v0.6.1-pre (/opt/crater/workdir) [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/lib.rs:313:13 [INFO] [stderr] | [INFO] [stderr] 313 | ptype: ptype, [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `ptype` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/lib.rs:325:13 [INFO] [stderr] | [INFO] [stderr] 325 | format: format, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `format` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/lib.rs:313:13 [INFO] [stderr] | [INFO] [stderr] 313 | ptype: ptype, [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `ptype` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/lib.rs:325:13 [INFO] [stderr] | [INFO] [stderr] 325 | format: format, [INFO] [stderr] | ^^^^^^^^^^^^^^ help: replace it with: `format` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: this `else { if .. }` block can be collapsed [INFO] [stderr] --> src/lib.rs:448:24 [INFO] [stderr] | [INFO] [stderr] 448 | } else { [INFO] [stderr] | ________________________^ [INFO] [stderr] 449 | | if err.is_some() { [INFO] [stderr] 450 | | err = Some(err.unwrap().chain_err(|| ret.err().unwrap())); [INFO] [stderr] 451 | | } else { [INFO] [stderr] 452 | | err = Some(ret.err().unwrap()); [INFO] [stderr] 453 | | } [INFO] [stderr] 454 | | } [INFO] [stderr] | |_________________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::collapsible_if)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stderr] help: try [INFO] [stderr] | [INFO] [stderr] 448 | } else if err.is_some() { [INFO] [stderr] 449 | err = Some(err.unwrap().chain_err(|| ret.err().unwrap())); [INFO] [stderr] 450 | } else { [INFO] [stderr] 451 | err = Some(ret.err().unwrap()); [INFO] [stderr] 452 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: this `else { if .. }` block can be collapsed [INFO] [stderr] --> src/lib.rs:448:24 [INFO] [stderr] | [INFO] [stderr] 448 | } else { [INFO] [stderr] | ________________________^ [INFO] [stderr] 449 | | if err.is_some() { [INFO] [stderr] 450 | | err = Some(err.unwrap().chain_err(|| ret.err().unwrap())); [INFO] [stderr] 451 | | } else { [INFO] [stderr] 452 | | err = Some(ret.err().unwrap()); [INFO] [stderr] 453 | | } [INFO] [stderr] 454 | | } [INFO] [stderr] | |_________________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::collapsible_if)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stderr] help: try [INFO] [stderr] | [INFO] [stderr] 448 | } else if err.is_some() { [INFO] [stderr] 449 | err = Some(err.unwrap().chain_err(|| ret.err().unwrap())); [INFO] [stderr] 450 | } else { [INFO] [stderr] 451 | err = Some(ret.err().unwrap()); [INFO] [stderr] 452 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: you should consider adding a `Default` implementation for `ProviderInfo` [INFO] [stderr] --> src/lib.rs:288:5 [INFO] [stderr] | [INFO] [stderr] 288 | / pub fn new() -> Self { [INFO] [stderr] 289 | | ProviderInfo { [INFO] [stderr] 290 | | name: String::from(""), [INFO] [stderr] 291 | | ptype: ProviderInfoType::IPv4, [INFO] [stderr] ... | [INFO] [stderr] 296 | | } [INFO] [stderr] 297 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::new_without_default)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 287 | impl Default for ProviderInfo { [INFO] [stderr] 288 | fn default() -> Self { [INFO] [stderr] 289 | Self::new() [INFO] [stderr] 290 | } [INFO] [stderr] 291 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/lib.rs:343:27 [INFO] [stderr] | [INFO] [stderr] 343 | pub fn key(self, key: &Vec) -> Self { [INFO] [stderr] | ^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::ptr_arg)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] help: change this to [INFO] [stderr] | [INFO] [stderr] 343 | pub fn key(self, key: &[String]) -> Self { [INFO] [stderr] | ^^^^^^^^^ [INFO] [stderr] help: change `key.clone()` to [INFO] [stderr] | [INFO] [stderr] 349 | key: key.to_owned(), [INFO] [stderr] | ^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: you should consider adding a `Default` implementation for `ProviderAny` [INFO] [stderr] --> src/lib.rs:414:5 [INFO] [stderr] | [INFO] [stderr] 414 | / pub fn new() -> Self { [INFO] [stderr] 415 | | ProviderAny { [INFO] [stderr] 416 | | providers: Vec::new(), [INFO] [stderr] 417 | | ptype: ProviderInfoType::IPv4, [INFO] [stderr] 418 | | } [INFO] [stderr] 419 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 413 | impl Default for ProviderAny { [INFO] [stderr] 414 | fn default() -> Self { [INFO] [stderr] 415 | Self::new() [INFO] [stderr] 416 | } [INFO] [stderr] 417 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: you should consider adding a `Default` implementation for `ProviderPlane` [INFO] [stderr] --> src/lib.rs:507:5 [INFO] [stderr] | [INFO] [stderr] 507 | / pub fn new() -> Self { [INFO] [stderr] 508 | | ProviderPlane { [INFO] [stderr] 509 | | info: ProviderInfo::new(), [INFO] [stderr] 510 | | timeout: 1000, [INFO] [stderr] 511 | | proxy: None, [INFO] [stderr] 512 | | } [INFO] [stderr] 513 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 506 | impl Default for ProviderPlane { [INFO] [stderr] 507 | fn default() -> Self { [INFO] [stderr] 508 | Self::new() [INFO] [stderr] 509 | } [INFO] [stderr] 510 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: you should consider adding a `Default` implementation for `ProviderJson` [INFO] [stderr] --> src/lib.rs:612:5 [INFO] [stderr] | [INFO] [stderr] 612 | / pub fn new() -> Self { [INFO] [stderr] 613 | | ProviderJson { [INFO] [stderr] 614 | | info: ProviderInfo::new(), [INFO] [stderr] 615 | | timeout: 1000, [INFO] [stderr] 616 | | proxy: None, [INFO] [stderr] 617 | | } [INFO] [stderr] 618 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 611 | impl Default for ProviderJson { [INFO] [stderr] 612 | fn default() -> Self { [INFO] [stderr] 613 | Self::new() [INFO] [stderr] 614 | } [INFO] [stderr] 615 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: you should consider adding a `Default` implementation for `ProviderDefaultV4` [INFO] [stderr] --> src/lib.rs:717:5 [INFO] [stderr] | [INFO] [stderr] 717 | / pub fn new() -> Self { [INFO] [stderr] 718 | | ProviderDefaultV4 { [INFO] [stderr] 719 | | provider: ProviderAny::from_toml(&DEFAULT_TOML).unwrap(), [INFO] [stderr] 720 | | } [INFO] [stderr] 721 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 716 | impl Default for ProviderDefaultV4 { [INFO] [stderr] 717 | fn default() -> Self { [INFO] [stderr] 718 | Self::new() [INFO] [stderr] 719 | } [INFO] [stderr] 720 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: you should consider adding a `Default` implementation for `ProviderDefaultV6` [INFO] [stderr] --> src/lib.rs:767:5 [INFO] [stderr] | [INFO] [stderr] 767 | / pub fn new() -> Self { [INFO] [stderr] 768 | | let mut p = ProviderAny::from_toml(&DEFAULT_TOML).unwrap(); [INFO] [stderr] 769 | | p.ptype = ProviderInfoType::IPv6; [INFO] [stderr] 770 | | ProviderDefaultV6 { [INFO] [stderr] 771 | | provider: p, [INFO] [stderr] 772 | | } [INFO] [stderr] 773 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 766 | impl Default for ProviderDefaultV6 { [INFO] [stderr] 767 | fn default() -> Self { [INFO] [stderr] 768 | Self::new() [INFO] [stderr] 769 | } [INFO] [stderr] 770 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: you should consider adding a `Default` implementation for `ProviderInfo` [INFO] [stderr] --> src/lib.rs:288:5 [INFO] [stderr] | [INFO] [stderr] 288 | / pub fn new() -> Self { [INFO] [stderr] 289 | | ProviderInfo { [INFO] [stderr] 290 | | name: String::from(""), [INFO] [stderr] 291 | | ptype: ProviderInfoType::IPv4, [INFO] [stderr] ... | [INFO] [stderr] 296 | | } [INFO] [stderr] 297 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::new_without_default)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 287 | impl Default for ProviderInfo { [INFO] [stderr] 288 | fn default() -> Self { [INFO] [stderr] 289 | Self::new() [INFO] [stderr] 290 | } [INFO] [stderr] 291 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/lib.rs:343:27 [INFO] [stderr] | [INFO] [stderr] 343 | pub fn key(self, key: &Vec) -> Self { [INFO] [stderr] | ^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::ptr_arg)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] help: change this to [INFO] [stderr] | [INFO] [stderr] 343 | pub fn key(self, key: &[String]) -> Self { [INFO] [stderr] | ^^^^^^^^^ [INFO] [stderr] help: change `key.clone()` to [INFO] [stderr] | [INFO] [stderr] 349 | key: key.to_owned(), [INFO] [stderr] | ^^^^^^^^^^^^^^ [INFO] [stderr] [INFO] [stderr] warning: you should consider adding a `Default` implementation for `ProviderAny` [INFO] [stderr] --> src/lib.rs:414:5 [INFO] [stderr] | [INFO] [stderr] 414 | / pub fn new() -> Self { [INFO] [stderr] 415 | | ProviderAny { [INFO] [stderr] 416 | | providers: Vec::new(), [INFO] [stderr] 417 | | ptype: ProviderInfoType::IPv4, [INFO] [stderr] 418 | | } [INFO] [stderr] 419 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 413 | impl Default for ProviderAny { [INFO] [stderr] 414 | fn default() -> Self { [INFO] [stderr] 415 | Self::new() [INFO] [stderr] 416 | } [INFO] [stderr] 417 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: you should consider adding a `Default` implementation for `ProviderPlane` [INFO] [stderr] --> src/lib.rs:507:5 [INFO] [stderr] | [INFO] [stderr] 507 | / pub fn new() -> Self { [INFO] [stderr] 508 | | ProviderPlane { [INFO] [stderr] 509 | | info: ProviderInfo::new(), [INFO] [stderr] 510 | | timeout: 1000, [INFO] [stderr] 511 | | proxy: None, [INFO] [stderr] 512 | | } [INFO] [stderr] 513 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 506 | impl Default for ProviderPlane { [INFO] [stderr] 507 | fn default() -> Self { [INFO] [stderr] 508 | Self::new() [INFO] [stderr] 509 | } [INFO] [stderr] 510 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: you should consider adding a `Default` implementation for `ProviderJson` [INFO] [stderr] --> src/lib.rs:612:5 [INFO] [stderr] | [INFO] [stderr] 612 | / pub fn new() -> Self { [INFO] [stderr] 613 | | ProviderJson { [INFO] [stderr] 614 | | info: ProviderInfo::new(), [INFO] [stderr] 615 | | timeout: 1000, [INFO] [stderr] 616 | | proxy: None, [INFO] [stderr] 617 | | } [INFO] [stderr] 618 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 611 | impl Default for ProviderJson { [INFO] [stderr] 612 | fn default() -> Self { [INFO] [stderr] 613 | Self::new() [INFO] [stderr] 614 | } [INFO] [stderr] 615 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: you should consider adding a `Default` implementation for `ProviderDefaultV4` [INFO] [stderr] --> src/lib.rs:717:5 [INFO] [stderr] | [INFO] [stderr] 717 | / pub fn new() -> Self { [INFO] [stderr] 718 | | ProviderDefaultV4 { [INFO] [stderr] 719 | | provider: ProviderAny::from_toml(&DEFAULT_TOML).unwrap(), [INFO] [stderr] 720 | | } [INFO] [stderr] 721 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 716 | impl Default for ProviderDefaultV4 { [INFO] [stderr] 717 | fn default() -> Self { [INFO] [stderr] 718 | Self::new() [INFO] [stderr] 719 | } [INFO] [stderr] 720 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: you should consider adding a `Default` implementation for `ProviderDefaultV6` [INFO] [stderr] --> src/lib.rs:767:5 [INFO] [stderr] | [INFO] [stderr] 767 | / pub fn new() -> Self { [INFO] [stderr] 768 | | let mut p = ProviderAny::from_toml(&DEFAULT_TOML).unwrap(); [INFO] [stderr] 769 | | p.ptype = ProviderInfoType::IPv6; [INFO] [stderr] 770 | | ProviderDefaultV6 { [INFO] [stderr] 771 | | provider: p, [INFO] [stderr] 772 | | } [INFO] [stderr] 773 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 766 | impl Default for ProviderDefaultV6 { [INFO] [stderr] 767 | fn default() -> Self { [INFO] [stderr] 768 | Self::new() [INFO] [stderr] 769 | } [INFO] [stderr] 770 | } [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/lib.rs:911:9 [INFO] [stderr] | [INFO] [stderr] 911 | / match addr { [INFO] [stderr] 912 | | Ok(x) => assert!(x.v6addr.is_some()), [INFO] [stderr] 913 | | Err(_) => (), [INFO] [stderr] 914 | | } [INFO] [stderr] | |_________^ help: try this: `if let Ok(x) = addr { assert!(x.v6addr.is_some()) }` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::single_match)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/lib.rs:926:9 [INFO] [stderr] | [INFO] [stderr] 926 | / match addr { [INFO] [stderr] 927 | | Ok(x) => assert!(x.v6addr.is_some()), [INFO] [stderr] 928 | | Err(_) => (), [INFO] [stderr] 929 | | } [INFO] [stderr] | |_________^ help: try this: `if let Ok(x) = addr { assert!(x.v6addr.is_some()) }` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] [INFO] [stderr] warning: you seem to be trying to use match for destructuring a single pattern. Consider using `if let` [INFO] [stderr] --> src/lib.rs:944:9 [INFO] [stderr] | [INFO] [stderr] 944 | / match addr { [INFO] [stderr] 945 | | Ok(x) => assert!(x.v6addr.is_some()), [INFO] [stderr] 946 | | Err(_) => (), [INFO] [stderr] 947 | | } [INFO] [stderr] | |_________^ help: try this: `if let Ok(x) = addr { assert!(x.v6addr.is_some()) }` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_match [INFO] [stderr] [INFO] [stderr] warning: unused `#[macro_use]` import [INFO] [stderr] --> src/gip.rs:5:1 [INFO] [stderr] | [INFO] [stderr] 5 | #[macro_use] [INFO] [stderr] | ^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_imports)] on by default [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/gip.rs:160:5 [INFO] [stderr] | [INFO] [stderr] 160 | return Ok(()); [INFO] [stderr] | ^^^^^^^^^^^^^^ help: remove `return` as shown: `Ok(())` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_return)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: this `else { if .. }` block can be collapsed [INFO] [stderr] --> src/gip.rs:150:12 [INFO] [stderr] | [INFO] [stderr] 150 | } else { [INFO] [stderr] | ____________^ [INFO] [stderr] 151 | | if opt.show_string { [INFO] [stderr] 152 | | print!("{}", addr_str); [INFO] [stderr] 153 | | } else if opt.show_json { [INFO] [stderr] ... | [INFO] [stderr] 157 | | } [INFO] [stderr] 158 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::collapsible_if)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stderr] help: try [INFO] [stderr] | [INFO] [stderr] 150 | } else if opt.show_string { [INFO] [stderr] 151 | print!("{}", addr_str); [INFO] [stderr] 152 | } else if opt.show_json { [INFO] [stderr] 153 | println!("{{\"{}\": \"{}\"}}", opt.json_key, addr_str); [INFO] [stderr] 154 | } else { [INFO] [stderr] 155 | println!("{}", addr_str); [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] warning: unused `#[macro_use]` import [INFO] [stderr] --> src/gip.rs:5:1 [INFO] [stderr] | [INFO] [stderr] 5 | #[macro_use] [INFO] [stderr] | ^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_imports)] on by default [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/gip.rs:160:5 [INFO] [stderr] | [INFO] [stderr] 160 | return Ok(()); [INFO] [stderr] | ^^^^^^^^^^^^^^ help: remove `return` as shown: `Ok(())` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_return)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: this `else { if .. }` block can be collapsed [INFO] [stderr] --> src/gip.rs:150:12 [INFO] [stderr] | [INFO] [stderr] 150 | } else { [INFO] [stderr] | ____________^ [INFO] [stderr] 151 | | if opt.show_string { [INFO] [stderr] 152 | | print!("{}", addr_str); [INFO] [stderr] 153 | | } else if opt.show_json { [INFO] [stderr] ... | [INFO] [stderr] 157 | | } [INFO] [stderr] 158 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::collapsible_if)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#collapsible_if [INFO] [stderr] help: try [INFO] [stderr] | [INFO] [stderr] 150 | } else if opt.show_string { [INFO] [stderr] 151 | print!("{}", addr_str); [INFO] [stderr] 152 | } else if opt.show_json { [INFO] [stderr] 153 | println!("{{\"{}\": \"{}\"}}", opt.json_key, addr_str); [INFO] [stderr] 154 | } else { [INFO] [stderr] 155 | println!("{}", addr_str); [INFO] [stderr] ... [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 22.04s [INFO] running `"docker" "inspect" "abd2e3eaff2413af506a39d589023b1e6a017cea9f084690e66882a3aca51e9d"` [INFO] running `"docker" "rm" "-f" "abd2e3eaff2413af506a39d589023b1e6a017cea9f084690e66882a3aca51e9d"` [INFO] [stdout] abd2e3eaff2413af506a39d589023b1e6a017cea9f084690e66882a3aca51e9d