[INFO] updating cached repository dalance/flexlint [INFO] running `"git" "fetch" "--all"` [INFO] [stdout] Fetching origin [INFO] [stderr] From git://github.com/dalance/flexlint [INFO] [stderr] * branch HEAD -> FETCH_HEAD [INFO] running `"git" "clone" "work/cache/sources/gh/dalance/flexlint" "work/ex/clippy-test-run/sources/stable/gh/dalance/flexlint"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/dalance/flexlint'... [INFO] [stderr] done. [INFO] running `"git" "clone" "work/cache/sources/gh/dalance/flexlint" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/dalance/flexlint"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/dalance/flexlint'... [INFO] [stderr] done. [INFO] running `"git" "rev-parse" "HEAD"` [INFO] [stdout] 77dc0db46d5f61d854f0863ea07fcc7534d95e26 [INFO] sha for GitHub repo dalance/flexlint: 77dc0db46d5f61d854f0863ea07fcc7534d95e26 [INFO] validating manifest of dalance/flexlint on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of dalance/flexlint on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing dalance/flexlint [INFO] finished frobbing dalance/flexlint [INFO] frobbed toml for dalance/flexlint written to work/ex/clippy-test-run/sources/stable/gh/dalance/flexlint/Cargo.toml [INFO] started frobbing dalance/flexlint [INFO] finished frobbing dalance/flexlint [INFO] frobbed toml for dalance/flexlint written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/dalance/flexlint/Cargo.toml [INFO] crate dalance/flexlint has a lockfile. skipping [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting dalance/flexlint against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-4/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/gh/dalance/flexlint:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] facbc95fe91fc7adf9ac127023f5171675ac689c2a46e87908f82809723e12bc [INFO] running `"docker" "start" "-a" "facbc95fe91fc7adf9ac127023f5171675ac689c2a46e87908f82809723e12bc"` [INFO] [stderr] Checking colored v1.6.1 [INFO] [stderr] Compiling quote v0.6.3 [INFO] [stderr] Compiling syn v0.14.9 [INFO] [stderr] Compiling synstructure v0.9.0 [INFO] [stderr] Compiling structopt-derive v0.2.10 [INFO] [stderr] Compiling serde_derive v1.0.66 [INFO] [stderr] Compiling failure_derive v0.1.2 [INFO] [stderr] Checking structopt v0.2.10 [INFO] [stderr] Checking failure v0.1.2 [INFO] [stderr] Checking flexlint v0.2.5-pre (/opt/crater/workdir) [INFO] [stderr] warning: trivial regex [INFO] [stderr] --> src/lint.rs:303:40 [INFO] [stderr] | [INFO] [stderr] 303 | format!("{:?}", Regex::new("bbb").unwrap()) [INFO] [stderr] | ^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::trivial_regex)] on by default [INFO] [stderr] = help: consider using `str::contains` [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivial_regex [INFO] [stderr] [INFO] [stderr] warning: trivial regex [INFO] [stderr] --> src/lint.rs:307:45 [INFO] [stderr] | [INFO] [stderr] 307 | format!("{:?}", Some(Regex::new("ccc").unwrap())) [INFO] [stderr] | ^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: consider using `str::contains` [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivial_regex [INFO] [stderr] [INFO] [stderr] warning: trivial regex [INFO] [stderr] --> src/lint.rs:311:45 [INFO] [stderr] | [INFO] [stderr] 311 | format!("{:?}", Some(Regex::new("ddd").unwrap())) [INFO] [stderr] | ^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: consider using `str::contains` [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivial_regex [INFO] [stderr] [INFO] [stderr] warning: trivial regex [INFO] [stderr] --> src/lint.rs:315:45 [INFO] [stderr] | [INFO] [stderr] 315 | format!("{:?}", Some(Regex::new("eee").unwrap())) [INFO] [stderr] | ^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: consider using `str::contains` [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#trivial_regex [INFO] [stderr] [INFO] [stderr] warning: this let-binding has unit value. Consider omitting `let _ =` [INFO] [stderr] --> src/printer.rs:338:9 [INFO] [stderr] | [INFO] [stderr] 338 | let _ = self.print_summary(path_checked, verbose, start_time)?; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::let_unit_value)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_unit_value [INFO] [stderr] [INFO] [stderr] warning: casting u32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/printer.rs:377:50 [INFO] [stderr] | [INFO] [stderr] 377 | let elapsed = elapsed.as_secs() as f64 + elapsed.subsec_micros() as f64 * 1e-6; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `f64::from(elapsed.subsec_micros())` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cast_lossless)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: this let-binding has unit value. Consider omitting `let _ =` [INFO] [stderr] --> src/printer.rs:338:9 [INFO] [stderr] | [INFO] [stderr] 338 | let _ = self.print_summary(path_checked, verbose, start_time)?; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::let_unit_value)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#let_unit_value [INFO] [stderr] [INFO] [stderr] warning: casting u32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/printer.rs:377:50 [INFO] [stderr] | [INFO] [stderr] 377 | let elapsed = elapsed.as_secs() as f64 + elapsed.subsec_micros() as f64 * 1e-6; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: try: `f64::from(elapsed.subsec_micros())` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cast_lossless)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 30.87s [INFO] running `"docker" "inspect" "facbc95fe91fc7adf9ac127023f5171675ac689c2a46e87908f82809723e12bc"` [INFO] running `"docker" "rm" "-f" "facbc95fe91fc7adf9ac127023f5171675ac689c2a46e87908f82809723e12bc"` [INFO] [stdout] facbc95fe91fc7adf9ac127023f5171675ac689c2a46e87908f82809723e12bc