[INFO] updating cached repository dakitten2358/rust_sudoku [INFO] running `"git" "fetch" "--all"` [INFO] [stdout] Fetching origin [INFO] [stderr] From git://github.com/dakitten2358/rust_sudoku [INFO] [stderr] * branch HEAD -> FETCH_HEAD [INFO] running `"git" "clone" "work/cache/sources/gh/dakitten2358/rust_sudoku" "work/ex/clippy-test-run/sources/stable/gh/dakitten2358/rust_sudoku"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/dakitten2358/rust_sudoku'... [INFO] [stderr] done. [INFO] running `"git" "clone" "work/cache/sources/gh/dakitten2358/rust_sudoku" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/dakitten2358/rust_sudoku"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/dakitten2358/rust_sudoku'... [INFO] [stderr] done. [INFO] running `"git" "rev-parse" "HEAD"` [INFO] [stdout] a099d400896428bcc995a0f85ef1b77e3d32f4e4 [INFO] sha for GitHub repo dakitten2358/rust_sudoku: a099d400896428bcc995a0f85ef1b77e3d32f4e4 [INFO] validating manifest of dakitten2358/rust_sudoku on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of dakitten2358/rust_sudoku on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing dakitten2358/rust_sudoku [INFO] finished frobbing dakitten2358/rust_sudoku [INFO] frobbed toml for dakitten2358/rust_sudoku written to work/ex/clippy-test-run/sources/stable/gh/dakitten2358/rust_sudoku/Cargo.toml [INFO] started frobbing dakitten2358/rust_sudoku [INFO] finished frobbing dakitten2358/rust_sudoku [INFO] frobbed toml for dakitten2358/rust_sudoku written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/dakitten2358/rust_sudoku/Cargo.toml [INFO] crate dakitten2358/rust_sudoku has a lockfile. skipping [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting dakitten2358/rust_sudoku against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-3/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/gh/dakitten2358/rust_sudoku:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 59d69300cb8e0dc04bcdf6d2f71a5feb7c20ee471398ca61b674c4b1507210a3 [INFO] running `"docker" "start" "-a" "59d69300cb8e0dc04bcdf6d2f71a5feb7c20ee471398ca61b674c4b1507210a3"` [INFO] [stderr] Checking image v0.14.0 [INFO] [stderr] Checking piston2d-opengl_graphics v0.45.0 [INFO] [stderr] Checking sudoku v0.1.0 (/opt/crater/workdir) [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/gameboard_controller.rs:48:13 [INFO] [stderr] | [INFO] [stderr] 48 | gameboard: gameboard, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: replace it with: `gameboard` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/gameboard_view.rs:65:25 [INFO] [stderr] | [INFO] [stderr] 65 | GameboardView { settings: settings } [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: replace it with: `settings` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/gameboard_controller.rs:48:13 [INFO] [stderr] | [INFO] [stderr] 48 | gameboard: gameboard, [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: replace it with: `gameboard` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/gameboard_view.rs:65:25 [INFO] [stderr] | [INFO] [stderr] 65 | GameboardView { settings: settings } [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^ help: replace it with: `settings` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/gameboard.rs:25:9 [INFO] [stderr] | [INFO] [stderr] 25 | return [0, row + 1]; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `[0, row + 1]` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_return)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/gameboard.rs:28:9 [INFO] [stderr] | [INFO] [stderr] 28 | return [col + 1, row]; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `[col + 1, row]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: doc comment not used by rustdoc [INFO] [stderr] --> src/gameboard.rs:60:9 [INFO] [stderr] | [INFO] [stderr] 60 | /// check to see if we already have this number in the given row or column [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_doc_comments)] on by default [INFO] [stderr] [INFO] [stderr] warning: unnecessary parentheses around `if` condition [INFO] [stderr] --> src/gameboard.rs:62:16 [INFO] [stderr] | [INFO] [stderr] 62 | if (self.cells[i][ind[0]] == val) { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove these parentheses [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_parens)] on by default [INFO] [stderr] [INFO] [stderr] warning: unnecessary parentheses around `if` condition [INFO] [stderr] --> src/gameboard.rs:65:16 [INFO] [stderr] | [INFO] [stderr] 65 | if (self.cells[ind[1]][i] == val) { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove these parentheses [INFO] [stderr] [INFO] [stderr] warning: unnecessary parentheses around `if` condition [INFO] [stderr] --> src/gameboard.rs:80:12 [INFO] [stderr] | [INFO] [stderr] 80 | if (self.cells[row1 + section_row][col1 + section_col] == val) { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove these parentheses [INFO] [stderr] [INFO] [stderr] warning: unnecessary parentheses around `if` condition [INFO] [stderr] --> src/gameboard.rs:83:12 [INFO] [stderr] | [INFO] [stderr] 83 | if (self.cells[row2 + section_row][col1 + section_col] == val) { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove these parentheses [INFO] [stderr] [INFO] [stderr] warning: unnecessary parentheses around `if` condition [INFO] [stderr] --> src/gameboard.rs:87:12 [INFO] [stderr] | [INFO] [stderr] 87 | if (self.cells[row1 + section_row][col2 + section_col] == val) { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove these parentheses [INFO] [stderr] [INFO] [stderr] warning: unnecessary parentheses around `if` condition [INFO] [stderr] --> src/gameboard.rs:90:12 [INFO] [stderr] | [INFO] [stderr] 90 | if (self.cells[row2 + section_row][col2 + section_col] == val) { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove these parentheses [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/gameboard_controller.rs:17:5 [INFO] [stderr] | [INFO] [stderr] 17 | return x >= 0.0 && x < size && y >= 0.0 && y < size; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `x >= 0.0 && x < size && y >= 0.0 && y < size` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: you should consider deriving a `Default` implementation for `gameboard::Gameboard` [INFO] [stderr] --> src/gameboard.rs:34:5 [INFO] [stderr] | [INFO] [stderr] 34 | / pub fn new() -> Gameboard { [INFO] [stderr] 35 | | Gameboard { cells: [[0; SIZE]; SIZE] } [INFO] [stderr] 36 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::new_without_default_derive)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default_derive [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 7 | #[derive(Default)] [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: you should consider deriving a `Default` implementation for `gameboard_view::GameboardViewSettings` [INFO] [stderr] --> src/gameboard_view.rs:38:5 [INFO] [stderr] | [INFO] [stderr] 38 | / pub fn new() -> GameboardViewSettings { [INFO] [stderr] 39 | | GameboardViewSettings { [INFO] [stderr] 40 | | offset: [10.0; 2], [INFO] [stderr] 41 | | size: 400.0, [INFO] [stderr] ... | [INFO] [stderr] 52 | | } [INFO] [stderr] 53 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default_derive [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 9 | #[derive(Default)] [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: `ref` on an entire `let` pattern is discouraged, take a reference with `&` instead [INFO] [stderr] --> src/gameboard_view.rs:78:13 [INFO] [stderr] | [INFO] [stderr] 78 | let ref settings = self.settings; [INFO] [stderr] | ----^^^^^^^^^^^^----------------- help: try: `let settings = &self.settings;` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::toplevel_ref_arg)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#toplevel_ref_arg [INFO] [stderr] [INFO] [stderr] warning: casting i32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/gameboard_view.rs:92:44 [INFO] [stderr] | [INFO] [stderr] 92 | let x = settings.offset[0] + (((i as f64) / 9.0) * settings.size); [INFO] [stderr] | ^^^^^^^^^^ help: try: `f64::from(i)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cast_lossless)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting i32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/gameboard_view.rs:93:44 [INFO] [stderr] | [INFO] [stderr] 93 | let y = settings.offset[1] + (((i as f64) / 9.0) * settings.size); [INFO] [stderr] | ^^^^^^^^^^ help: try: `f64::from(i)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting i32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/gameboard_view.rs:107:44 [INFO] [stderr] | [INFO] [stderr] 107 | let x = settings.offset[0] + (((i as f64) / 3.0) * settings.size); [INFO] [stderr] | ^^^^^^^^^^ help: try: `f64::from(i)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting i32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/gameboard_view.rs:108:44 [INFO] [stderr] | [INFO] [stderr] 108 | let y = settings.offset[1] + (((i as f64) / 3.0) * settings.size); [INFO] [stderr] | ^^^^^^^^^^ help: try: `f64::from(i)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: `ref` on an entire `let` pattern is discouraged, take a reference with `&` instead [INFO] [stderr] --> src/main.rs:38:9 [INFO] [stderr] | [INFO] [stderr] 38 | let ref mut glyphs = GlyphCache::new("assets/FiraSans-Regular.ttf", texture_settings) [INFO] [stderr] | ^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#toplevel_ref_arg [INFO] [stderr] help: try [INFO] [stderr] | [INFO] [stderr] 38 | let glyphs = &mut GlyphCache::new("assets/FiraSans-Regular.ttf", texture_settings) [INFO] [stderr] 39 | .expect("failed to load font"); [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/gameboard.rs:25:9 [INFO] [stderr] | [INFO] [stderr] 25 | return [0, row + 1]; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `[0, row + 1]` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::needless_return)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/gameboard.rs:28:9 [INFO] [stderr] | [INFO] [stderr] 28 | return [col + 1, row]; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `[col + 1, row]` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: doc comment not used by rustdoc [INFO] [stderr] --> src/gameboard.rs:60:9 [INFO] [stderr] | [INFO] [stderr] 60 | /// check to see if we already have this number in the given row or column [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_doc_comments)] on by default [INFO] [stderr] [INFO] [stderr] warning: unnecessary parentheses around `if` condition [INFO] [stderr] --> src/gameboard.rs:62:16 [INFO] [stderr] | [INFO] [stderr] 62 | if (self.cells[i][ind[0]] == val) { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove these parentheses [INFO] [stderr] | [INFO] [stderr] = note: #[warn(unused_parens)] on by default [INFO] [stderr] [INFO] [stderr] warning: unnecessary parentheses around `if` condition [INFO] [stderr] --> src/gameboard.rs:65:16 [INFO] [stderr] | [INFO] [stderr] 65 | if (self.cells[ind[1]][i] == val) { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove these parentheses [INFO] [stderr] [INFO] [stderr] warning: unnecessary parentheses around `if` condition [INFO] [stderr] --> src/gameboard.rs:80:12 [INFO] [stderr] | [INFO] [stderr] 80 | if (self.cells[row1 + section_row][col1 + section_col] == val) { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove these parentheses [INFO] [stderr] [INFO] [stderr] warning: unnecessary parentheses around `if` condition [INFO] [stderr] --> src/gameboard.rs:83:12 [INFO] [stderr] | [INFO] [stderr] 83 | if (self.cells[row2 + section_row][col1 + section_col] == val) { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove these parentheses [INFO] [stderr] [INFO] [stderr] warning: unnecessary parentheses around `if` condition [INFO] [stderr] --> src/gameboard.rs:87:12 [INFO] [stderr] | [INFO] [stderr] 87 | if (self.cells[row1 + section_row][col2 + section_col] == val) { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove these parentheses [INFO] [stderr] [INFO] [stderr] warning: unnecessary parentheses around `if` condition [INFO] [stderr] --> src/gameboard.rs:90:12 [INFO] [stderr] | [INFO] [stderr] 90 | if (self.cells[row2 + section_row][col2 + section_col] == val) { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove these parentheses [INFO] [stderr] [INFO] [stderr] warning: unneeded return statement [INFO] [stderr] --> src/gameboard_controller.rs:17:5 [INFO] [stderr] | [INFO] [stderr] 17 | return x >= 0.0 && x < size && y >= 0.0 && y < size; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: remove `return` as shown: `x >= 0.0 && x < size && y >= 0.0 && y < size` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return [INFO] [stderr] [INFO] [stderr] warning: you should consider deriving a `Default` implementation for `gameboard::Gameboard` [INFO] [stderr] --> src/gameboard.rs:34:5 [INFO] [stderr] | [INFO] [stderr] 34 | / pub fn new() -> Gameboard { [INFO] [stderr] 35 | | Gameboard { cells: [[0; SIZE]; SIZE] } [INFO] [stderr] 36 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::new_without_default_derive)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default_derive [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 7 | #[derive(Default)] [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: you should consider deriving a `Default` implementation for `gameboard_view::GameboardViewSettings` [INFO] [stderr] --> src/gameboard_view.rs:38:5 [INFO] [stderr] | [INFO] [stderr] 38 | / pub fn new() -> GameboardViewSettings { [INFO] [stderr] 39 | | GameboardViewSettings { [INFO] [stderr] 40 | | offset: [10.0; 2], [INFO] [stderr] 41 | | size: 400.0, [INFO] [stderr] ... | [INFO] [stderr] 52 | | } [INFO] [stderr] 53 | | } [INFO] [stderr] | |_____^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#new_without_default_derive [INFO] [stderr] help: try this [INFO] [stderr] | [INFO] [stderr] 9 | #[derive(Default)] [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: `ref` on an entire `let` pattern is discouraged, take a reference with `&` instead [INFO] [stderr] --> src/gameboard_view.rs:78:13 [INFO] [stderr] | [INFO] [stderr] 78 | let ref settings = self.settings; [INFO] [stderr] | ----^^^^^^^^^^^^----------------- help: try: `let settings = &self.settings;` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::toplevel_ref_arg)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#toplevel_ref_arg [INFO] [stderr] [INFO] [stderr] warning: casting i32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/gameboard_view.rs:92:44 [INFO] [stderr] | [INFO] [stderr] 92 | let x = settings.offset[0] + (((i as f64) / 9.0) * settings.size); [INFO] [stderr] | ^^^^^^^^^^ help: try: `f64::from(i)` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cast_lossless)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting i32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/gameboard_view.rs:93:44 [INFO] [stderr] | [INFO] [stderr] 93 | let y = settings.offset[1] + (((i as f64) / 9.0) * settings.size); [INFO] [stderr] | ^^^^^^^^^^ help: try: `f64::from(i)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting i32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/gameboard_view.rs:107:44 [INFO] [stderr] | [INFO] [stderr] 107 | let x = settings.offset[0] + (((i as f64) / 3.0) * settings.size); [INFO] [stderr] | ^^^^^^^^^^ help: try: `f64::from(i)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting i32 to f64 may become silently lossy if types change [INFO] [stderr] --> src/gameboard_view.rs:108:44 [INFO] [stderr] | [INFO] [stderr] 108 | let y = settings.offset[1] + (((i as f64) / 3.0) * settings.size); [INFO] [stderr] | ^^^^^^^^^^ help: try: `f64::from(i)` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: `ref` on an entire `let` pattern is discouraged, take a reference with `&` instead [INFO] [stderr] --> src/main.rs:38:9 [INFO] [stderr] | [INFO] [stderr] 38 | let ref mut glyphs = GlyphCache::new("assets/FiraSans-Regular.ttf", texture_settings) [INFO] [stderr] | ^^^^^^^^^^^^^^ [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#toplevel_ref_arg [INFO] [stderr] help: try [INFO] [stderr] | [INFO] [stderr] 38 | let glyphs = &mut GlyphCache::new("assets/FiraSans-Regular.ttf", texture_settings) [INFO] [stderr] 39 | .expect("failed to load font"); [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 12.66s [INFO] running `"docker" "inspect" "59d69300cb8e0dc04bcdf6d2f71a5feb7c20ee471398ca61b674c4b1507210a3"` [INFO] running `"docker" "rm" "-f" "59d69300cb8e0dc04bcdf6d2f71a5feb7c20ee471398ca61b674c4b1507210a3"` [INFO] [stdout] 59d69300cb8e0dc04bcdf6d2f71a5feb7c20ee471398ca61b674c4b1507210a3