[INFO] updating cached repository dainnilsson/adventofcode-2018 [INFO] running `"git" "fetch" "--all"` [INFO] [stdout] Fetching origin [INFO] [stderr] From git://github.com/dainnilsson/adventofcode-2018 [INFO] [stderr] * branch HEAD -> FETCH_HEAD [INFO] running `"git" "clone" "work/cache/sources/gh/dainnilsson/adventofcode-2018" "work/ex/clippy-test-run/sources/stable/gh/dainnilsson/adventofcode-2018"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable/gh/dainnilsson/adventofcode-2018'... [INFO] [stderr] done. [INFO] running `"git" "clone" "work/cache/sources/gh/dainnilsson/adventofcode-2018" "work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/dainnilsson/adventofcode-2018"` [INFO] [stderr] Cloning into 'work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/dainnilsson/adventofcode-2018'... [INFO] [stderr] done. [INFO] running `"git" "rev-parse" "HEAD"` [INFO] [stdout] ec0f98a7c60305d0ad05b9c4e26e4ed6964eb357 [INFO] sha for GitHub repo dainnilsson/adventofcode-2018: ec0f98a7c60305d0ad05b9c4e26e4ed6964eb357 [INFO] validating manifest of dainnilsson/adventofcode-2018 on toolchain stable [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] validating manifest of dainnilsson/adventofcode-2018 on toolchain stable+rustflags=-Dclippy::into_iter_on_array [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "read-manifest" "--manifest-path" "Cargo.toml"` [INFO] started frobbing dainnilsson/adventofcode-2018 [INFO] finished frobbing dainnilsson/adventofcode-2018 [INFO] frobbed toml for dainnilsson/adventofcode-2018 written to work/ex/clippy-test-run/sources/stable/gh/dainnilsson/adventofcode-2018/Cargo.toml [INFO] started frobbing dainnilsson/adventofcode-2018 [INFO] finished frobbing dainnilsson/adventofcode-2018 [INFO] frobbed toml for dainnilsson/adventofcode-2018 written to work/ex/clippy-test-run/sources/stable+rustflags=-Dclippy%3A%3Ainto_iter_on_array/gh/dainnilsson/adventofcode-2018/Cargo.toml [INFO] crate dainnilsson/adventofcode-2018 has a lockfile. skipping [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] running `"/mnt/big/crater/work/local/cargo-home/bin/cargo" "+stable" "fetch" "--locked" "--manifest-path" "Cargo.toml"` [INFO] linting dainnilsson/adventofcode-2018 against stable for clippy-test-run [INFO] running `"docker" "create" "-v" "/mnt/big/crater/work/local/target-dirs/clippy-test-run/worker-1/stable:/opt/crater/target:rw,Z" "-v" "/mnt/big/crater/work/ex/clippy-test-run/sources/stable/gh/dainnilsson/adventofcode-2018:/opt/crater/workdir:ro,Z" "-v" "/mnt/big/crater/work/local/cargo-home:/opt/crater/cargo-home:ro,Z" "-v" "/mnt/big/crater/work/local/rustup-home:/opt/crater/rustup-home:ro,Z" "-e" "USER_ID=1000" "-e" "SOURCE_DIR=/opt/crater/workdir" "-e" "MAP_USER_ID=1000" "-e" "CARGO_TARGET_DIR=/opt/crater/target" "-e" "CARGO_INCREMENTAL=0" "-e" "RUST_BACKTRACE=full" "-e" "RUSTFLAGS=--cap-lints=forbid" "-e" "CARGO_HOME=/opt/crater/cargo-home" "-e" "RUSTUP_HOME=/opt/crater/rustup-home" "-w" "/opt/crater/workdir" "-m" "1536M" "--network" "none" "rustops/crates-build-env" "/opt/crater/cargo-home/bin/cargo" "+stable" "clippy" "--frozen" "--all" "--all-targets"` [INFO] [stdout] 1ebfebf44d65d7db476dcc48ccbf6c4295e908b045a54ea83c7da01d8b52dff1 [INFO] running `"docker" "start" "-a" "1ebfebf44d65d7db476dcc48ccbf6c4295e908b045a54ea83c7da01d8b52dff1"` [INFO] [stderr] Checking aoc-18 v0.1.0 (/opt/crater/workdir) [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/main.rs:629:17 [INFO] [stderr] | [INFO] [stderr] 629 | rows: rows, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `rows` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/main.rs:630:17 [INFO] [stderr] | [INFO] [stderr] 630 | cols: cols, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `cols` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/main.rs:642:17 [INFO] [stderr] | [INFO] [stderr] 642 | x: x, [INFO] [stderr] | ^^^^ help: replace it with: `x` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/main.rs:643:17 [INFO] [stderr] | [INFO] [stderr] 643 | y: y, [INFO] [stderr] | ^^^^ help: replace it with: `y` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/main.rs:786:13 [INFO] [stderr] | [INFO] [stderr] 786 | state: state, [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `state` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/main.rs:629:17 [INFO] [stderr] | [INFO] [stderr] 629 | rows: rows, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `rows` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::redundant_field_names)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/main.rs:630:17 [INFO] [stderr] | [INFO] [stderr] 630 | cols: cols, [INFO] [stderr] | ^^^^^^^^^^ help: replace it with: `cols` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/main.rs:642:17 [INFO] [stderr] | [INFO] [stderr] 642 | x: x, [INFO] [stderr] | ^^^^ help: replace it with: `x` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/main.rs:643:17 [INFO] [stderr] | [INFO] [stderr] 643 | y: y, [INFO] [stderr] | ^^^^ help: replace it with: `y` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/main.rs:786:13 [INFO] [stderr] | [INFO] [stderr] 786 | state: state, [INFO] [stderr] | ^^^^^^^^^^^^ help: replace it with: `state` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/main.rs:787:13 [INFO] [stderr] | [INFO] [stderr] 787 | ts: ts, [INFO] [stderr] | ^^^^^^ help: replace it with: `ts` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: redundant field names in struct initialization [INFO] [stderr] --> src/main.rs:787:13 [INFO] [stderr] | [INFO] [stderr] 787 | ts: ts, [INFO] [stderr] | ^^^^^^ help: replace it with: `ts` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#redundant_field_names [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/main.rs:811:28 [INFO] [stderr] | [INFO] [stderr] 811 | let b = c2 + dc * (50000000000 - pots.tick as i64); [INFO] [stderr] | ^^^^^^^^^^^ help: consider: `50_000_000_000` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::unreadable_literal)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/main.rs:811:28 [INFO] [stderr] | [INFO] [stderr] 811 | let b = c2 + dc * (50000000000 - pots.tick as i64); [INFO] [stderr] | ^^^^^^^^^^^ help: consider: `50_000_000_000` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::unreadable_literal)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/main.rs:913:23 [INFO] [stderr] | [INFO] [stderr] 913 | assert_eq!(a, 101565); [INFO] [stderr] | ^^^^^^ help: consider: `101_565` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/main.rs:961:23 [INFO] [stderr] | [INFO] [stderr] 961 | assert_eq!(a, 374690); [INFO] [stderr] | ^^^^^^ help: consider: `374_690` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/main.rs:962:23 [INFO] [stderr] | [INFO] [stderr] 962 | assert_eq!(b, 3009951158); [INFO] [stderr] | ^^^^^^^^^^ help: consider: `3_009_951_158` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: long literal lacking separators [INFO] [stderr] --> src/main.rs:1000:23 [INFO] [stderr] | [INFO] [stderr] 1000 | assert_eq!(b, 1650000000055); [INFO] [stderr] | ^^^^^^^^^^^^^ help: consider: `1_650_000_000_055` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#unreadable_literal [INFO] [stderr] [INFO] [stderr] warning: use of `or_insert` followed by a function call [INFO] [stderr] --> src/main.rs:230:50 [INFO] [stderr] | [INFO] [stderr] 230 | Action::Wake => sleeps.entry(id).or_insert(vec![]).push((sleep_at, e.m)), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: try this: `or_insert_with(|| vec![])` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::or_fun_call)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] warning: You are using an explicit closure for cloning elements [INFO] [stderr] --> src/main.rs:275:37 [INFO] [stderr] | [INFO] [stderr] 275 | let mut x: Vec<_> = cs [INFO] [stderr] | _____________________________________^ [INFO] [stderr] 276 | | .iter() [INFO] [stderr] 277 | | .filter(|&x| *x != i && *x != i + 32) [INFO] [stderr] 278 | | .map(|&x| x) [INFO] [stderr] | |________________________________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::map_clone)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#map_clone [INFO] [stderr] help: Consider calling the dedicated `cloned` method [INFO] [stderr] | [INFO] [stderr] 275 | let mut x: Vec<_> = cs [INFO] [stderr] 276 | .iter() [INFO] [stderr] 277 | .filter(|&x| *x != i && *x != i + 32).cloned() [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/main.rs:366:15 [INFO] [stderr] | [INFO] [stderr] 366 | done: &Vec, [INFO] [stderr] | ^^^^^^^^^^ help: change this to: `&[char]` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::ptr_arg)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: called `filter(p).next()` on an `Iterator`. This is more succinctly expressed by calling `.find(p)` instead. [INFO] [stderr] --> src/main.rs:369:9 [INFO] [stderr] | [INFO] [stderr] 369 | / deps.iter() [INFO] [stderr] 370 | | .filter(|(k, v)| { [INFO] [stderr] 371 | | !done.contains(k) && !excl.contains(k) && v.iter().all(|x| done.contains(&x)) [INFO] [stderr] 372 | | }) [INFO] [stderr] 373 | | .next() [INFO] [stderr] | |___________________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::filter_next)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#filter_next [INFO] [stderr] [INFO] [stderr] warning: use of `or_insert` followed by a function call [INFO] [stderr] --> src/main.rs:384:27 [INFO] [stderr] | [INFO] [stderr] 384 | deps.entry(a).or_insert(vec![]).push(b); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: try this: `or_insert_with(|| vec![])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] warning: use of `or_insert` followed by a function call [INFO] [stderr] --> src/main.rs:385:27 [INFO] [stderr] | [INFO] [stderr] 385 | deps.entry(b).or_insert(vec![]); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: try this: `or_insert_with(|| vec![])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] warning: casting u8 to i32 may become silently lossy if types change [INFO] [stderr] --> src/main.rs:407:41 [INFO] [stderr] | [INFO] [stderr] 407 | (time - 4 + (c as u8) as i32, c) [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: try: `i32::from((c as u8))` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cast_lossless)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/main.rs:466:16 [INFO] [stderr] | [INFO] [stderr] 466 | if self.children.len() == 0 { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `self.children.is_empty()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::len_zero)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: single-character string constant used as pattern [INFO] [stderr] --> src/main.rs:482:20 [INFO] [stderr] | [INFO] [stderr] 482 | .split(" ") [INFO] [stderr] | ^^^ help: try using a char instead: `' '` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::single_char_pattern)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern [INFO] [stderr] [INFO] [stderr] warning: single-character string constant used as pattern [INFO] [stderr] --> src/main.rs:519:41 [INFO] [stderr] | [INFO] [stderr] 519 | let words: Vec<_> = input.split(" ").collect(); [INFO] [stderr] | ^^^ help: try using a char instead: `' '` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern [INFO] [stderr] [INFO] [stderr] warning: useless use of `format!` [INFO] [stderr] --> src/main.rs:757:13 [INFO] [stderr] | [INFO] [stderr] 757 | format!("{}", self.state.iter().collect::()) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using .to_string(): `self.state.iter().collect::().to_string()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::useless_format)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format [INFO] [stderr] = note: this error originates in a macro outside of the current crate (in Nightly builds, run with -Z external-macro-backtrace for more info) [INFO] [stderr] [INFO] [stderr] warning: this loop could be written as a `while let` loop [INFO] [stderr] --> src/main.rs:774:9 [INFO] [stderr] | [INFO] [stderr] 774 | / loop { [INFO] [stderr] 775 | | if let Some(l) = lines.next() { [INFO] [stderr] 776 | | let cs: Vec<_> = l.chars().collect(); [INFO] [stderr] 777 | | let t1 = cs[0..5].to_vec(); [INFO] [stderr] ... | [INFO] [stderr] 782 | | } [INFO] [stderr] 783 | | } [INFO] [stderr] | |_________^ help: try: `while let Some(l) = lines.next() { .. }` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::while_let_loop)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#while_let_loop [INFO] [stderr] [INFO] [stderr] warning: casting i32 to i64 may become silently lossy if types change [INFO] [stderr] --> src/main.rs:806:18 [INFO] [stderr] | [INFO] [stderr] 806 | let c1 = pots.checksum() as i64; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: try: `i64::from(pots.checksum())` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting i32 to i64 may become silently lossy if types change [INFO] [stderr] --> src/main.rs:808:18 [INFO] [stderr] | [INFO] [stderr] 808 | let c2 = pots.checksum() as i64; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: try: `i64::from(pots.checksum())` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: use of `or_insert` followed by a function call [INFO] [stderr] --> src/main.rs:230:50 [INFO] [stderr] | [INFO] [stderr] 230 | Action::Wake => sleeps.entry(id).or_insert(vec![]).push((sleep_at, e.m)), [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: try this: `or_insert_with(|| vec![])` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::or_fun_call)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] warning: You are using an explicit closure for cloning elements [INFO] [stderr] --> src/main.rs:275:37 [INFO] [stderr] | [INFO] [stderr] 275 | let mut x: Vec<_> = cs [INFO] [stderr] | _____________________________________^ [INFO] [stderr] 276 | | .iter() [INFO] [stderr] 277 | | .filter(|&x| *x != i && *x != i + 32) [INFO] [stderr] 278 | | .map(|&x| x) [INFO] [stderr] | |________________________________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::map_clone)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#map_clone [INFO] [stderr] help: Consider calling the dedicated `cloned` method [INFO] [stderr] | [INFO] [stderr] 275 | let mut x: Vec<_> = cs [INFO] [stderr] 276 | .iter() [INFO] [stderr] 277 | .filter(|&x| *x != i && *x != i + 32).cloned() [INFO] [stderr] | [INFO] [stderr] [INFO] [stderr] warning: writing `&Vec<_>` instead of `&[_]` involves one more reference and cannot be used with non-Vec-based slices. [INFO] [stderr] --> src/main.rs:366:15 [INFO] [stderr] | [INFO] [stderr] 366 | done: &Vec, [INFO] [stderr] | ^^^^^^^^^^ help: change this to: `&[char]` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::ptr_arg)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#ptr_arg [INFO] [stderr] [INFO] [stderr] warning: called `filter(p).next()` on an `Iterator`. This is more succinctly expressed by calling `.find(p)` instead. [INFO] [stderr] --> src/main.rs:369:9 [INFO] [stderr] | [INFO] [stderr] 369 | / deps.iter() [INFO] [stderr] 370 | | .filter(|(k, v)| { [INFO] [stderr] 371 | | !done.contains(k) && !excl.contains(k) && v.iter().all(|x| done.contains(&x)) [INFO] [stderr] 372 | | }) [INFO] [stderr] 373 | | .next() [INFO] [stderr] | |___________________^ [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::filter_next)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#filter_next [INFO] [stderr] [INFO] [stderr] warning: use of `or_insert` followed by a function call [INFO] [stderr] --> src/main.rs:384:27 [INFO] [stderr] | [INFO] [stderr] 384 | deps.entry(a).or_insert(vec![]).push(b); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: try this: `or_insert_with(|| vec![])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] warning: use of `or_insert` followed by a function call [INFO] [stderr] --> src/main.rs:385:27 [INFO] [stderr] | [INFO] [stderr] 385 | deps.entry(b).or_insert(vec![]); [INFO] [stderr] | ^^^^^^^^^^^^^^^^^ help: try this: `or_insert_with(|| vec![])` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#or_fun_call [INFO] [stderr] [INFO] [stderr] warning: casting u8 to i32 may become silently lossy if types change [INFO] [stderr] --> src/main.rs:407:41 [INFO] [stderr] | [INFO] [stderr] 407 | (time - 4 + (c as u8) as i32, c) [INFO] [stderr] | ^^^^^^^^^^^^^^^^ help: try: `i32::from((c as u8))` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::cast_lossless)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: length comparison to zero [INFO] [stderr] --> src/main.rs:466:16 [INFO] [stderr] | [INFO] [stderr] 466 | if self.children.len() == 0 { [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^ help: using `is_empty` is clearer and more explicit: `self.children.is_empty()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::len_zero)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#len_zero [INFO] [stderr] [INFO] [stderr] warning: single-character string constant used as pattern [INFO] [stderr] --> src/main.rs:482:20 [INFO] [stderr] | [INFO] [stderr] 482 | .split(" ") [INFO] [stderr] | ^^^ help: try using a char instead: `' '` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::single_char_pattern)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern [INFO] [stderr] [INFO] [stderr] warning: single-character string constant used as pattern [INFO] [stderr] --> src/main.rs:519:41 [INFO] [stderr] | [INFO] [stderr] 519 | let words: Vec<_> = input.split(" ").collect(); [INFO] [stderr] | ^^^ help: try using a char instead: `' '` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#single_char_pattern [INFO] [stderr] [INFO] [stderr] warning: useless use of `format!` [INFO] [stderr] --> src/main.rs:757:13 [INFO] [stderr] | [INFO] [stderr] 757 | format!("{}", self.state.iter().collect::()) [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ help: consider using .to_string(): `self.state.iter().collect::().to_string()` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::useless_format)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#useless_format [INFO] [stderr] = note: this error originates in a macro outside of the current crate (in Nightly builds, run with -Z external-macro-backtrace for more info) [INFO] [stderr] [INFO] [stderr] warning: this loop could be written as a `while let` loop [INFO] [stderr] --> src/main.rs:774:9 [INFO] [stderr] | [INFO] [stderr] 774 | / loop { [INFO] [stderr] 775 | | if let Some(l) = lines.next() { [INFO] [stderr] 776 | | let cs: Vec<_> = l.chars().collect(); [INFO] [stderr] 777 | | let t1 = cs[0..5].to_vec(); [INFO] [stderr] ... | [INFO] [stderr] 782 | | } [INFO] [stderr] 783 | | } [INFO] [stderr] | |_________^ help: try: `while let Some(l) = lines.next() { .. }` [INFO] [stderr] | [INFO] [stderr] = note: #[warn(clippy::while_let_loop)] on by default [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#while_let_loop [INFO] [stderr] [INFO] [stderr] warning: casting i32 to i64 may become silently lossy if types change [INFO] [stderr] --> src/main.rs:806:18 [INFO] [stderr] | [INFO] [stderr] 806 | let c1 = pots.checksum() as i64; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: try: `i64::from(pots.checksum())` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] warning: casting i32 to i64 may become silently lossy if types change [INFO] [stderr] --> src/main.rs:808:18 [INFO] [stderr] | [INFO] [stderr] 808 | let c2 = pots.checksum() as i64; [INFO] [stderr] | ^^^^^^^^^^^^^^^^^^^^^^ help: try: `i64::from(pots.checksum())` [INFO] [stderr] | [INFO] [stderr] = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#cast_lossless [INFO] [stderr] [INFO] [stderr] Finished dev [unoptimized + debuginfo] target(s) in 2.60s [INFO] running `"docker" "inspect" "1ebfebf44d65d7db476dcc48ccbf6c4295e908b045a54ea83c7da01d8b52dff1"` [INFO] running `"docker" "rm" "-f" "1ebfebf44d65d7db476dcc48ccbf6c4295e908b045a54ea83c7da01d8b52dff1"` [INFO] [stdout] 1ebfebf44d65d7db476dcc48ccbf6c4295e908b045a54ea83c7da01d8b52dff1